Change-Id: Icce460adc702547b12ad8e474507e396424c1eb3

This reverts commit 478d967e.

Sadly the change caused a crash in Writer. Stack trace:

> #0  0x00007fffc8b124cc in rtl::OUString::isEmpty() const (this=0x6666000000000000) at /ssd1/lo/fedora/include/rtl/ustring.hxx:646
> #1  0x00007fffc95ccaa8 in SwWrongList::GetWrongPos(int) const (this=0x5bb5f60, nValue=0)
>     at /ssd1/lo/fedora/sw/source/core/text/wrong.cxx:199
> #2  0x00007fffc95cd0d2 in SwWrongList::Move(int, int) (this=0x5bb5f60, nPos=0, nDiff=1)
>     at /ssd1/lo/fedora/sw/source/core/text/wrong.cxx:274
> #3  0x00007fffc94caffd in SwGrammarMarkUp::MoveGrammar(int, int) (this=0x5bb5f60, nPos=0, nDiff=1)
>     at /ssd1/lo/fedora/sw/source/core/text/SwGrammarMarkUp.cxx:41
> #4  0x00007fffc95af393 in lcl_SetWrong(SwTextFrame&, SwTextNode const&, int, int, bool) (rFrame=..., rNode=..., nPos=0, nCnt=1, bMove=true)
>     at /ssd1/lo/fedora/sw/source/core/text/txtfrm.cxx:1462
> #5  0x00007fffc95ad0ba in SwTextFrame::SwClientNotify(SwModify const&, SfxHint const&) (this=0x62f3c50, rModify=..., rHint=...)
>     at /ssd1/lo/fedora/sw/source/core/text/txtfrm.cxx:1676
> #6  0x00007fffc8bd96b8 in SwModify::CallSwClientNotify(SfxHint const&) const (this=0x4cef450, rHint=...)
>     at /ssd1/lo/fedora/sw/inc/calbck.hxx:444
> #7  0x00007fffc8bd893e in SwModify::ModifyBroadcast(SfxPoolItem const*, SfxPoolItem const*) (this=0x4cef450,
>     pOldValue=0x0, pNewValue=0x7ffffffed3a8) at /ssd1/lo/fedora/sw/inc/calbck.hxx:201
> #8  0x00007fffc8bd65d1 in SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) (this=0x4cef450, pOldValue=0x0, pNewValue=0x7ffffffed3a8) at /ssd1/lo/fedora/sw/source/core/attr/calbck.cxx:199
> #9  0x00007fffc965ec9f in SwTextNode::InsertText(rtl::OUString const&, SwIndex const&, SwInsertFlags) (this=0x4cef450, rStr="s", rIdx=SwIndex (offset 1), nMode=SwInsertFlags::EMPTYEXPAND) at /ssd1/lo/fedora/sw/source/core/txtnode/ndtxt.cxx:1997
> #10 0x00007fffc8ef97be in sw::DocumentContentOperationsManager::InsertString(SwPaM const&, rtl::OUString const&, SwInsertFlags) (this=0x4ca2ef0, rRg=SwPaM = {...}, rStr="s", nInsertMode=SwInsertFlags::EMPTYEXPAND)
>     at /ssd1/lo/fedora/sw/source/core/doc/DocumentContentOperationsManager.cxx:2509
> #11 0x00007fffc919bf7b in SwEditShell::Insert2(rtl::OUString const&, bool) (this=0x4d8eb90, rStr="s", bForceExpandHints=false)
>     at /ssd1/lo/fedora/sw/source/core/edit/editsh.cxx:98
> #12 0x00007fffca1d0cca in SwWrtShell::Insert(rtl::OUString const&) (this=0x4d8eb90, rStr="s")
>     at /ssd1/lo/fedora/sw/source/uibase/wrtsh/wrtsh1.cxx:224
> #13 0x00007fffc9e71220 in SwEditWin::FlushInBuffer() (this=0x4d7a3e0) at /ssd1/lo/fedora/sw/source/uibase/docvw/edtwin.cxx:989
> #14 0x00007fffc9e7accc in SwEditWin::KeyInput(KeyEvent const&) (this=0x4d7a3e0, rKEvt=...)
>     at /ssd1/lo/fedora/sw/source/uibase/docvw/edtwin.cxx:2620

Noel said I should revert and push.

Change-Id: I22d51bb3b5427af261cd4a1af19f9fa378891d27

Change-Id: Ic08253c3732f963eec6f97e6bd0530f95eb2916a
Reviewed-on: https://gerrit.libreoffice.org/57072
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Switching document provider when exception thrown casues
endless loop.
Signed-off-by: Mert Tumer <merttumer@outlook.com>

Change-Id: Ie34080abdf7b8d6a48cd96785700b7bd91910512
Reviewed-on: https://gerrit.libreoffice.org/57070
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I179c791aac5eb522aefb3ce20931fe44dd7248c6

Change-Id: Id3d1e070467bdb681919b380c0d2ace78ebd388d

Change-Id: I4b36d8700ad369b58205b699e0aff5591d2f1d6a

* Update translations from branch 'master'
  - update translations for master and add Kabyle
    
    Change-Id: Id526786e75a593590b553910a0e152bbfbfb690d
    

Change-Id: I2b232cd9ea791273e8a776bf88fa45ee0ad5edf0

    commit b649ce12
    CommitDate: Sun Apr 29 08:46:46 2018 +0200

        tdf#117063 Modify tree list double click behavior in the navigator

changed the return value in SvTreeListBox::DoubleClickHdl() from

  return !aDoubleClickHdl.IsSet() || aDoubleClickHdl.Call(this);

to an unconditional true. Earlier there was

    commit 1b9af084
    CommitDate: Tue Mar 13 16:28:40 2018 +0100

        tdf#116334: Actually when there is no handler, we have to return 'true'.

    -    aDoubleClickHdl.Call( this );
    -    return false;
    +    return !aDoubleClickHdl.IsSet() || aDoubleClickHdl.Call(this);

and before that

    commit 7651e575
    CommitDate: Thu Mar 1 15:41:13 2018 +0100

        tdf#115950: Indicate that the dialog was already destroyed.

    -    return true;
    +    return false;

Neither a constant false or true are correct return values here,
but only the value the double click handler, if any, returned to
indicate whether processing should continue (true) or not (false).

If handlers don't return a proper value so the intended behaviour
for tdf#117063 or anything else does not work then fix the
handlers instead.

If the handler returned false then don't even attempt to access
anything in SvImpLBox::MouseButtonDown() because an OK handler may
have destroyed everything and all is rotten.

Change-Id: Ia90c21288bedd7e5078dbe4b3dd6d9f5199a2a98
Reviewed-on: https://gerrit.libreoffice.org/57225
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Eike Rathke <erack@redhat.com>

Seems that calling getCanonicalDecl here results in us sometimes picking
up forward-decl's, which hides stuff

Also make the python processing code spit out a message if I manage to
mess up the log files

Change-Id: I08bf50eb26cf463c126507b51535b0a0fc9f7ecf

Change-Id: I3192704e0dc594f7496978414a8c1d93a4e0e5bb
Reviewed-on: https://gerrit.libreoffice.org/57300
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iea2b4a7c98a2751048dc2228ac550708bd22c238
Reviewed-on: https://gerrit.libreoffice.org/57318
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I542c87bc1de21727a035cc6ac3b3e20c0ccfb5f7

bitfields and make_unique don't play nice together, so bFirstRow
had to become a regular bool field.

Change-Id: I990a0ddcbbef5e826fbe26736e68ebce55cebb4c
Reviewed-on: https://gerrit.libreoffice.org/57303
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I26d6e98a768d40e97209e0a646cbb834d2635f9a
Reviewed-on: https://gerrit.libreoffice.org/57158
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories w* x*

Change-Id: I27bff44da3d34d24262031c7489e755311599bc5
Reviewed-on: https://gerrit.libreoffice.org/57307
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I360720b5c0402982e58416f9c902388034e5ecee
Reviewed-on: https://gerrit.libreoffice.org/57301
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Nobody reads these error messages if the build succeeds.

Change-Id: Ib1e52bf188d0da2bc35a0d2d2f79fff409e15977
Reviewed-on: https://gerrit.libreoffice.org/57270
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

and write the buffer in one go in SaveCont

Change-Id: Id41bb132ff3b4176b1fcb1798d10191c3d45fffc
Reviewed-on: https://gerrit.libreoffice.org/57298
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Icfa28a165d6697ca105b95fcc846ae05edbbdb11
Reviewed-on: https://gerrit.libreoffice.org/57282
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Regression from 80c35d97 - invert
the check for boost::optional validity.

Change-Id: If4e041e1fe349c1fcb2c74b2e5780bf57300486f
Reviewed-on: https://gerrit.libreoffice.org/57309
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I6e604a8a463ff453b82ca60f1bf92b7c73870482
Reviewed-on: https://gerrit.libreoffice.org/56455
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Also remove unused FPDFTextObj_GetUnicode() and FPDFTextObj_GetText().

Change-Id: I4b1f88f878f2754ff790b67d286a9d5366acc641
Reviewed-on: https://gerrit.libreoffice.org/57292
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ibb053d17a1da6e3db74b97b4f66a4ad03147b3bc
Reviewed-on: https://gerrit.libreoffice.org/57297
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0d4efde9ffa3a026052303eda4fe4dbbd48b22bc
Reviewed-on: https://gerrit.libreoffice.org/57306
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I74f4b9bef04b67380035eb7dcfdc73c89bf0c0d1
Reviewed-on: https://gerrit.libreoffice.org/57305
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I13b346751a001871fe2db04c0b40a0201d55352b
Reviewed-on: https://gerrit.libreoffice.org/57304
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3816fda10378852e06290e358b2bf18d48bee13d
Reviewed-on: https://gerrit.libreoffice.org/57302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic28b2aa9488b4a85e18d3777798bc1106cfb7c5f
Reviewed-on: https://gerrit.libreoffice.org/57299
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I25ff554e1dae45ff62bb3f036590a57a79d54b28
Reviewed-on: https://gerrit.libreoffice.org/57296
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1039d3f40409a0839c35d6270741aae8017ddf62
Reviewed-on: https://gerrit.libreoffice.org/57295
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I60a41111e76d72a7384cbb15f2d2a73c95af8c2d
Reviewed-on: https://gerrit.libreoffice.org/57280
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I30cfbf7ba87dda43ecb75ffd5f69253d77b6a00b
Reviewed-on: https://gerrit.libreoffice.org/57233
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

option leaves just-saved document modified; changes are not saved

Change-Id: Icad48fe1edcfb4c10c40f297326c23110144df53
Reviewed-on: https://gerrit.libreoffice.org/57211
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I661666166594ce3012767fac6edc64aa424442e5

Change-Id: I9a2e1e16d7683d790826fdc772fbcfbcf8af9881
Reviewed-on: https://gerrit.libreoffice.org/57149
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ic6de5319f936095fa1d165fc5901f13d0e7776f5
Reviewed-on: https://gerrit.libreoffice.org/57027
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I68ea3d2fc40163d0f3a67bb3723341f8e382db27
Reviewed-on: https://gerrit.libreoffice.org/56914
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

* Update helpcontent2 from branch 'master'
  - tdf#118314 Delete help content related to obsolete “Input Method Status” feature
    
    Change-Id: Ie80279915e3ee9a123204a729325ca9e119ab6bb
    Reviewed-on: https://gerrit.libreoffice.org/57224
    Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>