Both horizontal size and position looks sane now.

Change-Id: I6f040e4f0ff49be74420fafc4bcc5e899b6e94f7
Reviewed-on: https://gerrit.libreoffice.org/62397Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I2b75dce78ad8a955aa6f94ea5d225a79ae0e2dc6
Reviewed-on: https://gerrit.libreoffice.org/62392
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Finally the "parent text" of the test document now has correct width.

Change-Id: I05c552dda66ad91f19cfc335b464549920269f69
Reviewed-on: https://gerrit.libreoffice.org/62395Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Ie0b476164b370f58e0b220cee56ed52896753ade
Reviewed-on: https://gerrit.libreoffice.org/62394
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This prevents overwriting the existing logfile by
using the same logger as unopkg does.

Change-Id: Iaad4c5b99a4f428d3a4ad8a046c88404aecb5652
Reviewed-on: https://gerrit.libreoffice.org/62393
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I159b7e85f53e33c5359cca83aa958387d888f6a2
Reviewed-on: https://gerrit.libreoffice.org/62391
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ifbc2b127998e037be3f014bebf8721bef15ef53b
Reviewed-on: https://gerrit.libreoffice.org/62385
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

(ASCII and typographical) and for enclosing quotes of string literals.

Change-Id: I3caf3b707afa1fb41ba3afe9ff12ebce7ce63847
Reviewed-on: https://gerrit.libreoffice.org/62384
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I57dfc006d849918179a2398ef22be7585cb0993f

So match can be checked with IFNA(REGEX(...);...) and
IF(ISNA(REGEX(...);FALSE();TRUE())

Change-Id: I2b75dce78ad8a955aa6f94ea5d225a79ae0e2dc5
Reviewed-on: https://gerrit.libreoffice.org/62386Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e
Reviewed-on: https://gerrit.libreoffice.org/62041
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

<https://ci.libreoffice.org//job/lo_ubsan/1082/>:
> ==26422==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000accc72 at pc 0x2ae43e63f4b6 bp 0x2ae43e600510 sp 0x2ae43e600508
> READ of size 1 at 0x604000accc72 thread T70 (cppu_threadpool)
>     #0 0x2ae43e63f4b5 in Guess::Guess(char const*) /lingucomponent/source/languageguessing/guess.cxx:95:28
>     #1 0x2ae43e667f2f in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:169:19
>     #2 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12
>     #3 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24
[...]
> 0x604000accc72 is located 0 bytes to the right of 34-byte region [0x604000accc50,0x604000accc72)
> allocated by thread T70 (cppu_threadpool) here:
[...]
>     #7 0x2ae43e65350a in std::string::operator+=(char const*) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/bits/basic_string.h:3355:16
>     #8 0x2ae43e667e6e in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:168:21
>     #9 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12
>     #10 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24
[...]

shows, during UITest_librelogo, the Guess ctor making wrong assumptions about
the structure of guess_str and skipping over the terminating NUL.  Locally I
could see that while most inputs do have the expected syntax of starting with
"[" and containing two "-", one input is indeed just "[haw-utf8" without a
second "-".

I don't know where the strings passed into the Guess ctor in the two places in
lingucomponent/source/languageguessing/simpleguesser.cxx ultimately come from,
and what their guaranteed syntax and their semantics is.  So from the existing
code and the non--well-formed "[haw-utf8" sample (where the second segment shall
apparently designate an encoding, not a country), construct rules how to
robustly parse any input into potential language/country/encoding parts.  (What
is obvious from the call sites is that for one each input will start with "[",
and for another the item to parse need neither be "]"- nor NUL-terminated.)

(Guess::encoding_str and the local enc variable have effectively been unused
ever since the code's introduction in 07628119
"INTEGRATION: CWS languageguessing".  Guess::encoding_str, but not the local
enc variable, got later removed with b275246c
"loplugin:unusedfields in formula..registry".)

Change-Id: Icbedc05ed5b119ee4efbc3118cc17076a4d80c74
Reviewed-on: https://gerrit.libreoffice.org/62390
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I9230421a98ea5d1ec61bf1500b24949635db68d3
Reviewed-on: https://gerrit.libreoffice.org/62387
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

and fix a handful of small leaks in the process

Change-Id: I876e12ff5305f9dda84532d4182fb91657d6fa0c
Reviewed-on: https://gerrit.libreoffice.org/62389
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr

Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I36d3e874aac2d57d4e6f24a0e89c9836704bb7a6
Reviewed-on: https://gerrit.libreoffice.org/62383
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This will write log messages as plain text (no timestamp and other stuff
like PlainTextFormatter).
Warnings and errors will be prefixed accordingly.

Change-Id: Id82512d7dd3907a4c7cd69a963a375966189dc20
Reviewed-on: https://gerrit.libreoffice.org/62370
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Before only the output generated by extension add/remove/... functions
were logged to file, but not the error messages of unopkg itself.

Change-Id: I4451aa51e2877ae48c453ee4791e36d970832567
Reviewed-on: https://gerrit.libreoffice.org/62369
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This would create a com.sun.star.drawing.DiagramShape, and work with
that, but nobody implements such a service.

Change-Id: I32a63dd258a5f168e37c5926a832dadd45c2b179
Reviewed-on: https://gerrit.libreoffice.org/62371
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

from LibreLogo to Python

Change-Id: I39df100a13efe3573b33cb856701cbeb0d95954d
Reviewed-on: https://gerrit.libreoffice.org/62364
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I537871602282f85f2947f91f9b579b0e8cf12fe8
Reviewed-on: https://gerrit.libreoffice.org/62378
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ic85f7182b66f9f5c31b612e5a93299496e874fc0
Reviewed-on: https://gerrit.libreoffice.org/62381
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

This is arbitrary.

Change-Id: I88875e674464984c174e27fa6038080cc7366ecf
Reviewed-on: https://gerrit.libreoffice.org/62375Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

... as that does not affect the result string length.

Change-Id: Ia4426b4444845b3966da6a8c46089d8a98a38cb0
Reviewed-on: https://gerrit.libreoffice.org/62374Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

... and use that instead of SAL_MAX_UINT16 where string operations
are involved.

Change-Id: I41248bc1a876c19cd917269e44a6e91f51e569f5
Reviewed-on: https://gerrit.libreoffice.org/62373Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

... and set FormulaError::IllegalArgument for illegal values.

Change-Id: Iaf4c5123a3290ee1860d16fcf270e8c2a2e0845f
Reviewed-on: https://gerrit.libreoffice.org/62372Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

For a docking window which reparented to a floating window
via DockingManager, Window::GetParent() won't find the
floating window, because WindowImpl::mpRealParent points
to the previous parent (e.g. the toolbar). What we need is
to check WindowImpl::mpParent instead.

Change-Id: Ibdc5e29b7b8db37f9cbea65b3d7fbe39de334319
Reviewed-on: https://gerrit.libreoffice.org/62361
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Ife206ab29f2f8eaa2358f45e6bae2290d95fd4d6
Reviewed-on: https://gerrit.libreoffice.org/61779
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I92e392b315c9217b63db830dea1b2e91387b56c2
Reviewed-on: https://gerrit.libreoffice.org/61778
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

* Update helpcontent2 from branch 'master'
  - tdf#120221 Add experimental note
    
    Change-Id: I591c7ef34a84059060a7eeeff15ad2f7b6cc58ae
    Reviewed-on: https://gerrit.libreoffice.org/62365
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I8e58f9132c382885aa4cc85cf3e0a5277ec71623
Reviewed-on: https://gerrit.libreoffice.org/62368
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

The "Vertical Box List" preset in PowerPoint contains two linear
layouts, the inner one nested in the outer one. All the constraints are
stated on the parent layout. This commit doesn't actually read those
constraints yet, but adds infrastructure to look up parents of layout
nodes and also to get the constraints of a layout node.

No functional changes intended.

Change-Id: If844d17a90f8f180a9d21245249a2744bea32b31
Reviewed-on: https://gerrit.libreoffice.org/62367Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

I tried to use the new OUTDEV_PDF in replacement for the PDF
export check. It survived Jenkins and local builds, but sometimes
a tinderbox breaks, so check IsVirtual() instead.

Change-Id: I64fe7c145dc3b87345f6a967f6b2997f3c7e38c2
Reviewed-on: https://gerrit.libreoffice.org/62366
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

No need for a real reference, as GlyphItems are bound to their
GenericSalLayout, which holds the valid reference and doesn't
allow font change.

Change-Id: I8e1129ef99f576e43d55f39aee040ceeb635d51d
Reviewed-on: https://gerrit.libreoffice.org/62359Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

...that had been introduced in aecda33a
"#90370# Attribute Display uses FixedText instead of MultiLineEdit" together
with code that is long gone again:

+    // temporary to avoid incompatibility
+#if SUPD < 641 || defined( GT_DEBUG )
+    aSearchFormatsED.Hide();
+    aReplaceFormatsED.Hide();
+

Change-Id: If93425a3815f4946f97657f03bf066ee6ca4e6a4
Reviewed-on: https://gerrit.libreoffice.org/62363
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

InitFont() is always called after ImplNewFont(). Calling
InitFont() without a call to ImplNewFont() doesn't make much
sense.

There are some places which don't need to set the SalGraphics
font, but these are fine with calling ImplNewFont() as is.

It now looks like Printer' and OutputDevice' InitFont() do the
same, after commit c766a05a ("Antialias drawing is part of
the font selection") moved Antialias handling into the common
ImplNewFont() function.

Change-Id: I77b9a5b6dbed186a2b0868537930d6bf3fccd9d5
Reviewed-on: https://gerrit.libreoffice.org/62202
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Actually GlyphItem should be VCL internal, but this requires a
transparent SalLayoutGlyphs (i.e. via pImpl), which I'm too lazy
to implement currently.

This seperation makes the affected source files more obvious and
later migration of vcl/glyphitem.hxx easier.
While at it apply the coding style and add '_' to member prefix.

Change-Id: I61497af5c628c40f51597ce0ef286c47321acbc2
Reviewed-on: https://gerrit.libreoffice.org/62358
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Would be "HTML" by default, but reqif-html is mostly very simple
documents and the custom page styles is unexpected.

Change-Id: I3f1b293bcd074305cf5cc87f03248e934d5fac4d
Reviewed-on: https://gerrit.libreoffice.org/62317Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I4eda42a11239567c557431017a1fa99cb37298c5
Reviewed-on: https://gerrit.libreoffice.org/62357Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ief3a32a6001cf8b388107c74dc96fc82430d6398
Reviewed-on: https://gerrit.libreoffice.org/62354
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>