As it causes "unopkg.bin:
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/comphelper/source/misc/threadpool.cxx:96:
comphelper::ThreadPool::~ThreadPool(): Assertion `mbTerminate' failed."
in
<https://ci.libreoffice.org/job/lo_gerrit/8283/Config=linux_clang_dbgutil_64/console>
and also locally. Revert till it's clear if that assert() should be a
SAL_WARN() or unopkg has to be fixed.

This reverts commit 9899ffd2.

Change-Id: I72902f7da410012340aa8231d84c6871a3f7b976

Change-Id: If96fbf097e2314303e60fd4f10ae314d12f2c468

Change-Id: I960768ff98137a50da44348bffeec329295ea95f

Change-Id: I7acdea720ba29eb9b9fb3ef8e8cbc76a673d17c2

Change-Id: Iaf6310055b60da772187fdbeaca74d6eb296cfca

Change-Id: Ibb1625ff974cc1a35e5547b6ce88bf13d186d4bb

Change-Id: Ifd818cdf81516bd449db14bb1e84ed508e4b7d96

in preparation for "scoped UNO enums".

This is a little hacky: In order to limit the scope of this change,
the templated SvXMLEnumMapEntry struct actually has a fixed size field,
and we cast it to SvXMLEnumMapEntry<sal_uInt16>* in various
places, to avoid carrying the type param around.

Change-Id: Idfbc5561303c557598dd5564b7a7259ae5261d83
Reviewed-on: https://gerrit.libreoffice.org/34987Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I18eec89c4e1ebb86d64297e7cef4b36bf12df59f
Reviewed-on: https://gerrit.libreoffice.org/35004Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after faef35d8 "Move file download
verification from md5sum to sha256sum".

ATTENTION: A proper SHA from the source of that
b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext_0.9.5.oxt is needed. The value
substituted for now is just my local sha256sum after download.

Change-Id: Id31508f10c6cd936e5c6318731ceed71bdc25f48

I.e. show only 64bit JRE for 64bit LO and 32bit JRE for 32bit LO

Change-Id: Id5e890637c7e1014bcb4e6fdd9ed9a33765112d5
Reviewed-on: https://gerrit.libreoffice.org/35026Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

some stuff cppcheck missed in this file.
plus use empty() and front()

Change-Id: I612078d503c555afd681526f95d17502ffd585ba
Reviewed-on: https://gerrit.libreoffice.org/35094Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and make it easier to debug.
top crasher in 5.3.0.3 is around this area:
https://cgit.freedesktop.org/libreoffice/core/tree/vcl/source/gdi/
bmpacc2.cxx?h=libreoffice-5.3.0.3#n235

http://crashreport.libreoffice.org/stats/signature/
BitmapReadAccess::GetPixelForN32BitTcRgba(
unsigned%20char%20const%20*,long,ColorMask%20const%20&)#summary

in case someone wonders suffix increment '++' precedes dereference '*'

Change-Id: I15876711db569d55739da3514f61ef1b981269ab
Reviewed-on: https://gerrit.libreoffice.org/35099Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

That is always MD5 sum, but we expect SHA256 now.

Change-Id: I8edf61b9a663f6f1ecc5cf23c93211e0b3201631
Reviewed-on: https://gerrit.libreoffice.org/35067Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

This makes it MUCH easier to see what sort option is currently
selected. Removed the mechanism of switching between labels when
the option is toggled, and instead put all the options into a menu.

Change-Id: I44142dc842d983d5438faeb06b67046bad235308
Reviewed-on: https://gerrit.libreoffice.org/34640Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>

Fixes "Random Config" tb run #289

Change-Id: Ib1d672ac0a68e977f8d32f87c730ff1b0822f32c
Reviewed-on: https://gerrit.libreoffice.org/35109Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I12817adc50d45e2f08b3b5d4cb43daa527d274e9

Change-Id: I323be5e042e0ccb21956def70a8c481833f43998

Change-Id: I63da858b3f264cd099e60192633b44d362b6fad7
Reviewed-on: https://gerrit.libreoffice.org/35055Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If1216b03a313885bb284ca5ddcd8a91167a3638b

change for cicle to generate only one .vcxproj and .filter pr module

Change-Id: I93f2279e368e11ef5b9d442c6dcdfa4bf39bd6c2
Reviewed-on: https://gerrit.libreoffice.org/35075Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>

...so doesn't need to be passed through GetItemId.  Apparent thinko in
e3bd10f8 "adjust the hide of the zoom so its
dynamic on docking/undocking navigators".

Change-Id: I26c300522f048b8fd661856bfe2789ee7718ad15

...return value from ToolBox::GetItemId, as is done in all other places where
such is returned from one of the ToolBox::GetItemId overloads.  And
TOOLBOX_ITEM_NOTFOUND is otherwise only used for item positions, not item IDs.
(This lone odd use of TOOLBOX_ITEM_NOTFOUND was introduced with
ae5f75ab "Allow a common op. on a disposed
toolbox", probably by accident.)

Change-Id: Id767b1d8d0b3cdfdc0ec525f165d75ae0cef7301

Change-Id: I4940fe7e51df19275ba42a572c7a7a35ac2079f4
Reviewed-on: https://gerrit.libreoffice.org/35090Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I5c41c06f9bfa6c23a6984d2f7f5b118a13065da9
Reviewed-on: https://gerrit.libreoffice.org/35088Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

 This commit will combine the code of ListItemAdapter &
  GridItemAdapter in LibreOfficeUIActivity to one
  ExplorerItemAdapter which will handle both the view
  types.

Change-Id: I45c1f5124afee82ff0b78f13609acd37be87fde1
Reviewed-on: https://gerrit.libreoffice.org/34680Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>

...ever since b8f77081 "#96972# improved key and
focus handling"

Change-Id: I236143997f6e90eaa8cc28e10c17ff5a647da48c

Change-Id: I44ce5a8a7ef939cbe48f6164284fae88a090a724

Change-Id: I0d2cdae6a825fc74d08c55353f48f64021542be4

cause size arg is controllable by the file data

Change-Id: Ia92b56c04271557afbec1ab47620bcb34f1c0e8a

Change-Id: Ic7583e06cbb287805a11b148b40b6e5eda22c6eb

Shaperect is ignored by createAndInsert() so it has no effect
at all. Also when this parameter is set the size and position
is set using the same shaperect, so don't need to pass it also
as a parameter.

Change-Id: I35a7953f3eda1bdd19af6f3e77c55b5c7e1f7161
Reviewed-on: https://gerrit.libreoffice.org/35073Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

regression from...

commit ff8f6629
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Thu Jan 19 16:56:34 2017 +0000

    Resolves: ofz#424 guard against broken dxary length

but this weird typo doesn't appears in the 5-2 and 5-3 backports,
odd how I managed that

Change-Id: I5fb1db2284d48ee78e717d41274a3d37ab0255cf

Change-Id: I38092b9ca0de2c73a639588d441eff56eb88e33e

execute on Statement seems safer for some DDL statements
Additionally error handling was initiated, not terminated.

Change-Id: Ic2e987a84e87c01048b65f74efc938163ca17f2c

Change-Id: I8afde16343288888d9b1806fae6cba3514812d02
Reviewed-on: https://gerrit.libreoffice.org/35062Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia79bc8d35cf19438d177f31a8e0c8603102b4ef1
Reviewed-on: https://gerrit.libreoffice.org/35061Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I23b16792005d66588e3439eb6482adda96c45673
Reviewed-on: https://gerrit.libreoffice.org/35064Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I2be7113bfe86476acfd6550f1eed53eed83c9747
Reviewed-on: https://gerrit.libreoffice.org/35063Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ibefaed54c8fdce22fbae0116b4df5db4023ef7d6
Reviewed-on: https://gerrit.libreoffice.org/35057Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>