Change-Id: I4ba4a19a45ade62e65ae987cadb8ba07d4a5e006
Reviewed-on: https://gerrit.libreoffice.org/57794
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

See e.g. http://crashreport.libreoffice.org/stats/crash_details/dc1ae6ff-923e-44f6-99a9-84893039efd7

Change-Id: I3b5a24bfb62977ca922bf3bececb6676691bf6ea
Reviewed-on: https://gerrit.libreoffice.org/57789
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Seems like commented out during some refactoring/rewrite in 2013
with commit efb23f29, and then forgotten

Change-Id: I59148b7fd9ee8a68bfdb0609dc3a13634b29db5f
Reviewed-on: https://gerrit.libreoffice.org/57785
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

By default Legend's position is automatic and it is located
at the right side of the chart.
Unfortunately even if layout with manualLayout is set:
http://www.datypic.com/sc/ooxml/e-draw-chart_manualLayout-1.html
the empty space for the automatic legend on the right side of the chart,
was left.
This is issue with opening of the OOXML charts by LibreOffice,
as MS Word is opening the same document properly.

This patch fixes issue with wrong chart displaying, when manual position
of the legend is set.

Change-Id: Id5363d48b049c469b6761b43cecfbb56514bf7d8
Reviewed-on: https://gerrit.libreoffice.org/57762
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Iee76ed28d0dcd4ee57115ec951a181b2cf8d35fd
Reviewed-on: https://gerrit.libreoffice.org/57239
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Was last touched in 2012 by a mass find&replace
in commit d3e08f25

Change-Id: Id62c0ce4680afa1febca01d54734f11dd026a58f
Reviewed-on: https://gerrit.libreoffice.org/57786
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

XclObjComment formally cloned the SdrCaptionObj for a single
reason - to suppress functionality of the UNO API implementation
in SvxShape::GetBitmap - non-inserted SdrObjects did not create
Graphic return values.

Changed this to use an exclusive flag at SdrCaptionObj, only
accessible for XclObjComment. Due to bad/undefined behaviour
of SdrObjects that are not iinserted anywhere (see old comment
in XclObjComment) there is no way to return to cloning the
SdrObjects just to have them without being added to a SdrPage.

Also improved the time eater UNO API implementation SvxShape::GetBitmap
to use more modern stuff to create the Graphics needed. All the
time constructing a full E3DView and setting SdrObjects selected
and getting the selection as graphic is way too expensive. That
way save may even get somewhat faster.

Last was to cleanup the bInserted flag in SdrObject. It is no
longer needed, being inserted now depends on being a member
of an SdrObjList (Group or Page) - sounds normal anyways and
is a synergy effect of already done AW080 cleanups.

Checked now on linux. Problem is UnitTest 'testN777345' which
checks file "n777345.docx".

First point is that this only happens
  #if !defined(MACOSX)
  #if !defined(_WIN32)
so it's clear why I detected no problem on Windows.

Second point is that this test takes a checksum of a Graphic
that is created using getReplacementGraphic() this value *will*
change - of course - every time creation of that graphic is
even *slightly* modified, so from my POV this UnitTest is
defined to fill quite often. It may even create different
results on different systems (!). Adaption of the test value
 will be needed quite often and makes this test questionable.

Change-Id: If0918831a9cbd61b31298aeac7342e1913ee6c7a
Reviewed-on: https://gerrit.libreoffice.org/57758
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: Ia3e6f17217b837517faa588ea7f2e72dc5aff6aa
Reviewed-on: https://gerrit.libreoffice.org/57767
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

just the simplest case of a straight solid line which is outlined,
i.e. border in font color and filled with white

Change-Id: I7d670a543475b6457cb2827e74a05bba6c4a91ea
Reviewed-on: https://gerrit.libreoffice.org/57778
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This completes enabling all gla11y warnings

Change-Id: I791de2f03ec09098bd52bfff515270d15584d70d
Reviewed-on: https://gerrit.libreoffice.org/57609
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: If8697d13b8fa87fd07e8fef9cb6fdcb0f444fa71
Reviewed-on: https://gerrit.libreoffice.org/57775
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

In case an Impress shape has a "Fade in and Swivel" animation attached,
canvas calls OutputDevice::DrawBitmapEx() with a negative width. This
results in a call to OutputDevice::DrawDeviceAlphaBitmap(), which
asserts that the height/width is not negative.

Fix the problem by transforming the bitmap before calling
OutputDevice::DrawBitmapEx() in the GL case, similarly to how "complex"
transformations are handled already.

Change-Id: I65ccc8a984132c5921d6096bfe9c7a8fcfacd8dd
Reviewed-on: https://gerrit.libreoffice.org/57774Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

It is possible for paragraph styles to be based on -none-.
In those cases, the DocDefaults must be applied.

Change-Id: I5b3458384c6473f3aaf64e5f274372d291ff824d
Reviewed-on: https://gerrit.libreoffice.org/57371
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I46ece073659444e802bf480996a5797c9f1ec9e8
Reviewed-on: https://gerrit.libreoffice.org/57754
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

try deferring to after anchor stack is cleared

Change-Id: Iaa42d19635968d1656e171a7e0c5e473879cd8f3
Reviewed-on: https://gerrit.libreoffice.org/57772
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

idea from tml.

Extend the unusedfields plugin to find fields that are only assigned in
the constructor.

Change-Id: I258d3581afbe651d53ce730c9ba27a4598cd9248
Reviewed-on: https://gerrit.libreoffice.org/57733
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - tdf#115254 Some branch bookmarks are not working 6
    
    writerperfect and uui modules
    
    Change-Id: Ic5534fc23a8f631c82e39def337a867d355cb93f
    Reviewed-on: https://gerrit.libreoffice.org/57702
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#115254 Some branch bookmarks are not working 5
    
    vcl and xmlsecurity dialogs
    
    Change-Id: I538af5bf6f54a629e4d39a9a0f153bf97c7d8329
    Reviewed-on: https://gerrit.libreoffice.org/57701
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Ia78db6e7ab74a6f2f15280aff65857e2f97cb578
Reviewed-on: https://gerrit.libreoffice.org/57755
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id79036d8d96748525fedcf366dc6f92b03360e69
Reviewed-on: https://gerrit.libreoffice.org/56926
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I1048bea42c66b81244021aa2188e5dfe2ce6e83d
Reviewed-on: https://gerrit.libreoffice.org/57768
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I1450de6d00f52bbe1f4fdebb375f505243e1eba9
Reviewed-on: https://gerrit.libreoffice.org/57769
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

followup to commit 480ac84f which
nicely paved the way by doing this for top/bottom.

Change-Id: I61b4e298e8732391b4f0467b459d9c15298925fa
Reviewed-on: https://gerrit.libreoffice.org/57742
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Try to find >= 4.6 .NET SDK first.

+allow .NET SDK 4.7.2.

Change-Id: I64084e894ee829ecff091fe16a45f309a51eb4d5
Reviewed-on: https://gerrit.libreoffice.org/57550
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

That call in the RTFSprms copy ctor to the parent non-copy ctor was a
bit odd.

Change-Id: Ic219ec22c0b63472766a668406585dbbeebae2f7
Reviewed-on: https://gerrit.libreoffice.org/57763Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Ieea98a4e02096fcc28b7dff32fd2cbaedc7483cd
Reviewed-on: https://gerrit.libreoffice.org/57740Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Id8a9bc8b0190e1c469ea5cec71d465c9025ac5d0
Reviewed-on: https://gerrit.libreoffice.org/57757
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I586e6047f6723453801958e2d8f69ffbc4c47dcf
Reviewed-on: https://gerrit.libreoffice.org/57756
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2995dfe5fb39ae2e7f3c37992cb3e2147381784e
Reviewed-on: https://gerrit.libreoffice.org/57753
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If19da8d2d7ffe1d245e67466fa55166b76774013
Reviewed-on: https://gerrit.libreoffice.org/57752
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I15f30f655d409e3570bb33aa032f809263d3035b
Reviewed-on: https://gerrit.libreoffice.org/57751
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7d3a7a72c5de2915822ebb4cc73a504e65ce04a6
Reviewed-on: https://gerrit.libreoffice.org/57750
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Use std::vector<char> for pendingCharacters in SAXParser to avoid
calling the OUString utf8 conversion routine more than one per character
block. We seem to hit multiple characters() callbacks per chunk of text
fairly often in loading writer docs.

This is only good for about 0.5% performance

Change-Id: I354bb4efe9d883c4bebf49bc96dd44be4f2b1610
Reviewed-on: https://gerrit.libreoffice.org/57731
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id6f08fd29dd85e46bde487f99535ad91d2ac2712
Reviewed-on: https://gerrit.libreoffice.org/57734Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

since...

commit 7581730b
Date:   Wed May 23 17:36:44 2018 +0900

    tdf#117247 just send a GRAPHIC_ARRIVED hint after update

Change-Id: Id1a2a3bb25649f3f8e60d7edf79e5fd217b9e72f
Reviewed-on: https://gerrit.libreoffice.org/57736
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5f9754b96e954a8295d8fa84b2337bc8deac9bc8
Reviewed-on: https://gerrit.libreoffice.org/57735
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id085fb6ab14a27c84beed0d29284a125e82d277d
Reviewed-on: https://gerrit.libreoffice.org/57737
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

To indicate why the result isn't available ("External content
disabled") and in future maybe signal to the formula cell that it
could keep the hybrid string result, see source code comment.

Change-Id: Ic5d336b8489e8776f7b640b7e46815e71d0a82a4
Reviewed-on: https://gerrit.libreoffice.org/57738Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Firebird requires
   SELECT FIRST 1 ...
syntax, while HSQLDB and other RDBMS use
   SELECT TOP 1

Additionally the Value property for monoselect listboxes has been reworked

Change-Id: I7ed142158ab9306886555f3b14d39dfc5b12080d
Reviewed-on: https://gerrit.libreoffice.org/57706
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>