Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528
Reviewed-on: https://gerrit.libreoffice.org/64710
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

At least I think so. Thus now the code that queries the state of the
toolbar controls only queries dataset if connection is active.

Operating the navigation buttons (next/prev) will, naturally, activate
connection if not yet active. This should also enable the other controls
that may be initially disabled: create/save/print/email documents. Thus,
the navigation controls also check if they have activated the connection,
and invalidate said document creation controls state. Possibly there's a
better place for the invalidation of the controls, but I was unable to
find one.

Regression after commit 5c2c5ff0

Change-Id: I76f895c871718c9c761339ba03963baf6837b592
Reviewed-on: https://gerrit.libreoffice.org/64738
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Move XIndexAccess Java tests to C++ for ScUniqueCellFormatsObj.

Change-Id: I2aabc835d37c5f12afacfcbafc2d7d6346619a3c
Reviewed-on: https://gerrit.libreoffice.org/64666
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

...ever since f1579d3d "tdf#117171 support
localized number name numbering styles"

Change-Id: I93dcfa9f1310b35e3068a7e0efdce258364a7d78
Reviewed-on: https://gerrit.libreoffice.org/64720Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins

e.g.:

> [CXX] pyuno/source/module/pyuno_callable.cxx
> In file included from pyuno/source/module/pyuno_callable.cxx:19:
> In file included from pyuno/source/module/pyuno_impl.hxx:27:
> In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/Python.h:85:
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/unicodeobject.h:534:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
>     register PyObject *obj,     /* Object */
>     ^~~~~~~~~

(and some $enable_python=system/$_os=Darwin-specific code can thus be removed,
too)

Change-Id: Ic7901732c01bef9335c63dd6f0949453f5824226
Reviewed-on: https://gerrit.libreoffice.org/64732
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...after <https://gerrit.libreoffice.org/63951> "Bump (Linux) GCC baseline to
7.0.0".  (In some cases, those checks now need to check for __clang__, which was
implicitly covered in the past by Clang consistently reporting to be
GCC 4.2.1.)

Change-Id: I860fef8c4ca41c22a7541f0fb2d34b37d1d69bed
Reviewed-on: https://gerrit.libreoffice.org/63952
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...as discussed at
<https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html>
"minutes of ESC call ..."

Change-Id: Ib1a4fdc56c51ab5c9e45173263689db2b88d72e7
Reviewed-on: https://gerrit.libreoffice.org/63951
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id3b338278e6d47b90268f0bdc77f1bdaa495edb8
Reviewed-on: https://gerrit.libreoffice.org/64723
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cause command isn't available any more

Change-Id: Ie73491e02979fe24f59e8c627b69f902a12b512a
Reviewed-on: https://gerrit.libreoffice.org/64711
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Move XEnumerationAccess Java test to C++ for ScUniqueCellFormatsObj.

Change-Id: Ia49fce123577a62e1ad60ef0dab4ac61148a1551
Reviewed-on: https://gerrit.libreoffice.org/64665
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XElementAccess Java tests to C++ for ScUniqueCellFormatsObj.

Change-Id: I9cec7605afa2cbfec48e5ecee22c12983c68afee
Reviewed-on: https://gerrit.libreoffice.org/64664
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Id4ea2c3dd7420954b1852021f136bc98f20a9846
Reviewed-on: https://gerrit.libreoffice.org/64663
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Otherwise a test can already require a windowed VCL plugin by
calling gb_CppunitTest_use_vcl_non_headless(_with_windows)?.

For compatibility on unix --headless still implies the use of the
svp plugin, but now a SAL_USE_VCLPLUGIN will override it.

All the explicit SAL_USE_VCLPLUGIN=svp are not needed, as this is
now included in the gb_TEST_ENV_VARS variable and gengal already
calls Application::EnableConsoleOnly().

Change-Id: I6b4e75282aa88d747db87d60ffe6c8f282187c5f
Reviewed-on: https://gerrit.libreoffice.org/64052
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Since upstream Java reverted the strict classpath checks, it's
not needed anymore.

See discussion in https://gerrit.libreoffice.org/#/c/63118 and
http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/8513ac27b651

Change-Id: Iff863702b1aeda157c8e230ab36372a71dcfb4bb
Todo: tdf#121925
Reviewed-on: https://gerrit.libreoffice.org/64634
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

756c9f23 "Merge upstream fixes into
solenv/flatpak-manifest.in" had introduced it (via <https://github.com/flathub/
org.libreoffice.LibreOffice/commit/7d69e505165d4bbf5fa0b34b5fb2cbff9dfaf9bd>
"For now, bundle gst-libav to be able to play mp4 videos in impress" to fix
<https://github.com/flathub/org.libreoffice.LibreOffice/issues/20> "Impress
don't insert a video" back when the LO flatpak was based on
org.gnome.Platform//3.26 which doesn't contain
/usr/lib/gstreamer-1.0/libgstlibav.so.  (And
/app/lib/gstreamer-1.0/libgstlibav.so is apparently the only file that the
gst-libav module contributes to the LO flatpak.)

When 727bfa2c "Merge in Flatpak improvements"
switched the runtime to org.freedesktop.Platform//1.6 (via
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/
7a2393f5fcab8c6938180c4718f2c61acd495528> "port to freedesktop.org 1.6 runtime")
it kept the gst-libav module even though org.freedesktop.Platform//1.6 contains
/usr/lib/gstreamer-1.0/libgstlibav.so.  Lets assume it was kept by accident and
can be removed.  (At least the scenario from <https://github.com/flathub/
org.libreoffice.LibreOffice/issues/20#issuecomment-368543622> "Impress don't
insert a video" still works with this change.)

Change-Id: I692d01bfe5882c05d63124db7cdfa6390540e69f
Reviewed-on: https://gerrit.libreoffice.org/64703
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I25b1ed89b8d0e7a7c0e36c621a43644bc2b4aa7b
Reviewed-on: https://gerrit.libreoffice.org/64708
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - tdf#116078 OpenPGP encryption
    
    + some update (drop) references to LO file picker
    
    Addressed comments by reviewer.
    fix ordered list
    
    Fixed reviewer comment.
    Fixed DTD violations
    
    Change-Id: Ie71f736a5713b042e185e93e595b6880ffe7541c
    Reviewed-on: https://gerrit.libreoffice.org/64436
    Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
    

Specifically, the input arguments of the run programs and the results
buffer. This should make it much simpler to check if an OpenCL program
works correctly.

Change-Id: I0667082bf9a88757c8bda0c7ed54e2fc918534d7
Reviewed-on: https://gerrit.libreoffice.org/64547
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

since...

commit e194f597
Date:   Sun Sep 30 16:07:16 2018 +0200

    Change GlyphItem::nFallbackLevel to font instance

Change-Id: I14b40a63cd48ef527e76e15af8f421ce48cce769
Reviewed-on: https://gerrit.libreoffice.org/64698Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id05ad8b72e0ec4f9bad2a9cfb780a44a27618d37
Reviewed-on: https://gerrit.libreoffice.org/64700
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id951b94240b487f8c8cc3f612906d4b2e0bfd76d

Change-Id: Ie9d78346bb104734fddeb27ff0414b4c7ef64ae9

Change-Id: I8c59f7aa0cde22468c9451f7d910cf0106138fd7

This properly reimplements the fix, only changing the display strings
sent to native dialog, and never modifying the filter names as seen
by LibreOffice code.

Change-Id: Iee5f09acd6b12c0ba8b7568b16f8ab07821006ee
Reviewed-on: https://gerrit.libreoffice.org/64656
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

This reverts commit 1b50fa88.

Change-Id: Ide94c1be6a265cee2e70c319578d816efa1d2eb9
Reviewed-on: https://gerrit.libreoffice.org/64655Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

This reverts commit c444eb79.

Change-Id: I19b969572afbd0a017b8086b390611cfc04c7386
Reviewed-on: https://gerrit.libreoffice.org/64654
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Similar to 6d9a2557

Change-Id: Ifecc3f86a3da8fdd4b0535cb67c6315e0d418f5a
Reviewed-on: https://gerrit.libreoffice.org/64645Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: Id8405664e2045529826ba634986c414db742cc3b
    Reviewed-on: https://gerrit.libreoffice.org/64702
    Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    

Change-Id: I785d70cf05452ce3dbe209f595670d68b9653e22
Reviewed-on: https://gerrit.libreoffice.org/64668
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie4f9c142d221b16072748c9c2deaa96c4704b90d
Reviewed-on: https://gerrit.libreoffice.org/64422
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Not all compilerplugins/clang/*.cxx depend on config_clang.h (e.g., check.cxx
doesn't), so this mechanism trying to rebuild compilerplugins once the
underlying Clang installation changes doesn't work reliably in practice (just
debugged through this with Miklos on IRC, and it wasn't the first time that
`make distclean` fixed compilerplugins for somebody after they upgraded their
Clang installation).  Removing the brittle mechanism shows that plugin.hxx
doesn't actually depend on config_clang.h.

(There's a second mechanism trying to rebuild compilerplugins once the
underlying Clang installation changes, namely

> # Clang most probably doesn't maintain binary compatibility, so rebuild when clang changes.
> $(CLANGOUTDIR)/clang-timestamp: $(CLANGDIR)/bin/clang$(CLANG_EXE_EXT)
>         $(QUIET)touch $@

in compilerplugins/Makefile-clang.mk, but that doesn't work reliably either, as
it depends on the newly installed clang executable being newer than our
clang-timestamp file, which will be the case for self-built Clang installations,
but not necessarily when updating e.g. a distro-provided Clang installation.)

Change-Id: Ie576f14356b3f0e55444375095c86aa851404bf3
Reviewed-on: https://gerrit.libreoffice.org/64623
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I8254d350320115be532c6d595dc56268c8de3ad2
Reviewed-on: https://gerrit.libreoffice.org/64653
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I87e601b8a68bfcfee700299526e2b899427e56f1
Reviewed-on: https://gerrit.libreoffice.org/64652
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Ib483decf4cd7d8ec5cb73a23c36181bd3e1d49c0
Relates: tdf#107792
Reviewed-on: https://gerrit.libreoffice.org/64661
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I340be161aeb343ccc01b86bcb807e4441025419e
Reviewed-on: https://gerrit.libreoffice.org/64595
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after choosing a color using the color tab page

Change-Id: I8f39ed2055e8974356c9ad0894fc908db754b5a4
Reviewed-on: https://gerrit.libreoffice.org/63929
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

Change-Id: Ic717f68f0d107138dd18116b70f3a49588c5778f

Move XIndexAccess Java tests to C++ for ScCellFormatsObj.

Change-Id: I5ef1e789a535af55705c3a39f07a9396666adbed
Reviewed-on: https://gerrit.libreoffice.org/64648
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XEnumerationAccess Java test to C++ for ScCellFormatsObj.

Change-Id: I68b9e0308b1959b848e8a53b143c6a6a49589bb7
Reviewed-on: https://gerrit.libreoffice.org/64647
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XElementAccess Java tests to C++ for ScCellFormatsObj.

Change-Id: I8c72c7eb352720f4ff40727df4823855ec8014e5
Reviewed-on: https://gerrit.libreoffice.org/64646
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>