where used directly, since rtl_allocateMemory now just calls into std::malloc

Change-Id: I59f85bdb7efdf6baa30e8fcd2370c0f8e9c999ad
Reviewed-on: https://gerrit.libreoffice.org/59685
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

look for places where we are appending the temporary result of adding
strings together, to an OUStringBuffer, where we could rather call
append repeatedly and avoid the temporary creation

Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82
Reviewed-on: https://gerrit.libreoffice.org/59708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3089f9305b8142e2c78405a4f9ae6a2066e90cfa
Reviewed-on: https://gerrit.libreoffice.org/59725
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I25077e391ecca1b678062d261a83d88daadf0a58
Reviewed-on: https://gerrit.libreoffice.org/59701
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after 5b62a433 "Revert
'-Werror=redundant-move'" to fix the build for GCC 8.1 again.  Turns out the
std::move can only be dropped if the compiler has a fix for CWG1579.  For GCC
that's the case starting with GCC 5.1, so the !HAVE_CXX_GWG1579_FIX case can
hopefully be removed again soon, see the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-July/080588.html>
"Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)").

Change-Id: I3592cad7fb503db921c37e92831a34785a1054a1
Reviewed-on: https://gerrit.libreoffice.org/59741
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I0dc22130b5dec5eb2250c9625773b6c9720182a9
Reviewed-on: https://gerrit.libreoffice.org/59740
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I36d86e7ccca66b09f2f49e401d77deb52fbf742a
Reviewed-on: https://gerrit.libreoffice.org/59738
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

But only for XHTML, HTML stays unchanged to be in sync with web
browsers.

Change-Id: I3a1cf6651dab565bafece68963acb112ae715cdd
Reviewed-on: https://gerrit.libreoffice.org/59727Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I6ba581f3665bc2934b8e3af5985ae853d60be39f

Change-Id: Id3e167009ad5cc7677930ebfad412600e62f261f
Reviewed-on: https://gerrit.libreoffice.org/59681
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

pattern of area tab, pattern subtab of e.g. format page

and in the pattern editor the 5% style is shown wrong,
clicking ona different pattern and then back may make it draw correct

a problem since...

commit 6fbb6d80
Date:   Fri Feb 16 16:13:38 2018 +0200

    use std::array in createHistorical8x8FromArray

    to make the assumption about the size of the array obvious in the code.

Change-Id: I882384a13dedc7a14b63b3b8a9b764a4367b7cc6
Reviewed-on: https://gerrit.libreoffice.org/59724Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... instead of rtl::math::approxFloor(fValue*DATE_TIME_FACTOR+0.5)
seconds that most times works but sometimes not.

Change-Id: Iaca69630461f2067622898fab35cda61d20172a9
Reviewed-on: https://gerrit.libreoffice.org/59719Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Otherwise it may be uninitialized.

Change-Id: Iccb61d66c8410ac8ecdabbd96204d2393060bc1d
Reviewed-on: https://gerrit.libreoffice.org/59721Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I5af85ef9ed3e6d15f7e98e9d669c59a66fc70833
Reviewed-on: https://gerrit.libreoffice.org/59478
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

This reverts commit 3ba67ff4.  Turns out
GCC 4.8 fights GCC 9 here, so needs a more elaborate fix.  Sorry for the noise.

Change-Id: I8e239d95e288cba4fd798ce04cfe56cb62fff6a9

Change-Id: Ic3093d3c12c33cbcc09903409daec6277428ecd6
Reviewed-on: https://gerrit.libreoffice.org/59664
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Also add fFractionOfSecond and nFractionDecimals to obtain the
remaining fraction of second.

In preparation to use this in the number formatter and other
places that obtain the wall clock time particles, which likely so
far use bad rounding as well.

Change-Id: I4fbea4165c560646438b06c340756c97dafa7c78
Reviewed-on: https://gerrit.libreoffice.org/59700Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

To complete commit:
e9fa0887

It passed "make check" on Linux

Change-Id: I2772b1ac5d4024bb11f3e09e24afc566b7091fb8
Reviewed-on: https://gerrit.libreoffice.org/59693Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Ic4142b6f80f2b47e745c4d2bd898c6aef865ca36
Reviewed-on: https://gerrit.libreoffice.org/59703
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Since commit ee6dad51,
the "Use only paper size from printer settings" is shown
at two places in the print dialog

1) in the "Options" tab
2) in the "Properties" -> "Paper" tab

This makes the setting being correctly updated in the UI in
1) as well if changed in 2).

The other way around was already working previously.

Change-Id: I41d29a11b4e1695a4b2f676b8d7a9c01e4abde3e
Reviewed-on: https://gerrit.libreoffice.org/59581
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I864302cc7ba8f27300e4bf0dd3d8a6cc1896da4b
Reviewed-on: https://gerrit.libreoffice.org/59698
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

The too aggressive error handling in commit
fb04780c (tdf#116117 sfx2 store: don't
inherit temp file permissions when renaming, 2018-03-12) means that if
the file is already there, then we don't try to stat() it; even if there
is no problem with that.

Change-Id: Ie0b9084064834e339bcae3ad7b4a35c54cb9d3c2
Reviewed-on: https://gerrit.libreoffice.org/59684Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - Preface->Precede
    
    Just a suggestion.
    I'm not english-native but it sounds wrong to me with "preface".
    
    Change-Id: I403dfb162b399f4a487d616cde3209ba9efcba0b
    Reviewed-on: https://gerrit.libreoffice.org/59695
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

This doesn't make the LibreOfficeLight app work much better, though.
But at least it doesn't hang its event loop completely, some 10 s
timer keeps firing. (But nothing sane shows up in the app UI, even if
some welcome.odt document apparently does get loaded. Clearly
something is waiting for something else that never happens...)

Change-Id: Ieba22a5e1418d48a7dd6cacda526aca69cced4c3

Change-Id: I78571f8494a13f6f8c07f9aee2bf6f8144a48ed2

We can't handle the correct state when blocking via a tasks
mbActive bool, as this also schedules the task and starts the
scheduler timer. So reintroduce a bool for the unblock state.

Change-Id: I40991d0160b058fae3803fab002dc036fc0b0339
Reviewed-on: https://gerrit.libreoffice.org/59692
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Since nobody else seems to have this problems, this may be possibly
only specific to KDE builds or to using gold linker.

Change-Id: I29359e298178b934a6232b78da684e55db590863
Reviewed-on: https://gerrit.libreoffice.org/59655
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

... instead of letting them end up as 24:0:0

Change-Id: I0212a2b422a931a24fd2748aa2826a5b60d2a397
Reviewed-on: https://gerrit.libreoffice.org/59699Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Since anchored objects can contain paragraphs, considering all
of them to be "firstParagraphs" would generally be considered
an incorrect result. Browsing through the existing uses of
IsFirstPara.*InSection I didn't see any that looked like
it should be considered true if IsInShape.

Since this is the kind of gotcha that that the programmer
should be aware of, add it directly into the function instead
of requiring each use to have an additional qualification.

The following ooxml unit tests match these conditions, but
only one was fixed - the rest were unaffected since they just
avoided adding/removing dummy paragraphs.
fdo79540.docx - 5
tblppr-shape.docx - 5
ooo47778-3.odt- 5
ooo47778-4.odt- 5
textbox-rounded-corners.docx - 7
n780563.docx - 8
missing-path.docx - 10
floating-tables-anchor.docx - 10
tdf117805.odt - 11  (fixed - prevented extra section paragraphs)

Change-Id: I841475e214c194a673321c1229d9254dd07205f8
Reviewed-on: https://gerrit.libreoffice.org/59659
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I1310cb8f5f543f49f9667ee10cb26c9809df259e

Change-Id: Ida0ab3cd78514b2c10f8e6655becefe794217f8c

As such I am not convinced that this "dummy" replacement class
approach is the right thing; we don't do it like that elsewhere
either?

Change-Id: Ife912d9ed91bd26610ea40cf4b446beb2ed481ec

Change-Id: I222792dd34cd016196dfec9870161896c7c43b0d

Change-Id: I5a5b54872ce6ae351c6550a1ec0b2f7c52c35e13
Reviewed-on: https://gerrit.libreoffice.org/59683
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib05638865a42ad37c3382714e1790c7035ed8ebf
Reviewed-on: https://gerrit.libreoffice.org/59638Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4be97a5e93bd4cb08a9c25dc663883c2c5e8dd5e
Reviewed-on: https://gerrit.libreoffice.org/59682
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Some only-recently analyzed files were cleaned.
Also tried harder to use more fw decls instead of blacklisting

Change-Id: Ie4f8eb7065e44a2b5208d6da4fa8e3681a31820b
Reviewed-on: https://gerrit.libreoffice.org/59420
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Type "🐶" into Writer with e.g. the Liberation Serif font, glyph
layout doesn't execute, a literal 0 glyph id is rendered.

Fix the problem by returning the glyph items (to be inserted into a
cache) after handling glyph fallback.

Change-Id: I928b0087de309dbe04936c6e7732d79bec541596
Reviewed-on: https://gerrit.libreoffice.org/59665
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I437becdb0ed4840738d6c45d88cd3be2ff1243fb
Reviewed-on: https://gerrit.libreoffice.org/59591
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>