- 11 Haz, 2018 36 kayıt (commit)
-
-
Dennis Francis yazdı
The bug document has a formula cell (at O7) that depends on cells with non-default number formats, but this cell's number format was force set by the user to the default. So the mbNeedsNumberFormat for this ScFormulaCell object is now false. But when a copy to clip and paste as GDI metafile is made, this subtle information about the "user forced default number format" is lost. ScColumn::SetFormulaCell() is used while making the copies of the original formula cell to clipdoc and then to another document, where it sets the field mbNeedsNumberFormat of the formulacell to true if the number-format of the target cell is default. Note that the number-formats along with all attributes of the target cells are copied from the source before copying the actual cell contents. As a result, after copy pasting, the formulacell at O7 of the new document will have mbNeedsNumberFormat = true. This causes the attribute modification (in ScAttrArray of corresponding column) while Interpret()'ing the cell. Unfortunately this Interpret() happens while in a call to ScRefCellValue::hasNumeric() while in the middle of rendering the cell of the new document (in ScOutputData::LayoutStrings()), and naturally this messes up the ScPatternAttr references the view has been caching, hence the crash. The steps involved in the fix are :- 1. Carry around the state of mbNeedsNumberFormat in the copy-constructor of ScFormulaCell, in case the src formula-cell is not yet Interpret()'ed. Note that after Interpret() is done, the mbNeedsNumberFormat is set back to false and inherited numfmt is applied to attributes data structure. 2. In ScColumn::SetFormulaCell(), allow an optional param bInheritNumFormatIfNeeded (default = true). In that method, the mbNeedNumberFormat is set to true only if this flag is true and the cell format is default. So when the copy/paste operation is going on, we pass the mbNeedNumberFormat of the source formula-cell for the new parameter to SetFormulaCell(). Change-Id: I535e413d4bde4c33a5f6ad3ce01536d0e94e7074 Reviewed-on: https://gerrit.libreoffice.org/55555Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I5ba1f864b5fcf69e3437792f99d24367f5f5a44d Reviewed-on: https://gerrit.libreoffice.org/55603Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Takeshi Abe yazdı
It does not change only the date part nor the time part separately, thus holding single DateTime is sufficient. Change-Id: Ic619608ce7a961287c299698b9a004cbf7038702 Reviewed-on: https://gerrit.libreoffice.org/54058Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
-
ekuiitr yazdı
I got to know that, earlier the code I've submitted about line algorithm creates error. I've fixed that in this patch. Moreover, child width and height doesn't depend of nIncX and nIncY, so I've removed that code, it relates only to the position of the child. Change-Id: I9f4bdec87fc20340c21daed60246b9898967ab50 Reviewed-on: https://gerrit.libreoffice.org/55564Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ic8dd5523d774f84627cd13ad53508386071f92e9 Reviewed-on: https://gerrit.libreoffice.org/55606Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Id6a8ebdde5a08d9581c165a85f067ffaef490cab Reviewed-on: https://gerrit.libreoffice.org/55604Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Noel Grandin yazdı
look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I2ff0f1fff7302cbf884e35879c72df0dc09eede4 Reviewed-on: https://gerrit.libreoffice.org/55597Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Tamas Bunth yazdı
Change-Id: Id408f7a98011d806f01b6c63ae67008c4dba4b0d Reviewed-on: https://gerrit.libreoffice.org/55595Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
-
Stephan Bergmann yazdı
Change-Id: I14483c82490e17e9832215bc90a7f5870215bb93
-
andreas kainz yazdı
Change-Id: I8895c79a65750330600ebf0be19d184736fe2c1c Reviewed-on: https://gerrit.libreoffice.org/55543Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
-
Noel Grandin yazdı
regression from commit 79800559 convert MT_ constants to scoped enum The original code used bit-wise operations and some clever constant values, which I did not convert correctly Change-Id: I2fcd9e2584638d4a690773ef3f178415153b8b19 Reviewed-on: https://gerrit.libreoffice.org/55596Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Arkadiy Illarionov yazdı
Change-Id: I0e60ec7a3edae42b25ff0917828d0a893ed39a38 Reviewed-on: https://gerrit.libreoffice.org/55245Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
since we are now holding these via reference counting, no need to clone them Change-Id: I7b0bd86f4a5bca428f7dcd989f838a9aa0c7e179 Reviewed-on: https://gerrit.libreoffice.org/55427Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ied01f97a09d34c43f786c030fbdd256bcf849f04 Reviewed-on: https://gerrit.libreoffice.org/55535Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ic1e98a7efdd75a6c940c5ce81bfb414711c4ab37 Reviewed-on: https://gerrit.libreoffice.org/55534Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Icf2a8f2b334b1a0b9a7028fb1718710dd67c7a81 Reviewed-on: https://gerrit.libreoffice.org/55533Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I98b1a790fda68404cf13f21dbfb5b4493c849700 Reviewed-on: https://gerrit.libreoffice.org/55532Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I297f79d38b6e04a6df322f875f9410078a01c1f3 Reviewed-on: https://gerrit.libreoffice.org/55531Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Id3b59a5cfc0502042f0038fe4eacc780c2463660 Reviewed-on: https://gerrit.libreoffice.org/55530Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ib457e6894d233fa4737bb4a6488b37c5455ee098 Reviewed-on: https://gerrit.libreoffice.org/55529Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I8ba5a2e5800e88dcb6c17a8cf74bd315a9215918 Reviewed-on: https://gerrit.libreoffice.org/55528Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Icf91f59f1b874820ce707317e5deaf386fb9dbe5 Reviewed-on: https://gerrit.libreoffice.org/55527Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I08f00c00b22c6a680ec59d2e86eb035c58b17609 Reviewed-on: https://gerrit.libreoffice.org/55526Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ic2425c3b4068b3ec8ce6ba9f48311c7d2ab6e933 Reviewed-on: https://gerrit.libreoffice.org/55525Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I15828d7dca6569bb4792728e947feaaba47e8bf5 Reviewed-on: https://gerrit.libreoffice.org/55524Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I1a72613661d40a7de468a47c09e91c37d9d3dede Reviewed-on: https://gerrit.libreoffice.org/55523Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ic4bc1441802df3b62c1e8da69379f2677f243508 Reviewed-on: https://gerrit.libreoffice.org/55521Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I0bb696ccf8555fe597aaff1cb6ab74bf16d81731 Reviewed-on: https://gerrit.libreoffice.org/55520Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I7c9ec3bb26c6c329c66d684437bf934b9c2ad0e5 Reviewed-on: https://gerrit.libreoffice.org/55519Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I9a674cc87dc6aae4419389a7309304815ceb22ef Reviewed-on: https://gerrit.libreoffice.org/55518Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I8502e7695ad9d28d57d1cb5c7f01c7bacd4a69aa Reviewed-on: https://gerrit.libreoffice.org/55517Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I529a486b7b60306293089b776202810f84ab0126 Reviewed-on: https://gerrit.libreoffice.org/55516Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I47299326467e31b72094a4fa7de6dbe8dd3ced7e Reviewed-on: https://gerrit.libreoffice.org/55515Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
andreas kainz yazdı
Change-Id: Ibfc58322efb4f038298caff01f644a4ada78b69a Reviewed-on: https://gerrit.libreoffice.org/55568Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Olivier Hallot yazdı
Project: help 185624ce2dfea227f0357e417bb3615e88c95e8e tdf#116642 Fix COUNTIFS page + help makefiles + Add callateral file for COUNTIFS + Adjust makefiles + some tweaks in XSLT + adjust languages to gb_HELP_LANGS. Change-Id: I9d2684d20804b93fd0671621d28a8d786a101fdf Reviewed-on: https://gerrit.libreoffice.org/55493Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
-
- 10 Haz, 2018 4 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I9f182874551e7c1e32b2a00e72f7c3a8f1356fc3 Reviewed-on: https://gerrit.libreoffice.org/55461Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Zdeněk Crhonek yazdı
Change-Id: I7a718dd1cedb71e3c7430936a0f5b855af18090b Reviewed-on: https://gerrit.libreoffice.org/55563Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
-
Tor Lillqvist yazdı
In InterfaceOleWrapper::GetIDsOfNames(), look up also the parameter names, if present (if cNames > 1, rgszNames entries after the first). Return S_OK only if *all* the names were found, i.e. both the first (method or property) name, *and* all the parameter names. Change-Id: Ie04bc0558a7e2044ef527fc18f99230c71985a22 Reviewed-on: https://gerrit.libreoffice.org/55549Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
-
Regina Henschel yazdı
The only users were removed 18-Nov-2011 in commit ddb1d5eb, Felix Zhang. Change-Id: I3843d278881203f63f5daf24a3acf27b7d1f4aa9 Reviewed-on: https://gerrit.libreoffice.org/55562Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-