1. 13 Ara, 2018 7 kayıt (commit)
    • Stephan Bergmann's avatar
      Switch Android armeabi-v7a to libc++/libc++abi/libunwind too · 312eeeee
      Stephan Bergmann yazdı
      It had been left out in 4082a184 "android: use
      unified headers and llvm-c++ STL (x86) with NDK 16" because "arm unfortunately
      crashes with llvm-c++, so keep with gnustl for now/fix that later".
      
      Making armeabi-v7a work with libc++ etc. required a number of changes, listed
      below, in this commit and in preceding ones.  At least 32-bit x86 already worked
      with libc++ etc. prior to these changes in view mode, though it crashed in the
      experimental editing mode (enabled with strippedUIEditing in
      android/soruce/Makefile) as soon as one types in something,  But it is not
      entirely clear to me why 32-bit x86 view mode didn't also fail similar to how I
      saw armeabi-v7a fail.  (On 32-bit x86, these changes appear to neither improve
      nor worsen the current state, view mode still appears to work fine while editing
      still crashes upon typing anything.  With these changes, editing mode on
      armeabi-v7a appears to work fine.  But I tested armeabi-v7a only with a real
      device and 32-bit x86 only with an emulator, in case that might make a
      difference.)
      
      * Preceding <https://gerrit.libreoffice.org/#/c/64964/> "Move NSSLIBS to a more
        sensible place on the linker command line" plus this change's addition of
        -lunwind to the liblo-native-code.so linker command line make sure that
        liblo-native-code.so uses _Unwind_* functions from libunwind.a, instead of
        erroneously picking up the ones from libgcc.a that happen to be included in
        NSSLIB's nspr4 (-lgcc is automatically added to the end of the linker command
        line by the invoking compiler, that's how libgcc.a's _Unwind_* end up in
        NSSLIB's nspr4; it is neither clear to me why NSSLIB's nspr4, being a pure C
        library, uses _Unwind_* functions, nor why exception handling in
        liblo-native-code.so fails when using _Unwind_* functions from libgcc.a
        instead of from libunwind on armeabi-v7a, nor why that would work on 32-bit
        x86, but that's what I observed: ModuleManager::identify
        (framework/source/services/modulemanager.cxx) throws a
        css::lang::IllegalArgumentException, which calls __cxa_throw ->
        _Unwind_RaiseException, which ultimately lead to odd misbehavior and
        std::abort during stack unwinding when using _Unwind_RaiseException from
        libgcc.a instead of from libunwind).  (There is no libunwind.* in
        android-ndk-r16b for 32-bit x86 at least, so is presumably using _Unwind_*
        functions from libgcc.a.  It doesn't appear to make a difference if it
        indirectly uses those _Unwind_* functions from NSSLIB's nspr4, or directly
        from libgcc.a included in liblo-native-code.so if the
      
          $(if $(filter armeabi-v7a,$(ANDROID_APP_ABI)),-lunwind)
      
        had a ",-lgcc" else branch.)
      
      * Preceding <https://gerrit.libreoffice.org/#/c/64965/> "Export RTTI symbols
        from liblo-native-code.so, for binary UNO bridge" makes sure that excpetions
        thrown from the binary UNO bridge can be caught by compiled catch clauses.
        Not sure why the corresponding state of
        bridges/source/cpp_uno/gcc3_linux_intel shouldn't have run into the same
        issue.
      
      * Preceding <https://gerrit.libreoffice.org/#/c/64966/> "Adapt gcc3_linux_arm
        __cxa_exception to NDK 18 libc++abi" makes sure that our version of
        __cxa_exception matches the version from libc++abi.  This is clearly not
        relevant for 32-bit x86.  (The comment there android-ndk-r18b, but the
        additional member is already present in
        android-ndk-r16b/sources/cxx-stl/llvm-libc++abi/src/cxa_exception.hpp, too.)
      
      The remainder of this change just drops old armeabi-v7a--specific workarounds
      that are no longer needed/no longer work.
      
      Change-Id: Ief4c2d562c5032abe6c3b94ca3b3394be6fcd4d3
      Reviewed-on: https://gerrit.libreoffice.org/64973Tested-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      312eeeee
    • Stephan Bergmann's avatar
      Adapt gcc3_linux_arm __cxa_exception to NDK 18 libc++abi · 711f5233
      Stephan Bergmann yazdı
      ...which adds a member, and will be relevant when switching armeabi-v7a to
      libc++/libc++abi/libunwind (coming soon).
      
      Change-Id: I1f98f50ca299a583e73e0dbd6c8c94d973329f3a
      Reviewed-on: https://gerrit.libreoffice.org/64966
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      711f5233
    • Stephan Bergmann's avatar
      Export RTTI symbols from liblo-native-code.so, for binary UNO bridge · 357112d7
      Stephan Bergmann yazdı
      This will become important when switching armeabi-v7a to
      libc++/libc++abi/libunwind (coming soon) which uses address instead of string
      comparison when checking for type equality, so that exceptions thrown from the
      binary UNO bridge will need to use the exact same RTTI objects as referenced
      from the compiled catch clauses.
      
      Change-Id: If8bcb39212b5f5e154aee215cb5f471fe2dc4a7b
      Reviewed-on: https://gerrit.libreoffice.org/64965
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      357112d7
    • Stephan Bergmann's avatar
      Move NSSLIBS to a more sensible place on the linker command line · e465f9ae
      Stephan Bergmann yazdı
      511ae02c "Android: Enable HAVE_FEATURE_NSS and
      package the NSS libraries with apk" had added them to WHOLELIBS probably just
      because that already had the $(addprefix -l,...), even though --whole-archive
      doesn't make any sense for shared libraries.  Better place them later on the
      linker command line (after all our own archives and compiler support libraries),
      so that switching armeabi-v7a to libc++/libc++abi/libunwind (coming soon) will
      be able to override erroneously picking _Unwind_* symbols from NSSLIBS's nspr4
      instead of libunwind.
      
      Change-Id: Ie0c0b7a55da3eabe1bb427232d698b2a4af63e78
      Reviewed-on: https://gerrit.libreoffice.org/64964
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      e465f9ae
    • Stephan Bergmann's avatar
      Use declarations from cxxabi.h where available · 9ff5ca94
      Stephan Bergmann yazdı
      Change-Id: Ie92c9654c7ccc5cd4acde728b35311f251f740ac
      Reviewed-on: https://gerrit.libreoffice.org/64963
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      9ff5ca94
    • Dmitriy Shilin's avatar
      tdf#107792 vcl/win/gdi: shrink WinSalGraphicsImpl::MakePen API · 399af2e8
      Dmitriy Shilin yazdı
      Change-Id: I7d5752214a0c2f4891dcc023c6d573a8459b65f4
      Reviewed-on: https://gerrit.libreoffice.org/65037
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      399af2e8
    • Dmitriy Shilin's avatar
      tdf#107792 vcl/win/gdi: reduce number of return paths · 007396b2
      Dmitriy Shilin yazdı
      Change-Id: I3e7f00a10e76933424149a931042a0611ede5d47
      Reviewed-on: https://gerrit.libreoffice.org/65036
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      007396b2
  2. 12 Ara, 2018 33 kayıt (commit)
    • Serge Krot's avatar
      tdf#78611 mailmerge: new unit tests: numbering in headings · 7bbc1fd4
      Serge Krot yazdı
      Change-Id: I8672376dabcdc0011c59bb9ac5c32b8dbb88396d
      Reviewed-on: https://gerrit.libreoffice.org/65035
      Tested-by: Jenkins
      Reviewed-by: 's avatarThorsten Behrens <Thorsten.Behrens@CIB.de>
      7bbc1fd4
    • Jan-Marek Glogowski's avatar
      tdf#117295 WIN no main loop shortcut for OLE dialog · 5bb798a9
      Jan-Marek Glogowski yazdı
      Normally we handle Idle events directly without posting events
      to the main event queue, as there seem to be no way to post them
      to the end of the queue and this starves system events.
      
      This prevents using this short-cut, as the default Windows event
      processing doesn't know of this special handling.
      Eventually this hack should be removed by simply always processing
      all pending events...
      
      Change-Id: If9ae81ca7e847743f9251343e106dbf566371584
      Reviewed-on: https://gerrit.libreoffice.org/65040
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      5bb798a9
    • Miklos Vajna's avatar
      oox smartart, continuous block process: read space width from constraint · ee6787fc
      Miklos Vajna yazdı
      The information is needed by the linear layout, but it's provided by a
      child algorithm of type "space", with possibly multiple foreach atoms
      in-between.
      
      So start supporting a custom space factor by reading it from
      constraints, but still assume a fixed layout node name, as it's tricky
      to look that up.
      
      Change-Id: I2aa8db8823694618d8ca6707ddcd71715a65b831
      Reviewed-on: https://gerrit.libreoffice.org/65049Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      Tested-by: Jenkins
      ee6787fc
    • Eike Rathke's avatar
      Reset WelfordRunner in ScDPAggData::Reset() · ec3ab1c6
      Eike Rathke yazdı
      Change-Id: I170b6bc5557f6d0d982751ace3dccc94c6778808
      Reviewed-on: https://gerrit.libreoffice.org/65048Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
      Tested-by: Jenkins
      ec3ab1c6
    • Caolán McNamara's avatar
      Resolves: tdf#116098 avoid ctrl+shift+e as a default shortcut · 34485845
      Caolán McNamara yazdı
      Change-Id: Id5ec45290a0829d15a0d88a68d2ed891b9dae195
      Reviewed-on: https://gerrit.libreoffice.org/65041
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      34485845
    • Caolán McNamara's avatar
      expand normal tabs if overflow is active · 88fac446
      Caolán McNamara yazdı
      Change-Id: I4033fcb2c34c70eff554998752f93865ee1c9230
      Reviewed-on: https://gerrit.libreoffice.org/65046
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      88fac446
    • Caolán McNamara's avatar
      add activates.default, etc · a99f269b
      Caolán McNamara yazdı
      Change-Id: Idc3e86d8b0f18a1910c6cde691e96fb8b04e8669
      Reviewed-on: https://gerrit.libreoffice.org/65016Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      a99f269b
    • Caolán McNamara's avatar
      drop unused SwCaptionPreview · 7b8f23c1
      Caolán McNamara yazdı
      an rename CaptionPreview back to SwCaptionPreview
      
      Change-Id: I24d6f2c66f1c2b152b7d625501ea6fe39d2161ae
      Reviewed-on: https://gerrit.libreoffice.org/65015
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      7b8f23c1
    • Caolán McNamara's avatar
      weld SwCaptionDialog · 72ebf150
      Caolán McNamara yazdı
      Change-Id: I5babfbf3489f88c5d6cdeffbd514d86368f04fa9
      Reviewed-on: https://gerrit.libreoffice.org/65014
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      72ebf150
    • Caolán McNamara's avatar
      weld SwCaptionOptDlg · 320e8d38
      Caolán McNamara yazdı
      Change-Id: Iac2cb2ab3239e23a64dbc528f0d07d4071c4815c
      Reviewed-on: https://gerrit.libreoffice.org/65011
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      320e8d38
    • Caolán McNamara's avatar
      weld SwCaptionOptPage · 3bd10306
      Caolán McNamara yazdı
      Change-Id: I3373a39d6d8b39717b7aec69544a9d2957db15d8
      Reviewed-on: https://gerrit.libreoffice.org/65010
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      3bd10306
    • Michael Meeks's avatar
      tdf#122020 - avoid nullptr deref. · 27995e63
      Michael Meeks yazdı
      Change-Id: Iaa63a90841523061490d207ba5403de26d5c0025
      Reviewed-on: https://gerrit.libreoffice.org/65005
      Tested-by: Jenkins
      Reviewed-by: 's avatarXisco Faulí <xiscofauli@libreoffice.org>
      27995e63
    • Jan-Marek Glogowski's avatar
      Qt5+kde4 don't override generic VCL style settings · 89c888b4
      Jan-Marek Glogowski yazdı
      In commit 3911bf83 ("tdf#98253 Qt5 rely on VCL for
      SetDeactiveColor") the named was dropped from the Qt5 styling.
      This results in SetDeactiveColor now being controlled by LO,
      but SetActiveColor by the Qt theming.
      
      But IMHO both need to be managed together in some way, as the
      deactive color is normally some variant of active with a lower
      opacity.
      Also no other backends except Windows and headless even
      overide the four general colors Set(De|A)ctive(Text)?Color and
      Windows is setting them from the window decorations (CAPTION)?!
      
      So let's get rid of all these settings for Qt5 and kde4.
      
      Change-Id: Id9497dc067e4718d25d24c5795589b6c028a8817
      Reviewed-on: https://gerrit.libreoffice.org/65028
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      89c888b4
    • Jan-Marek Glogowski's avatar
      Qt5 fix the clang plugin build · 588f1cca
      Jan-Marek Glogowski yazdı
      ... and fix the global Qt* and wrong included headers.
      
      Change-Id: I436628d3a2d4469d5cc72f9fe7f394426d86fb2e
      Reviewed-on: https://gerrit.libreoffice.org/65023
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      588f1cca
    • Mike Kaganski's avatar
      tdf#104277 follow-up: use svtools::executeRestartDialog · 2b6bd096
      Mike Kaganski yazdı
      This harmonizes this setting's prompt with other places asking for restart.
      Related obsolete strings are removed.
      
      Change-Id: I2da63585747056714eb688681194acd35550e1c7
      Reviewed-on: https://gerrit.libreoffice.org/65022
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      2b6bd096
    • Winfried Donkers's avatar
      tdf#69569 implement proposed change to ODF1.2 part 2 §4.11.7.7 · 22be500b
      Winfried Donkers yazdı
      Calculating the number of days in a year in AddIn function GetDaysInYear()
      for basis 1 (actual/actual) gave wrong results.
      Now the results are correct and the same as in Excel.
      
      Extended the unit test document for function YEARFRAC and corrected the
      unit test document for function AMORDEGRC (verified the results with Excel).
      
      Change-Id: Ic68f108496f41dec71b3616095dff80512a64c31
      Reviewed-on: https://gerrit.libreoffice.org/64837
      Tested-by: Jenkins
      Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
      22be500b
    • Mike Kaganski's avatar
      tdf#122038: don't create another RestartDialog if already restarting · 12edea42
      Mike Kaganski yazdı
      otherwise it crashes/aborts in Window::dispose() with this backtrace:
      
      ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28
      	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28)
      ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154
      	at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154)
      ucrtbased.dll!abort() Line 61
      	at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
      vcllo.dll!SalAbort(const rtl::OUString & rErrorText, bool bDumpCore) Line 309
      	at c:\lo\src\core\vcl\source\app\salplug.cxx(309)
      vcllo.dll!Application::Abort(const rtl::OUString & rErrorText) Line 270
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(270)
      vcllo.dll!vcl::Window::dispose() Line 275
      	at c:\lo\src\core\vcl\source\window\window.cxx(275)
      vcllo.dll!SystemWindow::dispose() Line 114
      	at c:\lo\src\core\vcl\source\window\syswin.cxx(114)
      vcllo.dll!Dialog::dispose() Line 647
      	at c:\lo\src\core\vcl\source\window\dialog.cxx(647)
      vcllo.dll!VclReferenceBase::disposeOnce() Line 43
      	at c:\lo\src\core\vcl\source\outdev\vclreferencebase.cxx(43)
      tklo.dll!VclPtr<vcl::Window>::disposeAndClear() Line 206
      	at c:\lo\src\core\include\vcl\vclptr.hxx(206)
      tklo.dll!UnoWrapper::WindowDestroyed(vcl::Window * pWindow) Line 294
      	at c:\lo\src\core\toolkit\source\helper\unowrapper.cxx(294)
      vcllo.dll!vcl::Window::dispose() Line 233
      	at c:\lo\src\core\vcl\source\window\window.cxx(233)
      vcllo.dll!SystemWindow::dispose() Line 114
      	at c:\lo\src\core\vcl\source\window\syswin.cxx(114)
      vcllo.dll!WorkWindow::dispose() Line 129
      	at c:\lo\src\core\vcl\source\window\wrkwin.cxx(129)
      vcllo.dll!VclReferenceBase::disposeOnce() Line 43
      	at c:\lo\src\core\vcl\source\outdev\vclreferencebase.cxx(43)
      tklo.dll!VclPtr<OutputDevice>::disposeAndClear() Line 206
      	at c:\lo\src\core\include\vcl\vclptr.hxx(206)
      tklo.dll!VCLXWindow::dispose() Line 947
      	at c:\lo\src\core\toolkit\source\awt\vclxwindow.cxx(947)
      fwklo.dll!`anonymous namespace'::XFrameImpl::disposing() Line 2184
      	at c:\lo\src\core\framework\source\services\frame.cxx(2184)
      cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::dispose() Line 105
      	at c:\lo\src\core\cppuhelper\source\implbase.cxx(105)
      fwklo.dll!cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo,com::sun::star::frame::XFrame2,com::sun::star::awt::XWindowListener,com::sun::star::awt::XTopWindowListener,com::sun::star::awt::XFocusListener,com::sun::star::document::XActionLockable,com::sun::star::util::XCloseable,com::sun::star::frame::XComponentLoader,com::sun::star::frame::XTitle,com::sun::star::frame::XTitleChangeBroadcaster,com::sun::star::beans::XPropertySet,com::sun::star::beans::XPropertySetInfo>::dispose() Line 90
      	at c:\lo\src\core\include\cppuhelper\compbase.hxx(90)
      fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Line 1716
      	at c:\lo\src\core\framework\source\services\frame.cxx(1716)
      fwklo.dll!framework::Desktop::impl_closeFrames(bool bAllowUI) Line 1743
      	at c:\lo\src\core\framework\source\services\desktop.cxx(1743)
      fwklo.dll!framework::Desktop::terminate() Line 233
      	at c:\lo\src\core\framework\source\services\desktop.cxx(233)
      comphelper.dll!comphelper::OOfficeRestartManager::notify(const com::sun::star::uno::Any & __formal) Line 109
      	at c:\lo\src\core\comphelper\source\misc\officerestartmanager.cxx(109)
      tklo.dll!`anonymous namespace'::AsyncCallback::Notify_Impl(`anonymous-namespace'::AsyncCallback * __formal, void * p) Line 105
      	at c:\lo\src\core\toolkit\source\awt\asynccallback.cxx(105)
      tklo.dll!`anonymous namespace'::AsyncCallback::LinkStubNotify_Impl(void * instance, void * data) Line 97
      	at c:\lo\src\core\toolkit\source\awt\asynccallback.cxx(97)
      vcllo.dll!Link<void *,void>::Call(void * data) Line 84
      	at c:\lo\src\core\include\tools\link.hxx(84)
      vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1935
      	at c:\lo\src\core\vcl\source\window\winproc.cxx(1935)
      vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2486
      	at c:\lo\src\core\vcl\source\window\winproc.cxx(2486)
      vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285
      	at c:\lo\src\core\vcl\inc\salframe.hxx(285)
      vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4068
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(4068)
      vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5721
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(5721)
      vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(5828)
      user32.dll!UserCallWinProcCheckWow()
      user32.dll!CallWindowProcW()
      opengl32.dll!wglWndProc()
      user32.dll!UserCallWinProcCheckWow()
      user32.dll!DispatchMessageWorker()
      vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(410)
      vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 441
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(441)
      vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(512)
      vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(441)
      vcllo.dll!Application::Yield() Line 506
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(506)
      vcllo.dll!Dialog::Execute() Line 1041
      	at c:\lo\src\core\vcl\source\window\dialog.cxx(1041)
      vcllo.dll!SalInstanceDialog::run() Line 881
      	at c:\lo\src\core\vcl\source\app\salvtables.cxx(881)
      vcllo.dll!weld::DialogController::run() Line 1364
      	at c:\lo\src\core\include\vcl\weld.hxx(1364)
      svtlo.dll!svtools::executeRestartDialog(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & context, weld::Window * parent, svtools::RestartReason reason) Line 101
      	at c:\lo\src\core\svtools\source\dialogs\restartdialog.cxx(98)
      cuilo.dll!OfaTreeOptionsDialog::OKHdl_Impl(Button * __formal) Line 735
      	at c:\lo\src\core\cui\source\options\treeopt.cxx(735)
      cuilo.dll!OfaTreeOptionsDialog::LinkStubOKHdl_Impl(void * instance, Button * data) Line 704
      	at c:\lo\src\core\cui\source\options\treeopt.cxx(704)
      vcllo.dll!Link<Button *,void>::Call(Button * data) Line 84
      	at c:\lo\src\core\include\tools\link.hxx(84)
      vcllo.dll!Button::Click::__l2::<lambda>() Line 125
      	at c:\lo\src\core\vcl\source\control\button.cxx(125)
      vcllo.dll!std::_Invoker_functor::_Call<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & _Obj)
      vcllo.dll!std::invoke<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & _Obj)
      vcllo.dll!std::_Invoker_ret<void,1>::_Call<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & <_Vals_0>)
      vcllo.dll!std::_Func_impl_no_alloc<void <lambda>(void),void>::_Do_call()
      vcllo.dll!std::_Func_class<void>::operator()()
      vcllo.dll!Control::ImplCallEventListenersAndHandler(VclEventId nEvent, const std::function<void __cdecl(void)> & callHandler) Line 321
      	at c:\lo\src\core\vcl\source\control\ctrl.cxx(321)
      vcllo.dll!Button::Click() Line 125
      	at c:\lo\src\core\vcl\source\control\button.cxx(125)
      vcllo.dll!OKButton::Click() Line 1737
      	at c:\lo\src\core\vcl\source\control\button.cxx(1737)
      vcllo.dll!PushButton::Tracking(const TrackingEvent & rTEvt) Line 1260
      	at c:\lo\src\core\vcl\source\control\button.cxx(1260)
      vcllo.dll!vcl::Window::EndTracking(TrackingEventFlags nFlags) Line 320
      	at c:\lo\src\core\vcl\source\window\window2.cxx(320)
      vcllo.dll!ImplHandleMouseEvent(const VclPtr<vcl::Window> & xWindow, MouseNotifyEvent nSVEvent, bool bMouseLeave, long nX, long nY, unsigned __int64 nMsgTime, unsigned short nCode, MouseEventModifiers nMode) Line 703
      	at c:\lo\src\core\vcl\source\window\winproc.cxx(703)
      vcllo.dll!ImplHandleSalMouseButtonUp(vcl::Window * pWindow, const SalMouseEvent * pEvent) Line 1998
      	at c:\lo\src\core\vcl\source\window\winproc.cxx(1998)
      vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2336
      	at c:\lo\src\core\vcl\source\window\winproc.cxx(2336)
      vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285
      	at c:\lo\src\core\vcl\inc\salframe.hxx(285)
      vclplug_winlo.dll!ImplHandleMouseMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 3120
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(3120)
      vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5475
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(5475)
      vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(5828)
      user32.dll!UserCallWinProcCheckWow()
      user32.dll!CallWindowProcW()
      opengl32.dll!wglWndProc()
      user32.dll!UserCallWinProcCheckWow()
      user32.dll!DispatchMessageWorker()
      vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(410)
      vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 483
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(483)
      vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(512)
      vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(441)
      vcllo.dll!Application::Yield() Line 506
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(506)
      vcllo.dll!Dialog::Execute() Line 1041
      	at c:\lo\src\core\vcl\source\window\dialog.cxx(1041)
      cuilo.dll!OfaTreeOptionsDialog::Execute() Line 2040
      	at c:\lo\src\core\cui\source\options\treeopt.cxx(2040)
      cuilo.dll!CuiVclAbstractDialog_Impl::Execute() Line 112
      	at c:\lo\src\core\cui\source\factory\dlgfact.cxx(112)
      sfxlo.dll!SfxApplication::OfaExec_Impl(SfxRequest & rReq) Line 1361
      	at c:\lo\src\core\sfx2\source\appl\appserv.cxx(1361)
      sfxlo.dll!SfxStubSfxApplicationOfaExec_Impl(SfxShell * pShell, SfxRequest & rReq) Line 1248
      	at c:\lo\src\core\workdir\sditarget\sfx2\sdi\sfxslots.hxx(1248)
      sfxlo.dll!SfxShell::CallExec(void(*)(SfxShell *, SfxRequest &) pFunc, SfxRequest & rReq) Line 207
      	at c:\lo\src\core\include\sfx2\shell.hxx(207)
      sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, bool bRecord) Line 356
      	at c:\lo\src\core\sfx2\source\control\dispatch.cxx(356)
      sfxlo.dll!SfxDispatcher::Execute_(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, SfxCallMode eCallMode) Line 854
      	at c:\lo\src\core\sfx2\source\control\dispatch.cxx(854)
      sfxlo.dll!SfxDispatcher::Execute(unsigned short nSlot, SfxCallMode nCall, const SfxItemSet * pArgs, const SfxItemSet * pInternalArgs, unsigned short nModi) Line 913
      	at c:\lo\src\core\sfx2\source\control\dispatch.cxx(913)
      sfxlo.dll!SfxDispatchController_Impl::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & rListener) Line 774
      	at c:\lo\src\core\sfx2\source\control\unoctitm.cxx(774)
      sfxlo.dll!SfxOfficeDispatch::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs) Line 225
      	at c:\lo\src\core\sfx2\source\control\unoctitm.cxx(225)
      fwklo.dll!framework::MenuBarManager::Select(Menu * pMenu) Line 896
      	at c:\lo\src\core\framework\source\uielement\menubarmanager.cxx(896)
      fwklo.dll!framework::MenuBarManager::LinkStubSelect(void * instance, Menu * data) Line 832
      	at c:\lo\src\core\framework\source\uielement\menubarmanager.cxx(832)
      vcllo.dll!Link<Menu *,bool>::Call(Menu * data) Line 84
      	at c:\lo\src\core\include\tools\link.hxx(84)
      vcllo.dll!Menu::Select() Line 362
      	at c:\lo\src\core\vcl\source\window\menu.cxx(362)
      vcllo.dll!Menu::ImplCallSelect(void * __formal) Line 2140
      	at c:\lo\src\core\vcl\source\window\menu.cxx(2140)
      vcllo.dll!Menu::LinkStubImplCallSelect(void * instance, void * data) Line 2136
      	at c:\lo\src\core\vcl\source\window\menu.cxx(2136)
      vcllo.dll!Link<void *,void>::Call(void * data) Line 84
      	at c:\lo\src\core\include\tools\link.hxx(84)
      vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1935
      	at c:\lo\src\core\vcl\source\window\winproc.cxx(1935)
      vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2486
      	at c:\lo\src\core\vcl\source\window\winproc.cxx(2486)
      vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285
      	at c:\lo\src\core\vcl\inc\salframe.hxx(285)
      vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4068
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(4068)
      vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5721
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(5721)
      vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828
      	at c:\lo\src\core\vcl\win\window\salframe.cxx(5828)
      user32.dll!UserCallWinProcCheckWow()
      user32.dll!CallWindowProcW()
      opengl32.dll!wglWndProc()
      user32.dll!UserCallWinProcCheckWow()
      user32.dll!DispatchMessageWorker()
      vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(410)
      vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 441
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(441)
      vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512
      	at c:\lo\src\core\vcl\win\app\salinst.cxx(512)
      vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(441)
      vcllo.dll!Application::Yield() Line 506
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(506)
      vcllo.dll!Application::Execute() Line 422
      	at c:\lo\src\core\vcl\source\app\svapp.cxx(422)
      sofficeapp.dll!desktop::Desktop::Main() Line 1619
      	at c:\lo\src\core\desktop\source\app\app.cxx(1619)
      vcllo.dll!ImplSVMain() Line 199
      	at c:\lo\src\core\vcl\source\app\svmain.cxx(199)
      vcllo.dll!SVMain() Line 234
      	at c:\lo\src\core\vcl\source\app\svmain.cxx(234)
      sofficeapp.dll!soffice_main() Line 169
      	at c:\lo\src\core\desktop\source\app\sofficemain.cxx(169)
      soffice.bin!sal_main() Line 48
      	at c:\lo\src\core\desktop\source\app\main.c(48)
      soffice.bin!main(int argc, char * * argv) Line 47
      	at c:\lo\src\core\desktop\source\app\main.c(47)
      soffice.bin!invoke_main() Line 79
      	at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(79)
      soffice.bin!__scrt_common_main_seh() Line 288
      	at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288)
      soffice.bin!__scrt_common_main() Line 331
      	at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(331)
      soffice.bin!mainCRTStartup() Line 17
      	at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp(17)
      kernel32.dll!BaseThreadInitThunk()
      ntdll.dll!RtlUserThreadStart()
      
      Change-Id: I0518c48e48a50b99a2a1eaf17335e116d63bc587
      Reviewed-on: https://gerrit.libreoffice.org/65007Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      Tested-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      12edea42
    • Stephan Bergmann's avatar
      Make android/mobile-config.py compatible with Python 3 · 617b4bc8
      Stephan Bergmann yazdı
      Change-Id: I079c4efd28e7e0d10ca6edf242ddd85b9294db08
      Reviewed-on: https://gerrit.libreoffice.org/64962
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      617b4bc8
    • Noel Grandin's avatar
      use unique_ptr in createTransformedClone · 56ff7f77
      Noel Grandin yazdı
      Change-Id: I224f2ab64188d0df8f4a587af65f6bf80359a9de
      Reviewed-on: https://gerrit.libreoffice.org/65006
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      56ff7f77
    • Martin van Zijl's avatar
      tdf#95003 inserted frame loses background color · 083341cb
      Martin van Zijl yazdı
      The Area tab settings in the Insert Frame dialog are now applied
      correctly (including color).
      
      Change-Id: Id152c9409595970078970b43068a7ee594827d2b
      Reviewed-on: https://gerrit.libreoffice.org/64990
      Tested-by: Jenkins
      Reviewed-by: 's avatarTamás Zolnai <tamas.zolnai@collabora.com>
      083341cb
    • Caolán McNamara's avatar
      weld SwAddStylesDlg · 6236051a
      Caolán McNamara yazdı
      Change-Id: I1dfdf0cea69585991bc0fa8dc38ebdf78abe97bf
      Reviewed-on: https://gerrit.libreoffice.org/64976
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      6236051a
    • Sumit Chauhan's avatar
      tdf#98253 Qt5 rely on VCL for SetDeactiveColor · 3911bf83
      Sumit Chauhan yazdı
      Keep the DeactiveColor from generic vcl style without overriding it
      with the Qt5 style.
      
      Change-Id: I10ffdc79e1b6878d27ae13c6394ad50d7470f073
      Reviewed-on: https://gerrit.libreoffice.org/64522
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      3911bf83
    • Dmitriy Shilin's avatar
      tdf#107792 vcl: split MakeBrush into functions · 773a29a3
      Dmitriy Shilin yazdı
      Change-Id: I531442ca1e121c059fb21bd86ff0c6ac7fa0cac4
      Reviewed-on: https://gerrit.libreoffice.org/64914
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      773a29a3
    • Xisco Fauli's avatar
      tdf#122009: Hide notebookbar in full screen · 3b6ee27e
      Xisco Fauli yazdı
      Follow same logic as in presentation mode. See
      6a932680
      
      Change-Id: I89c31e23dd97e647ab380aa30635acda46064b2f
      Reviewed-on: https://gerrit.libreoffice.org/64911
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      Reviewed-by: 's avatarHeiko Tietze <tietze.heiko@gmail.com>
      Tested-by: 's avatarHeiko Tietze <tietze.heiko@gmail.com>
      3b6ee27e
    • himajin100000's avatar
      "functionor" to "function or", and added missing quote · a95815fa
      himajin100000 yazdı
      Change-Id: I647abff8c149b84aa7196e81d0820b23d8b93dd0
      Reviewed-on: https://gerrit.libreoffice.org/64890
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      a95815fa
    • Noel Grandin's avatar
      use std::<some_container>::swap, instead of copy and clear · d49e2e46
      Noel Grandin yazdı
      Change-Id: If49c33e271426ff5c2d0c6cc4010670f797bdd38
      Reviewed-on: https://gerrit.libreoffice.org/65001
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      d49e2e46
    • Katarina Behrens's avatar
      tdf#120454: Implement native rendering of tooltips · e4e28359
      Katarina Behrens yazdı
      side-step the entire misery of proper positioning of non-native
      tooltips just like in gtk3
      
      Change-Id: I09a75fae672d3d999c946c50c547d5f2cfa3ec14
      Reviewed-on: https://gerrit.libreoffice.org/64956
      Tested-by: Jenkins
      Reviewed-by: 's avatarKatarina Behrens <Katarina.Behrens@cib.de>
      e4e28359
    • Alain Romedenne's avatar
      Update git submodules · ce0ba2c9
      Alain Romedenne yazdı
      * Update helpcontent2 from branch 'master'
        - StarDesktop object and reorder indexes
          
          Add StarDesktop object description
          Reorder "Other commands" to add UNO objects
          
          Change-Id: Ia6547ea059276f8946b03392d29d968187bcd26c
      Signed-off-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          Reviewed-on: https://gerrit.libreoffice.org/64981
          Tested-by: Jenkins
          
      ce0ba2c9
    • Noel Grandin's avatar
      use unique_ptr in SfxChildWinContextCtor · 2b7e9314
      Noel Grandin yazdı
      Change-Id: I5ad26f30704708aac42f2c48fa38382c38f98b2a
      Reviewed-on: https://gerrit.libreoffice.org/64998
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      2b7e9314
    • Noel Grandin's avatar
      use unique_ptr in SfxChildWinCtor · 0bab9c02
      Noel Grandin yazdı
      Change-Id: I155036f6a47c765595938ff325ede6bbe6dd5c48
      Reviewed-on: https://gerrit.libreoffice.org/65000
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      0bab9c02
    • Caolán McNamara's avatar
      m_EntryList just shadows ComboBox entries · 25f06457
      Caolán McNamara yazdı
      seems CaptionComboBox has devolved to a ComboBox that doesn't allow typing
      space
      
      Change-Id: I6beffaa8157eb91f0fd9fbe7f0de92a54e97470c
      Reviewed-on: https://gerrit.libreoffice.org/64979
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      25f06457
    • Caolán McNamara's avatar
      GetEntryCount is 0 at ctor time · b5f372f5
      Caolán McNamara yazdı
      Change-Id: I01ae503df29dbce12b10d661072a7a45e2336d2e
      Reviewed-on: https://gerrit.libreoffice.org/64978
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      b5f372f5
    • Caolán McNamara's avatar
      m_DelEntryList is unused · 4309a966
      Caolán McNamara yazdı
      since...
      
      commit 08da15ca
      Author: Jakub Trzebiatowski <ubap.dev@gmail.com>
      Date:   Fri Mar 11 20:58:34 2016 +0100
      
          tdf#90855 Improve the 'Insert Bookmark' dialog
      
      Change-Id: Iabe462ddcfc2ea1a0eaeafe0d126f87158db97fd
      Reviewed-on: https://gerrit.libreoffice.org/64977
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      4309a966