Change-Id: I91806c3a55905dfd1ae90a10bc890cc526ff3270
Reviewed-on: https://gerrit.libreoffice.org/11908Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

...to keep UBSan from complaining about illegal downcasts from FormulaToken to
ScToken (which were practically harmless, given that ScToken did not add any
data members).

Change-Id: I8fdc026eec363442cc4b720b71d65c972b4a4446

Change-Id: I03daf7bb68ed33d9610b7ef19d3bd6c18dc8170f

Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07

...so that default implementations can return nullptr without further ado

Change-Id: Idc8778fe868efa00b1de597a54aa07a2e6fa3bc0

Change-Id: I2c81f24a27ede9922ed8ff16cf0ea4af824e9e59

Change-Id: I94f330d31f142bbeea2274597c855481cb311e0c

...and rename to extendRangeReference to avoid confusion with
formula::FormulaCompiler::ExtendRangeReference.

Change-Id: Ifcad309c14e04a0e37c80ca44462da587387241d

Change-Id: I5f27054ef2f9fdc4d0be0afe91ad31d053976bcf

'error: comparison is always true due to limited range of data type'

So just make the underlying type be 'signed int'

Change-Id: Ibf4ff72d85d33e88b7506289c622d34773ca259a

... as reported by sberg via UBSan in CppunitTest_sw_mailmerge:

> sw/source/core/txtnode/thints.cxx:3207:38: runtime error: downcast of address 0x000003cadcb0 which does not point to an object of type 'SwTxtAttrNesting'
> 0x000003cadcb0: note: object is of type 'SwTxtInputFld'
> #0 in SwpHints::TryInsertHint(SwTxtAttr*, SwTxtNode&, unsigned short) sw/source/core/txtnode/thints.cxx:3207:13
> #1 in SwTxtNode::InsertHint(SwTxtAttr*, unsigned short) sw/source/core/txtnode/thints.cxx:1583:25
> #2 in SwTxtNode::SetAttr(SfxItemSet const&, int, int, unsigned short) sw/source/core/txtnode/thints.cxx:1943:39
> #3 in SwRegHistory::InsertItems(SfxItemSet const&, int, int, unsigned short) sw/source/core/undo/rolbck.cxx:1390:28
> #4 in (anonymous namespace)::lcl_InsAttr(SwDoc*, SwPaM const&, SfxItemSet const&, unsigned short, SwUndoAttr*, bool) sw/source/core/doc/DocumentContentOperationsManager.cxx:1169:28
> #5 in sw::DocumentContentOperationsManager::InsertPoolItem(SwPaM const&, SfxPoolItem const&, unsigned short, bool) sw/source/core/doc/DocumentContentOperationsManager.cxx:3041:23
> #6 in SwXTextField::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sw/source/core/unocore/unofield.cxx:1966:13 > #7 in non-virtual thunk to SwXTextField::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) sw/source/core/unocore/unofield.cxx:2061:1

The SwTxtInputFld is unusual because it's both a field and has a range;
let's try to use virtual inheritance to inherit both from
SwTxtFld and SwTxtAttrNesting.  Sadly requires dynamic_cast everywhere.

Change-Id: I69f834d2b78ef7cdaac1f554bd80711084efcd02

Conflicts:
	svx/source/svdraw/svdotxat.cxx

Change-Id: Ie1c94a4c241352c580d2509529919806f01ed6c0

Change-Id: I4f878eff707e318fa80b7d3c19833bf724e4bcef

No need to call this (rather expensive) method twice.

Change-Id: I4c0a54acd1da0b8504ae7eb96beda4a8531943c7

No need to call this again in the caller.

Change-Id: Ib36853cf5a0720082275e0490b4443cd9e0bd007

Change-Id: I6ebf849243000920b1c1f7e67d2dc81fcee9e16b

Armin removed their uses in 120e469d.

Conflicts:
	svx/source/svdraw/svdotxtr.cxx

Change-Id: Id620466929ca3a66dd1c261e81aacd533a44cd76

Change-Id: Iece61424e09fc36768889fde2c848ed2b0722701

Change-Id: I6392eaceb0544b7faa9a0c726acf6619d971dbb7

Change-Id: Ia369bf99a5e381a6f1f9c3d8a2499aa1780f04b8

Change-Id: I26dce2dd11792ee118e78d23d652a5feb0789830

Change-Id: I0d3d1d9ab5f7bc270c89a2a98d45ebea3cc37e02

Otherwise we'd have to unnecessarily re-calculate the script types again
which is not cheap...

Change-Id: Ie589fb4a7e5ec9b5ef646dabea4e6bd0c0aca560

But only when the column contains only standard number format types.

Change-Id: I83982d2e87f9776cf03754beaf183e35675be992

Change-Id: Ifca77ccda7b2065b00ee29f29f377da599929843

Change-Id: Ib81ef144f168fed38100127bd63f43ea5a835a13

That's what the ods import filter does.

Change-Id: Ibcd9a80a51785a448594d29a02283cca0ec53e95

Change-Id: I7b42a4418408ee2c988c32e7f1adeee3dfe269c8

during import.  We'll then use this information to set script type to latin
for all numeric cells in those columns rather than leaving the script type
'unknown'.

Change-Id: I69eae1effc32c57290b0265bc6c87e58f51944b1

Since that method was really an optimization for xls(x) import code.

Change-Id: Ie2530f5dc27411bd45d72440681689c6c7a8b10a

This is slightly faster than doing it on a as-needed basis.

Change-Id: I7618f003f3c98ee894c3f1cf597681e4281cc6ab

Change-Id: Ib49a7a3eccee62e5496f7f19824631866e072b6a

Change-Id: I09b79bc76ffc55e25c24bbfa8f000f4a46df0a1c

Note that the original code would first set the rotation reference value
stored in the Xf, then later unconditionally overwrite it according to
the border setting.  The new code only ports the second part.  Perhaps
there was a bug in the original code....

Change-Id: I15b6839e9a58e8070a43db70e1a88b42ed99f2d8

Change-Id: I28decfdfd8248fb9b95416b9b269a4ffabcc6370

The problem was that in case we had {\revised foo {bar}}, then we only
started a redline before "foo", but we ended it twice: during handling
of both "}". Make sure that the end of the redline is only handled by
the second one.

Change-Id: I41ab8b486e8615d3479fa0fadd6016476859b4b2

Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640

The end goal is to convert the Sidebar to use
SvxColorToolBoxControl, and get rid of the Sidebar
specific color popup, so we don't need to maintain
two popups.

Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07

Change-Id: I0fe5d3b305c5105e987fcae90f2733b373fecc73

Change-Id: Ic0efcf61e43864d531721474540ec138033bffe6