09:28 <@sberg> vmiklos, I think I ran into a scenario last night where I had
both `git add`-ed and non-added changes in a non-blacklisted file, and the
non-added changes violated clang-format (and the added ones did not), and the
commit hook complained

So make sure we validate the index version, not the filesystem one.

(And modify a formatted file to trigger CI validation of the hook change
itself.)

Change-Id: I6431b35ac50dd03741104b5709c5195d6ff28632
Reviewed-on: https://gerrit.libreoffice.org/46368Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ib18f61f10225d5499f94144c8a0f9efff40e43aa
Reviewed-on: https://gerrit.libreoffice.org/46366Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

"Indirect" calls to isSallCallFunction (for canonic and overridden
FunctionDecls) already needed to handle many cases of FunctionDecls spanning
macros, so it isn't that much more work to make that also work for cases called
directly from VisitFunctionDecl.

Change-Id: I529f148c8872b86aa1ef082c6cb73db8ab1866e7
Reviewed-on: https://gerrit.libreoffice.org/46367Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I58fb10136a23c445edfd63a1f86ace3995524704
Reviewed-on: https://gerrit.libreoffice.org/46350Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

At least internally it was unused at least ever since
9399c662 "initial import", it is unlikely that
it ever was used for anything useful, and it is highly unlikely that it is used
by 3rd-party code.

Change-Id: I8b1e7e18e041164580acbb0bdba205ec1dca71d2
Reviewed-on: https://gerrit.libreoffice.org/46364Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: If59983d236c336a7ab136110e2e18f6801111902
Reviewed-on: https://gerrit.libreoffice.org/46303Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

since their range is 0-255

Also drop pTols from ImplColReplaceParam, since it is always nullptr.

Change-Id: I9e9ab7f7596e18cab1d67dd69922e5ac9867f45b
Reviewed-on: https://gerrit.libreoffice.org/46274Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

tables, objects and user-defined

Change-Id: I081446832ee86453227f4838552c88fd9e5cf75f
Reviewed-on: https://gerrit.libreoffice.org/46326Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iad0987e9935ff02c80fea9dd7ebd4fdbe9fe2a9c
Reviewed-on: https://gerrit.libreoffice.org/46317Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6d3ce03d5cb43df30f6f693c73ccf22c45a8b839
Reviewed-on: https://gerrit.libreoffice.org/46323Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iaab1d09be69fd3a47975ca360b78ca23954056af
Reviewed-on: https://gerrit.libreoffice.org/46290Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib0ae0baad1f34a06d67391fa9957b3f822ee50e4
Reviewed-on: https://gerrit.libreoffice.org/46353Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie91ca2c9aac9b3ab7ca103bf2e6b55d453255d77
Reviewed-on: https://gerrit.libreoffice.org/46242Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

Change-Id: I63730632933cbb1d6e655f70d222ffaaabd3fa08
Reviewed-on: https://gerrit.libreoffice.org/46361Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

to match the underlying fields

Change-Id: I79ce52b80e2589b3194616b3d43846cdefd7adae
Reviewed-on: https://gerrit.libreoffice.org/46349Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I02bad98458ae0c41b4bbc1b4ec79f3f935d4beaa
Reviewed-on: https://gerrit.libreoffice.org/46348Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

to match the underlying type on mxProgressBar->setValue

Change-Id: Ib04569235830f16b6507180e0f27816f8cfc50ff
Reviewed-on: https://gerrit.libreoffice.org/46347Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1475a12b600fdb693bad71d27dc628992b92588a
Reviewed-on: https://gerrit.libreoffice.org/46346Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

to match the underlying field

Change-Id: I4145df0fc308c09eca29f779a0ff241e4301db0b
Reviewed-on: https://gerrit.libreoffice.org/46345Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

was being used recursively

Change-Id: I2ab920ee62c663f6cdc93ae2ef7eafd142fa0c94
Reviewed-on: https://gerrit.libreoffice.org/46344Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ever since
    commit 90b15288
    Date:   Sun Jan 16 19:11:44 2011 +0100
    Remove some dead code in 'view'

Change-Id: Ic760605462960f6a5d2dd9280152081311c765cb
Reviewed-on: https://gerrit.libreoffice.org/46343Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ever since initial import in
    commit a4288059
    Date:   Wed Apr 11 15:27:24 2007 +0000
    INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED

Change-Id: I1e51f58b0e6062a6a3179ce7fad3170c19758f50
Reviewed-on: https://gerrit.libreoffice.org/46342Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

since
    commit 595f4634
    Date:   Mon Feb 29 13:37:14 2016 +0200
    loplugin:unuseddefaultparam in svx (part1)

Change-Id: I1c951df4fb75418036ca9c42a3c63daec879f3b4
Reviewed-on: https://gerrit.libreoffice.org/46341Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iec5c9e45ec753de98142615fdde16f61c393a6e2
Reviewed-on: https://gerrit.libreoffice.org/46311Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7cf53514641c52f3ebb503251e25df90bd6db8c7
Reviewed-on: https://gerrit.libreoffice.org/46310Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

also fix the
   X& X()
methods to be normal
void SetX(X const &)
methods

Change-Id: Id2999b09535ce560110eda646d3d5bbbedf87326
Reviewed-on: https://gerrit.libreoffice.org/46309Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0c076dafc1c565e77c4bfd1988d1b94a9a82672f
Reviewed-on: https://gerrit.libreoffice.org/46354Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>

Project: dictionaries  7ac9dd36dcbaef021399b8328d25c8a1ab000e83

Add logo for English dict to the .mk as well

Change-Id: I9a64cce5dd06f75d536b0740c492358e89e90666
Reviewed-on: https://gerrit.libreoffice.org/46360Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>

Project: dictionaries  cde2a4aa5184e8c6dfa565db50d004a70a12e7d2

Added "official" logo (icon) to English dictionaries

Change-Id: I7c0d250386cbd49a4a4869fa1ee165e957db3ae6
Reviewed-on: https://gerrit.libreoffice.org/45990Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>

Change-Id: Ia90a2bae0dab3d82cae1204a9205f386f71e5c49
Reviewed-on: https://gerrit.libreoffice.org/46301Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Page range size can only be valid for the input parameters, which
includes the document size, which was not taken into account at all
before. Now we look at all this parameters to decide if we need to
recalculate or not.

Change-Id: Ic52ad7516189b395c66f59aabc374c3da85f6a89
Reviewed-on: https://gerrit.libreoffice.org/46300Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

...and fix the call sites that exploited the hack's internals being non-
transparent.

Change-Id: Ib3b06c3945e303d4088c4e1b65be5beed8613bac
Reviewed-on: https://gerrit.libreoffice.org/46325Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

instead of one mutex for all instances. We still keep the global mutex
for some operations because there are some shared global data
structures.

Change-Id: Ic1106baa23d4ade18dbd732ad74979f3996f326b
Reviewed-on: https://gerrit.libreoffice.org/46304Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

.. instead of in every GetKeyWord() call, and force to EnglishOnly
if there aren't.

Change-Id: I56941298c0e02d041b80cdb5805905e24116405e

It's only a problem if the style contains an anchor position;
the anchor type by itself is fine, and the wrong assertion is
particularly stupid considering that
DocumentStylePoolManager::GetFormatFromPool() inits various
built-in styles with anchor types.

(regression from eed04643)

Change-Id: If8ac000b7f888686725d6bf0ef8e5fb38198c889

The original code tried to get the position of the window relative
to its parent and then ask the parent to adjust that position to
a position relative to the toplevel. But the position to use in
that case should have be WindowImpl::nX/WindowImpl::nY not GetPosPixel()

Much easier to just directly ask the the current window for its position
relative to the toplevel.

Change-Id: Iff202f052bc651a8c0e3a57ff3322e5e2a3e4b9a
Reviewed-on: https://gerrit.libreoffice.org/46314Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id9218e2113643f3a8c31c20680ee7885ed273e58
Reviewed-on: https://gerrit.libreoffice.org/46316Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

alternative is to not use themed text color when writing text
in non-nwf tooltips

Change-Id: I12556d5fd9a38c4b36f77c97144898f08fa4d738
Reviewed-on: https://gerrit.libreoffice.org/46312Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... in GetPreviewStringGuess() that is used in Calc TEXT()
spreadsheet function, if the format code didn't resolve as English
or the format code needs to be (re)parsed otherwise as locale
dependent.

Also SvNumberFormatterServiceObj::convertNumberToPreviewString()
(XNumberFormatPreviewer::convertNumberToPreviewString()) if
bAllowEnglish==true.

Change-Id: I7c4b1a610d2bcb20fe0f0ae06efc81f998cae048

Change-Id: I3942a7de52bcedf491da83407791fcd0080aaf4d