- 15 Agu, 2018 29 kayıt (commit)
-
-
Stephan Bergmann yazdı
...not 16-bit unsigned. Word2007RTFSpec9.docx states "A small number of control words take values in the range −2,147,483,648 to 2,147,483,647 (32-bit signed integer)." and for \picwN, \pichN, \picwgoalN, and \pichgoalN it states "The N argument is a long integer." This was found with Clang's new -fsanitize=implicit-conversion during CppunitTest_writerfilter_rtftok, where writerfilter/qa/cppunittests/rtftok/data/pass/TCI-TN65GP-DDRHDLL-partial.rtf contains "\pich81306": > Testing file:///home/sbergman/lo/core/writerfilter/qa/cppunittests/rtftok/data/pass/TCI-TN65GP-DDRHDLL-partial.rtf: [...] > writerfilter/source/rtftok/rtfdispatchvalue.cxx:770:48: runtime error: implicit conversion from type 'int' of value 81306 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 15770 (16-bit, unsigned) > #0 in writerfilter::rtftok::RTFDocumentImpl::dispatchValue(writerfilter::rtftok::RTFKeyword, int) at writerfilter/source/rtftok/rtfdispatchvalue.cxx:770:48 (instdir/program/libwriterfilterlo.so +0xb96f2f) > #1 in writerfilter::rtftok::RTFTokenizer::dispatchKeyword(rtl::OString const&, bool, int) at writerfilter/source/rtftok/rtftokenizer.cxx:311:29 (instdir/program/libwriterfilterlo.so +0xd86c93) > #2 in writerfilter::rtftok::RTFTokenizer::resolveKeyword() at writerfilter/source/rtftok/rtftokenizer.cxx:243:12 (instdir/program/libwriterfilterlo.so +0xd84b06) > #3 in writerfilter::rtftok::RTFTokenizer::resolveParse() at writerfilter/source/rtftok/rtftokenizer.cxx:123:27 (instdir/program/libwriterfilterlo.so +0xd8299a) > #4 in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/rtftok/rtfdocumentimpl.cxx:786:27 (instdir/program/libwriterfilterlo.so +0xbf03bd) > #5 in RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/RtfFilter.cxx:144:20 (instdir/program/libwriterfilterlo.so +0x132d911) > #6 in RtfTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at writerfilter/qa/cppunittests/rtftok/testrtftok.cxx:58:27 (workdir/LinkTarget/CppunitTest/libtest_writerfilter_rtftok.so +0x15c6e) > #7 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5724c) > #8 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x57ec9) > #9 in RtfTest::test() at writerfilter/qa/cppunittests/rtftok/testrtftok.cxx:78:5 (workdir/LinkTarget/CppunitTest/libtest_writerfilter_rtftok.so +0x16214) (Needs to add o3tl::clamp as a compatibility wrapper for C++17 std::clamp.) Change-Id: I515e70a435c2585777062fd5a27d1de8ddbe1b74 Reviewed-on: https://gerrit.libreoffice.org/59038Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
-
Noel Grandin yazdı
Change-Id: I88ef5de94f83cd8f7a7d2a60b072cc23bd147b27 Reviewed-on: https://gerrit.libreoffice.org/59009 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Iffdd62e8af5fa31caecc6ea01bd5e21de950862c Reviewed-on: https://gerrit.libreoffice.org/59021 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I3c8046a70ffce402d52caf2e7b77fa9951103f99 Reviewed-on: https://gerrit.libreoffice.org/59011 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Ia078a0f4262fbe18b6cf463dbff33df1d4fd0a95 Reviewed-on: https://gerrit.libreoffice.org/59036 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Julien Nabet yazdı
Fix opposite case, see https://bugs.documentfoundation.org/show_bug.cgi?id=118547#c10 Change-Id: I2c4e55f8929b1979e71a4040dfac1ba7cff51aeb Reviewed-on: https://gerrit.libreoffice.org/59035 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Miklos Vajna yazdı
Change-Id: If5fc2fb328320f6cad608bebbc704ced3d69cee8 Reviewed-on: https://gerrit.libreoffice.org/59006 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
"create appendCopy method in OUStringBuffer"; response_body is a std::string Change-Id: I58ab982c87fa568fdac8e3c72fbcb0e071d73228
-
Vincas Dargis yazdı
Exporting document to .xhtml produces AppArmor deny log entry. Add AppArmor rule for accessing /etc/xml/catalog as it is needed by libxml2. Change-Id: If62046059c4e1d458cca895f14f7d1e3f537c527 Reviewed-on: https://gerrit.libreoffice.org/59005 Tested-by: Jenkins Reviewed-by:
Rene Engelhard <rene@debian.org>
-
Vincas Dargis yazdı
Currently, exporting document to .epub fails if AppArmor profile is enabled. This patch fixes it by registering .epub extension within AppArmor profile. Change-Id: I5075ac803ffd9157c2f2cc6546895149b0fdd5f2 Reviewed-on: https://gerrit.libreoffice.org/59004 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I8e4f3599d30f94cfaa418f0adb35cf9fba97ff53 Reviewed-on: https://gerrit.libreoffice.org/59032 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I55e11d158c50a76b0fad1da0e1adc3712990aa8f Reviewed-on: https://gerrit.libreoffice.org/59028 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I3c39782cdbb332627e33ecb85c8d447a40ea0fea Reviewed-on: https://gerrit.libreoffice.org/59026 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I2043b6473ef18828a903a8da9faa98e3fd4dba0a Reviewed-on: https://gerrit.libreoffice.org/59025 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I2bcfeb1e670bc75f093a05e7d5bfb0be09235052 Reviewed-on: https://gerrit.libreoffice.org/59023 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
although I rather suspect these FreetypeFont objects would be better held by rtl::Reference Change-Id: I1a7d6ca47d1f78686637368a4bec57b1fcfaa6e9 Reviewed-on: https://gerrit.libreoffice.org/59020 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
and avoid some unnecessary copying Change-Id: Ieb9b1fe169a7d56197bf1e054e9af5dca7804301 Reviewed-on: https://gerrit.libreoffice.org/59019 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Idf8f843f2740bc20e6b0877b62dbfc778e31acd8 Reviewed-on: https://gerrit.libreoffice.org/59018 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Id0a6a44848541968e9084a198366accda9c1149a Reviewed-on: https://gerrit.libreoffice.org/59017 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Idf591f6d8557f1477eec4f8d69358ff41d9acff3 Reviewed-on: https://gerrit.libreoffice.org/59016 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I08564e76ed667d158bd885a66b994b421ae9b426 Reviewed-on: https://gerrit.libreoffice.org/59015 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...needed" This reverts commit 4a610062, as it turns out to actually break things. I'm not quite sure how I came across that code and the attempted fix back then, but at least ASan+UBSan `make check` still works after the revert (and UBSan seems the most likely reason I came across this). I know too little about that Writer table layout code to know whether the original code is actually good, or would need some other fixing, so lets just revert for now. Change-Id: I1e88372a3b688a5fdd4c1bf88033b51287195799 Reviewed-on: https://gerrit.libreoffice.org/59002 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Noel Grandin yazdı
Change-Id: Ieb536bb2ab7cef378b7279e086b26762f4291c56 Reviewed-on: https://gerrit.libreoffice.org/59014 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I4487552b2936cdfcc38055bf16e114fb6b54a3ed Reviewed-on: https://gerrit.libreoffice.org/59013 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I9c0b05081915712089d363a476d6354cfba2461d Reviewed-on: https://gerrit.libreoffice.org/59010 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Idaf02002cecb1300a5fc3bcb0e298b11a1958bb1 Reviewed-on: https://gerrit.libreoffice.org/59008 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Id6eef7772b32a93d43d0417c5b6e24d9189c4e73 Reviewed-on: https://gerrit.libreoffice.org/58955 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
no need for a linked list where each cell contains a single pointer Change-Id: I5353b178ddf3c6a69762edc23612995efd81fb41 Reviewed-on: https://gerrit.libreoffice.org/58987 Tested-by: Jenkins Reviewed-by:
-
Tor Lillqvist yazdı
No need to distribute that, apparently. We don't ship it on Windows, either. Change-Id: I76bf77311caceccd07afb0afa2f097b63f58bf54 Reviewed-on: https://gerrit.libreoffice.org/59034 Tested-by: Jenkins Reviewed-by:
Tor Lillqvist <tml@collabora.com>
-
- 14 Agu, 2018 11 kayıt (commit)
-
-
Vincas Dargis yazdı
Commit c86e4ad5 introduced qt-related rules, like linking to ~/.config/#[0-9]* files, though does not allow to write the files themselves, in result producing DENIED log entries if AppArmor profile is enabled. This is fixed by adding read-write rule for particular files. Change-Id: I6441398c4fcfbfcf59ba5f5b3178682c1e5d1cd5 Reviewed-on: https://gerrit.libreoffice.org/59007 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: Ia717a116056bddc7968a3e451058a94cb2bbbd29 Reviewed-on: https://gerrit.libreoffice.org/59003Reviewed-by:
Jean-Pierre Ledure <jp@ledure.be> Tested-by:
-
Caolán McNamara yazdı
Change-Id: I4506a3517eff7f73cf793195e9d605d450b84fda Reviewed-on: https://gerrit.libreoffice.org/58995 Tested-by: Jenkins Reviewed-by:
-
Jan Holesovsky yazdı
Reviewed-on: https://gerrit.libreoffice.org/58863Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
Mark Hung yazdı
Change-Id: Ie3c023b0efc4a6c5a92ffc8ba43259ff2bb7da8f Reviewed-on: https://gerrit.libreoffice.org/58849 Tested-by: Jenkins Reviewed-by:
Mark Hung <marklh9@gmail.com>
-
Mark Hung yazdı
Powerpoint only allows M,L,C,Z,E,m,l,c,z,e , i.e. V,H,S ( and their corresponding relative command ) must not be used and ending E is mandatory. Command and space delimiters also can not be skipped. Change-Id: Icad38ec2eed3e49143eb9a03aa56cc178baae99d Reviewed-on: https://gerrit.libreoffice.org/58848 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
we have two asserting cases... soffice.bin --headless --convert-to pdf odt/tdf109532-2.odt soffice.bin --headless --convert-to odt odt/fdo45450-1.odt both pass after this Change-Id: I24a9bdc5ab19f678dc611f78ed84347789915cc5 Reviewed-on: https://gerrit.libreoffice.org/58939 Tested-by: Jenkins Reviewed-by:
-
Jan Holesovsky yazdı
* Update helpcontent2 from branch 'master' - Let's make the help urls more standard, and use ?Target=...&... form. Change-Id: Ic2568c769ab11e3622f71b92a46fb124012a3c90 Reviewed-on: https://gerrit.libreoffice.org/58865 Tested-by: Jenkins Reviewed-by: -
Noel Grandin yazdı
regression from commit 65e4a776 simplify some OUString::copy calls I got the params switched around Change-Id: I68da0ae681f2b886e35f74bd72de0c482c843ae9 Reviewed-on: https://gerrit.libreoffice.org/58986 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I28f8338f5c318f2228b742e2e171d53820cb0cc8 Reviewed-on: https://gerrit.libreoffice.org/58984 Tested-by: Jenkins Reviewed-by:
-
Xisco Fauli yazdı
Change-Id: I2c89e44e5d78377666bacb2393b26323f1e0a904 Reviewed-on: https://gerrit.libreoffice.org/58919 Tested-by: Jenkins Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
