Change-Id: I49a006c31393664733a977f2620d055d3a0acff2
Reviewed-on: https://gerrit.libreoffice.org/67150
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id86b69f1bceb228d6bc5e383e7d98f177780d402
Reviewed-on: https://gerrit.libreoffice.org/67148
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie272373bcef3459b05dc29bf874ecc3fdfa31d4a
Reviewed-on: https://gerrit.libreoffice.org/67151Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Jenkins

Change-Id: I814e7b61ebbef1a0bbd38a5e70beeb7f99a0cfa1
Reviewed-on: https://gerrit.libreoffice.org/67146
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I9d71789af2a9fcb5072df16fc348b2641b62ec01
Reviewed-on: https://gerrit.libreoffice.org/67103
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I3a1ebc4cc4cadd3b4a69b772addbb51eace84e27
Reviewed-on: https://gerrit.libreoffice.org/67142
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

dialog window added by "Edit Comment..." of local
menu of the listed changes.

Change-Id: Ie6501d06f8ad233c44318cf8928892667534f6a2
Reviewed-on: https://gerrit.libreoffice.org/67162Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Change-Id: Ib9868bb31238905dd178fcf54c79f013079a037b
Reviewed-on: https://gerrit.libreoffice.org/67126
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Ia505271b395588647a2e0b3db449000d110cb395
Reviewed-on: https://gerrit.libreoffice.org/67139
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib6320ddc049e93cca4c5931ad28d1873d34bd8b4
Reviewed-on: https://gerrit.libreoffice.org/67137
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I916dfe036e1e4fbdc67b0c34dc0d3a428ae50d3a
Reviewed-on: https://gerrit.libreoffice.org/67123
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2fae1d529ea877acdf42c898323b10c0ba4edc9c
Reviewed-on: https://gerrit.libreoffice.org/67129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7892bef62c93dd30d5a7d9605e0e6d62fdd35cb1
Reviewed-on: https://gerrit.libreoffice.org/67133
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I84e969005ac2a96da449b5434ee5fdb37fc9b432
Reviewed-on: https://gerrit.libreoffice.org/66928
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I742d758796fecae2834c1407b504c1e1f8c8593e
Reviewed-on: https://gerrit.libreoffice.org/67127
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Must not call getTransferDataFlavors with m_Mutex held;

6  TransferableHelper::getTransferDataFlavors() (this=0x567b980) at svtools/source/misc/transfer.cxx:392
7  VclGtkClipboard::setContents(com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboardOwner> const&) (this=0x3199550, xTrans=uno::Reference to (SwTransferable *) 0x567b9a8, xClipboardOwner=uno::Reference to (SwTransferable *) 0x567b9b0) at vcl/unx/gtk3_kde5/../gtk3/gtk3gtkinst.cxx:618
8  TransferableHelper::CopyToSelection(vcl::Window*) const (this=0x567b980, pWindow=0x301b0c0) at svtools/source/misc/transfer.cxx:960

CopyToSelection() uses SolarMutexReleaser, then getTransferDataFlavors()
has a SolarMutexGuard; this will deadlock against the main thread
that holds SolarMutex and calls VclGtkClipboard::setContents() itself,
from VclGtkClipboard::OwnerPossiblyChanged().

Change-Id: Ibda0b6bce6f3388c45cee8077dd977abb3dda366
Reviewed-on: https://gerrit.libreoffice.org/67121
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Ia2363177e7187dfda9a1b326e5e110696b9a1697

Change-Id: Ib3f24671b0fe17954eec3c4d30de862dba3070b7
Reviewed-on: https://gerrit.libreoffice.org/67114
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

When no CFLAGS are passed into autogen.sh,
f104b3ca "tdf#72987 run firebird test for little
endian only for now" (introducing AC_C_BIGENDIAN before AC_PROG_CC) caused
CFLAGS in config_host.mk to accidentally be set to -g -O2 (instead of being left
undefined).

Change-Id: I639ce74b468e7fb25a6bda97346c7f97d6b829aa
Reviewed-on: https://gerrit.libreoffice.org/67125
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

See https://bugs.documentfoundation.org/show_bug.cgi?id=123036#c3

Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=52ccd8fabeea247da7077798b50a6db1da31a2eb

Change-Id: I1c24a6c59bda7ce06ed93c31a21d9bc1c8abe2f5
Reviewed-on: https://gerrit.libreoffice.org/67104
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I60b67eeabf5f11f0d3ad4de7b5ad11bc5851d474

Change-Id: I8ac8b1cbbf94f405ffef0037b6957b35d44a8f91

Adding the custom widgets to the native dialog currently depends
on the native dialog using a KFileWidget, which is just the case for
the native QFileDialog implementation on Plasma/KDE5.

In order not to lose custom controls for non-Plasma desktops,
fall back to using the non-native QFileDialog there and adding
the custom controls to its layout.
This was mostly taken over from Qt5FileDialog.
(This is a similar approach as that taken for the kde5 VCL plugin
in https://gerrit.libreoffice.org/#/c/67106/ ).

Adding the controls to the layout returned by 'QFileDialog::layout()'
cannot be used for the native dialog as well, since a nullptr is
returned in this case.

From QFileDialog doc:

> By default, a platform-native file dialog will be used if the platform
> has one. In that case, the widgets which would otherwise be used to
> construct the dialog will not be instantiated, so related accessors such
> as layout() and itemDelegate() will return null. You can set the
> DontUseNativeDialog option to ensure that the widget-based
> implementation will be used instead of the native dialog.

Change-Id: I75fbe7731da28d0dc7df878f4c57e141d4d89902
Reviewed-on: https://gerrit.libreoffice.org/67111Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Michael Weghorn <m.weghorn@posteo.de>

since...

commit 8780fa41
Date:   Tue Oct 30 12:23:36 2018 +0100

    svtools: fix lost replacement grpahic when updating it via OLE fails

EmbeddedObjectRef::UpdateReplacementOnDemand is called by a chart during
EmbeddedObjectRef::GetReplacement which resets mpImpl->pGraphic to null

Change-Id: Id473b807582164eeb1791a26f6e0005a240f5989
Reviewed-on: https://gerrit.libreoffice.org/67120
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

not sure if we should support also other than URL list mimetypes

Change-Id: Ida3f65637247822198b04682a3d1a7c196a24e0c
Reviewed-on: https://gerrit.libreoffice.org/66997
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Since KDE5FilePicker relies on the Plasma-specific KFileWidget
to be present for inserting custom controls, this doesn't work
on non-Plasma desktops, resulting in missing controls.

Therefore, use a plain (non-native) Qt5FilePicker for the non-Plasma case.

Change-Id: I163af89ecd7eab800d55baa2ce057802caed262c
Reviewed-on: https://gerrit.libreoffice.org/67106
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Ic8b0cbe0c7821d287b2233bc015cb888e0e18d88
Reviewed-on: https://gerrit.libreoffice.org/67110
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This is similar to commit 22aa6508
(framework: allow dispatching a command on the main thread, 2019-01-29),
except it addresses the scenario where save is performed with an UNO API
call, not with a dispatched command.

This way both load and save is possible on the main thread, providing a
safe way to interact with documents containing OLE objects on Windows.

Change-Id: I3516c944ece8ed0e26aa13fc9def5857b8344404
Reviewed-on: https://gerrit.libreoffice.org/67109Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: Ieb9fa5e9cd2d5919a36fbe65ced107eab33c72e2
Reviewed-on: https://gerrit.libreoffice.org/67090Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

With Clang -fsanitize=implicit-signed-integer-truncation,
CppunitTest_sw_ooxmlexport8 fails with

> sw/source/filter/writer/wrtswtbl.cxx:666:39: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 (16-bit, unsigned)
>  #0 in SwWriteTable::FillTableRowsCols(long, unsigned short, unsigned int, unsigned short, long, unsigned int, SwTableLines const&, SvxBrushItem const*, unsigned short, unsigned short) at sw/source/filter/writer/wrtswtbl.cxx:666:39
>  #1 in SwWriteTable::SwWriteTable(SwTable const*, SwTableLines const&, long, unsigned int, bool, unsigned short, unsigned short, unsigned short, unsigned int) at sw/source/filter/writer/wrtswtbl.cxx:757:5
>  #2 in DocxAttributeOutput::InitTableHelper(std::shared_ptr<ww8::WW8TableNodeInfoInner> const&) at sw/source/filter/ww8/docxattributeoutput.cxx:3481:31
>  #3 in DocxAttributeOutput::FinishTableRowCell(std::shared_ptr<ww8::WW8TableNodeInfoInner> const&, bool) at sw/source/filter/ww8/docxattributeoutput.cxx:907:9
>  #4 in DocxAttributeOutput::TableNodeInfoInner(std::shared_ptr<ww8::WW8TableNodeInfoInner>) at sw/source/filter/ww8/docxattributeoutput.cxx:4248:5
>  #5 in MSWordExportBase::OutputStartNode(SwStartNode const&) at sw/source/filter/ww8/wrtww8.cxx:4167:26
>  #6 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2812:13
>  #7 in DocxAttributeOutput::WriteFloatingTable(ww8::Frame const*) at sw/source/filter/ww8/docxattributeoutput.cxx:336:17
>  #8 in checkAndWriteFloatingTables(DocxAttributeOutput&) at sw/source/filter/ww8/docxattributeoutput.cxx:396:30
>  #9 in DocxAttributeOutput::StartParagraph(std::shared_ptr<ww8::WW8TableNodeInfo>) at sw/source/filter/ww8/docxattributeoutput.cxx:406:9
>  #10 in MSWordExportBase::OutputTextNode(SwTextNode&) at sw/source/filter/ww8/wrtw8nds.cxx:2181:22
>  #11 in MSWordExportBase::OutputContentNode(SwContentNode&) at sw/source/filter/ww8/wrtw8nds.cxx:3327:13
>  #12 in MSWordExportBase::WriteText() at sw/source/filter/ww8/wrtww8.cxx:2727:13
>  #13 in DocxExport::WriteMainText() at sw/source/filter/ww8/docxexport.cxx:1469:5
>  #14 in DocxExport::ExportDocument_Impl() at sw/source/filter/ww8/docxexport.cxx:527:5
>  #15 in MSWordExportBase::ExportDocument(bool) at sw/source/filter/ww8/wrtww8.cxx:3212:19
>  #16 in DocxExportFilter::exportDocument() at sw/source/filter/ww8/docxexportfilter.cxx:86:17
>  #17 in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at oox/source/core/filterbase.cxx:497:55
>  #18 in WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/WriterFilter.cxx:149:23
>  #19 in SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2411:25
>  #20 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1505:19
>  #21 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&) at sfx2/source/doc/objstor.cxx:2818:39
>  #22 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objstor.cxx:2675:9
>  #23 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) at sfx2/source/doc/objserv.cxx:321:19
>  #24 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:3001:46
>  #25 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1672:13
>  #26 in SwModelTestBase::reload(char const*, char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:796:20
>  #27 in SwModelTestBase::executeImportExportImportTest(char const*, char const*) at sw/qa/extras/inc/swmodeltestbase.hxx:283:9
>  #28 in testN779642::Import_Export_Import() at sw/qa/extras/ooxmlexport/ooxmlexport8.cxx:746:1

(where nCPos is 23, nOldCol is 2, and nCol is 0).

sw/qa/extras/ooxmlexport/data/n779642.docx processed by that testN779642 is the
only case during `make check` for which the added SAL_WARN_IF triggers.  That
file was added with 874f0a1b "n#779642: ignore
framePr inside table or the table import won't work", leaving its origin
unclear, and trying to open it with at least MS Word for Mac version 16.21 fails
with "could not be opened", so it looks somewhat plausible that computation of
such negative spans should just not happen.

Change-Id: I0d460d04050017f7793ae51dc2a51ebbd3c4c193
Reviewed-on: https://gerrit.libreoffice.org/67075
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Export the xLabelPropSet instead of the xPropset and the
individual data label formatting will not be disappeared.

Change-Id: Ic8c64543ad1e8b40d6d6a5cb7a9a244923e028f1
Reviewed-on: https://gerrit.libreoffice.org/66995
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

Change-Id: I8f608908689d9ebe2027bc36bf71b8cf84a016dc
Reviewed-on: https://gerrit.libreoffice.org/67095
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Move XPropertySet Java tests to C++ for ScSpreadsheetSettingsObj.

Change-Id: I59da149983ee3b897c1cdeaf5f40962b917c91ba
Reviewed-on: https://gerrit.libreoffice.org/67101
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

The consequence was that the shapes were inserted into the background
layer.

The problem was particularly visible with the LOK, but reproducible on
the desktop too.

Includes unit test.

Change-Id: I16137331f944101e25679ec8c4a034bea658bc57
Reviewed-on: https://gerrit.libreoffice.org/66917
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Ia6c5ca98005642bbcce9d9d66bf16a4d4cbed04e
Reviewed-on: https://gerrit.libreoffice.org/66648
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I01f5a09e65091f460c28f6c18d683f5a3135762e
Reviewed-on: https://gerrit.libreoffice.org/67100
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests
to ScFilterDescriptorBase.

Change-Id: I932560c42d9c5f3077f47f116f6ae011f6aea79e
Reviewed-on: https://gerrit.libreoffice.org/67097
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I085a21afdf842a70dcdaaf9694fc6b09502985fe
Reviewed-on: https://gerrit.libreoffice.org/67096
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

- Use the correct method to remove the frame, so DOC
export will work correctly.
- Remove pagedesc attribute of the first text node if
the table is moved before it to avoid to generate a page
break.

Change-Id: I02802c4d25c947ec140b846c594848117815f1ce
Reviewed-on: https://gerrit.libreoffice.org/67093
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I635097e00e6b5d4f08badb1e99fa9b61b6b43856
Reviewed-on: https://gerrit.libreoffice.org/67084
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>