found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1

Change-Id: I7b1f8d4621a3db9094bb61753218db3646c33e34

Change-Id: I92531f8fc96c0cb0ca944a7dd50c4fe4ea740b37

Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159

found by PMD

Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1

Fixed:
1. Open Calc
2. Open formula dialog
3. Choose AMORDEGRC function or other with >= 4 params
Edit field is covered by other controls

Change-Id: Ie14ff91a17373e11bc8ef6477f4f22c0ea4570c3
Reviewed-on: https://gerrit.libreoffice.org/11035Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

Change-Id: I2236a18608ffa9481c30088044f34e1a3372dd11

Change-Id: I8efdd4933d3e47c5e086dc4a4685110390d6b6e8

... as the code apparently can work even if xFormatTypes is empty.

Change-Id: I6b733b9b31329d4fafc745bc23d0f555286950e6

valgrind + bff

Change-Id: Id3c039a46dec5d2d4a4642dfb53d23a76972dde2

valgrind + bff

Change-Id: I3bd526b7ebf0f4fce5d0c7054809e0dc2908e73f

As of the JDK 1.4, Throwable.getCause() is the preferred method for getting thrown target exception.

Change-Id: I14f3f9ae52869d1149f92b32562e7fb3293109b5
Reviewed-on: https://gerrit.libreoffice.org/11027Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Avoid unnecessary temporaries when converting primitive data types into a String.

Change-Id: If361383be52d8258be7c8c9bddf3ba05d5ca92c1
Reviewed-on: https://gerrit.libreoffice.org/11026Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I5634bf40e8ccc4ce076409907c13f9c6f52d11a3

Change-Id: I579205c4cdc3149ef0c1b01daef32155a13d666b

Change-Id: If58b3a9f5b1d79d164bb1c2a7c18aa4f99f00ca8

The same info is already available from oox.

Change-Id: I0725799e1f3ffebf6140ad38a0ce376e5417265d

Removed its output paramater as GetCurrentViewShell should be
used instead and added a const version.

Change-Id: Iad8b57553b6e93e3472ce8c6905d08e8d49af770

Let Ctrl+; current date and Shift+Ctrl+; (Ctrl+:) current time behave more
flexible, depending on the formatting (and as such the type) of the existing
cell content.

key date on time  cell => current date + time of cell => date+time formatted cell
key date on other cell => current date => date formatted cell
key time on date  cell => date of cell + current time => date+time formatted cell
key time on other cell => current time => time formatted cell

Change-Id: I2ccbfbab3c50c36a72c4db4696520e32f94caefa

And use DateTime instead of manually concatenating Date and Time.

Change-Id: I6f9fb988beea2a9a17c976d3b98860c4f9ed063b

regression probably triggered by...

commit 2e3c45af
Date:   Fri Mar 4 07:38:16 2011 -0800
Remove usage of deprecated List container.

but that just stopped at the first NULL by chance

Change-Id: I767e3bc3130d99cedceb4172857d1741c677b19b

This is, not surprisingly, somewhat weird code, but I think this patch does
what is necessary, it does fix the bug.

Change-Id: Ie1947b311f1455ba48a904f5ef42ad92899fac31

Change-Id: I32d3f99a2f090637d6891123f91093c0bcceddf4

Change-Id: I7620d71fe34b5f7bbd9bf9bf63b634d85cdb4d6c

otherwise infinite loop in extensions update check

Change-Id: I0dbf4f34208f1bf0854e365006a79470b26571f3

Change-Id: I0fab5ae4335ed6016d31aa243b131899c3154388

Change-Id: I52c2298c9583617481069040e118520cf8935c6d

Change-Id: Ifc1968e5474c7f252960d4b790d6f01db29cab8a

In order to allow running them in parallel. There are already enough
tests to make it run for a couple of minutes and it's annoying to
see only once core busy with it.
I intentionally left the original file at the same name, without 1
appended, in order to avoid merge problems.

Change-Id: I097c45c34797cc68f5d1790cf31eefc96fbaf44e

Change-Id: Ic99c6519b02c546e0d3574cb756e3fb172d1ff52

Change-Id: I41392572692bc219ae18ad89d95fc8be47d6812c

valgrind + bff

Change-Id: I5fa40f7a9759c98bb70ee6eb854dd9b376401f89

by replacing it with a typedef.

Change-Id: Iaa88086e3c5195012982dd625bfd589de2e484a2
Reviewed-on: https://gerrit.libreoffice.org/11017Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>

C.f. commit 861a1c2d.

Change-Id: I9f6cf917c63ee8c0db5461529c4ee277e231368f

Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03

Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90

Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219

Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69

Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940

Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74