- 19 Eki, 2018 28 kayıt (commit)
-
-
Michael Stahl yazdı
PVS-Studio complains about the funny code. Change-Id: I58e2ebcca7e13baa78cfbcc4a654d5badab8d037 Reviewed-on: https://gerrit.libreoffice.org/61987Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
-
Stephan Bergmann yazdı
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of USAGE in e.g. enum ESCHER_BlibType in include/filter/msfilter/escherex.hxx Change-Id: If492c5086402e46158d3de5d4d6b00b61412c655 Reviewed-on: https://gerrit.libreoffice.org/61985 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Tor Lillqvist yazdı
The UnixErrnoString() function returns the symbolic name of an errno value, like "ENOENT". For now this is local to sal/osl/unx. If it can't figure out the symbolic name, it returns it as a number followed by the cleartext description (as from strerror()) in parentheses. Rationale why to use this and not strerror(): This is intended to be used in SAL_INFO() and SAL_WARN(). Such messages are intended to be read by developers, not end-users. Developers are (or should be) familiar with symbolic errno names in code anyway. The symbolic names of errno values are (or should be) instantly recognizable as such, they all start with E and are in UPPERCASE. strerror() can be localised although in LibreOffice it apparently isn't as there allegedly aren't setlocale() calls. But, anyway, the error strings might be less familiar to a developer than the symbolc errno names that one uses when coding. When encountering an unfamiliar error string the developer might want to add special handling for that error case in the code. They would need a reverse mapping from error string to errno value, by manually searching <errno.h>, looking at the comments there, hoping the match what strerror() produces, to find the corresponding symbolic errno value. Change-Id: Idc11595d528e8432a32bf474e6791f4ea7262a1e Reviewed-on: https://gerrit.libreoffice.org/61931 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
-
Tor Lillqvist yazdı
But I tested just a few times. If somebody re-starts work on LibreOfficeLight, and encounter hangs, hopefully they notice this commit and try to un-comment-out the line in question. I hadn't noticed that temporaryHackToInvokeCallbackHandlers() thing before, maybe calling it in the iOS app being developed (in the "online" repo) is necessary, and would help avoiding the hangs I occasionally see in it? Change-Id: I0f4d8c800024c43acb512d40efdfad71c229bec2
-
andreas kainz yazdı
design part of the personas patch Change-Id: I53c3b4d7dd6a4b47ac2d27b361978faa597386e6 Reviewed-on: https://gerrit.libreoffice.org/61507 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Katarina Behrens yazdı
Change-Id: If87ceeb8ddc4b2aada8ea0c963385a291622fef6 Reviewed-on: https://gerrit.libreoffice.org/61932Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Caolán McNamara yazdı
Change-Id: Ib57a26e51a69cc48f82b3474d11fe4f8c8398e07 Reviewed-on: https://gerrit.libreoffice.org/61977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: If352e7a0f6e8dab2a9acc9aa2cde56b40cedb50c Reviewed-on: https://gerrit.libreoffice.org/61974Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I0952bbaabeb8353b27b478ad6b17bc9348c6f61a Reviewed-on: https://gerrit.libreoffice.org/61978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Michael Stahl yazdı
Change-Id: I1ccaa95678b5ac6e3a25eb7577cb790ab388b73a Reviewed-on: https://gerrit.libreoffice.org/61986Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
-
Caolán McNamara yazdı
Change-Id: I57c7df50040737656c2a68e5fdc0d069ad21f833 Reviewed-on: https://gerrit.libreoffice.org/61975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Katarina Behrens yazdı
Change-Id: Iab328edd799dd4ce04312db4e640f86a8f7fda77 Reviewed-on: https://gerrit.libreoffice.org/61897Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
andreas kainz yazdı
Change-Id: Id12b92eaa472e59681cf684e6f007476c884cc5a Reviewed-on: https://gerrit.libreoffice.org/61964 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Justin Luth yazdı
Change-Id: Ib4f100d4019643cde893ef1d8643a5c08b55ff8f Reviewed-on: https://gerrit.libreoffice.org/61951 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
-
Caolán McNamara yazdı
Change-Id: Iadcdd4b5343992517718da4adc7945e9a9f53710 Reviewed-on: https://gerrit.libreoffice.org/61958 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: If2076aeef81b8354ceb231d6551bc06edb46f7b2 Reviewed-on: https://gerrit.libreoffice.org/61956 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Katarina Behrens yazdı
Change-Id: Iaad25a7acdc7d64013bc3dd0d9410e7d2d5c6762 Reviewed-on: https://gerrit.libreoffice.org/61791 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Noel Grandin yazdı
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Stephan Bergmann yazdı
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of SortAscending/Descending in enum SvSortMode in include/svtools/treelist.hxx Change-Id: I7022d3c6338c5ff50edf6362577f89f6609cd3e9 Reviewed-on: https://gerrit.libreoffice.org/61960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Miklos Vajna yazdı
Change-Id: If05d773d6823833ef075484807bf427dcc2c1426 Reviewed-on: https://gerrit.libreoffice.org/61955 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Noel Grandin yazdı
and don't bother with mutex when returning static data Change-Id: I92bb53cf4e9ae8996b25a1d83cb5ffa4a8d4aed5 Reviewed-on: https://gerrit.libreoffice.org/61948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I19ba8eb5251af3b0c381275a0a18cf8c50944372 Reviewed-on: https://gerrit.libreoffice.org/61941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ia25ac2e40f29e5b766a4c5c013fb53274196f656 Reviewed-on: https://gerrit.libreoffice.org/61934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I2bdab84dc81e0545aa96542caec213db61765f68 Reviewed-on: https://gerrit.libreoffice.org/61922 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: I283d162807a906334627613be7c340af566144f1 Reviewed-on: https://gerrit.libreoffice.org/61921 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Justin Luth yazdı
Just because some sections are unprotected doesn't mean that the document should not open in forms mode. MSWord 2016 opens it in "forms view" mode which also doesn't allow editing those unrestricted settings. Only when choosing the "Edit Document" view are the unprotected sections editable - similar to LO turning off the Compatibility: Protect Forms flag. Unfortunately, the "I want to address this" comment was from 2011, so obviously his temporarly solution became more permanent that expected. If this patch now blocks someone from being able to edit a document (because now only the forms components of the document are editable) they can remove the forms protection by going to tools - options - LibreOffice Writer - compatability - and disable Protect Form. patch developed to support tdf#120499 and depends on the patch for tdf#37778. Change-Id: I86e26095ade6b2cf0ab8ea8fc941a92fa672a2f7 Reviewed-on: https://gerrit.libreoffice.org/61901 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
-
Christian Lohmaier yazdı
This reverts commit 3f9c4779. Breaks the JunitTest_sc_unoapi tests with clang
-
- 18 Eki, 2018 12 kayıt (commit)
-
-
andreas kainz yazdı
Change-Id: Iee8cbf1d3be4f205c975d5100a8b3f2506653e26 Reviewed-on: https://gerrit.libreoffice.org/61954Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
-
Rizal Muttaqin yazdı
Change-Id: I53c3b4d7dd6a4b47ac2d27b361978faa597386e7 Reviewed-on: https://gerrit.libreoffice.org/61937 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
-
Zdeněk Crhonek yazdı
Change-Id: I96f56cee0cab3fa18992281e3745164377adade3 Reviewed-on: https://gerrit.libreoffice.org/61939 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
-
Stephan Bergmann yazdı
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of userSpaceOnUse in enum SvgUnits in svgio/inc/svgtools.hxx Change-Id: Ie1438e6ad0f73c73ad643157e5f8366a6e3f6851 Reviewed-on: https://gerrit.libreoffice.org/61933 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
andreas kainz yazdı
NB: sync MenuImage in tabbed toolbar context menu: sync graphic.xml context menu in writer, calc, impress and draw Change-Id: Idab90ae9af7ac68815fe689811d6c11f948063ca Reviewed-on: https://gerrit.libreoffice.org/61938Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
-
andreas kainz yazdı
Change-Id: Iee6c83ae03ead7ae0b2c33f6cf364c1c3c59528f Reviewed-on: https://gerrit.libreoffice.org/61892Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
-
Katarina Behrens yazdı
Change-Id: I67b8cecdc85ad77d7ab48d229459a79bc168072d Reviewed-on: https://gerrit.libreoffice.org/61721 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Katarina Behrens yazdı
Change-Id: I18ef6cb58632898ddfcb28098b99447565bcfb99 Reviewed-on: https://gerrit.libreoffice.org/61720 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Katarina Behrens yazdı
put (so far) no-op UNO ifaces in place Change-Id: I95394cfe05b8e3db21ddce6dfed1c1bb1d0e6381 Reviewed-on: https://gerrit.libreoffice.org/61385 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
heiko tietze yazdı
SendFeedbackURL, QA_URL, DocumentationURL, GetInvolvedURL, DonationURL added to global variables under Menus Change-Id: Ie95ef2795d4079edd204edb1fcd86fde4376cedf Reviewed-on: https://gerrit.libreoffice.org/61874 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
-
Christian Lohmaier yazdı
Change-Id: I666805e38c40826328d8c4226c394d4c3072b2a7
-
Miklos Vajna yazdı
This way at least something shows up in the import result. Far from perfect, though. Change-Id: Iae5a073d458598e7b5059ebdf435d50ce7c7df80 Reviewed-on: https://gerrit.libreoffice.org/61925Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
-