Fixes clang plugin reported problems in the KDE and KDE4 backend.

Change-Id: I0280beae9dd6f33ee59bdbe89cd38222f33fdc68

Change-Id: I8c854e2f651f8bf0018e8249827aae0fe23057e7

Change-Id: I6c4aa070eac55d7ca9a4bdc404087d32a079dc2c
Reviewed-on: https://gerrit.libreoffice.org/35254Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9eee6c55d7ec27e28d844de2ed544040b07fa501
Reviewed-on: https://gerrit.libreoffice.org/35203Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Iaea08b7a31fab1a8c9b8edc193754821c6608c53
Reviewed-on: https://gerrit.libreoffice.org/35249Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: I72c83724fcbd380e477a90a3e6db32406f68899b
Reviewed-on: https://gerrit.libreoffice.org/35192Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I97224afb4eb7af36abefd0c3b59ee07de7eaa601
Reviewed-on: https://gerrit.libreoffice.org/35247Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Ie56c0c0e1917f159957babca346f1a3fa04bc629
Reviewed-on: https://gerrit.libreoffice.org/35253Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ibc5424873f6cd4e5e4d9ee37823845b14f17c7fb

this is all a bit addled, but at least don't crash

Change-Id: I19c35205446cebc83b8299839bcab8e02ff7c07d

Change-Id: I1488e2147fa0cd4a821eb5bfe172a58a4e396ace
Reviewed-on: https://gerrit.libreoffice.org/35224Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>

This reverts commit 78dbfa9f.

Change-Id: Icbe9339148dc4aeb31c160e976385e3bcaef75b6

Change-Id: I8ce5b900353034c4ad1424375bed0ea0c9db36b1
Reviewed-on: https://gerrit.libreoffice.org/35255Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iba539fb03611bbe5627cc7976c1146d08a2ab5fd

no logic change intended

Change-Id: I936413d3bcd0853db88fd800394aca95d94108f3

Change-Id: I99fc65c7f2e684027db5f9418b855903fbd7bd70

Change-Id: Ic61bce94fe784d345b8c66ee2132dcc78f199808
Reviewed-on: https://gerrit.libreoffice.org/35220Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

when we can, e.g. for the svp/gtk3 case

Change-Id: I74f7b01004423f27ed2f142b325c2c74b4de290b
Reviewed-on: https://gerrit.libreoffice.org/35229Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8432f5147a3e73f0a4eafefceab7fbf715f58acf
Reviewed-on: https://gerrit.libreoffice.org/35228Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This reverts commit 5411d99c.

The unit test wasn't round-tripping due to the paragraph count changing.
Writer always add a CR to a blank paragraph, and so these are
ignored on import (bRemove). The unit test's second paragraph
was one of these.

Simplifying the unit test by removing that CR, allowing it
to become a round-trippable test.

Change-Id: I8786915fb5df8fc4325a6a427ab84bb879632a7a
Reviewed-on: https://gerrit.libreoffice.org/35072Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I170dfc5970896365322dedf4fb797478653578a0
Reviewed-on: https://gerrit.libreoffice.org/35250Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If1a6a9cb61ffd355a85835127e7c893969833587

+ removed listener
+ prevent from using invalid pointers

Change-Id: I3a846d2344148456d3edba23296a4781496eba8b
Reviewed-on: https://gerrit.libreoffice.org/35248Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>

Change-Id: I782fdd53641c0d7c629265b6179de70aa54382f9
Reviewed-on: https://gerrit.libreoffice.org/35246Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I043f184ccd21c782c16d4ae1bc1c939b5e31acc2
Reviewed-on: https://gerrit.libreoffice.org/35234Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I64e33601615f13d2227c24ba1d732817f42d412d
Reviewed-on: https://gerrit.libreoffice.org/35235Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2cbb6257aa65e45f3e46b64a8f00e36aecd95564
Reviewed-on: https://gerrit.libreoffice.org/35219Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This spares a pair of push and pop of the stack.

Change-Id: Ic5f1ee0ee158779f2f231dab9f7059ce6618bdcb
Reviewed-on: https://gerrit.libreoffice.org/35245Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: I74fb244b2440ddf7682362444c20730ac0e58cea
Reviewed-on: https://gerrit.libreoffice.org/35212Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

mostly so that the subclasses can use proper enum types for their own
IDs.
It turns out that nothing at the svl/sfx2 level needs an ID anyhow.

Change-Id: I3c020aeafb812fa30d896216d4e3bc1a82cbfeab
Reviewed-on: https://gerrit.libreoffice.org/35222Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

On linux it was not a problem. On Windows there were some
random failures, but that might be fixed by using
Liberation Mono font.

Change-Id: Iae2684b302b3380c3a63b1fa80b1d0585454ed56
Reviewed-on: https://gerrit.libreoffice.org/35241Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I900b72372a56d341d18091b0d4721d31002d147f
Reviewed-on: https://gerrit.libreoffice.org/35223Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

... the latter which was a misunderstanding and erroneous.

Change-Id: I4ec8eaf14348aaaed43ea4578d46b5488279c85b

Change-Id: I2e7c6fe0e3da4ab879486300a6e424b671322ad1
Reviewed-on: https://gerrit.libreoffice.org/35221Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7831fe2265f783d018699739b350b0c833a58e74

Change-Id: I13bf9ff8e824f69f54158af1aaf6d4cb5709b04a

Change-Id: Ia4b9c46949017a53c80f729af66b99c2e4f05cee

Change-Id: I61906c243f592012691d69a335db42b2010402b7