...in code accidentally using auto like

> auto const aURL = uri->getUriReference() + "/"
>     + INetURLObject::encode(
>         m_sEmbeddedName, INetURLObject::PART_FPATH,
>         INetURLObject::EncodeMechanism::All);
>
> uno::Reference<uno::XInterface> xDataSource(xDatabaseContext->getByName(aURL), uno::UNO_QUERY);

in <https://gerrit.libreoffice.org/#/c/44569/1> "Properly construct
vnd.sun.star.pkg URL" did (causing hard to debug test failures there).

So make functions taking O[U]StringConcat take those by rvalue reference.
Unfortunately, that also needed adaption of various functions that just forward
their arguments.  And some code in sc/qa/unit/ucalc_formula.cxx used
CPPUNIT_ASSERT_EQUAL on OUStringConcat arguments in cases where that happened to
actually compile (because the structure of the two OUStringConcats was
identical), which needed adaption too (but which would arguably better use
CPPUNIT_ASSERT_EQUAL_MESSAGE, anyway).

Change-Id: I8994d932aaedb2a491c7c81c167e93379d4fb6e3
Reviewed-on: https://gerrit.libreoffice.org/44608Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...that had been introduced with 9e87a00e "oox:
replace PUT_PROP macro with comphelper::makePropertyValue() calls", but for
reasons unclear to me.  toAny is specifically there to either wrap its argument
in an Any or, if the argument already is an Any, pass it on unwrapped.  There
is no deleted toAny overloads or explicit specializations.

Change-Id: I63edf22ba3a63f6b3ebb3347ec5dc9ff81fd3bc4
Reviewed-on: https://gerrit.libreoffice.org/44607Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

When using the presenter console, the secondary screen has
a small view of the current slide.

Currently nothing clips the shapes that are on the slide,
so they may be rendered outside the slide rectangle,
because there's a single VCL-canvas and OutPutDevice that covers
the entire screen.

Set up some brute force clipping in DrawShape::getViewRenderArgs().

Change-Id: I3b21f08c12718254b6cf166b7fb1540e9381b243

Change-Id: Icb8815ed20b06d2f43fbfb0088e6bdd0d5b389f6

Change-Id: Icde57593fb2cb589465c574894ab10184702655a
Reviewed-on: https://gerrit.libreoffice.org/44603Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>

Since the RDF entries are not copied (due to
limitations in the clipboard doc), metadata fields
become inconsistent upon copying. This is especially
problematic for signatures and classification as
they are no longer maintainable or verifyable
(which is a particularly critical issue for crypto
signatures of paragraphs).

Change-Id: I5468a961ed43befdc48fcea8be00734453917c1f
Reviewed-on: https://gerrit.libreoffice.org/43631Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>

Change-Id: Ic20330ed474d434dfb2ab25d4c94875ff305eca8
Reviewed-on: https://gerrit.libreoffice.org/44596Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I0436d0f3404a88abd81c4eedea09b16c81536b61
Reviewed-on: https://gerrit.libreoffice.org/44599Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Includes the regular, italic, bold and bold italic for
* Noto Sans, Noto Serif

Includes the regular and bold for

* Noto Kufi Arabic, Noto Naskh Arabic
* Noto Sans Armenian, Noto Serif Armenian
* Noto Sans Georgian, Noto Serif Georgian
* Noto Sans Hebrew, Noto Serif Hebrew
* Noto Sans Lao, Noto Serif Lao

Includes the regular and bold for

* Noto Mono
* Noto Sans Lisu

Change-Id: I2a423b7cac031e2e899df22ad902bd09d1da250d
Reviewed-on: https://gerrit.libreoffice.org/44128Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

Need to trigger a layouting to get the right panel size after we
show / hode context related items.

Change-Id: I791921ecb491bb65c53a4fe9562207d47f66a88a
Reviewed-on: https://gerrit.libreoffice.org/44565Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I90d8af7a1affa459400b1cae4805e3a80b6c5200
Reviewed-on: https://gerrit.libreoffice.org/44593Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...a using declaration should fix it just fine

Change-Id: I05cf76672bcceb7a94afa602e215a0b5a32de82b
Reviewed-on: https://gerrit.libreoffice.org/44591Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...a using declaration should fix it just fine

Change-Id: I0279994c155775e9a58e93aef8da4522d4fd93fd
Reviewed-on: https://gerrit.libreoffice.org/44590Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...to CompilerTest_compilerplugins_clang in
871e420c "Fix loplugin::unusedvariablecheck
check for std classes"

Change-Id: I011d8ff73189dfa85adb4cbd50e556f25be9b79c
Reviewed-on: https://gerrit.libreoffice.org/44592Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I3d1ae5f55343b1b8ec3b0d79a56c9368385a0af8
Reviewed-on: https://gerrit.libreoffice.org/44581Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

rather than passing the pointer around, tragic use of uno apis means monstrous
awt::Window thingy has to be passed around and still smuggled through the
dispatch arguments to get through the eye of the XDispatch::dispatch needle

Change-Id: I353f8a3b0bb698bb58f75576e49efd701f3db8bf
Reviewed-on: https://gerrit.libreoffice.org/44585Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Decrease is Ctrl-8, increase isCTRL-9. German-only, to prevent
issues with inaccessible combinations.

Change-Id: I8e009a9827265f49948464cc5356680c141663e6
Reviewed-on: https://gerrit.libreoffice.org/44584Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I545fb159960974841008d2a0e7843b71a59698aa

Change-Id: Ia7970d9318c0e9f738d7cdf646de2dd38f869a3c
Reviewed-on: https://gerrit.libreoffice.org/42847Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

look for classes containing protected methods where we can convert them
all to private

Change-Id: I4a448341943e0a613cde30501c4012da61dba713
Reviewed-on: https://gerrit.libreoffice.org/44588Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I424cd5aee41334aebfd9bc41e1f8a9aeb69b9827
Reviewed-on: https://gerrit.libreoffice.org/44582Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

...in SwDBManager::LoadAndRegisterEmbeddedDataSource.  For example, when the
authority encodes a file URL whose path contains '%23' (because one of the
pathname segments encoded in the file URL contains a '#' character), the
original code would have left it as %23 in the vnd.sun.star.pkg URL, instead of
encoding it as %2523.  That lead to bad file URLs being recovered from the
vnd.sun.star.pkg URL in dbaccess.  (And 03f58aa3
"dbaccess: properly encode path to prevent stripping 'fragment' from it", which
this commit reverts, wrongly tried to address that on the consuming instead of
the producing side.)

Change-Id: I17d2dc9e6306d006361fbcb63d77e93a9e20bf31
Reviewed-on: https://gerrit.libreoffice.org/44569Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ic92002ec4f5edc48ca1bb3ac84836c4e6d19833c
Reviewed-on: https://gerrit.libreoffice.org/44552Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I117156abf0e1f52491bf6bbe42bf18f4efd364f7
Reviewed-on: https://gerrit.libreoffice.org/44579Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Default value for 'Export placeholders' in dialog 'Export as PDF...'
should be false like in the print dialog

Change-Id: Ib68a0921bfcb62849774c1388b0d77761384a130
Reviewed-on: https://gerrit.libreoffice.org/44546Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I40dfa40dd157046aa5c1285b1855fb8c100fc315
Reviewed-on: https://gerrit.libreoffice.org/44577Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454
Reviewed-on: https://gerrit.libreoffice.org/44553Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

These are very common occurrences. Let's not flood the warning output.

Also ressurrect some helpful looking commented out SAL_INFOs

Change-Id: I3368fb46b27b72edd8ba1f52e2a145a661c40477

Change-Id: Ia2e6171a1aeb3b8ad679a547a63ccaeac20481df
Reviewed-on: https://gerrit.libreoffice.org/44554Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I0c356b100b732e259646d4ebb5d0aedd4dc4bcdd
Reviewed-on: https://gerrit.libreoffice.org/44302Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: Ifb6f22472a9e9c0be95131bf8f49985ccc17c483

Change-Id: I1fa3543d541ea084a43a1a11f62680fa798f5647

Change-Id: I5974cf3df434ebfff1e3748ddd291e2a21cbb0de
Reviewed-on: https://gerrit.libreoffice.org/44536Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Send _NET_ACTIVE_WINDOW message to the mapped frame with the timestamp
of current X11 server time (the real timestamp, not CurrentTime
constant, otherwise e.g. KWin focus stealing prevention would kick in)

Change-Id: I637e1c3548b874e7267f8fc71ffcca4b1a82a412
Reviewed-on: https://gerrit.libreoffice.org/44409Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I01c4cf877eca81880381060e1b3ebedf2979bcb8

Change-Id: I9fc79d2fc68cc0471fe6b8485a5fa62a1b81172a

Change-Id: Ib7f49b06669a5199b4bbe91d1b3eecf29ae6cfae
Reviewed-on: https://gerrit.libreoffice.org/44521Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I481cfa8b0f4bb9cbc257d28f36c372fb7367f294

mbIsFallback was added to ctor but not to copy assignment in
commit 258d9fac
    CID#1103756 missing initialization

Change-Id: I91ee5daf68c3c3682b5d7007c028eaf3579a0715
Reviewed-on: https://gerrit.libreoffice.org/44563Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9d8bc018dfe8bd8668d28daccd85ea5770fe31b0
Reviewed-on: https://gerrit.libreoffice.org/44537Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>