Change-Id: I389984fa56a8709416f9d525e4a879993b432bea
Reviewed-on: https://gerrit.libreoffice.org/63077
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

ee9ccdf6 "reduce cost of ProfileZone when it is
not active" had changed g_bRecording from a bool guarded by g_aMutex to a
volatile bool.  But having been guarded by a mutex indicates that g_bRecording
is potentially accessed from multiple threads, and volatile does not avoid
races.

Change-Id: I933ff5d912cbc7acce52155c605d9c19049c66aa
Reviewed-on: https://gerrit.libreoffice.org/63073Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I17c3d154144b13ce401b0e4afe84c91a2fe98d8e
Reviewed-on: https://gerrit.libreoffice.org/63075
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

ab8bf553 "Avoid error message from configure
about clang's header for compiler plugins" caused problems after
cd472d1d "Compile as C++2a, where available",
when the compiler used to build LO (CXX) supports -std=gnu++2a but the compiler
used to build loplugin (COMPILER_PLUGINS_CXX) does not.  So solve that problem
instead by just adding -std=c++11 to the default for COMPILER_PLUGINS_CXX.

Change-Id: I95e86bc28f2a0dfb2b7bdce6b15955b870428b8c
Reviewed-on: https://gerrit.libreoffice.org/62997Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Jenkins

making this consistent with ListBox

Change-Id: Ifa2fd7070f95232fca8aa129e107ef5adf32e3df
Reviewed-on: https://gerrit.libreoffice.org/62907
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

After 09841225 "soltools: fix
-Werror=format-overflow" changed the sprintf into an snprintf, at least the
Fedora 29 "gcc (GCC) 8.2.1 20181011 (Red Hat 8.2.1-4)" now complains about

> [C  ] soltools/mkdepend/include.c
> soltools/mkdepend/include.c: In function ‘remove_dotdot.constprop’:
> soltools/mkdepend/include.c:246:42: error: ‘snprintf’ output may be truncated before the last format character [-Werror=format-truncation=]
>      int n = snprintf(buf, BUFSIZ, "%s%s%s", dir, *dir ? "/" : "", component);
>                                           ^
> soltools/mkdepend/include.c:246:13: note: ‘snprintf’ output 1 or more bytes (assuming 8193) into a destination of size 8192
>      int n = snprintf(buf, BUFSIZ, "%s%s%s", dir, *dir ? "/" : "", component);
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This all looks not very helpful, lets limit the silencing to just GCC 8.2 (in
the hopes that later versions of GCC won't emit that warning any more, anyway).

Change-Id: I006964e4f32bbb52b6b90288e2d623797b8d38ea
Reviewed-on: https://gerrit.libreoffice.org/63068
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ie76555a007db13e89f06c85d02beebf84eadea0b
Reviewed-on: https://gerrit.libreoffice.org/62912Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 3fb90f6e)
Reviewed-on: https://gerrit.libreoffice.org/63062
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af
Reviewed-on: https://gerrit.libreoffice.org/62958
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

In a build using the system Python during build (i.e., not using
--enable-python=fully-internal) on Fedora 29 (where /usr/bin/python3 is 3.7.1),
UITest_librelogo failed with

> ======================================================================
> FAIL: test_compile_librelogo (compile.LibreLogoCompileTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/data/sbergman/lo-system/core/sw/qa/uitest/librelogo/compile.py", line 128, in test_compile_librelogo
>     self.assertEqual(test[1], re.sub(r'(\n| +\n)+', '\n', re.sub(r'\( ', '(', compiled)).strip())
> AssertionError: 'glob[52 chars]_#\n label(_y + _z)\n #_@L_i_N_e@_#\n#_@L_i_N_e@_#\nx(25, 26)' != 'glob[52 chars]_#\n label(_y + _z)\n #_@L_i_N_e@_#\n#_@L_i_N_e@_#\nx(25, ,26)'
>   global x
>   def x(_y, _z):
>    __checkhalt__()
>    #_@L_i_N_e@_#
>    label(_y + _z)
>    #_@L_i_N_e@_#
>   #_@L_i_N_e@_#
> - x(25, 26)+ x(25, ,26)?       +
>
>
> ----------------------------------------------------------------------

due to an upstream Python change discussed at
<https://bugs.python.org/issue34982#msg329418> "re.sub() different behavior in
3.7".

I am not sure that upstream change really makes sense, despite that being
explicitly confirmed in <https://bugs.python.org/issue34982#msg329420>.  But
lets tweak our code to adapt to that anyway.  (There may be further places in
LibreLogo.py that would need similar changes; I just fixed enough to make
UITest_librelogo succeed for me.)

Change-Id: I6c8f4b78f63953d582b88037fa56388b50af2b54
Reviewed-on: https://gerrit.libreoffice.org/63038
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I8371bd4184734857a6c5578dc5c235760f83cc36
Reviewed-on: https://gerrit.libreoffice.org/60787
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Iaf371360239ca07f45e76530c7d8e497b2ef697f
Reviewed-on: https://gerrit.libreoffice.org/63049
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I416eee47eaae49a629fb0199e6b086215d315a94
Reviewed-on: https://gerrit.libreoffice.org/63048
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5989ce6485656f6ddb8f4994e8764cfa278d9ecb
Reviewed-on: https://gerrit.libreoffice.org/63047
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I92bcb381330a129ca42a2407a3e4db0ed044ed51
Reviewed-on: https://gerrit.libreoffice.org/63041
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If50176e4c4ee0ce1d1746aeb516dda48631f6b07
Reviewed-on: https://gerrit.libreoffice.org/62939
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I3e3bf3160fe3627cd105d8b69ff165c0577d8c9b
Reviewed-on: https://gerrit.libreoffice.org/62807
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I386ead3e61a3162c1c4605d2f65ad23a6487389f
Reviewed-on: https://gerrit.libreoffice.org/63046
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ia59ecb8f7912157aee23a6f2b5ea4aa178dd20fa
Reviewed-on: https://gerrit.libreoffice.org/63051
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

A follow-up to 6acde4a6
("Context Menu: Remove Comment section in sw modules").
I doubt we want the table context menu to be so
different from the regular text context menu. And the
reason of the whole change is apparently a comment by
Mike Kaganski in https://gerrit.libreoffice.org/62242/,
which applies here too.

Change-Id: I2849e7c6b835a4d0d464a9a199b054dfb2b57606
Reviewed-on: https://gerrit.libreoffice.org/63050
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Ic4893d310e0503d5d0d4cd185976b149c9f079b1
Reviewed-on: https://gerrit.libreoffice.org/63053
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Id16846c19c57ec437a64146d0fa771c1bfc05135
Reviewed-on: https://gerrit.libreoffice.org/63028
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id5cddc6d85e227f18d10d7af6a8d4b25c40ab9f3
Reviewed-on: https://gerrit.libreoffice.org/63026
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I593ccc2fb43321caf3ff64d0c348b1bac742ad18
Reviewed-on: https://gerrit.libreoffice.org/63025
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iea1227a9f13a0a618d9bb6b0bbedaa5ce8d1a4f5
Reviewed-on: https://gerrit.libreoffice.org/62732
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id2dcfb69ad8440ea63564334a5a26a5f9b9bde14
Reviewed-on: https://gerrit.libreoffice.org/62789
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Cases indicated here correspond to portrait layout
so use else cases from sd/source/core/sdpage.cxx:3013 switch:

case 24/AUTOLAYOUT_HANDOUT3
nColCnt = 2; nRowCnt = 3;

case 26/AUTOLAYOUT_HANDOUT6
nColCnt = 2; nRowCnt = 3; break;

and so avoid some negative values for param given to
setHeight in xmloff/source/draw/sdxmlexp.cxx during sd tests

Change-Id: I5ffd9581c19f31b648775f57e270ab55f330dad5
Reviewed-on: https://gerrit.libreoffice.org/62978
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I39e639e2e14d4c377f2e8f3a74869622d0611bd9
Reviewed-on: https://gerrit.libreoffice.org/62977
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

It was caused by an unsigned integer underflow i.e. 0 - 1 on size_t.

Change-Id: I579aefa8ffc9e320fadf7180f51711e535fdb778
Reviewed-on: https://gerrit.libreoffice.org/63057
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

vcl/inc/unx/gtk/gtkinst.hxx's IsMainThread returns always false.

This breaks in iahndl.cxx on Linux.

This reverts commit bc089afb.

Change-Id: I8fbd945e3704214d242f6f9e65760d44b0cc7d40
Reviewed-on: https://gerrit.libreoffice.org/63044Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins

Change-Id: If524e701ab295c83b485376fd4139540d3f28d7b
Reviewed-on: https://gerrit.libreoffice.org/62961
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

See §18.8.1 of Part1 of the XLSX spec.

Change-Id: Id1822e3d0ddaa0d19fa4e9adc7f469e6ef334ef1
Reviewed-on: https://gerrit.libreoffice.org/62979
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Add support of Underline and Strikeout for DrawString and
DrawDriverString EMF+ records

Change-Id: I24c47e0d7524dabc13edd04c6b68aec69fa35e7b
Reviewed-on: https://gerrit.libreoffice.org/62827
Tested-by: Jenkins
Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: Ia6224c0d638cd3dee3c6de2b97e765df709034bb
Reviewed-on: https://gerrit.libreoffice.org/63023
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8ab8421354a296cb6382f28fd3bd40372e0665df
Reviewed-on: https://gerrit.libreoffice.org/62908
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44
Reviewed-on: https://gerrit.libreoffice.org/62787
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ica1c9f18d9486ff25662f9e9c0fc96e8fda706b1
Reviewed-on: https://gerrit.libreoffice.org/63033
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

It's possible all children request 100% of space, need to scale down in
that case. This means that children other than the first one is now
readable in the layout result.

Change-Id: I86a05cd77510bbb6686a53e33f13a60034c8e8f6
Reviewed-on: https://gerrit.libreoffice.org/63037Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I83015ea075c986ce5186f7a773df7b54ceb21636
Reviewed-on: https://gerrit.libreoffice.org/63034
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I8d8f93262481c35968cdfff49eddd7a20cf84c1f
Reviewed-on: https://gerrit.libreoffice.org/63022
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The deadlock happens from time to time, when converting documents
containing OLE objects via remote UNO (from Java) -- after the
conversion, when closing the document.

The relevant stacktraces are:

>Debug.ListCallStack /ShowLineOffset /AllThreads
Callstack for Thread 8 (Thread Id: 32912 (0x8090)):
...
 6      sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 75
 7      [Inline Frame] emboleobj.dll!osl::Mutex::acquire() Line 56
 8      [Inline Frame] emboleobj.dll!osl::Guard<osl::Mutex>::{ctor}(osl::Mutex &) Line 129
 9      emboleobj.dll!OleComponent::OnClose_Impl() Line 1399
 10     emboleobj.dll!OleWrapperAdviseSink::OnClose() Line 119

Callstack for Thread 11 (Thread Id: 21088 (0x5260)):
...
 11     ole32.dll!00007fffc5e44e83()
 12     [Inline Frame] emboleobj.dll!OleComponent::CloseObject() Line 1012
 13     emboleobj.dll!OleComponent::Dispose() Line 484
 14     emboleobj.dll!OleComponent::close(unsigned char bDeliverOwnership) Line 1463
 15     emboleobj.dll!OleEmbeddedObject::GetRidOfComponent() Line 239
 16     emboleobj.dll!OleEmbeddedObject::Dispose() Line 275
 17     emboleobj.dll!OleEmbeddedObject::close(unsigned char bDeliverOwnership) Line 497
...
 26     swlo.dll!SwXTextDocument::close(unsigned char bDeliverOwnership) Line 617

OleComponent::OnClose_Impl() taking a lock is fine, but
OleComponent::close() takes a lock and then later it still calls out
(via OleComponent::CloseObject()), which is a no-go.

Fix the problem by making sure that callers of Dispose() own no lock at
the time of the function call, and taking the lock in Dispose() only
after the CloseObject() call (which invokes event listeners).

Change-Id: I53befee21478188c7f79723b7d7596e66077d1c2
Reviewed-on: https://gerrit.libreoffice.org/63014
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>