Change-Id: I5174261484c64a6f223c4a2e197d0e042c3581e4
Reviewed-on: https://gerrit.libreoffice.org/54787Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Icde1f5b9af599ca8b1ef52863c2772670659a39b
Reviewed-on: https://gerrit.libreoffice.org/54648Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

- and to the couragous person writing that comment:
  * yes, likely you should have come back to check if this was
    superfluous
  * no, you didnt (so far)

Change-Id: I56633aee4b49979b60417f88235e9393c0bc48c8
Reviewed-on: https://gerrit.libreoffice.org/54895Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

Copy, Cut, PasteSpecial and Insert is used by Range excel object,
so after finishing executing the VBA script ensure to release XTransferable2
interface

Change-Id: I967a7ba1a1d101282f7a1b9d4b2e2ac3004f1c07
Reviewed-on: https://gerrit.libreoffice.org/54497Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>

https://github.com/google/oss-fuzz/issues/1449

Change-Id: I495f269b66f8232dce260031c4f74e574bec6aa9

Change-Id: I4924e62af79ba225a4cc9ed2f1221111854318b9
Reviewed-on: https://gerrit.libreoffice.org/54883Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ia494251483b57d747348976674206dd33eb29c7c
Reviewed-on: https://gerrit.libreoffice.org/54874Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Commit 28905832 was merged in 2004

Change-Id: Ie29b518d689208584fc22d4c261e0e7f139c2816
Reviewed-on: https://gerrit.libreoffice.org/54559Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I5d580e2efe6cf34b9855e47190f6242323d7823a
Reviewed-on: https://gerrit.libreoffice.org/54873Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

In fact, if there are no sheet-local names defined, then the loop
will not even be entered. Only the sheets that actually contain
the desired item will be iterated through.

Change-Id: I1fa94d8b9190f43b2896a002acdec18397225395
Reviewed-on: https://gerrit.libreoffice.org/54742Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ia2723b168ecc0bdb023c98bfb71b297684ee8c7f
Reviewed-on: https://gerrit.libreoffice.org/54876Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

... but don't update it in case it's a predefined API name

Change-Id: I20075a4e085bdeab8374860c16e7eb2a72772c33
Reviewed-on: https://gerrit.libreoffice.org/54879Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ic1725e78a34cc5fc7b76c272d4191266966a2b13
Reviewed-on: https://gerrit.libreoffice.org/54815Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id1283afe1ed4429a194a2a2c27eaf5c76387a23a
Reviewed-on: https://gerrit.libreoffice.org/54875Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I907e5dbcd7c62344c2c76fe2fdaf1b18ecfecee1
Reviewed-on: https://gerrit.libreoffice.org/54838Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I4a5356e275f1132898aec758a79f3a38c71d35ea
Reviewed-on: https://gerrit.libreoffice.org/54820Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Since 5ad8376d
Resolves: tdf#111080 framework user of convert menu needs action names set
2017-08-08

Change-Id: I2ec8358005e335941bd1c2530f30ce696d3e808f
Reviewed-on: https://gerrit.libreoffice.org/54865Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Project: help  7fe562928543fb6ef1bfc0e4662b6c10397c13a4

Fix misplaced xml tag

+ remove tabs

Change-Id: I0e09e1b80341ed5a379b54f782607c49f030a712
Reviewed-on: https://gerrit.libreoffice.org/54819Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I63e1164d5ee431450f1c780758d9fd6f69cf6916

Otherwise they may stay disabled until cursor position changes.

Change-Id: If734bbd4793b3b01c64601d68126d5752f5aba0c
Reviewed-on: https://gerrit.libreoffice.org/54841Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I59591d0209ddf2bcf6e57a78dc7999d773b73ae3
Reviewed-on: https://gerrit.libreoffice.org/54805Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Make it a bit clear that edit here means edit engine not merely text
editing as one would naïvely assume. Took me a while to realize that!

Change-Id: I570a0556d3272c480dc1ae95640de32f56ab9607
Reviewed-on: https://gerrit.libreoffice.org/54783Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: I26ec6c7fdfa5b6f6f818927fd9ede00184dc5e8c
Reviewed-on: https://gerrit.libreoffice.org/54813Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I8048b21de3a6cc7e027ad0123d1ef8aab32366dc
Reviewed-on: https://gerrit.libreoffice.org/54829Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

make -sr UITest_calc_tests
UITEST_TEST_NAME="tdf53482.tdf53482.test_tdf53482_Range_contains_column_headings_file"

passed for me 10 times in a row without problems after this, while 'make
check' randomly fails here & there since the introduction of this test.

Change-Id: I5c3eae027297e0b488cf72161815239a8b03aa60
Reviewed-on: https://gerrit.libreoffice.org/54825Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ib7e080864f809294a4a6ae78694730fb07120753

Change-Id: Ic0cdfc837ac8503968c5226ec309e75ff7172a75
Reviewed-on: https://gerrit.libreoffice.org/54801Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

partial revert part of
    commit	fa135fd0
    remove unused SID constants and associated code
noticed by Julien Nabet

Also document some more of that array to make the usage more obvious

Change-Id: I4d76034df32bc85b58e4a845b246e5e28dcea49f
Reviewed-on: https://gerrit.libreoffice.org/54799Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

(*) if we are already throwing a Wrapped*Exception, get the
exception using cppu::getCaughtexception.

(*) when catching and then immediately throwing UNO exceptions,
use cppu::getCaughtException to prevent exception slicing

(*) if we are going to catch an exception and then
immediately throw a RuntimeException, rather throw a
WrappedTargetRuntimeException and preserve the original exception information.

Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558
Reviewed-on: https://gerrit.libreoffice.org/54692Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I785e96599bbda029adf4698d11d7f981750dec07
Reviewed-on: https://gerrit.libreoffice.org/54802Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I63d67709ab50e86b138fecd814b4dee7e2f2a755
Reviewed-on: https://gerrit.libreoffice.org/53925Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Git commit: ae37972c added some logic at
the bottom to call Toolbox::SetItemImage to trigger the bitmap doubling
code. This is no longer needed and is faster without.

Change-Id: I0fb0538000d5616cb8d8a0ae35e15fb09cdf2c59
Reviewed-on: https://gerrit.libreoffice.org/54654Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I6a1dcba0afda88eaf083f0d4c73c1e74b0c78f56
Reviewed-on: https://gerrit.libreoffice.org/54297Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Since commit db04be03, empty Database
fields are hidden. But since Labels wizard generates a single paragraph
with line breaks for the label's text, the hiding feature cannot be
used efficiently.

Let the individual lines be in individual paragraphs.

Change-Id: I27430d54baea88461c2ea9de38baa95d6b7e9e62
Reviewed-on: https://gerrit.libreoffice.org/54800Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

if we're going to write "unhandled" messages, at least what is being
unhandled

Change-Id: I570183c92876d553f4344b979def653cbd5bb55d
Reviewed-on: https://gerrit.libreoffice.org/54793Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I837b20b3334dbb7f241af31c5fa5b702f1df8742

Change-Id: I00f336ee4eced431155c79bee6e2373e145ae95c
Reviewed-on: https://gerrit.libreoffice.org/54780Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Also simplify parent/child relationships, get rid
of double data (SdrPage/Parent infos in SdrObjects,
also in SdrObjList). This is all not needed - when a
SdrObject is inserted to a SdrPage, get SdrPage by
traveling over parents (no double info, member as soon
as inserted, ...).
More cleanups/reworks included, will need some more
cleanups, too.

Stabilizing: SetRectsDirty/DefaultStyleSheet

Had to correct the SetRectsDirty stuff for 3D due to
going down the hierarchy while the 2D implementation
goes the other direction -> endless loops. Added special
handling for 3D stuff for now (will be chnaged again when
SnapRect is no longer needed at SdrObject level).
Also had to adapt how the DefaultStyleSheet is set at
incarnated SdrObjects - better: their properties. Since
we now always have a SdrModel, it is possible to correctly
initialize with the correct default StyleSheet from that
SdrModel.
This needs to be done after ForceDefaultAttributes and in a
way that again deletes Items that are set in the StyleSheet.
This leads to an error in CppunitTest_sd_import_tests where
I checked tdf100491 - it is okay and thus I change the control
instance of the imported, XML-dumped file.
The less hard attributes, the better for Styles in general.

Cleanup of comments for last two commits

Corrected SvxShape::getParent()

Needed to get the direct parent, so test for SdrObject
first (to get SdrObjGroup/E3DScene), for SdrPage second

Fixed CppunitTest_sc_subsequent_export_test

Several problems arose. The used SdrCaptionObj was
Cloned, but the clone not inserted to a SdrPage. This
leads to not being able to access a UNO API imlementation
of the SdrPage (SvxPage) on lower levels.
It worked before due to SdrObject having a SdrPage*
additionally to being added to a SdrPage - this is exactly
the main cleanup this change does.
Looked for why it is cloned, could see no reasons. The
SdrCaptionObj exists during all im/export, not difference
to other SdrObjects (that do not get cloned). It is not
changed in any way. It *might* be to suppress a crash that
happened due to UNO API Service emfio/emfio not being
available in the UnitTest scenario. Interestingly it
did not crash with the cloned SdrCaptionObj, but the
Graphic exported was probably wrong.
Fixed by no longer Cloning the SdrCaptionObj and adding
emfio/emfio UNO API Service.

d139f821a5b39535a3e7b9c6261df7e18f8ae8ac
910e7f4bc628a715fda7545dffaf3369d5e76ea0
ca1de01b723051e09ac37d7ec7bba978beea41c5
3a76da1471dfe75e69847f64a6a3519ad21c8c9c

Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8
Reviewed-on: https://gerrit.libreoffice.org/54689Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Found with bin/find-unneeded-includes
Simple removal proposals are dealt with here
and a bit of fallout management

Change-Id: Ia6f8d4ca46d7b218f5827052ced5641367bd4478
Reviewed-on: https://gerrit.libreoffice.org/54683Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I53ef86a997f4ae1c0ad84bb381327cba3143dd4c