1. 21 Tem, 2017 10 kayıt (commit)
    • Caolán McNamara's avatar
      de-hrc various things · 182a74d9
      Caolán McNamara yazdı
      e.g.  helpid[s].hrc -> helpids.h
      and insert include guards where missing
      
      move "ordinary" defines into .hxx files
      
      remove .hrc entries that are used as arguments to dialog factory
      when a dedicated method can be added instead
      
      Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
      182a74d9
    • Caolán McNamara's avatar
      migrate to boost::gettext · 00657aef
      Caolán McNamara yazdı
      * all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl
      * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string")
      * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching
        MODULE .mo files
      * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui
        goes from l10n target to normal one, so the res/lang.zips of UI files go away
      * translation via Translation::get(hrc-define-key, imbued-std::locale)
      * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there
        to keep finding the .hrc file uniform) so magic numbers can go away there
      * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation
        mechanism
      * en-US res files go away, their strings are now the .hrc keys in the source code
      * remaining .res files are replaced by .mo files
      * in .res/.ui-lang-zip files, the old scheme missing translations of strings
        results in inserting the english original so something can be found, now the
        standard fallback of using the english original from the source key is used, so
        partial translations shrink dramatically in size
      * extract .hrc strings with hrcex which backs onto
         xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap
      * extract .ui strings with uiex which backs onto
         xgettext --add-comments --no-wrap
      * qtz for gettext translations is generated at runtime as ascii-ified crc32 of
         content + "|" + msgid
      * [API CHANGE] remove deprecated binary .res resouce loader related uno apis
            com::sun::star::resource::OfficeResourceLoader
            com::sun::star::resource::XResourceBundleLoader
            com::sun::star::resource::XResourceBundle
          when translating strings via uno apis
            com.sun.star.resource.StringResourceWithLocation
          can continue to be used
      
      Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
      00657aef
    • Chris Sherlock's avatar
      osl: Unix pipe converted from OSL_ASSERT to assert/SAL_WARNs · fa987cbb
      Chris Sherlock yazdı
      Explanation for each conversion:
      
      - osl_acceptPipe()
          - don't worry about an invalid oslPipe sent as function parameter an
            error gets flagged in Unix normally, so it might not be a
            programming error
          - definitely assert on an empty name, that's a definite programming
            error and should never, ever occur
          - createPipeImpl() allocates and initializes memory for the
            oslPipeImpl structure, if it can't do this then something has been
            done wrongly
      
      - osl_receivePipe()
          - invalid oslPipe sent as function parameter might not be a
            programming error, give a warning but don't assert
      
      - osl_sendPipe()
          - invalid oslPipe sent as function parameter might not be a
            programming error, give a warning but don't assert
      
      - osl_writePipe()
          - really just a thin wrapper around osl_sendPipe(), which detects
            and handles invalid pipes
      
      - osl_readPipe()
          - really just a thin wrapper around osl_receivePipe(), which detects
            and handles invalid pipes
      
      Change-Id: I4923265b4c648852743c406b682d43ffb9ac6537
      Reviewed-on: https://gerrit.libreoffice.org/40003Reviewed-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
      Tested-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
      fa987cbb
    • Chris Sherlock's avatar
      osl: fix Pipe noacquire/acquire tests · e0f990b9
      Chris Sherlock yazdı
      There is an incomplete test of ::osl::Pipe::Pipe(oslPipe, __sal_NoAcquire),
      but the comments show that the tester wasn't able to figure out a way to
      test the noacquire variant of this constructor. However, they seem to
      have not just given up but copied and pasted the acquire and no acquire
      tests - the error codes for the acquire test talk about non-acquisition
      and don't actually see if the handle is the same or not.
      
      I have fixed this test. To test if the noacquire is working or not then
      you merely have to:
      
      1. create a new Pipe instance
      2. create a new Pipe non-acquired instance copy of the first instance
      3. delete the non-acquired instance copy
      4. try to send a single character to the original Pipe instance, which
         should return an error (negative return result) because at this
         point there is no valid pipe to operate on as the pipe should have
         been destroyed when you deleted the copy.
      
      If the send() succeeds, then this is a test failure.
      
      For the acquire test, it didn't actually test if the handles are the
      same - I have corrected this now.
      
      Change-Id: If868746233d3a222cc6f9e7cd0d453e70ef6c7cc
      Reviewed-on: https://gerrit.libreoffice.org/40102Reviewed-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
      Tested-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
      e0f990b9
    • Noel Grandin's avatar
      loplugin:unusedfields in svtools · 8e7cb958
      Noel Grandin yazdı
      Change-Id: I5484fe5ee449e72919591bd374366aa60f792e28
      Reviewed-on: https://gerrit.libreoffice.org/40254Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      8e7cb958
    • Noel Grandin's avatar
      loplugin:unusedfields in svx · 7b59273c
      Noel Grandin yazdı
      Change-Id: I7fc5bf55b01d464815771220914f21d8e85b5a36
      Reviewed-on: https://gerrit.libreoffice.org/40253Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      7b59273c
    • Noel Grandin's avatar
      loplugin:constparams in svgio · 65c69af5
      Noel Grandin yazdı
      Change-Id: I35dd8b1373ce3c46a10b1da1ddc6dc3722ffa760
      Reviewed-on: https://gerrit.libreoffice.org/40245Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      65c69af5
    • Akshay Deep's avatar
      Remove unused function code special characters · a1dae160
      Akshay Deep yazdı
      Change-Id: I6610a986795c3169077b9c1a8e65a86f5488243d
      Reviewed-on: https://gerrit.libreoffice.org/40230Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarAkshay Deep <akshaydeepiitr@gmail.com>
      a1dae160
    • Albert Thuswaldner's avatar
      tdf#43157 - Clean up OSL_ENSURE and OSL_FAIL in sc/filter/lotus · 91325884
      Albert Thuswaldner yazdı
      Change-Id: I88e794752dff1bd46faac71234322d603c10bed9
      Reviewed-on: https://gerrit.libreoffice.org/40075Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarMarkus Mohrhard <markus.mohrhard@googlemail.com>
      91325884
    • Mohammed Abdul Azeem's avatar
      Moving legacy contexts to FastContexts: · a9588bac
      Mohammed Abdul Azeem yazdı
      ScXMLTableShapesContext
      ScXMLTableSourceContext
      ScXMLTableColContext
      ScXMLTableColsContext
      ScXMLConditionalFormatsContext
      ScXMLTableProtectionContext
      
      Change-Id: I36704c7f51cd5d13b3c0ebf9bc07b172c1576f3e
      Reviewed-on: https://gerrit.libreoffice.org/40246Reviewed-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
      Tested-by: 's avatarJenkins <ci@libreoffice.org>
      a9588bac
  2. 20 Tem, 2017 30 kayıt (commit)