...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca

Change-Id: I92a98bb196c9f6e7dfdca7008a34fb4fd3e10799

no logic change

Change-Id: Ib03a2516c9b3cf6bedf52760d8f7cb68cc70464f

...in preparation of enabling Clang's -Wimplicit-fallthrough

Change-Id: If64f9b18591b3cd2528adc6c2d6011d509d4afcd

In the original 5624be5a "CWS-TOOLING: integrate
CWS graphite01" it used to be read in debug-only code that meanwhile got
removed.

(And getIntValue can now be a non-member function, as noted by
loplugin:staticmethods.)

Change-Id: I758268064181d44c90f5c4d1841fb09f4c532669

mbErrors isn't read anywhere, anyway.

Change-Id: Ieef912c046535c130b82d2d2e0536a1ec0446905

The fallthrough will only happen if eCodeType is anything but NF_KEY_MMM..., in
which case the following cases will fall through to the end of the switch, too.

Change-Id: I2fea503a0ce919dad645e3749b2173676fda5373

The fallthrough will only happen if !pDocShell.  So if HAVE_FEATURE_SCRIPTING,
the following case's if-branch is not entered, leading to break.  And if
!HAVE_FEATURE_SCRIPTING, it leads directly to the default-branch's break.

Change-Id: Ia0ac8d849ea3c762893001bfb2c64acd9725dd92

...which itself only contains a "break" (or nothing at all at the end of the
"switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these.

Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b

Project: help  603ab87d4a7356a1490a00fc62a7e2f691b5ece3

Cleaned up some English

Change-Id:  I5f81ef8381536aeca8eac8d409c75f20d4245786
Reviewed-on: https://gerrit.libreoffice.org/24796Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>

Change-Id: If9f725c791f9d01efba098caed8387f21862fa04
Reviewed-on: https://gerrit.libreoffice.org/24825Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I0d401f09cb504c89329a27533c2df30b59bb60ad

Change-Id: I2c49ec843c0f95e8246cdf9d3185c11e81a3bde3
Reviewed-on: https://gerrit.libreoffice.org/24824Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I41fcdbb2381008b99f6cb7cafb085d35f8db9374
Reviewed-on: https://gerrit.libreoffice.org/24828Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I1e289c6891f3d0273104a909428a4aa0daeb738f

Change-Id: I96ae74d8d82468bebcc79cebebf86731685c446f

Change-Id: I3041b0a4f4427bbcbaf07e7a0694e9cfe5d10014

Change-Id: I6482ca005df385d79bcd55f3b1db3559021ab371
Reviewed-on: https://gerrit.libreoffice.org/24835Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I585ff0105f00793a80e0b5fa25e7dd08fb2fc95f

Change-Id: Id9500cf86988614d9dfa04a52b73decd2a4855e0

Table text is buffered, so buffer the shape import as well, otherwise
the anchor will precede the buffered text -> incorrect anchor position.

Change-Id: I527b898e2cd5fafaf122a20e11df66ba8d3185cf
Reviewed-on: https://gerrit.libreoffice.org/24822Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

after my "Convert SALEVENT to scoped enum" commit

Change-Id: Ib4a3f0e18fa5d8160446d5b5cd505bae651da7d5

Loop variable passed by value, pass by reference instead.

Change-Id: I12d1cb639cbe7a5686a1854168362b85322fa2e5

Avoid GL errors when glDisable() is called without a context.

Change-Id: Ie9eae498c207a82934228ad2f74b7096308f5530

We can tweak later what the "close enough" means - for the moment it is 10
columns and 25 rows.

Change-Id: I92127a71aa6683c03692e96b9e0da7827942c94b

Change-Id: I4dbfc090ab43065c719f83b5355cd9832ee4d1e3

after my "Convert SALEVENT to scoped enum" commit

Change-Id: I1b91997fdadfd70cb2a00a33ec00f2f51727656a

In the tiled rendering case, not all column and row are rendered,
so it was set a limit for tiled column and row.
However, when a client request to move the cursor beyond the limit,
the tiled column and row is updated and they are rendered later.

Change-Id: Id0de533ebf7b3c6e0343f9dc15336150729299fa
Reviewed-on: https://gerrit.libreoffice.org/24777Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I8eb25fc274b45b8add04dfc03e4b52f130ad04de
Reviewed-on: https://gerrit.libreoffice.org/24827Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic979d1470052039c4b966edd1d896af31ef55668
Reviewed-on: https://gerrit.libreoffice.org/24826Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

after my "Convert SAL_EVENT to scoped enum" commit

Change-Id: I1a52a1e3428c9b68d67bd521a3136f3a529392f5

used in loops, rewrite to range based loop

oox/source/drawingml/color.cxx has some mappings in plain arrays
make them arrays of pairs which can be used in range based loops

Change-Id: Ib6693197d890f595c27ca24b9f9b4e0763747f4c
Reviewed-on: https://gerrit.libreoffice.org/24809Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

if used in loops, rewrite to range based loop,
else replace STATIC_ARRAY_END( ) with std::end( )

Change-Id: Ib05063eb78f82c8af967bc82e9759af2a58258c8
Reviewed-on: https://gerrit.libreoffice.org/24808Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

after my "WindowStateState scoped enum" conversion.

WorkWindow::IsMinimized needs to check the return code of
SalFrame::GetWindowState, or it can end up reading uninitialised memory.

So mark the member as SAL_WARN_UNUSED_RESULT.

Change-Id: Iaeb132ed2fbf08162dbd7ec2e126dfa679cbda6c

Change-Id: I4e605e7acfe9d4fe409d32f20880b4c0e85a0ea7

Change-Id: I6d92c86035dd321eb6df46bcd01aed7a0113b0a4

Forgotten in 4f1f8b8e "pivot: new pivot table
layout dialog" (as clarified on IRC).

Change-Id: If35e1a9616e596b16bcb007f6ea172b634c11b85

Project: help  50ae47d7856c77dd682d0e7007acc70ee34fb5b5

tdf#99739 tdf#91945 Margins and edges aren’t the same thing

Change-Id: I6809b79bdde36fd5ee86f0eeb54c29871f54c19c

Change-Id: Id262a3019a693f236630b798579f360c9462d12e

Apparently forgotten when introducing the case PROPERTY_ID_GENERATEVBAEVENTS in
4fae740d "Disable fake VBA events for the
old-style form controls."

Change-Id: Id2783fd4f087669bd200a9c33eaad2bb6b7b50cd