- 14 Ara, 2018 14 kayıt (commit)
-
-
Mike Kaganski yazdı
PathRemoveFileSpec is used exclusively in GetCaseCorrectPathName(Ex). The GetCaseCorrectPathName function is only called for absolute or relative paths, not some arbitrary that chunks. So initial double backslashes are only possible for UNC paths. This change fixes handling of UNC paths by the functions. Previously, the UNC path was recursively shortened until it only consisted of a single "\"; then, if bCheckExistence was requested, testing this path failed, which resulted in the whole recursion to return empty result; else when returning from the recursion, original path components were appended, but initial double backslashes were never restored. This led to transformation "\\SERVER\Path\file.ext" to "\SERVER\Path\file.ext". The GetCaseCorrectPathName itself is only used in two places: osl_getSystemPathFromFileURL_() and osl_getFileStatus(). osl_getSystemPathFromFileURL_ only calls GetCaseCorrectPathName for paths longer than 248 characters; bCheckExistence is false. In that case, the resulting wrong path (missing one initial backslash) was then processed in /* it should be an UNC path, use the according prefix */ branch, where two initial characters of it were stripped, one of which being the first character of SERVER name. So, all the following manipulations with resulting path were incorrect. This code path was the reason for the bug. osl_getFileStatus calls GetCaseCorrectPathName always; it requires to check existence. This led to 0 returned from GetCaseCorrectPathName, then osl_getFileStatus continued with copying the original string, thus ignoring the error. Change-Id: If7409afa2c0dd6dd001c79e719acbfd271a6ab72 Reviewed-on: https://gerrit.libreoffice.org/65158 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Caolán McNamara yazdı
race in SwDoc::CreateNumberFormatter on thread unsafe mpNumberFormatter. thread 1: SwDoc::CreateNumberFormatter SwDoc::GetNumberFormatter ... sw::DocumentTimerManager::DoIdleJobs Timer::Invoke thread 2: SwDoc::CreateNumberFormatter SwDoc::GetNumberFormatter SwXTextDocument::GetNumberFormatter(); SwXTextDocument::queryInterface ... SvXMLExport::setSourceDocument SvXMLNumFmtExport::SvXMLNumFmtExport Change-Id: Iad9aa9514c9de61eb40256b954d0444d9fc9d81e Reviewed-on: https://gerrit.libreoffice.org/65034 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Justin Luth yazdı
In LO 4.3, Feb 2014 commit a31fbb53 totally changed the logic of the FormatBreak function, affecting doc and rtf even though the focus was only on docx. This was quickly patched for some specific cases, but the careless changes weren't fully reversed. Doing that now, because reading the code it just seems all wrong. As I understand it, there seems to typically be two passes - a valid pass for bBreakBefore and then a separate PageAfter pass. When DOC changed to prefer a breakBefore sprm, it removed the bBefore flag, did nothing on the bBreakBefore pass, and on the after pass, nC wasn't defined, so it did nothing extra. Dropping the bBefore flag probably broke the docx case. Docx commit a31fbb53 just blew that all away, and swapped when SectionBreak was called. Another 2014 patch restored the DOC PageBefore behaviour (nC not defined, so nothing happens), but didn't restore the PageAfter behaviour so SectionBreak was still swapped. So what logically seems to be needed is to restore the bBefore flag (prior to DOC's preference for breakBefore sprm), restore writing PageBreak_After in after pass, and ignore the FollowPageDesc (because it didn't seem to be included purposefully). PageAfter only seems to be UI possible in a table's text flow. So it is VERY uncommon (no instance at all in existing unit tests.) And, not surprisingly, it doesn't export a page break after the table in doc or docx format anyway. At least now it won't put the break BEFORE the table in docx. This will restore these previous behaviours: -doc/rtf: PageAfter no longer written in bBreakBefore stage -docx: -PageAfter no longer written in bBreakBefore stage -PageBefore not affected by FollowPageDesc. PageBefore is generally unaffected by this change, and now the test for page/column break matches again, as would be expected. Change-Id: I265541a04be49e6b60bfbd84c33ab5783b454058 Reviewed-on: https://gerrit.libreoffice.org/64983Reviewed-by:
Justin Luth <justin_luth@sil.org> Tested-by:
Miklos Vajna <vmiklos@collabora.com>
-
Xisco Fauli yazdı
This reverts commit c9493b34. According to https://bugs.documentfoundation.org/show_bug.cgi?id=96248#c15 the asert was gone even before the patch... Anyway, better to have an assert than a crash Change-Id: I84389bf2e8e604f6967923c0eedaae3aec3455e6 Reviewed-on: https://gerrit.libreoffice.org/65115 Tested-by: Jenkins Reviewed-by:
Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by:
Xisco Faulí <xiscofauli@libreoffice.org>
-
Caolán McNamara yazdı
Change-Id: Id27609a86558094e6b53c763aebe77c97cc11672 Reviewed-on: https://gerrit.libreoffice.org/65147 Tested-by: Jenkins Reviewed-by:
-
Vasily Melenchuk yazdı
Template format now supported not only for import, but for export too. Change-Id: I9fb9da14c4d6466b6979fa37fb2c0359ce5 Reviewed-on: https://gerrit.libreoffice.org/64947 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
Tamas Bunth yazdı
Result set field information should be stored correctly. It is queried from database on demand and stored locally. Change-Id: Ia62c62e6db32b45640b9fcd5f48c6249aecc41a2 Reviewed-on: https://gerrit.libreoffice.org/64861 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com>
-
Katarina Behrens yazdı
Change-Id: I0e975bb73211b1d4ddb2e721659f64b361d11322 Reviewed-on: https://gerrit.libreoffice.org/65121 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Cleaned directories are: accessibility, drawinglayer, itemsetwrapper, main, sidebar Change-Id: I612eae9dec636d57a3a3a00102d74b964da5b54c Reviewed-on: https://gerrit.libreoffice.org/64307 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I09775c92f7c5b5e0f554a2822d243a230a06f626 Reviewed-on: https://gerrit.libreoffice.org/65136 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Miklos Vajna yazdı
Martin Hosken thinks all patches are redundant now, so drop them. Change-Id: I062168416a1289b7f4dd42d8ae58b7df56a37712 Reviewed-on: https://gerrit.libreoffice.org/65074 Tested-by: Jenkins Reviewed-by:
-
andreas kainz yazdı
Change-Id: Id00bcd45faa3d9e82d3ed23843f5c4320bfa8f79 Reviewed-on: https://gerrit.libreoffice.org/65135 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
andreas kainz yazdı
Change-Id: I2d6c6d975a3047c879a87a1cee0305772c6b5d49 Reviewed-on: https://gerrit.libreoffice.org/65134 Tested-by: Jenkins Reviewed-by:
-
sabri unal yazdı
* Update helpcontent2 from branch 'master' - Correct "Print black" as "Print text in black" Change-Id: Ia6832472ac9b3c636e5880293794500601b5c010 Reviewed-on: https://gerrit.libreoffice.org/65131 Tested-by: Jenkins Reviewed-by:Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
- 13 Ara, 2018 26 kayıt (commit)
-
-
Michael Weghorn yazdı
Since 'QObject' and the 'Q_OBJECT' macro are used, the corresponding header needs to be included. Without the include and forward-declaration given here, the compiler doesn't know about 'QObject' and 'QAction' which are used further below, unless another header that takes care of this is included before 'QtMenu.hxx'. The error could be provoked e.g. by moving the '#include <Qt5Menu.hxx>' in front of all other includes in 'vcl/qt5/Qt5Frame.cxx'. Change-Id: I76c15eb445cbe26774d6e4177e12c93658daf0ad Reviewed-on: https://gerrit.libreoffice.org/65130 Tested-by: Jenkins Reviewed-by:
Michael Weghorn <m.weghorn@posteo.de>
-
Eike Rathke yazdı
... to squeeze some memory and later use this as a mass object during consolidation. Change-Id: I3f0aa03ec0bbbb4c64a4854b55a451dd3cacfa90 Reviewed-on: https://gerrit.libreoffice.org/65124 Tested-by: Jenkins Reviewed-by:
Eike Rathke <erack@redhat.com>
-
andreas kainz yazdı
Change-Id: I9ddb8f70b53600c02addeaf44a8cd1978e1ba5d0 Reviewed-on: https://gerrit.libreoffice.org/65128 Tested-by: Jenkins Reviewed-by:
-
Michael Weghorn yazdı
Take system includes ('-isystem') into account when generating the '*.pro' files for Qt Creator using the 'qtcreator-ide-integration' make target. Without this, Qt Creator is unable to find the corresponding included files. This also makes Qt Creator's ClangCodeModel able to properly process files and display actual problems, rather than always showing a multitude of errors due to missing includes while parsing the source/header files. Change-Id: Ie513341e1074ceab9304ae9df73fac9a79329db8 Reviewed-on: https://gerrit.libreoffice.org/65129 Tested-by: Jenkins Reviewed-by: -
Eike Rathke yazdı
ScMarkData is passed since long. Change-Id: I7bf66d1f66d66287206ba4ef69c89f9b020103c6 Reviewed-on: https://gerrit.libreoffice.org/65123 Tested-by: Jenkins Reviewed-by:
-
Eike Rathke yazdı
So we can start to bundle everything in one place. Change-Id: I5df76bfae0e1bd5e8923b0012c1337e3a7f14db8 Reviewed-on: https://gerrit.libreoffice.org/65122 Tested-by: Jenkins Reviewed-by:
-
Tor Lillqvist yazdı
(Exactly the same thing as the old name NSAnyEventMask. The naming convention just has changed to use a common prefix: NSEventMask* instead of NS*EventMask.) Change-Id: I18a1ae0a2b399ac38567a0171b0d211dcc9faec1
-
Caolán McNamara yazdı
Change-Id: Iee8305f581533dedcb94d75af15d7178792947ff Reviewed-on: https://gerrit.libreoffice.org/65114 Tested-by: Jenkins Reviewed-by:
-
Lionel Elie Mamane yazdı
commit fec8c14e changed the default value of InputRequired as read from the file; that is the value InputRequired has when it is set to neither false nor true in the file This is to mitigate the fact that InputRequired was not property enforced and now suddenly is, but its default value was "true"! So lots of past forms have InputRequired==true everywhere, users did not pay attention to it because it was not enforced, and now it is enforced, which suddenly is a huge PITA for users because they have to update most controls in all forms. Since older versions of LibreOffice omitted the input-required attribute in the file (the XML stream) when it had its then-default value (namely "true"), we changed that to now mean "false". As a side-effect, newer LibreOffice omits the attribute in the XML stream when InputRequired has its new default value, namely "false". So the situation is that any file saved with an older LibreOffice will have all its form controls with InputRequired==false when opened with a newer LibreOffice, and any file saved with a newer LibreOffice will have all its form controls with InputRequired==true when opened with an older LibreOffice. This commit makes LibreOffice always write the XML attribute. So that any file saved with a newer LibreOffice will have the same InputRequired values when opened in an older LibreOffice. This enhances forward compatibility, because InputRequired was enforced in older versions when the underlying database field was marked NOT NULL. So the current situation leads to unwanted enforcement in older LibreOffice versions, with a file that is saved from newer LibreOffice with a control having InputRequired==false and bound to a database field marked NOT NULL. This commit fixes that, by ensuring that any form control with InputRequired==false in newer LibreOffice will also have InputRequired==false in older LibreOffice. Change-Id: I92ef48ad99c4e2ead43e95376282cc861c181ab3 Reviewed-on: https://gerrit.libreoffice.org/64642 Tested-by: Jenkins Reviewed-by:
Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by:
-
Eike Rathke yazdı
Change-Id: Ie72854a812c9ea73ded6a3e8ed8992dcc73f40ad Reviewed-on: https://gerrit.libreoffice.org/65112 Tested-by: Jenkins Reviewed-by:
-
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Help files: http -> https + some more conservative changes Change-Id: I328505b05838c3f3ce40759096ca77d30c874c57 Reviewed-on: https://gerrit.libreoffice.org/63196 Tested-by: Jenkins Reviewed-by:Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Help files: http -> https + some more conservative changes Change-Id: I6f7e22164c975421f01e9ba974d82f14a34c0d5d Reviewed-on: https://gerrit.libreoffice.org/63219 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Help files: http -> https + some more conservative changes Change-Id: I0c5099f12438158ab6f9e4ac504612e2e2bea009 Reviewed-on: https://gerrit.libreoffice.org/63213 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Help files: Cleanups and Small Improvements Change-Id: Id363e364f66ab66989d853ba0d2edb49abd3f7f4 Reviewed-on: https://gerrit.libreoffice.org/63207 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces in sentences Change-Id: I2286dcecc52a6dafd8075a211161a16d5a637686 Reviewed-on: https://gerrit.libreoffice.org/64933 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces in sentences Change-Id: Ie60e05fb6b82cd91d3141ef567919f680fd84b6c Reviewed-on: https://gerrit.libreoffice.org/64929 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces Change-Id: I3d29383ab3674d2967b41cceeff1d0ef0fafea06 Reviewed-on: https://gerrit.libreoffice.org/64928 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - tdf#121173 correct double spaces in sentences Change-Id: Ia8116e46e75cbf32293f20e0c905ed8707156b95 Reviewed-on: https://gerrit.libreoffice.org/64886 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - tdf#121173 correct double spaces in sentences Change-Id: I46b602d6ca6323d932839b8da5bfef6d4eec2dcc Reviewed-on: https://gerrit.libreoffice.org/64872 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces in sentences Change-Id: I3bbcb7c64473be6ae9ffa165d448ed90a9a67b1d Reviewed-on: https://gerrit.libreoffice.org/64899 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces in sentences Change-Id: Icee0b15ad69fadc6e01a50b7f1c6485675ed42b5 Reviewed-on: https://gerrit.libreoffice.org/64927 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces in sentences Change-Id: Iabedfa85dcb06bea8bfb7b0946ef1feafd0eb1d2 Reviewed-on: https://gerrit.libreoffice.org/64926 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces in sentences Change-Id: Ifc4c6777d2b6b45c2dd08a4c62fa794151ad886d Reviewed-on: https://gerrit.libreoffice.org/64930 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces Change-Id: I9e923e6e67393ed460b7641c5c478c00a2a36e0b Reviewed-on: https://gerrit.libreoffice.org/64888 Tested-by: Jenkins Reviewed-by: -
Sophia Schröder yazdı
* Update helpcontent2 from branch 'master' - Related: tdf#121173 double spaces Change-Id: I6060aa9759a17cbcb5419586a565688c543cb8f4 Reviewed-on: https://gerrit.libreoffice.org/64898 Tested-by: Jenkins Reviewed-by: -
Andrea Gelmini yazdı
* Update helpcontent2 from branch 'master' - Fix typo Change-Id: If125b22f4d77670b82a8951ad72e07d3d7e82364 Reviewed-on: https://gerrit.libreoffice.org/65120 Tested-by: Jenkins Reviewed-by:
-
