Change-Id: I47be43c4ac50ee3938dc09d0206132fa7452017c

instead of a for loop

Change-Id: I3fbd92c5f96970543c2da3843e54a733bf811e72

Change-Id: I57d9a38cbb7672033ff204567bfb2b58093db490

Change-Id: I46307828757ee1142747c14d2942515340083605

Change-Id: I8a826c1b31f99e8d1592f284094ff921ddac74ad

the only caller of these methods is already synchronized

Change-Id: Icea587d71acba1eca2a97ae0138a69fa98063f50

- ... with a custom deleter
- and kill homegrown implementation

Change-Id: I9babf556dc75772f388d23fd05b916abb4bed497

Change-Id: If6b64c92d4f6f786767802cc046ccd96bd8367cb

Change-Id: I8628fd1fecb3e2cf54704f9844ff921862da46e5

Change-Id: Ia58e286760e52191edbe968504e3db0967ce09d3

Change-Id: I7e1fc471ca5930ceaff4b1c6c6ba351ff0594639

Change-Id: I23d75d094c2b2dd8d234b608556a8b2339b7f166

Change-Id: I46d464405d5de6460b10a2965e0c1f011c8142b2

Change-Id: I7c7431edd79cf4527f97c7dc0695d49174b61e2c

Change-Id: I11bb3ab21e3434574578cd7fbe03b0b75158e355

Change-Id: I977c9915414eedead860622b120f00ad811e18e9

Change-Id: I017a4b5ccc28d90e1464e8cbf60cffbc96324963

Change-Id: I1582705ce3ae9cc7bbe33789a1626e8d7d3853cf

Change-Id: I1bd9668a2567390ceceb1742483a9fdabc025db7

Change-Id: Idcf0ef3670209c6b68e4afac8efcd8ab463e4774

- abstract base class reduces boilerplate
- Pimpl is pointless here, except for SolarMutex, which is handled by
  overriding release

Change-Id: Ia08dc26104f70411a783ade681be3bcebb3b9acb

Change-Id: I23d9beabe38587eca2b0620b5c431835ce70d37b

Change-Id: I5fdf0bdd8609aa07c49b155cc75cade8bdb2c292

Change-Id: I20b993f1775b2db9865487ed84c60e07fd0a4ced

- abstract base class reduces boilerplate
- Pimpl is pointless here, except for SolarMutex, which is handled by
  overriding release

Change-Id: I55df9b20c9b0a78412535f2cca37e04ddaccb5cf

Change-Id: Iabcb98f664739aaae0d92b4f2a6b0e50bdcbc09b

- abstract base class reduces boilerplate
- Pimpl is pointless here, except for SolarMutex, which is handled by
  overriding release

Change-Id: I191dc0fecd25937f41fd724355e88c04da89db61

Change-Id: I27813e34936bf9525e2931869ec33311fb5f59e2

Change-Id: I9db71fb4be78b5d6fda64217287efea6abd7d771

Change-Id: Ic18b44942f4fe02083c0e8167e8c8d4205e66abf

This reverts commit dfedebd1.

This reverts commit 9857c639.

Change-Id: Id47e982eb346c092991f07964c0146daefccb031
(cherry picked from commit 64dc505c)

Change-Id: Iee0e9ef3a623706c33f84c34c1fbbf5b173f7f5d

Change-Id: I2011b491012dfd623ece9fd24a265107ac690cba

Change-Id: I85fa46de5b864369158d047fd3f7c683f10c822f

Change-Id: I76cf487c66e048b5e9d0877a1b690cd066b73528

I guess the intention is to catch all "own" formats, and Base is just
missing from that list.

Change-Id: I064068c2ab17db9109a9a4681775ba8d18292292

If "EmbeddedDatabase" in test.odt refers test.ods in the same directory,
that will be "../../test.ods". Now if we save test.odt in a different
directory, we need to re-save the embedded data source definition,
otherwise the relative reference will resolve to a non-existing path.

Relative references are normally not supported for embedded objects, so
this is not a problem, but for data sources they are, that's why they
are a special case here.

Change-Id: Id138b9cdc38f2de589d9b80c66f1a61174699770

Change-Id: Ifc6471f58793cde057f354c4c6a549c073b7d34b

Modify createTestEnvironment so that it throws Exception. This
is appropriate for unit testing.
The wrapping adds no value and the calling method already has
a catch(Exception) to handle anything.

Change-Id: I430a414f63d2cbfc3b65ecfde0285509265e5192