Insert constructor everywhere, except a couple places that apparently
want to compare GetMapUnit().

Change-Id: I1910deb60562e5e949203435e827057f70a3f988

Change-Id: I3d4f15cd4929b553673f1a1d8950b6c9082a0cdc

Change-Id: Idc4668cba7412d0b4a3e486a8629c7f95a701091

Change-Id: Ibd26816cb00b3b8b2514aca536906b689c8cbd5e

Change-Id: Ic2eadf1942927efb6a6b209db591e869b61362f4

Change-Id: I16726fbc8bf4f67fe1018d54437d59b715738bfe

Change-Id: I4dc2d5a5fbbded5f4c7a1417c150fe6b1a73a69d

... and LocaleData2 service, which is necessary with new-style
services because optional interface at published service is not
possible.

Change-Id: I77703243a961b5385eaea146e4c9c42d5f30e1ad

Change-Id: I19bb1d566bd80f859810b4023d965c8fd80b98f2

...see a2d814ac
"loplugin:implicitboolconversion" and 24eeb4d2
"loplugin:implicitboolconversion" for things previously only found in C++17.  As
expected, no further occurrences were found.

Change-Id: Id0ab621b82dc3c40c8b5801413fceb73ade1408a

Change-Id: I8f984c3b3833437f6b4d65ab99da608a6868ff74

Change-Id: I899df8d0609d6a3c55d130cffc5b1b23eebece13

Change-Id: I8848784cd867714019f90bb7fc57ca7289e51f81
Reviewed-on: https://gerrit.libreoffice.org/43873Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

There can be a dual mode flag set in the EMF+ data. If set,
we should process either EMF or EMF+ data, because the contained
information should be equal (says the documentation).
The more advanced EMF+ renderer is chosen here.

The flag is read in the EMFPlusReader and blocks the reading of other
EMF records than HEADER, EOF and COMMENT.

Thanks to Chris, for pointing out the dual mode!

Change-Id: I8522930cebbb9e9ecc732397cbb3deea9e8c9127
Reviewed-on: https://gerrit.libreoffice.org/43122Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: I620b0278273e285100fe44d252389e6393a2022c
Reviewed-on: https://gerrit.libreoffice.org/43877Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ica00209bc6679edaa0c83fc7d31bd5d4653b5e96
Reviewed-on: https://gerrit.libreoffice.org/43879Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(or does the comment need to go exactly at the line before the one containing
the "return" token?)

Change-Id: I5f92e59ee05d0b5ba3d6bda775e6ca02f185dbe8

Added Copy/Move/Delete since this is the only way to access
the local storage.

Change-Id: I9b054a4f23d32d5220ae500a37b52cb7e7a8587c

Added button in Document window, to signal if working local or in iCloud

Change-Id: Ib33b67c95dfad466664e2289390ea577ba5e3391

(i.e., using constructor="..." in the .component file) that implement multiple
services, but are not implemented as single-instance objects (i.e., always
return different objects from that constructor function).  In that case, the
"factory" would be the object itself, and would thus be different for different
instantiations of that implementation.  erAck ran into such a case with new code
he's writing.

Change-Id: Ib134a4c6d1400b43a7df3cf6a115f8206fb80c93

Change-Id: I8404ebed8ba84ee83528310ee63f796356674553
Reviewed-on: https://gerrit.libreoffice.org/43830Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: I1657b84d613b28d5762057954069d2a2fe2e3ab2
Reviewed-on: https://gerrit.libreoffice.org/43103Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>

Change-Id: I8ffdf86e98e261b337cfa81b1be0cb64539c9a9c
Reviewed-on: https://gerrit.libreoffice.org/43871Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I665f6c2f94b6c03d6fb5136fff3054ad6f0ca962

Change-Id: Ibd89fd25ca8dd43aa5f8fa4ba8ab15eb6eb042cc
Reviewed-on: https://gerrit.libreoffice.org/43220Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Blueprint_Plans, Portfolio, Progress added, Vintage updated, LushGreen, Pencil deleted

Change-Id: I9b11fc63378486b70f264cf715e3f3ba177e165f
Reviewed-on: https://gerrit.libreoffice.org/43887Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>

Introduce 21 database On... events returning the invoked scripts
Read-only

Change-Id: Iad7d6b045be90efb32da3ffb1c19753b58b1753d
Reviewed-on: https://gerrit.libreoffice.org/43616Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I05d2cdefb7faf489ec29ba28dc5e3c28d08b9780
Reviewed-on: https://gerrit.libreoffice.org/43863Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Although 2013 commit 60ec497e
added support for the other tcMar items, it omitted _start and
_end (perhaps because they caused unit test failures).
The document in bug 78508 proves that these are needed.

Testing whether the cell spacing matches the default table
spacing should occur before adjusting for MSO compatibility.
This fixes the three unit tests that mysteriously failed
when adding _start/_end support.

Unfortunately, these two fixes could not be committed
separately - the unit test fails unless both parts
are included. I couldn't figure out why.

Change-Id: I9507da48b629b9618c5ee790bf0088ce82fc5692
Reviewed-on: https://gerrit.libreoffice.org/43432Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ib1284b819d4af2e8055698be4160bbb41acba851
Reviewed-on: https://gerrit.libreoffice.org/43866Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: If92869e19c413e11f1f299a97f96b9637aaba65d
Reviewed-on: https://gerrit.libreoffice.org/43864Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I13df4e184a826682f34a1d9e974b601397ba4a3d
Reviewed-on: https://gerrit.libreoffice.org/43865Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

81892b20 "loplugin:unnecessaryparen when
compiling as C++17, so the ParenExpr is no longer hidden behind
ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me
the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in
loplugin:unnecessaryparen.  However, that would still not look through implicit
CXXConstructExpr, so would still not have found the occurrences in
81892b20 when compiling in pre-C++17 mode.
Therefore, let ignoreAllImplicit also look through CXXConstructExpr.  (I am not
entirely sure in which situations non-implicit CXXConstructExpr---that should
thus not be ignored---would occur, but assume they would be underneath something
like a CXXFunctionalCastExpr, which is not ignored.)

Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843

Change-Id: I16fc145a4d6378b1ca47cdd24caac9a8da913715
Reviewed-on: https://gerrit.libreoffice.org/43854Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

like as fixed at 8a5b178e.
This change affects e.g. the string of the tooltip appearing
when changing document margin in Writer by dragging ruler,
after choosing pica as the unit in context menu.

Change-Id: I55d2cea8b30016e2578c6a112f54e26d62741b44
Reviewed-on: https://gerrit.libreoffice.org/43819Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: I7b446f9eed6cf00c605d1cdb8a84273d0ea6628e

The bugdoc has an (outer) table containing a single cell, which has an
(inner) table with 12 cells, all content is inside sections, one section
/ cell.

This relatively simple setup can already hit the loop control in
lcl_RecalcRow(), as the SwLayNotify dtor always does invalidation in an
async way, so the loop control's counter is incremented after each and
every table cell.

Instead of increasing the max tolerance in lcl_RecalcRow() (one can
easily construct a document where the bug is still there even if the max
is set to 100 instead of the current 10 iterations), just calculate the
lower synchronously.

Change-Id: Ifbffe13e5f2f237e1578bdd3e17d4d8b7c34806d
Reviewed-on: https://gerrit.libreoffice.org/43848Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

+ replace list by vector for maFontSubstList

Change-Id: I4d5668611212358c759fa5cf26f5341311551298
Reviewed-on: https://gerrit.libreoffice.org/43855Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2638a8440601264ff00221ead28a71c891abae16
Reviewed-on: https://gerrit.libreoffice.org/43860Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>