- 31 May, 2018 5 kayıt (commit)
-
-
Tor Lillqvist yazdı
Generate Application.DocumentChange and Application.Quit events. SfxHintId::DocChanged seems to correspond nicely enough to Application.DocumentChange. It is generated a bit eagerly, but as its documentation is fairly vague and no specific detailed information is passed in parameters anyway, it probably doesn't hurt if a client gets it a bit more often with LO than with some other product. Can now remove the FIXME-marked Quit event things in SwVbaApplication. Now need oovbaapi in many makefiles for them to compile. Change-Id: I4d0c5b93b584f198bcc854002eec7aaba7909ecc Reviewed-on: https://gerrit.libreoffice.org/55106Reviewed-by:
Tor Lillqvist <tml@collabora.com> Tested-by:
-
László Németh yazdı
– new Bulgarian and Icelandic language support – fixes of language data based on libreoffice-l10n's patches and feedback (see ChangeLog in the external package for details) Change-Id: I98598747c8b4e8e7fba380998c6ebbc1f63fef2e Reviewed-on: https://gerrit.libreoffice.org/54936Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
László Németh <nemeth@numbertext.org>
-
Noel Grandin yazdı
part of making mask and alpha internal details of Bitmap/BitmapEx Change-Id: I87ca24af18a29f5eb8a5761c5d95ae2806d97e77 Reviewed-on: https://gerrit.libreoffice.org/55078Reviewed-by:
Michael Meeks <michael.meeks@collabora.com> Tested-by:
-
Tor Lillqvist yazdı
Instead, be generic, check whether the objects implements ooo::vba::XConnectable. That's what we do in the IID_IConnectionPointContainer case, too. Change-Id: Ib499aa011775f79a2accaef64e19738bdb7ed143 Reviewed-on: https://gerrit.libreoffice.org/55109Tested-by:
-
Tor Lillqvist yazdı
Change-Id: I0243ee3e492d8445ebcc059293dcc4cb3c5c889b Reviewed-on: https://gerrit.libreoffice.org/55105Tested-by:
-
- 30 May, 2018 35 kayıt (commit)
-
-
Tor Lillqvist yazdı
Change-Id: I594258303469a1f5b9490b824fdc304a5a780784
-
Olivier Hallot yazdı
Project: help fc875c6ab3763e36008fd872b3670d953f18ba9d Fix default cases in switches Change-Id: I40f6c8e5a6fd0a0ff1d3e6205de449f14598212b Reviewed-on: https://gerrit.libreoffice.org/55107Tested-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
Olivier Hallot yazdı
Project: help a0b4db5f17e58f656d527b807e09ed02b04c2827 tdf#58134 Some Options settings cannot be reset Add warnings in help pages when some options cannot be reset. This patch does not close the bug, which in some cases is a bug in the dialog controller. Change-Id: Ie6d0019a9c6611c2ad8784f593ceefa5748bf56b Reviewed-on: https://gerrit.libreoffice.org/55103Tested-by:
-
Tor Lillqvist yazdı
I think. Anyway, if it turns out we do want one per client, easy to revert this. (And it isn't very common to have several Automation clients connected at the same time anyway, surely.) There will still additionally be one SwVbaGlobals (and SwVbaApplication) per open document with a StarBasic interpreter, though. I think. Change-Id: I5f7dbfd65b5decb152c1192298bc85dcf6027d64 Reviewed-on: https://gerrit.libreoffice.org/55094Reviewed-by:
-
Tor Lillqvist yazdı
XConnectable interfaces need a second IID, for the interface "itself", not the coclass. (I am sure there is some catchy short term for that, I just can't find it right now.) Allow several simultaneous sinks for a SwVbaApplication. Not sure in what case such would be needed, but you never know about 3rd-party client code, and it's trivial to handle anyway, so why not. Lots of FIXMEs still. There is likely also a lot of leaks. But at least an event handler in a simple VBScript script does get invoked. Note that the changed and added code in extensions/source/ole is totally unaware of what outgoing ("event") interfaces Writer or Calc implements, it is all handled generically through the UNO interfaces I added recently. One particular thing that needs doing is to actually make Writer (and Calc) raise this kind of events when necessary. The current code to invoke events handlers in StarBasic (including StarBasic code running in "VBA" compaibility) is very much tied to having StarBasic running (not surprisingly), which of course is not at all the case when it is an Automation client that is manipulating a Writer or Calc instance and wants events. There is demonstration-only code in SwVbaApplication::Documents() to raise the "Quit" event. (I would have put that in the SwVbaApplication destructor but that doesn't seem to get called.) That should of course go away once we invoke other relevant events in appropriate places. And the "Quit" event needs to be invoked when the application is quitting. The whole callback mechanism with IConnectionPoint etc is still partly a mystery to me. It is entirely possible that even if this now works for a simple VBScript client, it won't work for (for instance) a VB6 client that might exercise the APIs of the COM interfaces we provide in a different way. Add XSinkCaller, for something that perhaps calls one or several XSinks. Change-Id: Ica03344010e374542f4aceff5ec032c78579f937 Reviewed-on: https://gerrit.libreoffice.org/55093Tested-by: -
Noel Grandin yazdı
part of the process of making Bitmap's internals be private to vcl Change-Id: I3784c14be1572d4df64b9cbdb5adcebdd1b274fd Reviewed-on: https://gerrit.libreoffice.org/55050Tested-by:
-
Noel Grandin yazdı
commit 1f6af5c4 "vcl: move Bitmap::MakeMonochrome() to BitmapMonochromeFilter" seems to have dropped a line of code which means the filtering doesn't actually have an effect. Change-Id: If46c15bd9ab9d4e3911bdb9baf3091889b1f634d Reviewed-on: https://gerrit.libreoffice.org/55071Tested-by:
-
Caolán McNamara yazdı
Change-Id: I935f0b1a28b483fad70caf7af96742dee74916ad Reviewed-on: https://gerrit.libreoffice.org/55087Tested-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Miklos Vajna yazdı
Embedded native data (what we don't parse just carry on) and real OLE2 embedding already worked, this adds the case where the actual content is ODF, just inside OLE2. The DOC import/export had support for handleing ODF content inside OLE2, so reuse that code: add new functions to SvxMSDffManager for import purposes and reuse SvxMSExportOLEObjects for export purposes. Change-Id: I0acf65d4bf29af896b8f1dd625e8672050aae350 Reviewed-on: https://gerrit.libreoffice.org/55088Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> Tested-by:
-
Miklos Vajna yazdı
--enable-ext-mariadb-connector is not the default, this fixes the build after using that switch up to the mariadb-connector-c module. mysql-connector-cpp is still broken, VS 2015 gives internal compiler error there for the used boost pieces... Change-Id: I1845cde03d5166594aac67c23e61186920ab3785 Reviewed-on: https://gerrit.libreoffice.org/55055Reviewed-by:
-
Tor Lillqvist yazdı
Some customer VB6 code calls it. It doesn't seem to do anything interesting in Word either, so I don't feel that bad for it not doing anything in Writer. Change-Id: I81162fcdd0caa22b19760f8cb40266f7f571d8ce Reviewed-on: https://gerrit.libreoffice.org/55069Tested-by:
-
Tor Lillqvist yazdı
It is just supposed to return 1, after all. And we do try to implement the GetTypeInfo(). (Sure, the testing I am doing that turned out to require GetTypeInfo() to work then immediately after this runs into much harder problems to solve, but that is another issue.) Change-Id: If7e0707d7b404d6a46b24e642c2146b3bfff03f0 Reviewed-on: https://gerrit.libreoffice.org/55070Reviewed-by:
-
Xisco Fauli yazdı
Change-Id: I41a5be165af21c197c4f9d4f40f0ff27c80a7168 Reviewed-on: https://gerrit.libreoffice.org/55061Reviewed-by:
Sophia Schröder <sophia.schroeder@libreoffice.org> Tested-by:
-
Tor Lillqvist yazdı
Implementation is just a dummy, though. At first I thought that it would work to get the XModel of the "current" document (as returned by getCurrentDocument()), and then get the XFrame of that, and then use the XFrame's getName() and setName(). But, it seems that getCurrentDocument() and what it calls is tightly coupled to StarBasic, and it doesn't do anything sane in the case of Automation clients. Change-Id: I74ded5114ecce06e72862f69d0c06d963e55fd75 Reviewed-on: https://gerrit.libreoffice.org/55064Tested-by:
-
Kshitij Pathania yazdı
flipping is fixed. Labelcolor not gets updated immediately but when statechanged function triggers via executemethod things workwell.(like it triggers on changing mode of notebookbar) Change-Id: I755fb4ff434d7971112d2f0beb44ca09f4a7e0f1 Reviewed-on: https://gerrit.libreoffice.org/54301Reviewed-by:
Szymon Kłos <szymon.klos@collabora.com> Tested-by:
-
Eike Rathke yazdı
Change-Id: Ice57b81106d35f5b217f0680824d1acf62ff9098
-
Tor Lillqvist yazdı
Change-Id: I5bf56b6216835870b4beefd588f070a127835514 Reviewed-on: https://gerrit.libreoffice.org/55068Reviewed-by:
-
Mark Hung yazdı
Change-Id: I8647c6e820b4bac795e87d538eba822fac7ddbe7 Reviewed-on: https://gerrit.libreoffice.org/54644Tested-by:
Mark Hung <marklh9@gmail.com>
-
Mark Hung yazdı
Like what has been done with left distance to border, so that the ruler handle reflects the setting. Change-Id: I4ed920280aafc537ba3068f0f666778c2d723b6b Reviewed-on: https://gerrit.libreoffice.org/54618Tested-by:
-
Mark Hung yazdı
SvxProtectItems were used to protect size and position of the rulers in Impress/Draw but weren't really activated because they were missing in the sdi of the view shell. See also: DrawViewShell::GetRulerState() in drviews3.cxx. Change-Id: I576932fb45acd996a3b6f3045dcbc131b7316ece Reviewed-on: https://gerrit.libreoffice.org/54616Tested-by:
-
Mark Hung yazdı
Use the cell boundary to decide correct SvxLRSpaceItem values. Change-Id: I1906eaf34a7ff5f852b729114371ddb5387692d3 Reviewed-on: https://gerrit.libreoffice.org/54615Tested-by:
-
Mark Hung yazdı
Change-Id: I7ddce601bd7204e5696b601c6f8cd16619017aa2 Reviewed-on: https://gerrit.libreoffice.org/54881Tested-by:
-
Takeshi Abe yazdı
Change-Id: Ifb1429eb3ad6d1093a7b5126ea3d15c4509cf8cc Reviewed-on: https://gerrit.libreoffice.org/54981Tested-by:
Eike Rathke <erack@redhat.com>
-
Stephan Bergmann yazdı
Change-Id: I6550af7949e4838d9f23310fe5ab49fb6b466eaf Reviewed-on: https://gerrit.libreoffice.org/55053Tested-by:
Stephan Bergmann <sbergman@redhat.com>
-
Tor Lillqvist yazdı
Change-Id: Iab17340f57cf8b116d2f058661dabd3a95fb61d2
-
Tor Lillqvist yazdı
For Automation clients. Provided in extensions/source/ole/servprov.cxx for an instance of ooo.vba.word.Application. Change-Id: I277f461bf6206f3516b14fabe8b27dc4c06018b5 Reviewed-on: https://gerrit.libreoffice.org/55052Reviewed-by:
-
Samuel Mehrbrodt yazdı
Change-Id: I977eae208bd12886d25679d4c75308d51245766a Reviewed-on: https://gerrit.libreoffice.org/55057Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by:
-
Stephan Bergmann yazdı
Change-Id: I48d78fb86c2604040b3d0c2d207aae410faf4870
-
Samuel Mehrbrodt yazdı
Change-Id: I7684d4747c4977103fcc3dca62f5d1c28a0836bf Reviewed-on: https://gerrit.libreoffice.org/55056Tested-by:
-
Tor Lillqvist yazdı
Instead, never participate in the macOS system full-screen mode. There is just too much complexity involved, and the way LibreOffice works really isn't prepared for the concept of windows having the option from a system point of view to being full-screenable or not. This means that the green bubble in window title bars changes from being a (system) full-screen toggle to being a maximize/restore toggle. Sure, the "maximize" concept also probably can be confused with LibreOffice's own full-screen concept. For instance, the Start Centre window is not expecting to be made full-screen. Still, when you from the Start Centre open a Writer document, it is the *same* window that is re-used as the Writer window, and then suddenly should be prepared to handle going full-screen. Also, it is up to each separate kind of document window whether it can be made full-screen (from the LibreOffice point of view) or not. Writer windows can, but Impress windows can't, for example. The View>Full Screen menu entry is added separately each case. Maybe I will come back to this mess later, or not. Anybody else is welcome to have a go, too, of course. This reverts commit 4b42fd7e. Change-Id: I6983481cbd30c0e5190c450483b1246006c80632 Reviewed-on: https://gerrit.libreoffice.org/55049Reviewed-by:
-
Tor Lillqvist yazdı
As VS2017 so eloquently puts it, "Warning STL4017: std::wbuffer_convert, std::wstring_convert, and the <codecvt> header (containing std::codecvt_mode, std::codecvt_utf8, std::codecvt_utf16, and std::codecvt_utf8_utf16) are deprecated in C++17. (The std::codecvt class template is NOT deprecated.) The C++ Standard doesn't provide equivalent non-deprecated fu tml_ nctionality; consider using MultiByteToWideChar() and WideCharToMultiByte() from <Windows.h> instead. You can define _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING or _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS to acknowledge that you have received this warning." So VS2017 actually recommends using platform-specific API instead of standard C++ API that is or will be deprecated but has no standard replacement. Insane. Note that it is not enough to define that _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING just right where you are including <codecvt> because "for all of the warning suppression macros, you must define them before any C++ Standard Library header has been included (both <vector> etc. and <cstdlib> etc.)" as mentioned on https://blogs.msdn.microsoft.com/vcblog/2017/12/08/c17-feature-removals-and-deprecations/ So define it in the single file that includes windowsdebugoutput.hxx for now. Change-Id: Iecd9702502ce3b33013d6799c618d6b98d803c3e
-
Tor Lillqvist yazdı
Change-Id: I4354adf5353bdfb0b080b24a5c49e3d22539eb23 Reviewed-on: https://gerrit.libreoffice.org/55051Tested-by:
-
Mike Kaganski yazdı
Seems that the fix is not complete: e.g. https://ci.libreoffice.org/job/gerrit_windows/7272/console This reverts commit b7da22a6. Change-Id: Ib174cdde18765d2efa3446d7116e95d6759a431f Reviewed-on: https://gerrit.libreoffice.org/55054Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Luboš Luňák yazdı
Otherwise there is a race condition when calc uses threading, and lp#390983-2 sometimes crashes. Change-Id: I390928c02b8e7d74bebef2dcc98a5c21cb3a8197 Reviewed-on: https://gerrit.libreoffice.org/54795Reviewed-by:
Luboš Luňák <l.lunak@collabora.com>
-
Eike Rathke yazdı
To insert separators, literal strings between digits and other, the formatter operates backwards on the string obtained from doubleToUString() cleaned of the decimal separator. The number of decimals returned by doubleToUString() may be less than the decimals of the number format as entered by the user, which lead to separators inserted at wrong positions. This wrong behavior was triggered respectively made more obvious by commit 0f6203ed CommitDate: Wed Jan 13 14:47:57 2016 +0100 tdf#96918 display accurate integer double values up to (2^53)-1 which for integer values returns at most 15 decimals ('0' in this case). Before operating on the decimals' part ensure that the number of decimals matches the digits requested, and if shorter append trailing '0' characters for the required amount so the separators (and other strings) are inserted at the correct positions. Change-Id: Ic02652699ea7d6fae3b2b3348f6f7d183319e043 Reviewed-on: https://gerrit.libreoffice.org/55039Reviewed-by:
-
