- 17 Nis, 2019 38 kayıt (commit)
-
-
Stephan Bergmann yazdı
All of those have been broken with recent loplugin:sequentialassign changes (and have been found with a new plugin to be commited). The code in SbUnoClass::Find (basic/source/classes/sbunoobj.cxx) looks suspicious, but has been effectively like that ever since at least c25ec060 "initial import", so just marked it with a TODO comment for now. Change-Id: I0d691cb55ef317cf2b16b0490169de7ec97375cf Reviewed-on: https://gerrit.libreoffice.org/70874 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
Change-Id: I72ac69f9cbea34f69d828f55468fb630ca8290fe Reviewed-on: https://gerrit.libreoffice.org/70885 Tested-by: Jenkins Reviewed-by:
-
Katarina Behrens yazdı
Two use-cases here in kde5backend 1) kde or qt vclplug has already started qt event loop => just use this loop to read KDE settings 2) no qt event loop runs (we're most likely in gtk3_kde5 vclplug) => start a new event loop, read the settings and stop it In case 2) letting qt event loop run means subsequently all UI ops need to happen in main thread. This is problematic to enforce in non-qt-based vclplugs In both cases, cache those settings for future use - the assumption is, most of them are static during a session anyway. Change-Id: Ifa203f4cdb9a753db808f945762fb131ee83393c Reviewed-on: https://gerrit.libreoffice.org/70808 Tested-by: Jenkins Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Michael Stahl yazdı
Change-Id: I3fe30de8140dce3d81cdfae7d41e0bd465b1d5f4 Reviewed-on: https://gerrit.libreoffice.org/70879 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
Stephan Bergmann yazdı
mbCurVisible is immediately read in ImplPrepForDraw, which inits some more members but not mnStyle which is then read in ImplCursorInvert. Regression introduced with b9c10ee9 "weld ClassificationDialog", found when valgrind'ing UITest_classification. Change-Id: I986af0531e250953b8e45c914997b31c53a9ba91 Reviewed-on: https://gerrit.libreoffice.org/70876 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
...which avoids a false positive from an upcoming loplugin that finds suspicious uses of variables during their own initialization (as happened with xReturn in getProcessServiceFactory). Change-Id: I40e90e2e74cde84a3425b014d87584f4a56c0e22 Reviewed-on: https://gerrit.libreoffice.org/70877 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Commit 3e009203 (tdf#112318 sd opengl: fix lack of initial animation, 2019-04-05) enabled processing of idle events between two updates of the slideshow to help OpenGL, which uncovered a problem with media shapes. On one hand, slideshow::internal::ViewMediaShape::implInitializePlayerWindow() calls EnablePaint(false) on the media window. OTOH, vcl::Window::ImplCallPaint() handles mbPaintDisabled by invalidating the relevant area of the window, which causes a paint<->invalidate loop. Fix the problem by nominally still enabling paints on the media window: nothing will change in practice (since the actual media overlay will be on top of it), but this way the loop goes away. mbPaintDisabled is handled like this since the initial import, the media window flag was added much later, so it makes more sense to adapt the later. Change-Id: Ib89b68d93aa9d09dbcad33eb6e75a8a25ef1b752 Reviewed-on: https://gerrit.libreoffice.org/70869Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Samuel Mehrbrodt yazdı
Follow-up fix for 6f43902b Also remove calling to super class (doesn't work and those methods return void anyway) Change-Id: I1aa927e373e6d19e4060daba1f34ef72428ead59 Reviewed-on: https://gerrit.libreoffice.org/70878Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by:
-
Stephan Bergmann yazdı
This has been broken with 48314f25 "improve function-local statics in basic..cui" (and has been found with a new plugin to be commited). Change-Id: I518360e3273af9db4a8560a89bc8a789410c8033 Reviewed-on: https://gerrit.libreoffice.org/70875 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
regression from commit 7282014e Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I5ecc52dd709455718a2f3e245b1d41e0c30e7f80 Reviewed-on: https://gerrit.libreoffice.org/70862Reviewed-by:Julien Nabet <serval2412@yahoo.fr> Tested-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Henry Castro yazdı
Change-Id: I41a9ff0d281d9032ddaafbbcb55352254a809efe Reviewed-on: https://gerrit.libreoffice.org/70824 Tested-by: Jenkins Reviewed-by:
Henry Castro <hcastro@collabora.com>
-
Balazs Varga yazdı
Also fix tdf#123833 and tdf#123837. In combined charts, now axis types are exported in the right order (catAx[1], valAx[1], catAx[2], valAx[2]). The Y axes are exported correctly with the correct axIDs of the chart types: the first one with the primary axId, the second one with the secondary axId. X category axis crosses the Y axis at the right place, all data series are attached to the right Y axis, and the Y major grid doesn't disappear. Note: don't export the CrossoverPosition/CrossoverValue, if the axis is deleted and invisible, because MSO will show the secondary X axis, even if the axis doesn't exist. The problem was the unnecessary export of the axis with the default css::chart::ChartAxisPosition_END CrossoverPosition value. Change-Id: Id429e654ff0ba45b5f9db877b7c4dd6e65433408 Reviewed-on: https://gerrit.libreoffice.org/70814Reviewed-by:
László Németh <nemeth@numbertext.org> Tested-by:
-
Michael Meeks yazdı
NB. outside of the often contended SolarMutexGuard. Change-Id: Ieb651e2ed4349e692010a7588721f461af7d2b5b Reviewed-on: https://gerrit.libreoffice.org/70848 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com>
-
Mike Kaganski yazdı
... otherwise Excel would reset data formatting e.g. from currency to plain numbers upon refresh. Excel relies on per-field format setting in pivot tables, while Calc takes fields formatting from source. Change-Id: Ia8cdf3f8fcd23720e3daaf989152c170057b339c Reviewed-on: https://gerrit.libreoffice.org/70860Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by:
-
Mike Kaganski yazdı
... since on some boxes vswhere returns no results when VS 2017 is present Change-Id: Ieabfbbc30195008ef93147d7d390eee58fa2b7f9 Reviewed-on: https://gerrit.libreoffice.org/70861Reviewed-by:
-
Michael Weghorn yazdı
In some observed cases, 100 ms were not enough for the separate 'lo_kde5filepicker' process to terminate properly, in particular on slow or busy hardware. Drop the timeout here and just wait for the process to finish to avoid killing it unnecessarily, which could e.g. lead to file dialog settings/state not properly being saved by the native KDE Plasma QFileDialog (plasma-integration, e.g. in 'KDEPlatformFileDialogHelper::saveSize'), so that the last used mode or size would not be remembered. The assumption is that the separate fpicker process should now properly finish in all cases, in particular since commit 93815c2b. Should that assumption not hold, let's rather fix the underlying issues than increasing the timeout here. Change-Id: I0a58c1425940fbfaecb5012a24fd9a0222cbaccb Reviewed-on: https://gerrit.libreoffice.org/70834 Tested-by: Jenkins Reviewed-by:
Michael Weghorn <m.weghorn@posteo.de>
-
Muhammet Kara yazdı
Users need an in-process copy of pdf to share with peers and discuss the redacted areas Change-Id: I68c16c6f09690a9d5cd2df191963107029e5ed88 Reviewed-on: https://gerrit.libreoffice.org/70863Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
-
Michael Stahl yazdı
... that happens when you accept a delete redline (or reject an insert redline) with such end pos. The problem is that first a DeleteRange() will move the anchor position onto the table node (because check in SwUndoSaveContent::DelContentIndex() is surprisingly asymmetric and so the fly not deleted by the previous bugfix), then DelFullPara() creates a second SwUndoDelete then deleting the fly crashes because its anchors was moved. The code in lcl_AcceptRedline() / lcl_RejectRedline() doesn't make much sense (but always was like this), if we just call DeleteFullPara() once instead, the problem is avoided, and we don't even have to worry about why DelContentIndex() is so asymmetric (is "selection direction" really a meaningful concept?). Reportedly this started to crash with commit e07feb94, previously it was just wrong. Change-Id: Ib3d4b31e0255a6f4e7b49b40f204dec168ea3006 Reviewed-on: https://gerrit.libreoffice.org/70836 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: Ic29460926173ed37c60d8626872dda15cc1f76ec Reviewed-on: https://gerrit.libreoffice.org/70851Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I678ddb576f6cfeadf2418781675023def545c2c8 Reviewed-on: https://gerrit.libreoffice.org/70850 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I6307b00dfc1dad4cc0b22bfd6d142d54a1c96c92 Reviewed-on: https://gerrit.libreoffice.org/70852 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: If9f6fa6e072a95381aaf4a539e2081733a0248ec Reviewed-on: https://gerrit.libreoffice.org/70828 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
which is closer to how it was before welding Change-Id: If43e2109d9c511a3e8f191b7704dc42aa06b7353 Reviewed-on: https://gerrit.libreoffice.org/70858 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
and rename FilterOptionsMgr back to ScFilterOptionsMgr Change-Id: Ieada679e0c96dfdf9d62732550302f3b5f2a444d Reviewed-on: https://gerrit.libreoffice.org/70833 Tested-by: Jenkins Reviewed-by:
-
Tomoyuki Kubota yazdı
calloc,free,clock,time,ceil,frexp,fabs,ldex,access,getpid for C4013 __FUNCTION__ for C4117 Change-Id: I71e1894893f3aa9cf0e5ac699e44586144a14743 Reviewed-on: https://gerrit.libreoffice.org/70423 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I0eb35ce0c19c0b235f61216c8d1894e668c8b33d Reviewed-on: https://gerrit.libreoffice.org/70853 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I633047306372ce285bf3531c609f364addf927c8 Reviewed-on: https://gerrit.libreoffice.org/70854Reviewed-by:
-
Gabor Kelemen yazdı
and Ctrl-Shift-N should go to the Templates dialog Actually, since the latter is a global keybinding this - and the 4 other uno:NewDoc - entry is redundant a bit Change-Id: I3c36b0b98f04033c8214e9c3c23f8cf5e99451d6 Reviewed-on: https://gerrit.libreoffice.org/70857 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
tundet yazdı
Hyperlink inserted to chart lost after export. chart_hyperlink.xlsx: Test file from Excel 2016. Change-Id: Ideca10e544193ba43d7c2ef6e9dd8e393383edc1 Reviewed-on: https://gerrit.libreoffice.org/70648 Tested-by: Jenkins Reviewed-by:
-
Noel Grandin yazdı
Change-Id: I9287d266cd5267e194f2539f95a7efff3824e9b1 Reviewed-on: https://gerrit.libreoffice.org/70715 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
IsPaintTransparent() is preventing to paint the background but not sure why this is needed. removing this condition doesn't seem to have any ill effects. Change-Id: I5ac54e208e4f1c9941beb4012aa44182d21dbed9 Reviewed-on: https://gerrit.libreoffice.org/70855 Tested-by: Jenkins Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com>
-
Miklos Vajna yazdı
In most cases these were public without a good reason, in other cases setter / getters are added. Change-Id: Id6c1032189db1bba211344162e737dabf7ff3f07 Reviewed-on: https://gerrit.libreoffice.org/70842 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
Change-Id: I53be5303404cf60609314630b841ebbf2af117de Reviewed-on: https://gerrit.libreoffice.org/70818 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Iecf88c5720f2407654d85a1a70a04faed43fd690 Reviewed-on: https://gerrit.libreoffice.org/70832 Tested-by: Jenkins Reviewed-by:
-
Samuel Mehrbrodt yazdı
When user registers a mouse listener to a window, he expects to receive mouse events when a user clicks in somewhere in that window, even if it's technically a widget inside that window Change-Id: Ie6d3f8b140e4a5b516051014282b43775ecec59e Reviewed-on: https://gerrit.libreoffice.org/70512Reviewed-by:
-
Mike Kaganski yazdı
... use GetModuleFileNameW() for that. We call SetDllDirectoryW and SetSearchPathMode to improve security of the process, and exclude some paths (including current directory) from search when using API that looks for binaries whose names are not fully qualified. So the sequence is this: 1. Program is started using relative executable path like "instdir\program\soffice"; 2. sal_detail_initialize is called, which calls the two mentioned hardening functions; 3. sal_detail_initialize calls osl_setCommandArgs, which in turn calls osl_createCommandArgs_Impl; 4. The latter uses SearchPathW with empty path and first program arg "instdir\program\soffice" to find fully qualified program path. That now naturally fails, because current path is not searched. But to find the process name, we need no search: we can simply use GetModuleFileNameW() with NULL passed as module handle. Let's use that. Note that we can't use _wpgmptr/_get_wpgmptr, because we don't use wide entry point like wmain. Change-Id: I7a0013a0505f7bdd38164b09b045bfade9686664 Reviewed-on: https://gerrit.libreoffice.org/70844Reviewed-by:
-
Jim Raykowski yazdı
Navigate by Control only works in design mode so turn design mode on when Navigate by Previous or Next Control button is pressed. Change-Id: I26a565758672c8dd1ec8bf979b199e8b240424e3 Reviewed-on: https://gerrit.libreoffice.org/70644 Tested-by: Jenkins Reviewed-by:
Jim Raykowski <raykowj@gmail.com>
-
Tomaž Vajngerl yazdı
First plan was to move it to bitmapaccess.hxx, but that would add dependency for the backends, which only need BitmapAccessMode. Change-Id: Id8ed980207da5b0c7d4de48d82446b33f6b76b13 Reviewed-on: https://gerrit.libreoffice.org/70827 Tested-by: Jenkins Reviewed-by:
-
- 16 Nis, 2019 2 kayıt (commit)
-
-
Tomaž Vajngerl yazdı
Change-Id: Ibd28b8fa92e98ebeb482a9081fbeae24defe4adb Reviewed-on: https://gerrit.libreoffice.org/70826 Tested-by: Jenkins Reviewed-by:
-
Jens Carl yazdı
Move XTextField Java tests to C++ for ScEditFieldObj_Header (formerly ScHeaderFieldObj). Change-Id: I36b723945d9306720846b4a4e2d3eaddb1a1c063 Reviewed-on: https://gerrit.libreoffice.org/70841 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
