Also add an assert to ErrorBox to ensure the mutex is acquired

Change-Id: I3e426024dad6ddfc5cffc7861b0cba9e8989c018
Reviewed-on: https://gerrit.libreoffice.org/47388Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

on any of our platforms

Change-Id: Id453ada9c79c76f2736f568436e386b05bcd08c5
Reviewed-on: https://gerrit.libreoffice.org/47468Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

first attempt was in commit e75abe6e,
reverted in 7accac09

Change-Id: I460e9ab5fcca3a99656e5d8434fa04c2387d7183
Reviewed-on: https://gerrit.libreoffice.org/47463Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  abf8c3ef55e98aeb9011020e8a217a0bd8de17ff

Various fixes on Impress General options page

- ahelp and bookmark fixes
- Templates window on startup instead of wizard
- Preseter Console option
- tdf#114310 Add spacing... option renamed

Change-Id: I930402fc1a8efa74ec747b06b2c720a963d6cc38
Reviewed-on: https://gerrit.libreoffice.org/47425Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Patch is thanks to Jon N.

Change-Id: Idba9ec9b32b144523f0e7da5f7273f6af9fdfd31

Extended the bridge to include original LibreOfficeKit.h
as well as Kit pointer (set in init call)

Change-Id: I5e96f2706ac4d1ee897b977d3322bdc1b91f1a0b

Change-Id: I972ff9e0dbb73f6a38c886e1acd03cc4d62da2ec
Reviewed-on: https://gerrit.libreoffice.org/47251Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: I7136f5c0bc884a2f9ea945b4e0bc093a5ef2d8df
Reviewed-on: https://gerrit.libreoffice.org/47481Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I5376616ed1b1a1087dd8bac6830d31212252e4bd
Reviewed-on: https://gerrit.libreoffice.org/47459Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

In particular, the STR_SVT_MIMETYPE defines are dead
since
    commit 1b694dad
    Date:   Thu Aug 24 22:14:27 2017 +0200
    loplugin:unusedmethods

Change-Id: I641ec0a14efedc55c9d6a4de4a28784c273602e9
Reviewed-on: https://gerrit.libreoffice.org/47464Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id3f223d8d2220fb7d7bb2aaa50bb1a8e29bc0f70
Reviewed-on: https://gerrit.libreoffice.org/47462Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

it is always nullptr

Change-Id: I0eae17a58423cceda08867f4dc5945a3e5553d5e
Reviewed-on: https://gerrit.libreoffice.org/47461Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  189c97fd18cdcb99ad4b4d77a8ae97f8ce41f3b9

Fix typo

Change-Id: I7a9fab7c50139bcd5f5b5999b4e61e89f2e8e646
Reviewed-on: https://gerrit.libreoffice.org/47298Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  9e6681b78b9578eb739c3577218d6ce9141e7091

Fix typos

Change-Id: I2a98c7a079c69ac32b382d6c320dde456be98cf1
Reviewed-on: https://gerrit.libreoffice.org/47282Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  e3dc182b9dda0ba1a0e42dcea00e4d3b01e4b34f

Fix typos

Change-Id: I4ab0df8ed7f3d8ac95f28220c9b4f59e2a6a1eb2
Reviewed-on: https://gerrit.libreoffice.org/47281Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Project: help  f1126fd812d5f812803f666f7fb4bcd5024c9772

Fix typos

Change-Id: Ie3e0490e8ca41f9d4f20b834a3d5865c0fb18ad7
Reviewed-on: https://gerrit.libreoffice.org/47480Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I0df4bc2c8d9c5d5f95141b585826fc773a1fde3e
Reviewed-on: https://gerrit.libreoffice.org/47484Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

As far as I see the old qadevOOo/runner/lib/MultiPropertyTest.java
didn't assert the content of the property value (only avoided the set of
the property if the value was null or void), the new C++ version asserts
both the type and the value. Asserting the type is probably a good
thing, but asserting the value is problematic, at least the test failed
for me without these tweaks.

Change-Id: I688486025e6118ad4c8907de6cb2629dd008f8fd
Reviewed-on: https://gerrit.libreoffice.org/47475Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I6929fc192e0e602c06edf89cf70e256797f7543a
Reviewed-on: https://gerrit.libreoffice.org/47476Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9f2b0cbb5108f57ec2f80ebe24f748c33ea9cf59
Reviewed-on: https://gerrit.libreoffice.org/47477Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8862e7f4d2dcb007295028b9ec7be04e58ebafd3
Reviewed-on: https://gerrit.libreoffice.org/47264Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

Change-Id: Icf66aa82e72a2b9f24f590b84bb0441ebf09463f
Reviewed-on: https://gerrit.libreoffice.org/47466Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7fac3c4a0f2d81c4decf59f707d1cb4d764e3e41
Reviewed-on: https://gerrit.libreoffice.org/47152Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: If114b42912a98b85f1b64f87bdb1f64afd15c85e
Reviewed-on: https://gerrit.libreoffice.org/47457Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Project: help  382ba1bc41a04d2f7b444e4c4ca9460b66147717

Switched to a sidebar layout. Art direction by Andreas Kainz

Markup and JS got simpler, layout got more robust.

Change-Id: Ia74489038e7d11b632ea2b6ca6efe0d90dfe5181
Reviewed-on: https://gerrit.libreoffice.org/47441Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I7929ccf751d37f65975d6412e28d34bec4421c07

Change-Id: If94e32689c6742b2080c213796e27d49ebe6df74
Reviewed-on: https://gerrit.libreoffice.org/47458Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Apparently this fails currently for unknown reasons, see report
by Luke Benes at
https://lists.freedesktop.org/archives/libreoffice/2017-December/079196.html

Change-Id: Ib4c79fbc6a4353ab51612836f51196bc37a90ae1
Reviewed-on: https://gerrit.libreoffice.org/47444Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Just translate the test, it checks just a tiny fraction of what it does
just like the Java version.

Change-Id: I85b4c890d970a00402d7f1b6f13d4e9ea2dd6e3c
Reviewed-on: https://gerrit.libreoffice.org/47443Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ibf1cc3b678a54ceaf6eb82f0b51fc6082ba1e78d

(regression from 33460160)

Change-Id: I6e257f07a44740f77450ca6278aa2c0fa8ce2551

Change-Id: I1e895382fc858ecd9be3d974b2be155d7e9de52d
Reviewed-on: https://gerrit.libreoffice.org/47452Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Reverting CustomTarget_iOS_prelink.mk to static lib version

Change-Id: I44d7441ce4284ed0551637a3827e93c2df369af9

after commit
    commit 7accac09
    Date:   Fri Jan 5 11:12:54 2018 +0200
    tdf#114837 FILEOPEN: Image is blank

Change-Id: I2f89e7d292a658ef99f93281a318046c4e9329be

This reverts commit 4f111825.

Turns out I was wrong, there are tons of place defining
slotid<->whichid mappings.

Change-Id: I2a124ecba02c45f14ee917727adb993c39994881
Reviewed-on: https://gerrit.libreoffice.org/47454Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...newly added with 61be109b "tdf#98141 add svg
file for all app icons in all sizes".  Otherwise building the rpms complains
about "Installed (but unpackaged) file(s) found".  (And per <https:
//specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-0.13.html> it
indeed seems OK to have .svg files in all the NxN sub-directories too, not only
the scalable sub-directories.)

Change-Id: I730ca19e67b452b309ca48a26ce806db7780c9f5

Change-Id: I9d54a942ee8e772a05fdef126aa80b25e273f8a3
Reviewed-on: https://gerrit.libreoffice.org/47451Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

revert

    commit e75abe6e
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Tue Dec 12 09:33:14 2017 +0200
    convert tolerance params to sal_uInt8

for now.

Change-Id: Iafaada0fb338f60ecc9f94aafe138500dfb27cf7
Reviewed-on: https://gerrit.libreoffice.org/47453Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and mpPoolDefaults doesn't need to be a pointer

Change-Id: I02735b22466711d7260d2ff0cbc6bf0cab5d83b2
Reviewed-on: https://gerrit.libreoffice.org/47450Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I766862d255ac285329ae423629c7445837ddd55f
Reviewed-on: https://gerrit.libreoffice.org/47280Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>