...in Dialog::add_button (vcl/source/window/dialog.cxx:1348) during
CppunitTest_cui_dialogs_test (part of `make screenshot`)

Change-Id: Ie5b8e301b99350a19f6de7de6496a9b315b633ee
Reviewed-on: https://gerrit.libreoffice.org/50415Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

repair test case - original file contain smb:// URL. New test file created from scratch.

Change-Id: I64f32f87cb620be9988b91f8c96548e219057316
Reviewed-on: https://gerrit.libreoffice.org/50386Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Id4022092765c085efcd71627a1dd8290f7441e74
Reviewed-on: https://gerrit.libreoffice.org/50407Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

Change-Id: I261fa22fa8557409c13370761de584fe64083fba
Reviewed-on: https://gerrit.libreoffice.org/50403Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

and get rid of:
warn:legacy.osl:10410:10410:sfx2/source/control/msgpool.cxx:211: GroupId-Name not defined in SFX!

Indeed "Navigation" isn't taken into account in getGidResId from msgpool.cxx (sfx2)

Change-Id: Ie5d54175106c1ca835a487ccfe2a38f3f21dc93d
Reviewed-on: https://gerrit.libreoffice.org/50400Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I0577de02000c6aeb45bf1e950b9212beadacb05b
Reviewed-on: https://gerrit.libreoffice.org/50334Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

... to de-duplicate implementation and cut some overhead.
Also, it seems UTF-16BE password was never handled.

Change-Id: I46cae8516c6f2d1568aabc8d993c883f424c7d12
Reviewed-on: https://gerrit.libreoffice.org/50401Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

using

    git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)"
    | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g"

and then some manual fixup where the resulting expression no longer
compiled

Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4
Reviewed-on: https://gerrit.libreoffice.org/50372Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  87195b21bae39f7bc4fe4c35f305241d1f5d0b3f

update help ids for accept/reject dialog

Change-Id: Iea81698d82be9ecced7b45c0a465459abec88860

Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38
Reviewed-on: https://gerrit.libreoffice.org/50398Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I0c858676e1fc02a72b4b6bfd10f512d8e9166061
Reviewed-on: https://gerrit.libreoffice.org/50402Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

for :wrap property to be effective, a reasonable height request is
needed so the text is not forced into single line again

Change-Id: I3bfe459b4894cad1682d03a8ef77f0c54690bf4d
Reviewed-on: https://gerrit.libreoffice.org/50394Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a

Change-Id: I4e317abb3cfceee2de4826f967a27d14fb3878ef
Reviewed-on: https://gerrit.libreoffice.org/50354Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If963704ec8af82ed2af1418621ef7fc5e475567f
Reviewed-on: https://gerrit.libreoffice.org/50364Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1db8954b86e9b2ec27ecc1f65e8ff7715612d756
Reviewed-on: https://gerrit.libreoffice.org/50363Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8af9c5c0085f5e6f8e498c48bae69f8247ef88ed
Reviewed-on: https://gerrit.libreoffice.org/50362Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3652c0a35a6873e80ee22d908a8969d09410776b
Reviewed-on: https://gerrit.libreoffice.org/50361Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

avoid O(n^2) due to broadcasting in the initial round of spellcheck.
Also always delete OPO

Change-Id: I70f2165686dee6a22ab7803e21ed886ff1679d07
Reviewed-on: https://gerrit.libreoffice.org/50360Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I91033395cb30a4ba9e65adb89712b3c70a39a508
Reviewed-on: https://gerrit.libreoffice.org/50396Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

The only reason the DOCX equivalent of the bugdoc was imported correctly
is that these default zero margins are simply missing from the DOCX
markup, suggesting Word ignores them. We now do the same, this way
the stripped down document's 3 paragraphs all have different margins as
expected.

(Also rework the testTdf112211_2 testcase to test the original problem
better: I verified that the layout is unchanged before/after this
patch.)

Change-Id: I88d56c27c19e070e983c3392f99bca96597cd56e
Reviewed-on: https://gerrit.libreoffice.org/50391Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

This helps in case the HTML filter is given an XHTML that has an
explicit namespace alias for <http://www.w3.org/1999/xhtml>.

Change-Id: I437fa85ba19ce907c9c4b10c8d10aaf2217dc0ea
Reviewed-on: https://gerrit.libreoffice.org/50380Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ia82df7c6c8260c90f76d77355b70b8589978b9c2
Reviewed-on: https://gerrit.libreoffice.org/50341Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Moved struct FltCallDialogParameter to svtools/inc as this struct is
used only in the files located there . A separate header file is made
named FltCallDialogParameter.hxx which has this struct and appropriate
modification are done to the inclusion of header files in each file.

Change-Id: I60326b58fcbbb9c34abdb7c3de48667268b5d5e5
Reviewed-on: https://gerrit.libreoffice.org/50265Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

So always enable the button to activate the styles sidebar.

Found by UBSAN:
test_asian_phonetic_guide (asianPhoneticGuide.asianPhoneticGuide) ... /svx/source/dialog/rubydialog.cxx:322:68: runtime error: downcast of address 0x602000635e30 which does not point to an object of type 'SfxBoolItem'
0x602000635e30: note: object is of type 'SfxVoidItem'

Change-Id: I6ff20c76b4a45189d78707cd258ed2aff80c50a5
Reviewed-on: https://gerrit.libreoffice.org/50367Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ief511d75e5a9b1e9230036c453edcb8b0a039221
Reviewed-on: https://gerrit.libreoffice.org/50328Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I8caee48fa9a08d6ee8c5c084468634dcd2a5fbf6
Reviewed-on: https://gerrit.libreoffice.org/50383Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I6a3b0b7bd6d4d3f432877e9fab0aadc041a4e8e9
Reviewed-on: https://gerrit.libreoffice.org/50389Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Project: help  e99b572b78c43358f910219ee89a13a87d8e7bba

Fix typo

Change-Id: Ia48c3586354cf4144a42810fcf0ca678ae28085c
Reviewed-on: https://gerrit.libreoffice.org/50374Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Project: help  acc847de97f5bbaefe27500d630ae8180215f09e

Fix typo

Change-Id: I474984c776c141f18c789a9e16b026cd4588bca7
Reviewed-on: https://gerrit.libreoffice.org/50376Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Do this by going to basegfx::B2DRange, adding a
single pixel size and using floor/ceil to go to
full integer (as needed for pixels). Also need
to go back to basegfx::B2DPolyPolygon for the
creation of the needed MaskPrimitive2D.
The general problem is that Writer is scrolling
using blitting the unchanged parts, this forces
this part of the scroll to pixel coordinate steps,
while the ViewTransformation for paint nowadays has
a sub-pixel precision. This results in an offset
up to one pixel in radius. To solve this for now,
we need to expand to the next outer pixel bound.
Hopefully in the future we will someday be able to
stay on the full available precision, but this
will need a change in the repaint/scroll paradigm.

Change-Id: Idb4a596bc298d1b80aab6f36ad4204afe94d54f7
Reviewed-on: https://gerrit.libreoffice.org/50369Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

Change-Id: I2c8315c7223adac2d7e0e2aa403db0f865bdc48e
Reviewed-on: https://gerrit.libreoffice.org/50377Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ic8b58b792236a733b6687148eac5c06bbf734acf
Reviewed-on: https://gerrit.libreoffice.org/50325Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In preparation to use this in AgileEngine.

Change-Id: I45fb6ba24b759a72af0c7afa22eae75f1ae728ce

Change-Id: If4a0b9532c69a1b3746fab8c727f245cd2e8a131
Reviewed-on: https://gerrit.libreoffice.org/50375Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6b5259d56e8fe5855f8a1125bb87a3dea8e5f425
Reviewed-on: https://gerrit.libreoffice.org/50301Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This change reuses TryLaterQueryBox, but only uses the new option to
ignore the lock and save. Other options ("Try Again" and "Save As")
are not used, because this functionality is not implemented currently
(TODO/LATER).

Change-Id: Idf825be23cf97d2b338c0cf5d532f8460843bf48
Reviewed-on: https://gerrit.libreoffice.org/50371Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Clarifies intention, and with IterCount::NONE prepared to handle
something like old PBKDF1, if anything actually used that. See
https://tools.ietf.org/html/rfc8018#section-5.1 where iteration
count is not part of the re-hash.

Change-Id: I5f97ca7a91f611eced8ced0a0c64961c04535d36

"voided" new formal parameter

Change-Id: I7d8849765eb6a2642f48159bae34c3b8bec3a8cd

Change-Id: Icc385fb760b8a5ff337f58dc95ba3c3f86805eaa
Reviewed-on: https://gerrit.libreoffice.org/50108Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>