Kayıtlar (commit) · 0a840edcc19ad1b8bb1525717d91ce8ade0c0092 · LibreOffice / core

18 Kas, 2016 9 kayıt (commit)

includes should be at the top of the file · 0a840edc

Noel Grandin Kas 18, 2016 yazdı

not randomly scattered through the code

found with something like:
   git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include"

Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351
Reviewed-on: https://gerrit.libreoffice.org/30952Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

0a840edc

starmath: fix loplugin:cppunitassertequals warnings · 3ab9cebf

Miklos Vajna Kas 18, 2016 yazdı

Change-Id: I49bddc1e51550c1696a1e93ce22e6b85bb663cd6
Reviewed-on: https://gerrit.libreoffice.org/30949Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

3ab9cebf

tdf#103944: Fix symbol font remapping · d8c38659

Khaled Hosny Kas 17, 2016 yazdı

This reverts:

commit 8556cd88
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date:   Thu Mar 6 09:48:54 2014 +0100

    cp#1000039 DOC import: ignore symbol charset of the symbol font

    Otherwise characters unhandled by our OpenSymbol font (like Arabic 0-9
    numbers) won't be rendered using an other font, as no other font
    provides the symbol charset. Do this in
    SwWW8ImplReader::GetFontParams(), where we already have font name ->
    font family mappings for a few well-known fonts.

    The DOCX filter does the same for quite some time, and that's how Arabic
    numbers in text using the Symbol font were rendered, instead of little
    rectangles.

The reverted commit prevented remapping symbols supported by OpenSymbol,
and it seems to have worked incidentally because of the fallback to the
“Standard Symbols L” Type 1 font which we longer support. The bug doc is
broken in master with or without this commit, but reverting this fixes
tdf#103944.

Change-Id: I17ac699fc5987e11e5c9e490895fc3c4967d3127
Reviewed-on: https://gerrit.libreoffice.org/30932Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

d8c38659

Make sure swui's pSwResMgr is initialized in CppunitTest_sw_dialogs_test · 2ec76e5d

Stephan Bergmann Kas 18, 2016 yazdı

...to avoid -fsanitize=null at

> sw/source/ui/misc/glossary.cxx:840:17: runtime error: reference binding to null pointer of type 'ResMgr'
>     #0 0x7f980fc6b73f in SwGlTreeListBox::SwGlTreeListBox(vcl::Window*, long) sw/source/ui/misc/glossary.cxx:840:17
>     #1 0x7f980fc80d56 in VclPtr<SwGlTreeListBox> VclPtr<SwGlTreeListBox>::Create<VclPtr<vcl::Window>&, long>(VclPtr<vcl::Window>&, long&&) include/vcl/vclptr.hxx:138:46
>     #2 0x7f980fc6c5d2 in makeSwGlTreeListBox sw/source/ui/misc/glossary.cxx:851:1
>     #3 0x7f985da4c3c4 in VclBuilder::makeObject(vcl::Window*, rtl::OString const&, rtl::OString const&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&) vcl/source/window/builder.cxx:1793:17

Change-Id: Ieb0d0f6b561e93acbee8208e1ba445879e99adc1

2ec76e5d

Fix comment about pSwResMgr · fd222a8b
Stephan Bergmann Kas 18, 2016 yazdı
```
Change-Id: I567446ebb41c553cf1a0f6cfdba89857c018c6f2
```
fd222a8b

remove some double calls · fc18da91

Noel Grandin Kas 17, 2016 yazdı

found with
   git grep -P '\W(\w+)\s*\(\s*\W'

Change-Id: Ia93f83193959c72dcc15c5c1bf54e805b43f14e5
Reviewed-on: https://gerrit.libreoffice.org/30934Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

fc18da91

Correct minute mapping from Adobe Symbol encoding · 43b5ca69

Khaled Hosny Kas 18, 2016 yazdı

It should be mapped to U+2032 PRIME not U+0384 GREEK TONOS, based on:
http://www.unicode.org/Public/MAPPINGS/VENDORS/ADOBE/symbol.txt

Change-Id: I554fe307955ac166d5c4e96813be71c03234eb4f

43b5ca69

Re-label more class members private from protected. · 964f4ca9
Kohei Yoshida Kas 17, 2016 yazdı
```
Change-Id: I0043da67de3a459bf26b13f9f69d3677bcc2824d
```
964f4ca9

tdf#84650 Fix X-coordinate of SmMatrixNode's elements · 395295a4

Takeshi Abe Kas 17, 2016 yazdı

which are aligned to left or right against the column.

Change-Id: Ie2b6944bc0dddb0e1589842472298f787fabf596
Reviewed-on: https://gerrit.libreoffice.org/30929Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

395295a4

17 Kas, 2016 31 kayıt (commit)

Resolves: tdf#103994 AdjustReferenceOnMove: handle external references · 4665be3a
Eike Rathke Kas 17, 2016 yazdı
```
Change-Id: I8b104b0c843dd268d8760a2a73cdd3e672e6efd6
```
4665be3a

ODF: do not write an empty style:text-position="" attribute for CharEscapement · 8aec9057

Eike Rathke Kas 17, 2016 yazdı

... and CharEscapementHeight if the Any is void.
This was a real error complained about in the officeotron validation
https://bugs.documentfoundation.org/attachment.cgi?id=128411
https://bugs.documentfoundation.org/show_bug.cgi?id=103493

Also showed up as console warning

	warn:legacy.osl:3269:1:xmloff/source/core/xmlerror.cxx:178: An error or a warning has occurred during XML import/export!
	Error-Id: 0x20040003
		Flags: 2 ERROR
		Class: 4 API
		Number: 3
	Parameters:
		0: CharEscapement
	Exception-Message: UNKNOWN_PROPERTY
	Position:
		Public Identifier:
		System Identifier: file:///.../103493-LotroPlan%203.8.ods
		Row, Column: 2,1850164

Change-Id: Ifc634cc6b3d5d6dfa43741005ef0c9a1f7ff71fe

8aec9057

tdf#103876: PPTX import: Title shape's character properties are wrong · 5c7f3e4a

Tamás Zolnai Kas 15, 2016 yazdı

Text properties are applied on a shape during text insertion,
but if a placeholder shape has no text, then it has a placehodler
text which should have the right text properties.

Change-Id: I54175d52dd25915ee4d7153298e01ec07c6be1f6
Reviewed-on: https://gerrit.libreoffice.org/30881Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

5c7f3e4a

Fix tdf#103855 add language codes and names to language lists from extensions · 6b35e804

Martin Hosken Kas 16, 2016 yazdı

Rationale for changes to languagetag.hxx can be found in the bug
tdf#103855.

Change-Id: I7fa7c8a3f7b219ce08df69a3965f544ae156beab
Reviewed-on: https://gerrit.libreoffice.org/30882Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

6b35e804

sfx2: let .uno:SignPDF result in a custom infobar text · 3b94229f

Miklos Vajna Kas 17, 2016 yazdı

To make the intention a bit more explicit.

Change-Id: I70ce053b9f068a2288e4a05eba55fb3e2451b561
Reviewed-on: https://gerrit.libreoffice.org/30935Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

3b94229f

Avoid -fsanitize=enum · 2f46a7d1

Stephan Bergmann Kas 17, 2016 yazdı

...when doing Writer "Insert - Table of Contents and Index - Table of Contents,
Index or Bibliography...":

> sw/source/uibase/inc/cnttab.hxx:58:16: runtime error: load of value 65535, which is not a valid value for type 'TOXTypes'
>     #0 0x7fbed9c2c9c8 in CurTOXType::operator==(CurTOXType const&) sw/source/uibase/inc/cnttab.hxx:58:16
>     #1 0x7fbed9b711b1 in SwTOXEntryTabPage::ActivatePage(SfxItemSet const&) sw/source/ui/index/cnttab.cxx:2071:25
>     #2 0x7fc217524056 in SfxTabDialog::ActivatePageHdl(TabControl*) sfx2/source/dialog/tabdlg.cxx:1126:19
>     #3 0x7fc217519ac3 in SfxTabDialog::LinkStubActivatePageHdl(void*, TabControl*) sfx2/source/dialog/tabdlg.cxx:1035:1
>     #4 0x7fc1f15c0e37 in Link<TabControl*, void>::Call(TabControl*) const include/tools/link.hxx:84:45
>     #5 0x7fc1f157cbaa in TabControl::ActivatePage() vcl/source/control/tabctrl.cxx:1601:19

Change-Id: I458e010b10dfdf3e944c389f61595869cc41036f

2f46a7d1

Silence -Werror,-Wlogical-op-parentheses · 721cbf44
Stephan Bergmann Kas 17, 2016 yazdı
```
Change-Id: I4d592ef4bd683ffe8d9d44b3d3b188f9d4ed63ba
```
721cbf44
clearly a wrong offset is worth an assert() instead of OSL_ENSURE() · 89ec8095
Eike Rathke Kas 17, 2016 yazdı
```
Change-Id: I2a4a8f054269df3ee085b9373f00bd749667665e
```
89ec8095
that should have been LibreOfficeKit*Document*Class · e1b2af19
Christian Lohmaier Kas 17, 2016 yazdı
```
Change-Id: I48f9db39be18ae9a456002de8f40fbb0fb3be707
```
e1b2af19
put the render frame at the end of these blocks too · 7f1af0a1
Caolán McNamara Kas 17, 2016 yazdı
```
Change-Id: I72270faa4138377ea04467ad0c6f01a3de0156b6
```
7f1af0a1

gtk3: spinbuttons under Ambiance don't look beautiful enough · 4579c438

Caolán McNamara Kas 17, 2016 yazdı

lets draw the frame after the sub-contents are done, and
use a dedicated entry child

Change-Id: I7db1ac56e5cfb1a46ddd2fb56c5e95deaa83a95d

4579c438

xmlsecurity PDF sign: handle AdES when writing SubFilter · 972c1e9e

Miklos Vajna Kas 17, 2016 yazdı

Page 21 of "PAdES baseline signatures" specification from
<http://www.etsi.org/deliver/etsi_en/319100_319199/31914201/01.01.01_60/en_31914201v010101p.pdf>
says:

"The Signature Dictionary shall contain a value of ETSI.CAdES.detached
for the key SubFilter."

So in case the UI has the adescompliant checkbox enabled, write that
value instead of the Adobe default.

Change-Id: I69e606a32fb09bebd5e9b25b32150d1b8672f544

972c1e9e

loplugin:stringconcat · 07d4f5d9
Stephan Bergmann Kas 17, 2016 yazdı
```
Change-Id: I72bfe53ba1b8162e34561cdc96c4313861042050
```
07d4f5d9

add RIGHT and RIGHTB test case · 833a0853

Zdeněk Crhonek Kas 17, 2016 yazdı

Change-Id: Ifa08f4cbb0e0c5e07902ceb80001004d0b656f38
Reviewed-on: https://gerrit.libreoffice.org/30928Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

833a0853

Avoid -fsanitize=signed-integer-overflow · 2f976709

Stephan Bergmann Kas 17, 2016 yazdı

Both Writer: "Table - Insert Table... - Insert", "Table - AutoFormat Styles...";
and Calc: select multiple cells, "Format - AutoFormat Styles..." cause

> svx/source/dialog/framelinkarray.cxx:82:29: runtime error: signed integer overflow: -4702111234474983744 + -4702111234474983746 cannot be represented in type 'long'
>     #0 0x7f84ef0e36ba in svx::frame::lclRecalcCoordVec(std::__debug::vector<long, std::allocator<long> >&, std::__debug::vector<long, std::allocator<long> > const&) svx/source/dialog/framelinkarray.cxx:82:29
>     #1 0x7f84ef0e780e in svx::frame::ArrayImpl::GetColPosition(unsigned long) const svx/source/dialog/framelinkarray.cxx:265:9
>     #2 0x7f84ef0f95ae in svx::frame::Array::GetColPosition(unsigned long) const svx/source/dialog/framelinkarray.cxx:762:20
>     #3 0x7f84ef0f9e56 in svx::frame::Array::GetWidth() const svx/source/dialog/framelinkarray.cxx:787:12
>     #4 0x7f852e9df8fd in ScAutoFmtPreview::CalcCellArray(bool) sc/source/ui/miscdlgs/autofmt.cxx:429:32
>     #5 0x7f852e9c7740 in ScAutoFmtPreview::Init() sc/source/ui/miscdlgs/autofmt.cxx:407:5
>     #6 0x7f852e9c9102 in ScAutoFmtPreview::ScAutoFmtPreview(vcl::Window*) sc/source/ui/miscdlgs/autofmt.cxx:73:5

where -4702111234474983746 = 0xbebebebebebebebe is ASan's uninitialized value
stored into ScAutoFmtPreview::mnLableColWidth et al.  Those (overflowing, even)
computations on uninitialized values appear to be harmless in practice, though,
presumably because they are overwritten with "real" values soon after.

Change-Id: I487fc4681afe79c4e8532595226cba4c9c0c9b2d

2f976709

coverity#1394292 Unchecked return value · 447a65db
Caolán McNamara Kas 17, 2016 yazdı
```
Change-Id: I90db6e3c69a6dc90ce1df0dbb5b9d7a81cd1bbea
```
447a65db
coverity#1394372 Division or modulo by zero · dc6d4772
Caolán McNamara Kas 17, 2016 yazdı
```
Change-Id: I1d8d134bf423778a76f7dc6fc5a5e4f8c30c6c3d
```
dc6d4772
vcl: work around missing std::fmax() on Android · c84d8ebb
Miklos Vajna Kas 17, 2016 yazdı
```
Change-Id: Iaa4e6aa84c163f2ec5541f233cf7593c0a501b5e
```
c84d8ebb

tdf#103950 Undo does not revert bundled font size changes for table cells · 90646b49

Noel Grandin Kas 16, 2016 yazdı

Change-Id: Id41b7777739bfa93610f955e6c31f8bb979b8e2c
Reviewed-on: https://gerrit.libreoffice.org/30902Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

90646b49

loplugin:unusedfields · bb674aa5

Noel Grandin Kas 17, 2016 yazdı

Change-Id: Id2dbbf384637223db3d334d95332251832918003
Reviewed-on: https://gerrit.libreoffice.org/30927Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

bb674aa5

Resolves: tdf#87960 add and use a ToolFontColor for toolbar item entries · b79cf88a

Caolán McNamara Kas 17, 2016 yazdı

instead of using the MenuBar text color, cause for Ambiance theme the
menubar is dark and its font is light, while the toolbars can be light,
so light font on light bg appears greyed out

Change-Id: I0fa4ab8eabdd3cd69eb682e5ddba8314b8c9ff0f

b79cf88a

Add Skeleton for DataProvider Class · 46f544fa

Jaskaran Singh Eki 16, 2016 yazdı

DataProvider class serves as an abstraction of various External
Data Importing Techniques we have and the others which
could be implemented in the future.

Change-Id: I9fc9455f7fbf9025aace4c3248df9b32f522ce52
Reviewed-on: https://gerrit.libreoffice.org/30906Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>

46f544fa

tdf#91222 VclBuilder constructor cleanup · 69d08eff

melikeyurtoglu Kas 17, 2016 yazdı

Change-Id: I367c2096b3c0d508bca1e207c78c2f955f51e263
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30921Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

69d08eff

vcl PDF NSS sign: don't embed signed timestamp to the signature blob · f099e139

Miklos Vajna Kas 17, 2016 yazdı

There are several reasons to avoid doing so:

- The mscrypto backend doesn't do that, so the previous situation was
  inconsistent.
- PDF provides markup to provide a timestamp, and that's automatically
  part of the signed data.
- Page 10 of "PAdES Basic" specification from
  <http://www.etsi.org/deliver/etsi_ts%5C102700_102799%5C10277802%5C01.02.01_60%5Cts_10277802v010201p.pdf>
  explicitly requests either not writing that data, or writing it as an
  unsigned attribute (probably to underline that the value is from untrusted
  source, it's the signer's computer clock).

Change-Id: I35b1a9ef4a391a24e6695353d617f27c7d96d93b
Reviewed-on: https://gerrit.libreoffice.org/30926Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

f099e139

chmod -x · c6ec6539
Tor Lillqvist Kas 17, 2016 yazdı
```
Change-Id: Ie07ef2f9e9f6d0b31b513afa913b79d9c641e4f1
```
c6ec6539

Have a specific TARGETTYPE for CompilerTest after all · 439a3c03

Stephan Bergmann Kas 17, 2016 yazdı

...instead of leaving it empty.  (645583df "New
compilerplugins/clang unit tests": "Checking the input files is implicitly
phony, as the compilation step doesn't generate any object files, and the link
step does nothing because there is no gb_LinkTarget_set_targettype for
CompilerTest.")  In preparation for using compilerplugins/clang with clang-cl on
Windows.

Change-Id: Ica4f16a4b249537f78ce21fcbe7c4afea8214821

439a3c03

loplugin:datamembershadow · 401d07f3
Noel Grandin Kas 17, 2016 yazdı
```
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
```
401d07f3

libxmlsec: remove no longer applying mingw patches · 586a461a

Miklos Vajna Kas 17, 2016 yazdı

One from the two patches do not apply anymore. Remove both of them for
now.

Change-Id: I8e06cc28810a9dac13054282a630b0e9b716af86
Reviewed-on: https://gerrit.libreoffice.org/30924Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

586a461a