- 24 Mar, 2017 40 kayıt (commit)
-
-
Takeshi Abe yazdı
instead of pushing it to the stack, for later refactoring. Change-Id: I61760fbfe95771dede62f90f82df3e9961efdcd6 Reviewed-on: https://gerrit.libreoffice.org/35609Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
-
Varun Dhall yazdı
Just because Underline is as important as Bold/Italic we cannot skip a test for it :) Change-Id: I6c240a3232cf97794c8265afe66f58ce6f68fa43 Reviewed-on: https://gerrit.libreoffice.org/35217Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
-
László Németh yazdı
using recent fixes of Hunspell code base Change-Id: I180a2ecba924180419c5eb1a0e78b5c84e7242c4 Reviewed-on: https://gerrit.libreoffice.org/35665Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
-
Michael Stahl yazdı
Change-Id: I317b5fcd6e5753b4f854930ed4f4ceea53a385c4
-
Miklos Vajna yazdı
Start copying referenced objects recursively, and also take care of updating references to the object IDs as they appear in our output. With this, the 4th image referenced from the PDF image has a correctly updated reference in its dictionary's ColorSpace key. Change-Id: I8b49701c1f60bd0ef5a097b24ce59164554c44fa Reviewed-on: https://gerrit.libreoffice.org/35653Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
Jan Holesovsky yazdı
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
-
Jan Holesovsky yazdı
Change-Id: I9dbb62950e639376c26122ceb9fcec2982b3ca82
-
Michael Stahl yazdı
What's the point? Change-Id: Ifdff4aae85282d213f82bd2d69f61f96f8b5e40c
-
Michael Stahl yazdı
Change-Id: I74d4b31ea619c94245759b7a061c40095a0879ad
-
Michael Stahl yazdı
Change-Id: Ie375b199e055a01b0888a6efe56ef3a2801412b2
-
Michael Stahl yazdı
Change-Id: I3bb8430be2460fa72938a4952670d3d92b12e123
-
Michael Stahl yazdı
Clearly the mutex must be locked by the caller already. Change-Id: I2c8a76f5b04751610ed07819343994b75bea4f4f
-
Michael Stahl yazdı
Change-Id: Ifa0a036589fba816eaa3503b17223e80f5b99aa1
-
Michael Stahl yazdı
Change-Id: I43aef41cee96f69b0bbd540b832780c4002219e3
-
Michael Stahl yazdı
These are unnecessary with the fix for tdf#58624, because now SwAccessibleContext dtor will check that the map is still alive. Anything that's still alive at that point should have been disposed by the recursive Dispose call. Change-Id: I39102a6b222b2121987d92077d4b9548281d9973
-
Stephan Bergmann yazdı
Change-Id: Ia7701e84ea87588abb526ad82da659114474bee5
-
jan Iversen yazdı
added action menu in Document viewer Change-Id: Ia7c796f7806e363769a5932ce774f33bb4ae8bd2 Reviewed-on: https://gerrit.libreoffice.org/35666Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
-
Stephan Bergmann yazdı
(to avoid warnings about undefined macros in external code) Change-Id: Ie1007207b22c19a3d9d96f0f94070c32d417595a
-
Bjoern Michaelsen yazdı
Change-Id: Ica8a8c8cfd1f0743c4ad9421f3cac9aa92645838 Reviewed-on: https://gerrit.libreoffice.org/35650Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
-
Stephan Bergmann yazdı
(with EOF represented as 0), so better actually use 'char'. Same as 0a92c29e "This code trades in 'char' entities disguised as 'int'" in idl. Change-Id: Ie664c1a0cceb7281fae29bdb75d191b998df44cc
-
jan Iversen yazdı
Update to filemanager to act as an overlay to documentView updated appIcon to include only required added setName dialog (used for rename/create directory/save as) Removed trailing whitespace Change-Id: I1c8a8cd7ef4eb76687f40e806a14884a1e396bc5 Reviewed-on: https://gerrit.libreoffice.org/35612Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@libreoffice.org>
-
Caolán McNamara yazdı
Change-Id: Ifc1f654e4f63fc7aa62e1b920d1550281a0fa71e
-
Caolán McNamara yazdı
Change-Id: I6ba3131155fbbe5a01e47aca4008d39191254fe0
-
Caolán McNamara yazdı
Change-Id: I33ad32f4fa6ca6206e98b38f9170634bce9970de
-
Caolán McNamara yazdı
Change-Id: I9dbe7218d6ca0fa7ffc780094843be232af74e95
-
Caolán McNamara yazdı
I only *need* it for the fuzzers, just wanted to keep this in sync with those for simplicity Change-Id: I4fd8aef54c6604c0d44faca9a6515bfd8e85d8bf
-
Michael Stahl yazdı
As seen in JunitTest_toolkit_unoapi_1: Method doAccessibleAction() finished with state OK LOG> doAccessibleAction(): COMPLETED.OK debug:27272:12: -SwAccessibleParagraph mutexwait 0x3fd9f50 debug:27272:9: SwAccessibleContext::Dispose 0x3872620 11SwRootFrame debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x386d600 11SwPageFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x386cef0 11SwBodyFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleContext::DisposeChildren 0x4047c80 0x3878fe0 11SwTextFrame debug:27272:9: SwAccessibleContext::DisposeChildren xAcc 0 debug:27272:9: SwAccessibleMap::RemoveContext erase 0x3872620 debug:27272:9: ~SwAccessibleMap: frame entry 0x3878fe0 debug:27272:9: ~SwAccessibleMap: mpFrameMap 0x3eb64a0 debug:27272:9: ~SwAccessibleMap: mpShapeMap 0 soffice.bin: sw/source/core/access/accmap.cxx:1726: virtual SwAccessibleMap::~SwAccessibleMap(): Assertion `(!mpFrameMap || mpFrameMap->empty()) && "Frame map should be empty after disposing the root frame"' The problem here is that thread 12 is blocked on SolarMutex in ~SwAccessibleParagraph(), while thread 9 is in ~SwAccessibleMap(). This means that in SwAccessibleContext::DisposeChildren(), the WeakReference to the SwAccessibleParagraph cannot create a uno::Reference because its reference count is 0, so SwAccessibleContext::Dispose() is not called on it and it remains in the SwAccessibleMap::mpFrameMap. This triggers the assert and later on ~SwAccessibleContext() would access the deleted SwAccessibleMap and crash. To fix this, introduce a weak reference from SwAccessibleContext to SwAccessibleMap; use a std::weak_ptr because that is not derived from OWeakObject. The weak_ptr is only used in the dtor ~SwAccessibleContext(); as long as the ref-count of SwAccessibleContext is > 0 it is guaranteed that the SwAccessibleContext::m_pMap is either null or valid as the recursive Dispose() will work fine. It is possible that additional temporary owning references could delay the destruction of SwAccessibleMap, and the order of destruction of Writer documents is very fragile, so rely on the SolarMutex lock to prevent that; the only shared_ptr that owns SwAccessibleMap while SolarMutex is not locked is the one in SwViewShellImp. (An alternative fix would be to represent the 3 lifecycle stages of SwAccessibleContext by adding a C++-pointer to the SwAccessibleMap::mpFrameMap, so that DisposeChildren() can, if the WeakReference is no longer valid due to ref-count 0, use the pointer and clear SwAccessibleContext::m_pMap - this and the corresponding call to SwAccessibleMap::RemoveContext() from ~SwAccessibleContext() under a mutex that is shared_ptr-owned by SwAccessibleMap and all SwAccessibleContext.) Change-Id: If2b44c79189e3b3d276491a5c57d5404bb2be71a
-
Caolán McNamara yazdı
because we just write past the end instead of resizing before hand Change-Id: I4742980a331b14ca39aff8aa6cfc27db154091ff
-
Caolán McNamara yazdı
Change-Id: I091491a628b267a18d044d770a28a6b9e96f39f4
-
Stephan Bergmann yazdı
Change-Id: Ic8f6322854ff0ac25c34cd9286545c8aaa27d03b Reviewed-on: https://gerrit.libreoffice.org/35628Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Miklos Vajna yazdı
With this the images inside the PDF image show up correctly. Change-Id: I430502fb6ae9de8111dda7e67db33642ff263317 Reviewed-on: https://gerrit.libreoffice.org/35621Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
Noel Grandin yazdı
checked that none of these are present in any .xcu files. Change-Id: Ife5ac45ca4e71fed9515941c20853b9ab811e057 Reviewed-on: https://gerrit.libreoffice.org/35619Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Kohei Yoshida yazdı
Change-Id: I553c18107d469bd7dce37d673f958126455b4393 Reviewed-on: https://gerrit.libreoffice.org/35608Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
-
Kohei Yoshida yazdı
Change-Id: If1932a5eb10da4c50fbcc3329af75f2e7a0a5137 Reviewed-on: https://gerrit.libreoffice.org/35607Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
-
Christian Lohmaier yazdı
Change-Id: I527a524c282d4314e57c30cdd9eb89bff38443db
-
Caolán McNamara yazdı
fontconfigs alloc mechanism is too complicated for lsan/valgrind so force the fontconfig options to be released at the end of every iteration, they are demand loaded so will be recreated if necessary on next use Change-Id: I061117b1fb8136298593a165847f78eabe008f0f
-
Caolán McNamara yazdı
Change-Id: Ic0b9b23764bd7533adbc746419d38da8ab7ce704
-
Caolán McNamara yazdı
Change-Id: I89aa885c2d5a5c1150ac83b515c0bb84ff2ce039
-
Michael Meeks yazdı
Hopefully addresses: http://crashreport.libreoffice.org/stats/crash_details/7a33b96a-b479-47a4-a006-eb62718128cc Change-Id: I221c04a6626a39449405387343cdc43e9f02dee1 Reviewed-on: https://gerrit.libreoffice.org/35587Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
-
Noel Grandin yazdı
after commit 7916487c "convert ViewShellId to o3tl::strong_int" Change-Id: Ie7b8ac51a94c3b9e6d39e397aa3dd5cb42acc6d0 Reviewed-on: https://gerrit.libreoffice.org/35623Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-