Change-Id: I01855c37955dcae13dbb3c6f028d4030dc48945a
Reviewed-on: https://gerrit.libreoffice.org/61657Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins

Change-Id: Ia42daaf0dbb8fcd0230c7cee21a0f5d560885c22

Change-Id: I9ff0b4287c5be0dfc83740b75d58cab78dc990f7

Keep sal.file for the SAL_INFO logging of file system calls (open,
close, rename, etc), and use sal.fileio for the (very verbose) file
I/O.

Change-Id: I0e166d83e20921696a8a0880f9fcbbdec55053dd

Change-Id: Idb7b16a6976df62a1beea8a01c812206a0b8b85a

Change-Id: Id18bafaaf8f5315a0590687d98ea97952bdf883b

The code is much too convoluted for my little brain. We can't create a
backup copy of a file from outside the sandbox in the same folder as
the original file. At least not using just normal Unix APIs. And if we
store it somewhere else, how would the user find it anyway? Let's just
skipt this mess for now.

No idea how the code manages to create backup files in the same folder
as the actual document in a sandboxed LibreOffice on macOS. Or does
it? Maybe we do some similar bypassing of the backup dance at some
other place in the code already, and I should just have made that
happen for iOS, too?

Change-Id: I0c90edf9e72f54cce78b2cd325e67c710b6df745

Change-Id: I4bea64f959a6d6f3010809261804748b4fcd7718

Change-Id: I03efe36dac946dd00c91af44a2f6401d56c23214
Reviewed-on: https://gerrit.libreoffice.org/61630
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: I0c62ef3c296f8aa1ce8b924cf88f569c48dc198f
Reviewed-on: https://gerrit.libreoffice.org/61666
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

a) SetFirst doesn't imply SetMin
b) ModifyFlag and SaveValue are orthogonal

Change-Id: Ibe637ec5d33af030af068fcf8690191a775a6460
Reviewed-on: https://gerrit.libreoffice.org/61670
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

That folder typically is not inside the app sandbox, and the process
has access only to the one file that they have selected for editing
there. Trying to create other files in that folder is doomed to fail.

Change-Id: Ib4ff5c7c60aa372eb412e87dc8bbce48ec6d6b54

Change-Id: I66c3fb02f4c44adec5c8f663d8845658adfe803f

Change-Id: I1fde453d5d37481aedec152a1a4da8a85fc6c99b

Calling stat() on a non-existent file outside the sandbox fails with
EPERM on iOS, not ENOENT. (Presumably calling stat() even on an
existing file, but one you don't have been granted access to, also
fails, because that is after all a point of sandboxing, you shouldn't
even be allowed to figure out whether arbitrary files exist outside
the sandbox.)

Not sure why this change hasn't been necessary also for a sandboxed
LibreOffice on macOS.

Change-Id: I67c768e9c34fd17fa35f08232284210ff4a71b98

CppunitTest_editeng_core explicitly request the
"Liberation Sans" font.

Change-Id: I810bddda26498252985f1869df58610e79ebc5ef
Reviewed-on: https://gerrit.libreoffice.org/61658
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

As we already do SAL_INFO logging for some low-level file operations,
surely we should try to do it for all such operations.

Change-Id: I252bbb2149c1dc7aaeaa9ea15674e1f87547f249
Reviewed-on: https://gerrit.libreoffice.org/61659Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

This results in a garbage OUString.

Change-Id: I03b8030a812d7016df5c29f1341749fbdedf1729
Reviewed-on: https://gerrit.libreoffice.org/61652
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I46b38a4adb4e1e825918029c7b4aba1d267a6e62
Reviewed-on: https://gerrit.libreoffice.org/61665
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id918a413febc39a8f147bd1b65b7204433d91ae1
Reviewed-on: https://gerrit.libreoffice.org/61663
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Icd0f854ee9480f98684f8254a542b671c12960d1
Reviewed-on: https://gerrit.libreoffice.org/61662Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Allow on-top if tabs would fit, even when > 6. Some themes have
much smaller tabs where more can fit comfortably.

Change-Id: Ia9de9059bd5af4de0e6d6a8b8817f87226e2066a
Reviewed-on: https://gerrit.libreoffice.org/61661
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Invoke ImpConnectParagraphs with bSpecialBackward set to
false by default in DeleteLeftOrRight(). Old design connect
backward when pressing backspace to connect two paragraphs.
The former paragraph of the two ( or the remain one ) adopt
the paragraph style ( bullet on/off status, color, etc. )
from the later paragraph.

It's hard to understand the intention of the original design,
and the design was not activated until LibreOffice6.1,
hence just don't connect backward anymore.

Change-Id: I3697acc01d718d7a769fb8d0bd573084c4fe2969
Reviewed-on: https://gerrit.libreoffice.org/61537
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: Icc6f93bbf85df245ba332ce89791a1c8d266b1c6
Reviewed-on: https://gerrit.libreoffice.org/61639Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Minimize column width: Adjusts the width of the selected columns
to fit the selected content. The table can shrink if necessary,
but will not grow.

(Previously no way to minimize columns. Since
minimizing really can mess up merged cells, enhance my
new calcPreferredColumnWidth function.)

Minimize row height: Adjusts the height of the selected rows
to fit the content, causing the table to shrink.

(The new optimize action functioned as minimize. So this change
tweaks optimize so that it does not reduce the table size. A
followup commit will make it distribute based on largest
minimized row (still without reducing table size), and change
distributed rows to work the way the document states - based
on the largest row.

Change-Id: I807a9cc9e9441a1215539e817b87158afe5a0604
Reviewed-on: https://gerrit.libreoffice.org/61472
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

The area of a GroupBox indicates which radio buttons
are considered to be part of the same group. The
button needs to be fully inside of the groupbox
in order to participate. This patch resolves the last
worry of commit 9f969799

Change-Id: Ie6057337c63bf9eb173a0615e30c8d4e4d0c7a19
Reviewed-on: https://gerrit.libreoffice.org/61131
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

The previous optimal implementation was cloned as a new
uno:MinimalColumnWidth function.

Optimal should try to keep the table the same size, but ultimately
the ideal row/table height will be balanced, so grow to achieve
that if necessary.

Optimize row height: Adjust the height of the selected rows
to match the height of the tallest row in the selection
(fit to content), without shrinking the table.
This option is the same as minimizing row height and then
distributing rows evenly except that it adds the benefit
of preventing the table from shrinking.

Change-Id: Ib772ae4943127d17a915cdae8cd6000db3a9d164
Reviewed-on: https://gerrit.libreoffice.org/60903
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

A followup commit will modify the optimize functions,
which currently function as a minimize, so lets make
sure that the ability to minimize is still available.

Minimize column width: Adjusts the width of the
selected columns to fit the selected content.
The table can shrink if necessary, but will not grow.
(This is how Optimize column width worked in LO <= 6.1.)

Minimize row height: Adjusts the height of the
selected rows to fit the content, causing the table to shrink.
(This is how Optimize row height worked in LO <= 6.1.)

Change-Id: I2c0b8c7b7a05c31328f2feef464ef0e131318ff8
Reviewed-on: https://gerrit.libreoffice.org/60902
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I2d40b1512420b5601c0ea6db42f319caf7c4170f
Reviewed-on: https://gerrit.libreoffice.org/61634
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I1d96e4a5e091caddf46131385ff5274521844fa9
Reviewed-on: https://gerrit.libreoffice.org/61637
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This change makes LXQt use the Breeze icon theme, and adds it as a
desktop environment along the other supported DEs.

Change-Id: I482d85620986c8fc4e33b4722b887b81c77c23bf
Reviewed-on: https://gerrit.libreoffice.org/61641Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

<https://ci.libreoffice.org/job/lo_ubsan/1065/console>:

> [build CXX] chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx
> /home/tdf/lode/jenkins/workspace/lo_ubsan/sd/qa/unit/dialogs-test.cxx:430:41: error: default initialization of an object of const type 'const std::vector<OUString>' without a user-provided default constructor
>             const std::vector<OUString> aPageNames;
>                                         ^
>                                                   {}
> 1 error generated.

Change-Id: I543ba3420e1997f21bc2c83c632fbd93ef016459
Reviewed-on: https://gerrit.libreoffice.org/61638
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

These are all the cases where the warning suggests a direct replacement.

This is a companion to 2f2c9df8
"-Werror,-Wdeprecated-declarations (--with-macosx-version-min-required=10.14)"
which covered all the other cases (via SAL_WNODEPRECATED_PUSH/POP) that offered
no direct replacement.

Change-Id: If22a3f8cec1ff22fd1ac4b9d2f2bffde50e11e86
Reviewed-on: https://gerrit.libreoffice.org/61633
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I20664f8c2dc2c49feec17ee6a1df72776d43cc40
Reviewed-on: https://gerrit.libreoffice.org/61635
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

A bookmark cross-reference was trying to access the textform
field by name, but an autogenerated __Fieldmark__ name obviously
wasn't matching.

Change-Id: I1018fecf44fda5d947b214c599f1a405f311e2ee
Reviewed-on: https://gerrit.libreoffice.org/61565Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

Just keep the definition of _WIN32_WINNT in windows.mk, which
claims it automatically derivates WINVER in some sdk header.

Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c
Reviewed-on: https://gerrit.libreoffice.org/61631Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

since type name might also contain unacceptable characters,
encode all of them

See comments 8/9/10 and 11 (bt here) of bugtracker

+ add SAL_WARN in catch (which would have avoided me to waste a lot of
time chasing the root cause)

Change-Id: If8555bba8cda011218206621216e0405615229eb
Reviewed-on: https://gerrit.libreoffice.org/61601
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I31f3a787e6f835f576c02b5831508fa78340bf22
Reviewed-on: https://gerrit.libreoffice.org/61629
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iad5770b512d7c49483ac823aa4f51212f281bbca
Reviewed-on: https://gerrit.libreoffice.org/61628Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6bbd9300fd3ec468267af2cf5d7f87d96d1817bc
Reviewed-on: https://gerrit.libreoffice.org/61627Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>