Change-Id: I03688ec1d869720b4a042602ff1da15727174592
Reviewed-on: https://gerrit.libreoffice.org/53046Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

There was a minor bug in the compat flag, leading
to a regression from commit 8d62b79f

Change-Id: I1e468e665a583ef15b6e474c3adb32f1dcf98f46
Reviewed-on: https://gerrit.libreoffice.org/52674Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Found by searching for the header names and the localization functions:
git grep -l -e \<sfx2/sfxresid.hxx\> -e \<sfx2/strings.hrc\> | xargs grep -c -e SfxResId -e GetResString | grep :0$ | grep -v /pch

Change-Id: If0571ae4029b5fb2699cdd6ea768d3cd240bdce3
Reviewed-on: https://gerrit.libreoffice.org/53073Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Found by searching for the header names and the localization function:
git grep -l -e \<editeng/eerdll.hxx\> -e \<editeng/editrids.hrc\> | xargs grep -c EditResId | grep :0$ | grep -v /pch

Change-Id: Ic542ceee09352cb52dcdc9780d4cb1890e02f383
Reviewed-on: https://gerrit.libreoffice.org/53062Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

In Windows, filesystem redirectors can map WebDAV resources to UNC
paths, or to drive-based "local" paths; so a WebDAV URI of the form
"http://WebDADServer/root/directory/File.ext" may be accessed using
"\\WebDADServer\root\directory\File.ext" or "Z:\directory\File.ext".

When using these paths, failure to create a lockfile aside the opened
document should not be considered an error; so this patch checks for
this.

Regression from commit 6ca3b364.

Change-Id: I1de55b66447dc91d22b6d2b5b121de96bf32e4ee
Reviewed-on: https://gerrit.libreoffice.org/53070Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Idff219e1c8f18adaa0f445a5469650c7793cae3a
Reviewed-on: https://gerrit.libreoffice.org/53066Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Project: help  23665d6b04829ac2b949c88de261c6f7b2de8baa

Remove unused sourceMappingURL

Caused

  Source map error: TypeError: NetworkError when attempting to fetch resource.
  Resource URL: file:///data/sbergman/lo-clang/core/instdir/help/fuse.js
  Source Map URL: fuse.js.map

when loading

  <file:///.../instdir/help/index.html?swriter/.uno:HelpIndex?Language=en-US&System=UNIX&Version=6.1>

in the browser.

Change-Id: I5d318fe8c358cedbb961113561edea3b6d4a2ce1
Reviewed-on: https://gerrit.libreoffice.org/53077Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ibba26b0eb3d85f2da3caafa1b8cc60357de297d5

Change-Id: I7f75c835339b61ba9e545c13d7e5bb208c12df4c
Reviewed-on: https://gerrit.libreoffice.org/53069Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I77a49d55dd49b0fd41f5335ac30a5484ac130250
Reviewed-on: https://gerrit.libreoffice.org/53050Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

e.g., during CppunitTest_sc_screenshots

Change-Id: I71bd617df629dab57c73252db0e46ab51eee2a18

This reverts commits 914f6385 and
a6045159. A investigation required why
is the problem with them; meanwhile, they break builds.

Change-Id: I713b27dd64e8ac7beb2757c362765b60ce191f8d
Reviewed-on: https://gerrit.libreoffice.org/53078Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Don't want to risk breaking something by using -O2 with an older
Clang, even if I don't remember exactly what the issue was when
introducing the -O1 in 7b660e14.

Change-Id: I2adeb0e8eb85a9b5021fca3d9e1e703cb5604a81
Reviewed-on: https://gerrit.libreoffice.org/53068Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I1e4112ab18e76eec4cb11fb4bc3a7cea67e7ae1d
Reviewed-on: https://gerrit.libreoffice.org/53065Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I4e0a6e3eb1f945daf2036bc1d009ae96d5a72802
Reviewed-on: https://gerrit.libreoffice.org/53072Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I51e6b32593f2e67585c6c45b0b1daefcf4860e20
Reviewed-on: https://gerrit.libreoffice.org/53067Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

With EMF+ Only mode, still the EMF records could be used for
displaying objects, by using Get Device Context (GetDC).
Files identified as EMF+ Only can contain both EMF+ records and EMF records. All EMF+
records are used to render the image. The EMF records that are part of the drawing are those
preceded by a Get Device Context record.

Unfortunately after finishing EMF drawing, the clip region was
not reset. As a result records after EMF record was not displayed.

With this patch, the issue was fixed by resetting clip region.

Change-Id: I998b14e7c3b56a7711ba6a7bec08ec2097e0dfce
Reviewed-on: https://gerrit.libreoffice.org/52897Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

Change-Id: I6d87ddc3520c74f776321329e39e7562c93ad6da
Reviewed-on: https://gerrit.libreoffice.org/53060Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ib31a8cb75f4cebcaa974b95097270362b3b26aef
Reviewed-on: https://gerrit.libreoffice.org/52689Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

collect up all the piece of data that the dispatch requires and launch
it in an idle. So if a dialog appears its embedded mainloop will not return
to body if the deleted SvxHyperlinkNewDocTp

Change-Id: Ie978bc552c3b88dc11eae2ec49417cc8bd0f02bc
Reviewed-on: https://gerrit.libreoffice.org/53056Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2386c2d8f7c6754b197df9216eed82e0152a35c8
Reviewed-on: https://gerrit.libreoffice.org/53045Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I827563c16a2ae59c698e1bfa82022a11f5256483
Reviewed-on: https://gerrit.libreoffice.org/53055Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3423511c0d7a13bd28e9a808e0d634148b759643
Reviewed-on: https://gerrit.libreoffice.org/53057Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

...to avoid false positive with --disable-dbgutil in SfxApplication ctor
(sfx2/source/appl/app.cxx), which contains

    bool bOk = InitializeDde();
  #ifdef DBG_UTIL
    ...
  #else
    (void)bOk;
  #endif

Change-Id: I4de6322a848a9c6aea3057e4598b2161888dee6a
Reviewed-on: https://gerrit.libreoffice.org/53051Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

No no need to patch the Firebird build settings for i386.

Change-Id: Ic187ff462325511a9a498e312f54350be7542366
Reviewed-on: https://gerrit.libreoffice.org/53054Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I58ceb44f96d8ae3e3732b85eafd44c4d6eab42aa
Reviewed-on: https://gerrit.libreoffice.org/53035Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The C++ tests are now located in sheetsortdescriptor2.(hxx|cxx), because
this is the latest implementation of the UNO API interface
(SheetSortDescriptor2.idl).

Change-Id: I5b11a38f6cd0473714c4d57ee92889bfd7605e83
Reviewed-on: https://gerrit.libreoffice.org/52930Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I1c675ffbfd4737a6c618c2b4d548e27c1ec295b7
Reviewed-on: https://gerrit.libreoffice.org/53038Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  f4c54d3af32ca4c6d02afff71532dbf10147fd33

Include help2.js not help.js

Otherwise, causes a

  ReferenceError: getParameterByName is not defined

when loading

  <file:///.../instdir/help/index.html?swriter/.uno:HelpIndex?Language=en-US&System=UNIX&Version=6.1>

in the browser.

Change-Id: I13cdd36e44859a74c9a1b4e3b020fed2f56edda0
Reviewed-on: https://gerrit.libreoffice.org/53048Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I3072c7725d0769c0a4a1974664b1546ca3ee35ad
Reviewed-on: https://gerrit.libreoffice.org/53036Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Works fine with -O2 as far as I see. At least with current Xcode.

Change-Id: Id28e1bb905efffa3e3b548eb34f3455c8a021f63
Reviewed-on: https://gerrit.libreoffice.org/53041Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I60cb9bbc4c094cea909ecbe4365b37ae0d9a4f78
Reviewed-on: https://gerrit.libreoffice.org/53040Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3b6815b3ca7ec94021be9229ae320b86e86f5418
Reviewed-on: https://gerrit.libreoffice.org/53020Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3f04519ad3fe35bcaa040934547d5b206184efbd
Reviewed-on: https://gerrit.libreoffice.org/53039Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I4e6ace300ffc19c5586d1d0371a06fca36b81080
Reviewed-on: https://gerrit.libreoffice.org/52954Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: If89ec640901253121529c09aef4537c6b13cee1d
Reviewed-on: https://gerrit.libreoffice.org/52280Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

it's not adding anything useful, just hold the underlying SalBitmap
instead

Change-Id: I54852707b2f8af99283b9c882a428a8a7a11c4cf
Reviewed-on: https://gerrit.libreoffice.org/52955Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4a34890c1db282a0db4ce332e0221113dedcd3d2
Reviewed-on: https://gerrit.libreoffice.org/53034Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

and

coverity#1401334 Uncaught exception

Change-Id: Ib2fadd83068cc94c972f6312719081d5ac75d8ce

...so change it from 'const bool*' to just 'bool'

Change-Id: Ibc36058f2faab565162cd05f6e798ecaae094dc1
Reviewed-on: https://gerrit.libreoffice.org/52990Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>