Skip to content

C
core
Kaydet (Commit) fad7d441 authored tarafından Noel Grandin's avatar Noel Grandin
Dosyalara gözat
Seçenekler

clang-tidy performance-unnecessary-value-param in drawinglayer 

Change-Id: I59d65ba81afab41e781f9dea5339a01d7918c51c
üst f3120c0a
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 36 additions and 36 deletions
drawinglayer/source/dumper/EnhancedShapeDumper.cxx
Dosyayı görüntüle @ fad7d441
......@@ -17,7 +17,7 @@ using namespace com::sun::star;
// ---------- EnhancedCustomShapeExtrusion.idl ----------
void EnhancedShapeDumper::dumpEnhancedCustomShapeExtrusionService(uno::Reference< beans::XPropertySet > xPropSet)
void EnhancedShapeDumper::dumpEnhancedCustomShapeExtrusionService(const uno::Reference< beans::XPropertySet >& xPropSet)
{
{
uno::Any anotherAny = xPropSet->getPropertyValue("Extrusion");
......@@ -185,7 +185,7 @@ void EnhancedShapeDumper::dumpEnhancedCustomShapeParameterPair(drawing::Enhanced
}
}
void EnhancedShapeDumper::dumpDepthAsElement(drawing::EnhancedCustomShapeParameterPair aDepth)
void EnhancedShapeDumper::dumpDepthAsElement(const drawing::EnhancedCustomShapeParameterPair& aDepth)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "Depth" ));
dumpEnhancedCustomShapeParameterPair(aDepth);
......@@ -286,7 +286,7 @@ void EnhancedShapeDumper::dumpShadeModeAsAttribute(drawing::ShadeMode eShadeMode
}
}
void EnhancedShapeDumper::dumpRotateAngleAsElement(drawing::EnhancedCustomShapeParameterPair aRotateAngle)
void EnhancedShapeDumper::dumpRotateAngleAsElement(const drawing::EnhancedCustomShapeParameterPair& aRotateAngle)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "RotateAngle" ));
dumpEnhancedCustomShapeParameterPair(aRotateAngle);
......@@ -305,7 +305,7 @@ void EnhancedShapeDumper::dumpShininessAsAttribute(double aShininess)
xmlTextWriterWriteFormatAttribute( xmlWriter, BAD_CAST("shininess"), "%f", aShininess);
}
void EnhancedShapeDumper::dumpSkewAsElement(drawing::EnhancedCustomShapeParameterPair aSkew)
void EnhancedShapeDumper::dumpSkewAsElement(const drawing::EnhancedCustomShapeParameterPair& aSkew)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "Skew" ));
dumpEnhancedCustomShapeParameterPair(aSkew);
......@@ -341,7 +341,7 @@ void EnhancedShapeDumper::dumpViewPointAsElement(drawing::Position3D aViewPoint)
xmlTextWriterEndElement( xmlWriter );
}
void EnhancedShapeDumper::dumpOriginAsElement(drawing::EnhancedCustomShapeParameterPair aOrigin)
void EnhancedShapeDumper::dumpOriginAsElement(const drawing::EnhancedCustomShapeParameterPair& aOrigin)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "Origin" ));
dumpEnhancedCustomShapeParameterPair(aOrigin);
......@@ -360,7 +360,7 @@ void EnhancedShapeDumper::dumpExtrusionColorAsAttribute(bool bExtrusionColor)
// ---------- EnhancedCustomShapeGeometry.idl -----------
void EnhancedShapeDumper::dumpEnhancedCustomShapeGeometryService(uno::Reference< beans::XPropertySet > xPropSet)
void EnhancedShapeDumper::dumpEnhancedCustomShapeGeometryService(const uno::Reference< beans::XPropertySet >& xPropSet)
{
{
uno::Any anotherAny = xPropSet->getPropertyValue("Type");
......@@ -617,7 +617,7 @@ void EnhancedShapeDumper::dumpHandlesAsElement(const uno::Sequence< beans::Prope
// ---------- EnhancedCustomShapeHandle.idl -----------
void EnhancedShapeDumper::dumpEnhancedCustomShapeHandleService(uno::Reference< beans::XPropertySet > xPropSet)
void EnhancedShapeDumper::dumpEnhancedCustomShapeHandleService(const uno::Reference< beans::XPropertySet >& xPropSet)
{
{
uno::Any anotherAny = xPropSet->getPropertyValue("MirroredX");
......@@ -719,14 +719,14 @@ void EnhancedShapeDumper::dumpSwitchedAsAttribute(bool bSwitched)
xmlTextWriterWriteFormatAttribute( xmlWriter, BAD_CAST("switched"), "%s", "false");
}
void EnhancedShapeDumper::dumpPositionAsElement(drawing::EnhancedCustomShapeParameterPair aPosition)
void EnhancedShapeDumper::dumpPositionAsElement(const drawing::EnhancedCustomShapeParameterPair& aPosition)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "Position" ));
dumpEnhancedCustomShapeParameterPair(aPosition);
xmlTextWriterEndElement( xmlWriter );
}
void EnhancedShapeDumper::dumpPolarAsElement(drawing::EnhancedCustomShapeParameterPair aPolar)
void EnhancedShapeDumper::dumpPolarAsElement(const drawing::EnhancedCustomShapeParameterPair& aPolar)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "Polar" ));
dumpEnhancedCustomShapeParameterPair(aPolar);
......@@ -781,42 +781,42 @@ void EnhancedShapeDumper::dumpEnhancedCustomShapeParameter(drawing::EnhancedCust
xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST("type"), "%" SAL_PRIdINT32, aType);
}
void EnhancedShapeDumper::dumpRangeXMinimumAsElement(drawing::EnhancedCustomShapeParameter aRangeXMinimum)
void EnhancedShapeDumper::dumpRangeXMinimumAsElement(const drawing::EnhancedCustomShapeParameter& aRangeXMinimum)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "RangeXMinimum" ));
dumpEnhancedCustomShapeParameter(aRangeXMinimum);
xmlTextWriterEndElement( xmlWriter );
}
void EnhancedShapeDumper::dumpRangeXMaximumAsElement(drawing::EnhancedCustomShapeParameter aRangeXMaximum)
void EnhancedShapeDumper::dumpRangeXMaximumAsElement(const drawing::EnhancedCustomShapeParameter& aRangeXMaximum)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "RangeXMaximum" ));
dumpEnhancedCustomShapeParameter(aRangeXMaximum);
xmlTextWriterEndElement( xmlWriter );
}
void EnhancedShapeDumper::dumpRangeYMinimumAsElement(drawing::EnhancedCustomShapeParameter aRangeYMinimum)
void EnhancedShapeDumper::dumpRangeYMinimumAsElement(const drawing::EnhancedCustomShapeParameter& aRangeYMinimum)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "RangeYMinimum" ));
dumpEnhancedCustomShapeParameter(aRangeYMinimum);
xmlTextWriterEndElement( xmlWriter );
}
void EnhancedShapeDumper::dumpRangeYMaximumAsElement(drawing::EnhancedCustomShapeParameter aRangeYMaximum)
void EnhancedShapeDumper::dumpRangeYMaximumAsElement(const drawing::EnhancedCustomShapeParameter& aRangeYMaximum)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "RangeYMaximum" ));
dumpEnhancedCustomShapeParameter(aRangeYMaximum);
xmlTextWriterEndElement( xmlWriter );
}
void EnhancedShapeDumper::dumpRadiusRangeMinimumAsElement(drawing::EnhancedCustomShapeParameter aRadiusRangeMinimum)
void EnhancedShapeDumper::dumpRadiusRangeMinimumAsElement(const drawing::EnhancedCustomShapeParameter& aRadiusRangeMinimum)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "RadiusRangeMinimum" ));
dumpEnhancedCustomShapeParameter(aRadiusRangeMinimum);
xmlTextWriterEndElement( xmlWriter );
}
void EnhancedShapeDumper::dumpRadiusRangeMaximumAsElement(drawing::EnhancedCustomShapeParameter aRadiusRangeMaximum)
void EnhancedShapeDumper::dumpRadiusRangeMaximumAsElement(const drawing::EnhancedCustomShapeParameter& aRadiusRangeMaximum)
{
xmlTextWriterStartElement(xmlWriter, BAD_CAST( "RadiusRangeMaximum" ));
dumpEnhancedCustomShapeParameter(aRadiusRangeMaximum);
......@@ -827,7 +827,7 @@ void EnhancedShapeDumper::dumpRadiusRangeMaximumAsElement(drawing::EnhancedCusto
// ---------- EnhancedCustomShapePath.idl ---------------
void EnhancedShapeDumper::dumpEnhancedCustomShapePathService(uno::Reference< beans::XPropertySet > xPropSet)
void EnhancedShapeDumper::dumpEnhancedCustomShapePathService(const uno::Reference< beans::XPropertySet >& xPropSet)
{
{
uno::Any anotherAny = xPropSet->getPropertyValue("Coordinates");
......@@ -1034,7 +1034,7 @@ void EnhancedShapeDumper::dumpSubViewSizeAsElement(const uno::Sequence< awt::Siz
// ---------- EnhancedCustomShapeTextPath.idl ---------------
void EnhancedShapeDumper::dumpEnhancedCustomShapeTextPathService(uno::Reference< beans::XPropertySet > xPropSet)
void EnhancedShapeDumper::dumpEnhancedCustomShapeTextPathService(const uno::Reference< beans::XPropertySet >& xPropSet)
{
{
uno::Any anotherAny = xPropSet->getPropertyValue("TextPath");
......
drawinglayer/source/dumper/EnhancedShapeDumper.hxx
Dosyayı görüntüle @ fad7d441
......@@ -45,10 +45,10 @@ public:
void dumpEnhancedCustomShapeParameter(css::drawing::EnhancedCustomShapeParameter aParameter);
// EnhancedCustomShapeExtrusion.idl
void dumpEnhancedCustomShapeExtrusionService(css::uno::Reference< css::beans::XPropertySet > xPropSet);
void dumpEnhancedCustomShapeExtrusionService(const css::uno::Reference< css::beans::XPropertySet >& xPropSet);
void dumpExtrusionAsAttribute(bool bExtrusion);
void dumpBrightnessAsAttribute(double aBrightness);
void dumpDepthAsElement(css::drawing::EnhancedCustomShapeParameterPair aDepth);
void dumpDepthAsElement(const css::drawing::EnhancedCustomShapeParameterPair& aDepth);
void dumpDiffusionAsAttribute(double aDiffusion);
void dumpNumberOfLineSegmentsAsAttribute(sal_Int32 aNumberOfLineSegments);
void dumpLightFaceAsAttribute(bool bLightFace);
......@@ -60,18 +60,18 @@ public:
void dumpSecondLightDirectionAsElement(css::drawing::Direction3D aSecondLightDirection);
void dumpMetalAsAttribute(bool bMetal);
void dumpShadeModeAsAttribute(css::drawing::ShadeMode eShadeMode);
void dumpRotateAngleAsElement(css::drawing::EnhancedCustomShapeParameterPair aRotateAngle);
void dumpRotateAngleAsElement(const css::drawing::EnhancedCustomShapeParameterPair& aRotateAngle);
void dumpRotationCenterAsElement(css::drawing::Direction3D aRotationCenter);
void dumpShininessAsAttribute(double aShininess);
void dumpSkewAsElement(css::drawing::EnhancedCustomShapeParameterPair aSkew);
void dumpSkewAsElement(const css::drawing::EnhancedCustomShapeParameterPair& aSkew);
void dumpSpecularityAsAttribute(double aSpecularity);
void dumpProjectionModeAsAttribute(css::drawing::ProjectionMode eProjectionMode);
void dumpViewPointAsElement(css::drawing::Position3D aViewPoint);
void dumpOriginAsElement(css::drawing::EnhancedCustomShapeParameterPair aOrigin);
void dumpOriginAsElement(const css::drawing::EnhancedCustomShapeParameterPair& aOrigin);
void dumpExtrusionColorAsAttribute(bool bExtrusionColor);
// EnhancedCustomShapeGeometry.idl
void dumpEnhancedCustomShapeGeometryService(css::uno::Reference< css::beans::XPropertySet > xPropSet);
void dumpEnhancedCustomShapeGeometryService(const css::uno::Reference< css::beans::XPropertySet >& xPropSet);
void dumpTypeAsAttribute(const OUString& sType);
void dumpViewBoxAsElement(css::awt::Rectangle aViewBox);
void dumpMirroredXAsAttribute(bool bMirroredX); // also used in EnhancedCustomShapeHandle
......@@ -85,23 +85,23 @@ public:
void dumpHandlesAsElement(const css::uno::Sequence< css::beans::PropertyValues >& aHandles);
// EnhancedCustomShapeHandle.idl
void dumpEnhancedCustomShapeHandleService(css::uno::Reference< css::beans::XPropertySet > xPropSet);
void dumpEnhancedCustomShapeHandleService(const css::uno::Reference< css::beans::XPropertySet >& xPropSet);
void dumpSwitchedAsAttribute(bool bSwitched);
void dumpPositionAsElement(css::drawing::EnhancedCustomShapeParameterPair aPosition);
void dumpPolarAsElement(css::drawing::EnhancedCustomShapeParameterPair aPolar);
void dumpPositionAsElement(const css::drawing::EnhancedCustomShapeParameterPair& aPosition);
void dumpPolarAsElement(const css::drawing::EnhancedCustomShapeParameterPair& aPolar);
void dumpRefXAsAttribute(sal_Int32 aRefX);
void dumpRefYAsAttribute(sal_Int32 aRefY);
void dumpRefAngleAsAttribute(sal_Int32 aRefAngle);
void dumpRefRAsAttribute(sal_Int32 aRefR);
void dumpRangeXMinimumAsElement(css::drawing::EnhancedCustomShapeParameter aRangeXMinimum);
void dumpRangeXMaximumAsElement(css::drawing::EnhancedCustomShapeParameter aRangeXMaximum);
void dumpRangeYMinimumAsElement(css::drawing::EnhancedCustomShapeParameter aRangeYMinimum);
void dumpRangeYMaximumAsElement(css::drawing::EnhancedCustomShapeParameter aRangeXMaximum);
void dumpRadiusRangeMinimumAsElement(css::drawing::EnhancedCustomShapeParameter aRadiusRangeMinimum);
void dumpRadiusRangeMaximumAsElement(css::drawing::EnhancedCustomShapeParameter aRadiusRangeMaximum);
void dumpRangeXMinimumAsElement(const css::drawing::EnhancedCustomShapeParameter& aRangeXMinimum);
void dumpRangeXMaximumAsElement(const css::drawing::EnhancedCustomShapeParameter& aRangeXMaximum);
void dumpRangeYMinimumAsElement(const css::drawing::EnhancedCustomShapeParameter& aRangeYMinimum);
void dumpRangeYMaximumAsElement(const css::drawing::EnhancedCustomShapeParameter& aRangeXMaximum);
void dumpRadiusRangeMinimumAsElement(const css::drawing::EnhancedCustomShapeParameter& aRadiusRangeMinimum);
void dumpRadiusRangeMaximumAsElement(const css::drawing::EnhancedCustomShapeParameter& aRadiusRangeMaximum);
// EnhancedCustomShapePath.idl
void dumpEnhancedCustomShapePathService(css::uno::Reference< css::beans::XPropertySet > xPropSet);
void dumpEnhancedCustomShapePathService(const css::uno::Reference< css::beans::XPropertySet >& xPropSet);
void dumpCoordinatesAsElement(const css::uno::Sequence< css::drawing::EnhancedCustomShapeParameterPair >& aCoordinates);
void dumpSegmentsAsElement(const css::uno::Sequence< css::drawing::EnhancedCustomShapeSegment >& aSegments);
void dumpStretchXAsAttribute(sal_Int32 aStretchX);
......@@ -116,7 +116,7 @@ public:
void dumpSubViewSizeAsElement(const css::uno::Sequence< css::awt::Size >& aSubViewSize);
// EnhancedCustomShapePath.idl
void dumpEnhancedCustomShapeTextPathService(css::uno::Reference< css::beans::XPropertySet > xPropSet);
void dumpEnhancedCustomShapeTextPathService(const css::uno::Reference< css::beans::XPropertySet >& xPropSet);
void dumpTextPathAsAttribute(bool bTextPath);
void dumpTextPathModeAsAttribute(css::drawing::EnhancedCustomShapeTextPathMode eTextPathMode);
void dumpScaleXAsAttribute(bool bScaleX);
......
include/drawinglayer/XShapeDumper.hxx
Dosyayı görüntüle @ fad7d441
......@@ -46,8 +46,8 @@ class DRAWINGLAYER_DLLPUBLIC XShapeDumper
public:
XShapeDumper();
static OUString dump(css::uno::Reference<css::drawing::XShapes> xPageShapes, bool bDumpInteropProperties=false);
static OUString dump(css::uno::Reference<css::drawing::XShape> xPageShapes, bool bDumpInteropProperties=false);
static OUString dump(const css::uno::Reference<css::drawing::XShapes>& xPageShapes, bool bDumpInteropProperties=false);
static OUString dump(const css::uno::Reference<css::drawing::XShape>& xPageShapes, bool bDumpInteropProperties=false);
};
#endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment