Skip to content

C
core
Kaydet (Commit) f9fa180e authored tarafından Miklos Vajna's avatar Miklos Vajna
Dosyalara gözat
Seçenekler

logerrit: --code-review=2 in review implies --submit 

Change-Id: Ibd21dfdb76536ea0e0a71791a91ec87e31d49960
üst 28f04b0a
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 1 deletion
logerrit
Dosyayı görüntüle @ f9fa180e
...@@ -146,6 +146,7 @@ case "$1" in ...@@ -146,6 +146,7 @@ case "$1" in
esac esac
read -p 'is the code looking good (+), bad (-) or none of that ()? ' CODEREVIEW read -p 'is the code looking good (+), bad (-) or none of that ()? ' CODEREVIEW
ask_tristate $CODEREVIEW ask_tristate $CODEREVIEW
SUBMITFLAG=""
case "$ANSWER" in case "$ANSWER" in
"y") "y")
read -p 'do you approve the change (+) too, or prefer someone else to do that ()? ' CODEREVIEW read -p 'do you approve the change (+) too, or prefer someone else to do that ()? ' CODEREVIEW
...@@ -153,6 +154,7 @@ case "$1" in ...@@ -153,6 +154,7 @@ case "$1" in
case "$ANSWER" in case "$ANSWER" in
"y") "y")
CODEREVIEWFLAG="--code-review=2" CODEREVIEWFLAG="--code-review=2"
SUBMITFLAG="--submit"
;; ;;
"n") "n")
CODEREVIEWFLAG="--code-review=1" CODEREVIEWFLAG="--code-review=1"
...@@ -185,7 +187,7 @@ case "$1" in ...@@ -185,7 +187,7 @@ case "$1" in
esac esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
get_REVISION_for_change $CHANGEID get_REVISION_for_change $CHANGEID
ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $REVISION ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SUBMITFLAG $REVISION
;; ;;
checkout) checkout)
get_SHA_for_change $2 get_SHA_for_change $2
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment