loplugin:unnecessaryvirtual in basctl..chart2

Change-Id: Id4eeb12792c3a66b68a907cb459ab437e3d64e4c
Reviewed-on: https://gerrit.libreoffice.org/30680Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

basctl/source/basicide/moduldl2.cxx

@@ -92,7 +92,7 @@ public:
 };
 
 // LibUserData
-class LibUserData
+class LibUserData final
 {
 private:
     ScriptDocument m_aDocument;
@@ -102,7 +102,7 @@ public:
         : m_aDocument(rDocument)
     {
     }
-    virtual ~LibUserData() {};
+    ~LibUserData() {};
 
     const ScriptDocument& GetDocument() const { return m_aDocument; }
 };

chart2/source/controller/chartapiwrapper/Chart2ModelContact.hxx

@@ -43,11 +43,11 @@ class ChartModel;
 namespace wrapper
 {
 
-class Chart2ModelContact
+class Chart2ModelContact final
 {
 public:
     explicit Chart2ModelContact( const css::uno::Reference< css::uno::XComponentContext >& xContext );
-    virtual ~Chart2ModelContact();
+    ~Chart2ModelContact();
 
 public:
     void setModel( const css::uno::Reference< css::frame::XModel >& xChartModel );

chart2/source/controller/dialogs/DataBrowserModel.hxx

@@ -35,13 +35,13 @@ namespace chart
 
 class DialogModel;
 
-class DataBrowserModel
+class DataBrowserModel final
 {
 public:
     explicit DataBrowserModel(
         const css::uno::Reference< css::chart2::XChartDocument > & xChartDoc,
         const css::uno::Reference< css::uno::XComponentContext > & xContext );
-    virtual ~DataBrowserModel();
+    ~DataBrowserModel();
 
     /** Inserts a new data series after the data series to which the data column
         with index nAfterColumnIndex belongs.

chart2/source/controller/dialogs/res_DataLabel.hxx

@@ -31,11 +31,11 @@ class SvNumberFormatter;
 namespace chart
 {
 
-class DataLabelResources
+class DataLabelResources final
 {
 public:
     DataLabelResources( VclBuilderContainer* pWindow, vcl::Window* pParent, const SfxItemSet& rInAttrs );
-    virtual ~DataLabelResources();
+    ~DataLabelResources();
 
     bool FillItemSet(SfxItemSet* rOutAttrs) const;
     void Reset(const SfxItemSet& rInAttrs);

chart2/source/controller/dialogs/res_Trendline.hxx

@@ -31,11 +31,11 @@
 namespace chart
 {
 
-class TrendlineResources
+class TrendlineResources final
 {
 public:
     TrendlineResources( vcl::Window* pParent, const SfxItemSet& rInAttrs );
-    virtual ~TrendlineResources();
+    ~TrendlineResources();
 
     void Reset(const SfxItemSet& rInAttrs);
     bool FillItemSet(SfxItemSet* rOutAttrs) const;

chart2/source/controller/inc/ChartController.hxx

@@ -408,14 +408,14 @@ private:
             //each controller might consider himself as owner of the model first
             bool m_bOwnership;
     };
-    class TheModelRef
+    class TheModelRef final
     {
         public:
             TheModelRef( TheModel* pTheModel, ::osl::Mutex& rMutex );
             TheModelRef( const TheModelRef& rTheModel, ::osl::Mutex& rMutex );
             TheModelRef& operator=(ChartController::TheModel* pTheModel);
             TheModelRef& operator=(const TheModelRef& rTheModel);
-            virtual ~TheModelRef();
+            ~TheModelRef();
             bool is() const;
                 TheModel* operator->() const { return m_pTheModel; }
         private:

chart2/source/controller/inc/TimerTriggeredControllerLock.hxx

@@ -28,11 +28,11 @@
 namespace chart
 {
 
-class TimerTriggeredControllerLock
+class TimerTriggeredControllerLock final
 {
 public:
     TimerTriggeredControllerLock( const css::uno::Reference< css::frame::XModel >& xModel );
-    virtual ~TimerTriggeredControllerLock();
+    ~TimerTriggeredControllerLock();
 
     void startTimer();
 

chart2/source/controller/inc/ViewElementListProvider.hxx

@@ -29,11 +29,11 @@ namespace chart
 
 class DrawModelWrapper;
 
-class ViewElementListProvider
+class ViewElementListProvider final
 {
 public:
     ViewElementListProvider( DrawModelWrapper* pDrawModelWrapper );
-    virtual ~ViewElementListProvider();
+    ~ViewElementListProvider();
 
     XColorListRef     GetColorTable() const;
     XDashListRef      GetDashList() const;

chart2/source/controller/inc/dlg_ObjectProperties.hxx

@@ -27,11 +27,11 @@
 namespace chart
 {
 
-class ObjectPropertiesDialogParameter
+class ObjectPropertiesDialogParameter final
 {
 public:
     ObjectPropertiesDialogParameter( const OUString& rObjectCID );
-    virtual ~ObjectPropertiesDialogParameter();
+    ~ObjectPropertiesDialogParameter();
 
     void            init( const css::uno::Reference< css::frame::XModel >& xModel );
     ObjectType      getObjectType() const { return m_eObjectType;}

chart2/source/controller/inc/res_LegendPosition.hxx

@@ -29,7 +29,7 @@
 namespace chart
 {
 
-class LegendPositionResources
+class LegendPositionResources final
 {
 
 public:
@@ -38,7 +38,7 @@ public:
     //constructor inclusive Display checkbox
     LegendPositionResources(VclBuilderContainer& rParent, const css::uno::Reference<
                        css::uno::XComponentContext>& xCC );
-    virtual ~LegendPositionResources();
+    ~LegendPositionResources();
 
     void writeToResources( const css::uno::Reference< css::frame::XModel >& xChartModel );
     void writeToModel( const css::uno::Reference< css::frame::XModel >& xChartModel ) const;

chart2/source/controller/inc/res_Titles.hxx

@@ -26,11 +26,11 @@
 namespace chart
 {
 
-class TitleResources
+class TitleResources final
 {
 public:
     TitleResources(VclBuilderContainer& rParent, bool bShowSecondaryAxesTitle);
-    virtual ~TitleResources();
+    ~TitleResources();
 
     void writeToResources( const TitleDialogData& rInput );
     void readFromResources( TitleDialogData& rOutput );

chart2/source/inc/ExplicitCategoriesProvider.hxx

@@ -47,13 +47,13 @@ public:
     virtual css::uno::Sequence< OUString > getStringsForLevel( sal_Int32 nIndex ) const = 0;
 };
 
-class OOO_DLLPUBLIC_CHARTTOOLS ExplicitCategoriesProvider
+class OOO_DLLPUBLIC_CHARTTOOLS ExplicitCategoriesProvider final
 {
 public:
     ExplicitCategoriesProvider( const css::uno::Reference< css::chart2::XCoordinateSystem >& xCooSysModel
                        , ChartModel& rChartModel
                        );
-    virtual ~ExplicitCategoriesProvider();
+    ~ExplicitCategoriesProvider();
 
     void init();
 

chart2/source/inc/NumberFormatterWrapper.hxx

@@ -26,15 +26,13 @@
 namespace chart
 {
 
-/**
-*/
 class FixedNumberFormatter;
 
-class OOO_DLLPUBLIC_CHARTTOOLS NumberFormatterWrapper
+class OOO_DLLPUBLIC_CHARTTOOLS NumberFormatterWrapper final
 {
 public:
     NumberFormatterWrapper( const css::uno::Reference< css::util::XNumberFormatsSupplier >& xSupplier );
-    virtual ~NumberFormatterWrapper();
+    ~NumberFormatterWrapper();
 
     SvNumberFormatter* getSvNumberFormatter() const { return m_pNumberFormatter;}
     const css::uno::Reference< css::util::XNumberFormatsSupplier >&
@@ -51,12 +49,12 @@ private: //private member
     css::uno::Any m_aNullDate;
 };
 
-class OOO_DLLPUBLIC_CHARTTOOLS FixedNumberFormatter
+class OOO_DLLPUBLIC_CHARTTOOLS FixedNumberFormatter final
 {
 public:
     FixedNumberFormatter( const css::uno::Reference< css::util::XNumberFormatsSupplier >& xSupplier
         , sal_Int32 nNumberFormatKey );
-    virtual ~FixedNumberFormatter();
+    ~FixedNumberFormatter();
 
     OUString getFormattedString( double fValue, sal_Int32& rLabelColor, bool& rbColorChanged ) const;
 

chart2/source/inc/TrueGuard.hxx

@@ -25,11 +25,11 @@ namespace chart
 {
 /** This guard sets the given boolean reference to true in the constructor and to false in the destructor
  */
-class OOO_DLLPUBLIC_CHARTTOOLS TrueGuard
+class OOO_DLLPUBLIC_CHARTTOOLS TrueGuard final
 {
 public:
     explicit TrueGuard( bool& rbTrueDuringGuardedTime );
-    virtual ~TrueGuard();
+    ~TrueGuard();
 
 private:
     bool& m_rbTrueDuringGuardedTime;

chart2/source/view/inc/VDiagram.hxx

@@ -36,13 +36,13 @@ The axes and data series are subobjects which are created and managed by the
 diagram.
 */
 
-class VDiagram
+class VDiagram final
 {
 public: //methods
     VDiagram( const css::uno::Reference<css::chart2::XDiagram>& xDiagram,
               const css::drawing::Direction3D& rPreferredAspectRatio,
               sal_Int32 nDimension = 3 );
-    virtual ~VDiagram();
+    ~VDiagram();
 
     void init(
         const css::uno::Reference<css::drawing::XShapes>& xTarget,

chart2/source/view/main/VTitle.hxx

@@ -26,14 +26,11 @@
 namespace chart
 {
 
-/**
-*/
-
-class VTitle
+class VTitle final
 {
 public:
     explicit VTitle( const css::uno::Reference< css::chart2::XTitle > & xTitle );
-    virtual ~VTitle();
+    ~VTitle();
 
     void    init( const css::uno::Reference< css::drawing::XShapes >& xTargetPage
              , const css::uno::Reference< css::lang::XMultiServiceFactory >& xFactory

include/basic/codecompletecache.hxx

@@ -70,7 +70,7 @@ public:
     static void SetAutoCorrectOn( bool b );
 };
 
-class BASIC_DLLPUBLIC CodeCompleteDataCache
+class BASIC_DLLPUBLIC CodeCompleteDataCache final
 {
 /*
  * cache to store data for
@@ -82,7 +82,7 @@ private:
 
 public:
     CodeCompleteDataCache(){}
-    virtual ~CodeCompleteDataCache(){}
+    ~CodeCompleteDataCache(){}
 
     friend BASIC_DLLPUBLIC std::ostream& operator<< (std::ostream& aStream, const CodeCompleteDataCache& aCache);
 

include/codemaker/global.hxx

@@ -37,11 +37,11 @@ typedef ::std::set< ::rtl::OString >    StringSet;
 
 // FileStream
 
-class FileStream
+class FileStream final
 {
 public:
     FileStream();
-    virtual ~FileStream();
+    ~FileStream();
 
     bool isValid();
 
@@ -84,11 +84,11 @@ bool removeTypeFile(const ::rtl::OString& fileName);
 
 ::rtl::OUString convertToFileUrl(const ::rtl::OString& fileName);
 
-class CannotDumpException {
+class CannotDumpException final {
 public:
     CannotDumpException(OUString const & message): message_(message) {}
 
-    virtual ~CannotDumpException() throw ();
+    ~CannotDumpException() throw ();
 
     const OUString& getMessage() const { return message_; }