loplugin:passstuffbyref improved return in xmlhelp,slideshow

Change-Id: I57e235ecec733f1b5dd03f95f4e022769a369ae2
Reviewed-on: https://gerrit.libreoffice.org/47165Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

basegfx/source/polygon/b3dpolygon.cxx

@@ -1548,7 +1548,7 @@ namespace basegfx
             mpPolygon->clearBColors();
     }
 
-    B3DVector B3DPolygon::getNormal() const
+    B3DVector const & B3DPolygon::getNormal() const
     {
         return mpPolygon->getNormal();
     }

include/basegfx/polygon/b3dpolygon.hxx

@@ -79,7 +79,7 @@ namespace basegfx
         void clearBColors();
 
         // Normals interface
-        B3DVector getNormal() const; // plane normal
+        B3DVector const & getNormal() const; // plane normal
         B3DVector getNormal(sal_uInt32 nIndex) const; // normal in each point
         void setNormal(sal_uInt32 nIndex, const B3DVector& rValue);
         void transformNormals(const B3DHomMatrix& rMatrix);

slideshow/source/engine/animationnodes/animationbasenode.cxx

@@ -465,7 +465,7 @@ AnimationBaseNode::fillCommonParameters() const
         getSlideSize());
 }
 
-AttributableShapeSharedPtr AnimationBaseNode::getShape() const
+AttributableShapeSharedPtr const & AnimationBaseNode::getShape() const
 {
     // any subsetting at all?
     if (mpShapeSubset)

slideshow/source/engine/animationnodes/animationbasenode.hxx

@@ -56,7 +56,7 @@ protected:
     /// Create parameter struct for ActivitiesFactory
     ActivitiesFactory::CommonParameters fillCommonParameters() const;
     ::basegfx::B2DVector const&         getSlideSize() const { return maSlideSize; }
-    AttributableShapeSharedPtr          getShape() const;
+    AttributableShapeSharedPtr const &  getShape() const;
 
 private:
     virtual bool hasPendingAnimation() const override;

slideshow/source/engine/opengl/TransitionerImpl.cxx

@@ -808,7 +808,7 @@ namespace
         }
     };
 
-    uno::Reference<rendering::XIntegerBitmapColorSpace>
+    uno::Reference<rendering::XIntegerBitmapColorSpace> const &
     getOGLColorSpace()
     {
         return OGLColorSpaceHolder::get();

slideshow/source/engine/slide/userpaintoverlay.cxx

@@ -468,7 +468,7 @@ namespace slideshow
             mrMultiplexer.addUserPaintHandler(mpHandler);
         }
 
-        PolyPolygonVector UserPaintOverlay::getPolygons()
+        PolyPolygonVector const & UserPaintOverlay::getPolygons()
         {
             return mpHandler->getPolygons();
         }

slideshow/source/engine/slide/userpaintoverlay.hxx

@@ -65,7 +65,7 @@ namespace slideshow
             ~UserPaintOverlay();
             UserPaintOverlay(const UserPaintOverlay&) = delete;
             UserPaintOverlay& operator=(const UserPaintOverlay&) = delete;
-            PolyPolygonVector getPolygons();
+            PolyPolygonVector const & getPolygons();
             void drawPolygons();
 
         private:

slideshow/source/engine/smilfunctionparser.cxx

@@ -525,7 +525,7 @@ namespace slideshow
             }
         }
 
-        std::shared_ptr<ExpressionNode> SmilFunctionParser::parseSmilValue( const OUString&          rSmilValue,
+        std::shared_ptr<ExpressionNode> const & SmilFunctionParser::parseSmilValue( const OUString&          rSmilValue,
                                                                     const ::basegfx::B2DRectangle&  rRelativeShapeBounds )
         {
             // TODO(Q1): Check if a combination of the RTL_UNICODETOTEXT_FLAGS_*
@@ -570,7 +570,7 @@ namespace slideshow
             return pContext->maOperandStack.top();
         }
 
-        std::shared_ptr<ExpressionNode> SmilFunctionParser::parseSmilFunction( const OUString&           rSmilFunction,
+        std::shared_ptr<ExpressionNode> const & SmilFunctionParser::parseSmilFunction( const OUString&           rSmilFunction,
                                                                        const ::basegfx::B2DRectangle&   rRelativeShapeBounds )
         {
             // TODO(Q1): Check if a combination of the RTL_UNICODETOTEXT_FLAGS_*

slideshow/source/inc/smilfunctionparser.hxx

@@ -95,7 +95,7 @@ namespace slideshow
 
                 @return the generated function object.
              */
-            static std::shared_ptr<ExpressionNode> parseSmilValue( const OUString&           rSmilValue,
+            static std::shared_ptr<ExpressionNode> const & parseSmilValue( const OUString&           rSmilValue,
                                                            const ::basegfx::B2DRectangle&   rRelativeShapeBounds ); // throw ParseError
 
             /** Parse a string containing a SMIL function.
@@ -143,7 +143,7 @@ namespace slideshow
 
                 @return the generated function object.
              */
-            static std::shared_ptr<ExpressionNode> parseSmilFunction( const OUString&            rSmilFunction,
+            static std::shared_ptr<ExpressionNode> const & parseSmilFunction( const OUString&            rSmilFunction,
                                                               const ::basegfx::B2DRectangle&    rRelativeShapeBounds ); // throw ParseError
 
         };

xmlhelp/source/cxxhelp/provider/urlparameter.cxx

@@ -198,7 +198,7 @@ OUString URLParameter::get_the_tag()
 }
 
 
-OUString URLParameter::get_path()
+OUString const & URLParameter::get_path()
 {
     if(m_bUseDB) {
         if( ! m_bHelpDataFileRead )

xmlhelp/source/cxxhelp/provider/urlparameter.hxx

@@ -124,7 +124,7 @@ namespace chelp {
 
         //  Not called for an directory
 
-        OUString get_path();
+        OUString const & get_path();
 
         const OUString& get_eid() const   { return m_aEid; }