Kaydet (Commit) e1bd0dd9 authored tarafından Caolán McNamara's avatar Caolán McNamara

tdf#114342 move recursion guard to encompass threaded path too

Change-Id: If815d3faeb72fd8a176225fb80f87ee584ece3ba
Reviewed-on: https://gerrit.libreoffice.org/46195Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarDennis Francis <dennis.francis@collabora.co.uk>
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst adad3724
......@@ -4342,6 +4342,12 @@ bool ScFormulaCell::InterpretFormulaGroup()
return false;
}
// Guard against endless recursion of Interpret() calls, for this to work
// ScFormulaCell::InterpretFormulaGroup() must never be called through
// anything else than ScFormulaCell::Interpret(), same as
// ScFormulaCell::InterpretTail()
RecursionCounter aRecursionCounter( pDocument->GetRecursionHelper(), this);
if (!bThreadingProhibited && !ScCalcConfig::isOpenCLEnabled() &&
pCode->GetVectorState() == FormulaVectorEnabledForThreading &&
officecfg::Office::Calc::Formula::Calculation::UseThreadedCalculationForFormulaGroups::get())
......@@ -4478,12 +4484,6 @@ bool ScFormulaCell::InterpretFormulaGroup()
return false;
}
// Guard against endless recursion of Interpret() calls, for this to work
// ScFormulaCell::InterpretFormulaGroup() must never be called through
// anything else than ScFormulaCell::Interpret(), same as
// ScFormulaCell::InterpretTail()
RecursionCounter aRecursionCounter( pDocument->GetRecursionHelper(), this);
// TODO : Disable invariant formula group interpretation for now in order
// to get implicit intersection to work.
if (mxGroup->mbInvariant && false)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment