Kaydet (Commit) dd20a8c6 authored tarafından Caolán McNamara's avatar Caolán McNamara

SvtFileDialogURLSelector::OpenURL can go apparently

üst fe630f3b
......@@ -164,14 +164,6 @@ SvtFileDialogURLSelector::~SvtFileDialogURLSelector()
delete m_pMenu;
}
//-----------------------------------------------------------------------------
void SvtFileDialogURLSelector::OpenURL( const String& rURL )
{
INetURLObject aObj( rURL );
DBG_ASSERT( aObj.GetProtocol() != INET_PROT_NOT_VALID, "SvtFileDialogURLSelector::OpenURL: Invalid URL!" );
m_pParent->OpenURL_Impl( aObj.GetMainURL( INetURLObject::NO_DECODE ) );
}
//-----------------------------------------------------------------------------
void SvtFileDialogURLSelector::Activate()
{
......
......@@ -100,7 +100,6 @@ protected:
inline SvtFileDialog* GetDialogParent() { return m_pParent; }
protected:
void OpenURL( const String& rURL );
virtual void FillURLMenu( PopupMenu* _pMenu ) = 0;
......
......@@ -28,7 +28,9 @@ d) gcc will only emit code for inlines if those inlines are used, so
e) if a constructor is listed as unused, and it's the *only* ctor in the class,
then no object of that class can be construsted, so the whole thing is
unused, which can lead to a whole cascade of tricky but logical fallout.
f) there's more actually unused code then what's listed. The idea is that what's
f) if a destructor is listed as unused, and a constructor isn't, then there's
a leak somewhere, and the destructor most likely *should* be called.
g) there's more actually unused code then what's listed. The idea is that what's
listed is definitely unused under the generation configuration, not that
it's a list of all unused code. If the count of unused easy hits 0 then
we can have a look at the non-easy and if that hits 0, then strip out
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment