Kaydet (Commit) ce03ae64 authored tarafından Kohei Yoshida's avatar Kohei Yoshida

Cleaned up ScDPSource and ScDPMember(s) a bit.

* boolean, string conversion.
* removing virtual keywords when it makes no sense.
* privatize methods that are called only from within.
* removed methods that are not used.
* etc.
üst e1bb54d7
This diff is collapsed.
......@@ -1048,9 +1048,9 @@ void ScDPResultMember::FillItemData( ScDPItemData& rData ) const
sal_Bool ScDPResultMember::IsNamedItem( SCROW nIndex ) const
{
//! store ScDPMember pointer instead of ScDPMember ???
const ScDPMember* pMemberDesc = GetDPMember();
const ScDPMember* pMemberDesc = GetDPMember();
if (pMemberDesc)
return ((ScDPMember*)pMemberDesc)->IsNamedItem( nIndex );
return pMemberDesc->IsNamedItem(nIndex);
return false;
}
......@@ -1242,8 +1242,8 @@ sal_Bool ScDPResultMember::IsValid() const
// non-Valid members are left out of calculation
// was member set no invisible at the DataPilotSource?
const ScDPMember* pMemberDesc =GetDPMember();
if ( pMemberDesc && !pMemberDesc->getIsVisible() )
const ScDPMember* pMemberDesc = GetDPMember();
if ( pMemberDesc && !pMemberDesc->isVisible() )
return false;
if ( bAutoHidden )
......
......@@ -113,7 +113,7 @@ IMPL_LINK( ScNoteMarker, TimeHdl, Timer*, EMPTYARG )
pModel->InsertPage( pPage );
}
bVisible = sal_True;
bVisible = true;
}
Draw();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment