loplugin:returnconstant in reportdesign

Change-Id: I3a198faad8f4dff607b1a7e1a06afda0225b4f9a
Reviewed-on: https://gerrit.libreoffice.org/58964
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

reportdesign/source/core/inc/conditionupdater.hxx

@@ -42,7 +42,7 @@ namespace rptui
 
     private:
         /// does late initializations, return whether or not successful
-        bool impl_lateInit_nothrow();
+        void impl_lateInit_nothrow();
 
         void impl_adjustFormatConditions_nothrow(
             const css::uno::Reference< css::report::XReportControlModel >& _rxRptControlModel,

reportdesign/source/core/misc/conditionupdater.cxx

@@ -52,8 +52,7 @@ namespace rptui
 
     void ConditionUpdater::notifyPropertyChange( const PropertyChangeEvent& _rEvent )
     {
-        if ( !impl_lateInit_nothrow() )
-            return;
+        impl_lateInit_nothrow();
 
         Reference< XReportControlModel > xRptControlModel( _rEvent.Source, UNO_QUERY );
         if ( xRptControlModel.is() && _rEvent.PropertyName == "DataField" )
@@ -66,13 +65,12 @@ namespace rptui
     }
 
 
-    bool ConditionUpdater::impl_lateInit_nothrow()
+    void ConditionUpdater::impl_lateInit_nothrow()
     {
         if ( !m_aConditionalExpressions.empty() )
-            return true;
+            return;
 
         ConditionalExpressionFactory::getKnownConditionalExpressions( m_aConditionalExpressions );
-        return true;
     }