loplugin:oncevar

Change-Id: If1f4f8136368349777c6fb616328cfa89efd9e0f

fpicker/source/aqua/FilterHelper.mm

@@ -304,9 +304,8 @@ void SAL_CALL FilterHelper::appendFilterGroup( const ::rtl::OUString& /* sGroupT
 
     // append the filter
     if (bPrependSeparator) {
-        rtl::OUString dash("-");
         OUStringList emptyList;
-        m_pFilterList->push_back(FilterEntry(dash, emptyList));
+        m_pFilterList->push_back(FilterEntry("-", emptyList));
     }
 
     const css::beans::StringPair* pSubFilters   = aFilters.getConstArray();
@@ -347,9 +346,8 @@ bool FilterHelper::filenameMatchesFilter(NSString* sFilename)
 
     {
         rtl::OUString aName = [sFilename OUString];
-        rtl::OUString allMatcher(".*");
         for(OUStringList::iterator iter = suffixList.begin(); iter != suffixList.end(); iter++) {
-            if (aName.matchIgnoreAsciiCase(*iter, aName.getLength() - (*iter).getLength()) || ((*iter).equals(allMatcher))) {
+            if (*iter == ".*" || aName.endsWithIgnoreAsciiCase(*iter)) {
                 return true;
             }
         }

fpicker/source/aqua/SalAquaFilePicker.mm

@@ -293,9 +293,7 @@ uno::Sequence<rtl::OUString> SAL_CALL SalAquaFilePicker::getSelectedFiles()
         }
 #endif
 
-        InfoType info = FULLPATH;
-
-        OUString sFileOrDirURL = [url OUStringForInfo:info];
+        OUString sFileOrDirURL = [url OUStringForInfo:FULLPATH];
 
         aSelectedFiles[nIndex] = sFileOrDirURL;
     }