scripting: Use appropriate OUString functions on string constants

Change-Id: Iacb434225e779de4911e9acc8431662f5eabcee3

scripting/source/basprov/basmethnode.cxx

@@ -44,7 +44,7 @@ using namespace ::sf_misc;
 #define BASPROV_PROPERTY_ID_EDITABLE    2
 
 #define BASPROV_PROPERTY_URI            OUString( "URI"  )
-#define BASPROV_PROPERTY_EDITABLE       OUString( "Editable"  )
+#define BASPROV_PROPERTY_EDITABLE       "Editable"
 
 #define BASPROV_DEFAULT_ATTRIBS()       PropertyAttribute::BOUND | PropertyAttribute::TRANSIENT | PropertyAttribute::READONLY
 

scripting/source/basprov/basprov.cxx

@@ -226,7 +226,7 @@ namespace basprov
             if ( !( aArguments[0] >>= m_sScriptingContext ) )
             {
                 throw IllegalArgumentException(
-                    OUString( "BasicProviderImpl::initialize: incorrect argument type " ) + aArguments[0].getValueTypeName(),
+                    "BasicProviderImpl::initialize: incorrect argument type " + aArguments[0].getValueTypeName(),
                     *this,
                     1
                 );

scripting/source/provider/MasterScriptProvider.cxx

@@ -310,11 +310,11 @@ throw ( provider::ScriptFrameworkErrorException,
     // ** Special case is BASIC, all calls to getScript will be handled
     // by the language script provider in the current location context
     // even if its different
-    if  (   (   location.equals( "document" )
+    if  (   (   location == "document"
             &&  m_xModel.is()
             )
             ||  ( endsWith( m_sCtxString, location ) )
-            ||  ( language.equals( "Basic" ) )
+            ||  ( language == "Basic" )
          )
     {
         Reference< provider::XScriptProvider > xScriptProvider;

scripting/source/provider/URIHelper.cxx

@@ -122,7 +122,7 @@ ScriptingFrameworkURIHelper::initBaseURI()
     else if ( m_sLocation == USER_UNO_PACKAGES )
     {
         test = "uno_packages";
-        uri = OUString( USER_URI ) + USER_UNO_PACKAGES_DIR;
+        uri = OUStringLiteral(USER_URI) + USER_UNO_PACKAGES_DIR;
     }
     else if (m_sLocation == SHARE)
     {