upgrade the internal harfbuzz to 1.8.4

Change-Id: I127cf3fa3ae00e91c73114e1a1915ea614924819
Reviewed-on: https://gerrit.libreoffice.org/57771
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

download.lst

@@ -94,8 +94,8 @@ export GPGME_SHA256SUM := 1b29fedb8bfad775e70eafac5b0590621683b2d9869db994568e64
 export GPGME_TARBALL := gpgme-1.9.0.tar.bz2
 export GRAPHITE_SHA256SUM := aa5e58356cd084000609ebbd93fef456a1bc0ab9e46fea20e81552fb286232a9
 export GRAPHITE_TARBALL := graphite2-minimal-1.3.10.tgz
-export HARFBUZZ_SHA256SUM := b5d6ac8415f97f3540d73f3f91c41c5c10f8a4d76350f11a7184062aae88ac0b
-export HARFBUZZ_TARBALL := harfbuzz-1.7.4.tar.bz2
+export HARFBUZZ_SHA256SUM := 3c592f86fa0da69e2e0e98cae9f5d5b61def3bb7948aa00ca45748f27fa545fd
+export HARFBUZZ_TARBALL := harfbuzz-1.8.4.tar.bz2
 export HSQLDB_SHA256SUM := d30b13f4ba2e3b6a2d4f020c0dee0a9fb9fc6fbcc2d561f36b78da4bf3802370
 export HSQLDB_TARBALL := 17410483b5b5f267aa18b7e00b65e6e0-hsqldb_1_8_0.zip
 export HUNSPELL_SHA256SUM := 3cd9ceb062fe5814f668e4f22b2fa6e3ba0b339b921739541ce180cac4d6f4c4

external/harfbuzz/ExternalProject_harfbuzz.mk

@@ -47,7 +47,7 @@ $(call gb_ExternalProject_get_state_target,harfbuzz,build) :
 				$(if $(ENABLE_OPTIMIZED), \
 					$(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS)) \
 				$(if $(debug),$(gb_DEBUG_CFLAGS) $(gb_DEBUG_CXXFLAGS)) \
-				$(CXXFLAGS) \
+				$(CXXFLAGS) $(CXXFLAGS_CXX11) \
 				$(ICU_UCHAR_TYPE) \
 				$(if $(filter LINUX,$(OS)),-fvisibility=hidden)' \
 		&& (cd $(EXTERNAL_WORKDIR)/src && $(MAKE) lib) \

external/harfbuzz/clang-cl.patch

 --- src/hb-common.h
 +++ src/hb-common.h
-@@ -331,7 +331,9 @@
+@@ -346,7 +346,9 @@
     *
-    *   http://lists.freedesktop.org/archives/harfbuzz/2014-March/004150.html
+    *   https://lists.freedesktop.org/archives/harfbuzz/2014-March/004150.html
     */
 +#if !defined _MSC_VER /* avoid clang-cl -Wmicrosoft-enum-value */
    _HB_SCRIPT_MAX_VALUE				= HB_TAG_MAX, /*< skip >*/
 +#endif
    _HB_SCRIPT_MAX_VALUE_SIGNED			= HB_TAG_MAX_SIGNED /*< skip >*/
- 
+
  } hb_script_t;

external/harfbuzz/ubsan.patch

 --- src/hb-ot-hmtx-table.hh
 +++ src/hb-ot-hmtx-table.hh
-@@ -143,7 +143,7 @@
- 	  return default_advance;
+@@ -263,7 +263,7 @@ struct hmtxvmtx
+           return default_advance;
        }
  
--      return table->longMetric[MIN (glyph, (uint32_t) num_advances - 1)].advance
-+      return static_cast<OT::LongMetric const *>(table->longMetric)[MIN (glyph, (uint32_t) num_advances - 1)].advance
- 	   + var_table->get_advance_var (glyph, font->coords, font->num_coords); // TODO Optimize?!
+-      return table->longMetric[MIN (glyph, (uint32_t) num_advances - 1)].advance;
++      return static_cast<OT::LongMetric const *>(table->longMetric)[MIN (glyph, (uint32_t) num_advances - 1)].advance;
      }
  
+     inline unsigned int get_advance (hb_codepoint_t  glyph,