Kaydet (Commit) a890e318 authored tarafından Stephan Bergmann's avatar Stephan Bergmann

SAL_FALLTRHOUGH in Windows-only code

Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
üst 3ec901fa
...@@ -338,7 +338,8 @@ extern "C" typelib_TypeClass cpp_vtable_call( ...@@ -338,7 +338,8 @@ extern "C" typelib_TypeClass cpp_vtable_call(
} }
TYPELIB_DANGER_RELEASE( pTD2 ); TYPELIB_DANGER_RELEASE( pTD2 );
} }
} // Fall through! SAL_FALLTHROUGH;
}
default: default:
{ {
typelib_InterfaceMethodTypeDescription * pMethodTD = typelib_InterfaceMethodTypeDescription * pMethodTD =
......
...@@ -423,7 +423,8 @@ void unoInterfaceProxyDispatch( ...@@ -423,7 +423,8 @@ void unoInterfaceProxyDispatch(
} }
TYPELIB_DANGER_RELEASE( pTD ); TYPELIB_DANGER_RELEASE( pTD );
} }
} // Else perform queryInterface() SAL_FALLTHROUGH; // else perform queryInterface()
}
default: default:
if ( ! cpp_call( if ( ! cpp_call(
pThis, aVtableSlot, pThis, aVtableSlot,
......
...@@ -192,7 +192,7 @@ STDMETHODIMP EmbedDocument_Impl::DoVerb( ...@@ -192,7 +192,7 @@ STDMETHODIMP EmbedDocument_Impl::DoVerb(
pActiveSite,TRUE))) pActiveSite,TRUE)))
return NOERROR; return NOERROR;
// intended fall through SAL_FALLTHROUGH;
case OLEIVERB_OPEN: case OLEIVERB_OPEN:
OSL_ENSURE(m_pDocHolder,"no document to open"); OSL_ENSURE(m_pDocHolder,"no document to open");
......
...@@ -16,6 +16,11 @@ ...@@ -16,6 +16,11 @@
* except in compliance with the License. You may obtain a copy of * except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 . * the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/ */
#include <sal/config.h>
#include <sal/types.h>
#ifdef _MSC_VER #ifdef _MSC_VER
#pragma warning(disable : 4917 4555) #pragma warning(disable : 4917 4555)
#endif #endif
...@@ -442,6 +447,7 @@ BOOL Tracker::TrackHandle(int nHandle,HWND hWnd,POINT point,HWND hWndClipTo) ...@@ -442,6 +447,7 @@ BOOL Tracker::TrackHandle(int nHandle,HWND hWnd,POINT point,HWND hWndClipTo)
case WM_KEYDOWN: case WM_KEYDOWN:
if (msg.wParam != VK_ESCAPE) if (msg.wParam != VK_ESCAPE)
break; break;
SAL_FALLTHROUGH;
case WM_RBUTTONDOWN: case WM_RBUTTONDOWN:
if (bMoved) if (bMoved)
{ {
......
...@@ -84,6 +84,7 @@ static BOOL IsValidFilePathComponent( ...@@ -84,6 +84,7 @@ static BOOL IsValidFilePathComponent(
break; break;
} }
} }
SAL_FALLTHROUGH;
case 0: case 0:
case ' ': case ' ':
if ( dwFlags & VALIDATEPATH_ALLOW_INVALID_SPACE_AND_PERIOD ) if ( dwFlags & VALIDATEPATH_ALLOW_INVALID_SPACE_AND_PERIOD )
...@@ -104,6 +105,7 @@ static BOOL IsValidFilePathComponent( ...@@ -104,6 +105,7 @@ static BOOL IsValidFilePathComponent(
case '*': case '*':
if ( dwFlags & VALIDATEPATH_ALLOW_WILDCARDS ) if ( dwFlags & VALIDATEPATH_ALLOW_WILDCARDS )
break; break;
SAL_FALLTHROUGH;
/* The following characters are reserved */ /* The following characters are reserved */
case '<': case '<':
case '>': case '>':
...@@ -580,6 +582,7 @@ static void _osl_encodeURL( rtl_uString *strURL, rtl_String **pstrEncodedURL ) ...@@ -580,6 +582,7 @@ static void _osl_encodeURL( rtl_uString *strURL, rtl_String **pstrEncodedURL )
pURLDest += 3; pURLDest += 3;
break; break;
} }
SAL_FALLTHROUGH;
case '!': case '!':
case '\'': case '\'':
case '(': case '(':
......
...@@ -559,6 +559,7 @@ sal_Bool SAL_CALL osl_isEqualSocketAddr(oslSocketAddr Addr1, oslSocketAddr Addr2 ...@@ -559,6 +559,7 @@ sal_Bool SAL_CALL osl_isEqualSocketAddr(oslSocketAddr Addr1, oslSocketAddr Addr2
(pInetAddr1->sin_addr.s_addr == pInetAddr2->sin_addr.s_addr) && (pInetAddr1->sin_addr.s_addr == pInetAddr2->sin_addr.s_addr) &&
(pInetAddr1->sin_port == pInetAddr2->sin_port)) (pInetAddr1->sin_port == pInetAddr2->sin_port))
return sal_True; return sal_True;
SAL_FALLTHROUGH;
} }
default: default:
......
...@@ -125,7 +125,7 @@ HDDEDATA CALLBACK DdeInternal::CliCallback( WORD nCode, WORD nCbType, ...@@ -125,7 +125,7 @@ HDDEDATA CALLBACK DdeInternal::CliCallback( WORD nCode, WORD nCbType,
nRet = (HDDEDATA)DDE_FACK; nRet = (HDDEDATA)DDE_FACK;
break; break;
} }
// no break SAL_FALLTHROUGH;
case XTYP_REQUEST: case XTYP_REQUEST:
if( !hData && XTYP_REQUEST == nCode ) if( !hData && XTYP_REQUEST == nCode )
......
...@@ -846,6 +846,7 @@ createPreferredCharsetList(rtl_TextEncoding eEncoding) ...@@ -846,6 +846,7 @@ createPreferredCharsetList(rtl_TextEncoding eEncoding)
#if defined(_WIN32) #if defined(_WIN32)
pList->prepend(Charset(RTL_TEXTENCODING_MS_1252, pList->prepend(Charset(RTL_TEXTENCODING_MS_1252,
aWindows1252Ranges)); aWindows1252Ranges));
break;
#endif // WNT #endif // WNT
case RTL_TEXTENCODING_ISO_8859_1: case RTL_TEXTENCODING_ISO_8859_1:
case RTL_TEXTENCODING_UTF7: case RTL_TEXTENCODING_UTF7:
......
...@@ -50,6 +50,7 @@ bool WinSalGraphics::supportsOperation( OutDevSupportType eType ) const ...@@ -50,6 +50,7 @@ bool WinSalGraphics::supportsOperation( OutDevSupportType eType ) const
break; break;
case OutDevSupport_B2DDraw: case OutDevSupport_B2DDraw:
bRet = bAllowForTest; bRet = bAllowForTest;
break;
default: break; default: break;
} }
return bRet; return bRet;
......
...@@ -5707,6 +5707,7 @@ LRESULT CALLBACK SalFrameWndProc( HWND hWnd, UINT nMsg, WPARAM wParam, LPARAM lP ...@@ -5707,6 +5707,7 @@ LRESULT CALLBACK SalFrameWndProc( HWND hWnd, UINT nMsg, WPARAM wParam, LPARAM lP
case WM_KILLFOCUS: case WM_KILLFOCUS:
DestroyCaret(); DestroyCaret();
SAL_FALLTHROUGH;
case WM_SETFOCUS: case WM_SETFOCUS:
case SAL_MSG_POSTFOCUS: case SAL_MSG_POSTFOCUS:
ImplHandleFocusMsg( hWnd ); ImplHandleFocusMsg( hWnd );
......
...@@ -3011,6 +3011,7 @@ void CMAccessible::ConvertAnyToVariant(const css::uno::Any &rAnyVal, VARIANT *pv ...@@ -3011,6 +3011,7 @@ void CMAccessible::ConvertAnyToVariant(const css::uno::Any &rAnyVal, VARIANT *pv
} }
} }
} }
SAL_FALLTHROUGH;
} }
case TypeClass_SERVICE: case TypeClass_SERVICE:
case TypeClass_MODULE: case TypeClass_MODULE:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment