Kaydet (Commit) a4807544 authored tarafından Tor Lillqvist's avatar Tor Lillqvist

Fix "external" graphic filter code for the DISABLE_DYNLOADING case

The DISABLE_DYNLOADING case in ImpFilterLibCacheEntry::GetImportFunction()
had apparently been broken from the start, but nobody never noticed as
the common formats (PNG, JPEG, GIF etc) use a more "internal"code
path. The problem was noticed now with a TIFF image in a presentation.

The fix for the import case seems to work, but I could not test the
fix for the export case.

Change-Id: Icbd33c7cb654136a562f18b06d5b0896e701bf3d
üst 27cd31a7
......@@ -721,27 +721,27 @@ PFilterCall ImpFilterLibCacheEntry::GetImportFunction()
else if (maFormatName == "iti")
mpfnImport = reinterpret_cast<PFilterCall>(maLibrary.getFunctionSymbol("itiGraphicImport"));
#else
if (maFiltername == "icd")
if (maFormatName == "icd")
mpfnImport = icdGraphicImport;
else if (maFiltername == "idx")
else if (maFormatName == "idx")
mpfnImport = idxGraphicImport;
else if (maFiltername == "ime")
else if (maFormatName == "ime")
mpfnImport = imeGraphicImport;
else if (maFiltername == "ipb")
else if (maFormatName == "ipb")
mpfnImport = ipbGraphicImport;
else if (maFiltername == "ipd")
else if (maFormatName == "ipd")
mpfnImport = ipdGraphicImport;
else if (maFiltername == "ips")
else if (maFormatName == "ips")
mpfnImport = ipsGraphicImport;
else if (maFiltername == "ipt")
else if (maFormatName == "ipt")
mpfnImport = iptGraphicImport;
else if (maFiltername == "ipx")
else if (maFormatName == "ipx")
mpfnImport = ipxGraphicImport;
else if (maFiltername == "ira")
else if (maFormatName == "ira")
mpfnImport = iraGraphicImport;
else if (maFiltername == "itg")
else if (maFormatName == "itg")
mpfnImport = itgGraphicImport;
else if (maFiltername == "iti")
else if (maFormatName == "iti")
mpfnImport = itiGraphicImport;
#endif
}
......@@ -1893,9 +1893,7 @@ ErrCode GraphicFilter::ExportGraphic( const Graphic& rGraphic, const OUString& r
FilterConfigItem aConfigItem( pFilterData );
OUString aFilterName( pConfig->GetExportFilterName( nFormat ) );
#ifndef DISABLE_DYNLOADING
OUString aExternalFilterName(pConfig->GetExternalFilterName(nFormat, true));
#endif
ErrCode nStatus = ERRCODE_NONE;
GraphicType eType;
Graphic aGraphic = ImpGetScaledGraphic( rGraphic, aConfigItem );
......@@ -2187,11 +2185,11 @@ ErrCode GraphicFilter::ExportGraphic( const Graphic& rGraphic, const OUString& r
#else
--nIdx; // Just one iteration
PFilterCall pFunc = NULL;
if (aFilterName == "egi")
if (aExternalFilterName == "egi")
pFunc = egiGraphicExport;
else if (aFilterName == "eps")
else if (aExternalFilterName == "eps")
pFunc = epsGraphicExport;
else if (aFilterName == "eti")
else if (aExternalFilterName == "eti")
pFunc = etiGraphicExport;
#endif
if( pFunc )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment