tdf#89329: use unique_ptr for pImpl in new

Fix "error: declaration of ‘pImpl’ shadows a
member of 'this' [-Werror=shadow]" too

Change-Id: Ib0fc66375ed7d9ae700d5a81a2adb5975fcae592
Reviewed-on: https://gerrit.libreoffice.org/25319Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

include/sfx2/new.hxx

@@ -59,7 +59,7 @@ class SFX2_DLLPUBLIC SfxNewFileDialog : public SfxModalDialog
     friend class SfxNewFileDialog_Impl;
 
 private:
-    SfxNewFileDialog_Impl* pImpl;
+    std::unique_ptr< SfxNewFileDialog_Impl > pImpl;
 
 public:
 

sfx2/source/doc/new.cxx

@@ -423,9 +423,9 @@ SfxNewFileDialog_Impl::~SfxNewFileDialog_Impl()
 
 SfxNewFileDialog::SfxNewFileDialog(vcl::Window *pParent, sal_uInt16 nFlags)
     : SfxModalDialog(pParent, "LoadTemplateDialog",
-        "sfx/ui/loadtemplatedialog.ui")
+        "sfx/ui/loadtemplatedialog.ui"),
+      pImpl( new SfxNewFileDialog_Impl(this, nFlags) )
 {
-    pImpl = new SfxNewFileDialog_Impl(this, nFlags);
 }
 
 SfxNewFileDialog::~SfxNewFileDialog()
@@ -435,7 +435,7 @@ SfxNewFileDialog::~SfxNewFileDialog()
 
 void SfxNewFileDialog::dispose()
 {
-    delete pImpl;
+    pImpl.reset();
     SfxModalDialog::dispose();
 }
 

sw/source/uibase/uiview/view.cxx

@@ -1763,8 +1763,8 @@ void SwView::NotifyDBChanged()
 
 SfxObjectShellLock SwView::CreateTmpSelectionDoc()
 {
-    SwXTextView *const pImpl = GetViewImpl()->GetUNOObject_Impl();
-    return pImpl->BuildTmpSelectionDoc();
+    SwXTextView *const pTempImpl = GetViewImpl()->GetUNOObject_Impl();
+    return pTempImpl->BuildTmpSelectionDoc();
 }
 
 void SwView::AddTransferable(SwTransferable& rTransferable)