Various trivial loplugin fixes in --enable-qt5

Change-Id: I9539eb77f663e1174919ae801495801f81571710

vcl/inc/qt5/Qt5FilePicker.hxx

@@ -119,7 +119,7 @@ public:
 
     // XEventListener
     /// @throws css::uno::RuntimeException
-    virtual void SAL_CALL disposing(const css::lang::EventObject& rEvent);
+    virtual void disposing(const css::lang::EventObject& rEvent);
     using cppu::WeakComponentImplHelperBase::disposing;
 
     // XServiceInfo

vcl/qt5/Qt5Bitmap.cxx

@@ -17,9 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Bitmap.hxx"
-#include "Qt5Tools.hxx"
-#include "Qt5Graphics.hxx"
+#include <Qt5Bitmap.hxx>
+#include <Qt5Tools.hxx>
+#include <Qt5Graphics.hxx>
 
 #include <QtGui/QImage>
 #include <QtCore/QVector>

vcl/qt5/Qt5Data.cxx

@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Data.hxx"
+#include <Qt5Data.hxx>
 
 #include <QtGui/QCursor>
 #include <QtGui/QBitmap>

vcl/qt5/Qt5FilePicker.cxx

@@ -17,12 +17,12 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5FilePicker.hxx"
+#include <Qt5FilePicker.hxx>
 #include <Qt5FilePicker.moc>
 
-#include "Qt5Frame.hxx"
-#include "Qt5Tools.hxx"
-#include "Qt5Widget.hxx"
+#include <Qt5Frame.hxx>
+#include <Qt5Tools.hxx>
+#include <Qt5Widget.hxx>
 
 #include <com/sun/star/lang/DisposedException.hpp>
 #include <com/sun/star/lang/IllegalArgumentException.hpp>
@@ -65,7 +65,7 @@ using namespace ::com::sun::star::uno;
 
 namespace
 {
-uno::Sequence<OUString> SAL_CALL FilePicker_getSupportedServiceNames()
+uno::Sequence<OUString> FilePicker_getSupportedServiceNames()
 {
     uno::Sequence<OUString> aRet(3);
     aRet[0] = "com.sun.star.ui.dialogs.FilePicker";
@@ -750,7 +750,7 @@ void SAL_CALL Qt5FilePicker::initialize(const uno::Sequence<uno::Any>& args)
 
 void SAL_CALL Qt5FilePicker::cancel() {}
 
-void SAL_CALL Qt5FilePicker::disposing(const lang::EventObject& rEvent)
+void Qt5FilePicker::disposing(const lang::EventObject& rEvent)
 {
     uno::Reference<XFilePickerListener> xFilePickerListener(rEvent.Source, uno::UNO_QUERY);
 

vcl/qt5/Qt5Font.hxx

@@ -23,7 +23,7 @@
 
 #include <QtGui/QFont>
 
-#include "Qt5FontFace.hxx"
+#include <Qt5FontFace.hxx>
 
 class Qt5Font final : public QFont, public LogicalFontInstance
 {

vcl/qt5/Qt5FontFace.cxx

@@ -17,9 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5FontFace.hxx"
+#include <Qt5FontFace.hxx>
 #include "Qt5Font.hxx"
-#include "Qt5Tools.hxx"
+#include <Qt5Tools.hxx>
 
 #include <sft.hxx>
 #include <impfontcharmap.hxx>

vcl/qt5/Qt5Frame.cxx

@@ -17,13 +17,13 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Frame.hxx"
+#include <Qt5Frame.hxx>
 
-#include "Qt5Tools.hxx"
-#include "Qt5Instance.hxx"
-#include "Qt5Graphics.hxx"
-#include "Qt5Widget.hxx"
-#include "Qt5Data.hxx"
+#include <Qt5Tools.hxx>
+#include <Qt5Instance.hxx>
+#include <Qt5Graphics.hxx>
+#include <Qt5Widget.hxx>
+#include <Qt5Data.hxx>
 #include <Qt5Menu.hxx>
 
 #include <QtCore/QPoint>

vcl/qt5/Qt5Graphics.cxx

@@ -17,11 +17,11 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Graphics.hxx"
+#include <Qt5Graphics.hxx>
 
 #include "Qt5Font.hxx"
-#include "Qt5Frame.hxx"
-#include "Qt5Painter.hxx"
+#include <Qt5Frame.hxx>
+#include <Qt5Painter.hxx>
 
 #include <QtGui/QImage>
 #include <QtGui/QPainter>

vcl/qt5/Qt5Graphics_Controls.cxx

@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Graphics.hxx"
+#include <Qt5Graphics.hxx>
 
 bool Qt5Graphics::IsNativeControlSupported(ControlType /*nType*/, ControlPart /*nPart*/)
 {

vcl/qt5/Qt5Graphics_GDI.cxx

@@ -17,10 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Graphics.hxx"
+#include <Qt5Graphics.hxx>
 
-#include "Qt5Bitmap.hxx"
-#include "Qt5Painter.hxx"
+#include <Qt5Bitmap.hxx>
+#include <Qt5Painter.hxx>
 
 #include <QtGui/QPainter>
 #include <QtGui/QScreen>

vcl/qt5/Qt5Graphics_Text.cxx

@@ -17,10 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Graphics.hxx"
-#include "Qt5FontFace.hxx"
+#include <Qt5Graphics.hxx>
+#include <Qt5FontFace.hxx>
 #include "Qt5Font.hxx"
-#include "Qt5Painter.hxx"
+#include <Qt5Painter.hxx>
 
 #include <vcl/fontcharmap.hxx>
 

vcl/qt5/Qt5Instance.cxx

@@ -17,17 +17,17 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Instance.hxx"
+#include <Qt5Instance.hxx>
 #include <Qt5Instance.moc>
 
-#include "Qt5Bitmap.hxx"
-#include "Qt5Data.hxx"
-#include "Qt5FilePicker.hxx"
-#include "Qt5Frame.hxx"
-#include "Qt5Menu.hxx"
-#include "Qt5Object.hxx"
-#include "Qt5Timer.hxx"
-#include "Qt5VirtualDevice.hxx"
+#include <Qt5Bitmap.hxx>
+#include <Qt5Data.hxx>
+#include <Qt5FilePicker.hxx>
+#include <Qt5Frame.hxx>
+#include <Qt5Menu.hxx>
+#include <Qt5Object.hxx>
+#include <Qt5Timer.hxx>
+#include <Qt5VirtualDevice.hxx>
 
 #include <headless/svpvd.hxx>
 

vcl/qt5/Qt5Instance_Print.cxx

@@ -17,8 +17,8 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Instance.hxx"
-#include "Qt5Printer.hxx"
+#include <Qt5Instance.hxx>
+#include <Qt5Printer.hxx>
 
 #include <vcl/svapp.hxx>
 #include <vcl/timer.hxx>

vcl/qt5/Qt5Menu.cxx

@@ -7,8 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#include "Qt5Frame.hxx"
-#include "Qt5Menu.hxx"
+#include <Qt5Frame.hxx>
+#include <Qt5Menu.hxx>
 #include <Qt5Menu.moc>
 
 #include <QtWidgets/QtWidgets>
@@ -46,7 +46,7 @@ void Qt5Menu::RemoveItem(unsigned nPos)
     maItems.erase(maItems.begin() + nPos);
 }
 
-void Qt5Menu::SetSubMenu(SalMenuItem* pSalMenuItem, SalMenu* pSubMenu, unsigned nPos)
+void Qt5Menu::SetSubMenu(SalMenuItem* pSalMenuItem, SalMenu* pSubMenu, unsigned)
 {
     SolarMutexGuard aGuard;
     Qt5MenuItem* pItem = static_cast<Qt5MenuItem*>(pSalMenuItem);
@@ -146,22 +146,19 @@ void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar, QMenu* pParentMenu)
     }
 }
 
-void Qt5Menu::ShowItem(unsigned nPos, bool bCheck) {}
+void Qt5Menu::ShowItem(unsigned, bool) {}
 
-void Qt5Menu::CheckItem(unsigned nPos, bool bCheck) {}
+void Qt5Menu::CheckItem(unsigned, bool) {}
 
-void Qt5Menu::EnableItem(unsigned nPos, bool bEnable) {}
+void Qt5Menu::EnableItem(unsigned, bool) {}
 
-void Qt5Menu::SetItemText(unsigned nPos, SalMenuItem* pSalMenuItem, const rtl::OUString& rText) {}
+void Qt5Menu::SetItemText(unsigned, SalMenuItem*, const rtl::OUString&) {}
 
-void Qt5Menu::SetItemImage(unsigned nPos, SalMenuItem* pSalMenuItem, const Image& rImage) {}
+void Qt5Menu::SetItemImage(unsigned, SalMenuItem*, const Image&) {}
 
-void Qt5Menu::SetAccelerator(unsigned nPos, SalMenuItem* pSalMenuItem, const vcl::KeyCode& rKeyCode,
-                             const OUString& rKeyName)
-{
-}
+void Qt5Menu::SetAccelerator(unsigned, SalMenuItem*, const vcl::KeyCode&, const OUString&) {}
 
-void Qt5Menu::GetSystemMenuData(SystemMenuData* pData) {}
+void Qt5Menu::GetSystemMenuData(SystemMenuData*) {}
 
 Qt5Menu* Qt5Menu::GetTopLevel()
 {

vcl/qt5/Qt5Object.cxx

@@ -17,9 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Object.hxx"
+#include <Qt5Object.hxx>
 
-#include "Qt5Frame.hxx"
+#include <Qt5Frame.hxx>
 
 #include <QtWidgets/QWidget>
 

vcl/qt5/Qt5Painter.cxx

@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Painter.hxx"
+#include <Qt5Painter.hxx>
 
 #include <QtGui/QColor>
 

vcl/qt5/Qt5Printer.cxx

@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Printer.hxx"
+#include <Qt5Printer.hxx>
 
 bool Qt5InfoPrinter::Setup(weld::Window*, ImplJobSetup*) { return false; }
 

vcl/qt5/Qt5Timer.cxx

@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Timer.hxx"
+#include <Qt5Timer.hxx>
 #include <Qt5Timer.moc>
 
 #include <QtWidgets/QApplication>

vcl/qt5/Qt5Tools.cxx

@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Tools.hxx"
+#include <Qt5Tools.hxx>
 
 #include <cairo.h>
 

vcl/qt5/Qt5VirtualDevice.cxx

@@ -17,10 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5VirtualDevice.hxx"
+#include <Qt5VirtualDevice.hxx>
 
-#include "Qt5Graphics.hxx"
-#include "Qt5Tools.hxx"
+#include <Qt5Graphics.hxx>
+#include <Qt5Tools.hxx>
 
 #include <QtGui/QImage>
 

vcl/qt5/Qt5Widget.cxx

@@ -17,12 +17,12 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include "Qt5Widget.hxx"
+#include <Qt5Widget.hxx>
 #include <Qt5Widget.moc>
 
-#include "Qt5Frame.hxx"
-#include "Qt5Graphics.hxx"
-#include "Qt5Tools.hxx"
+#include <Qt5Frame.hxx>
+#include <Qt5Graphics.hxx>
+#include <Qt5Tools.hxx>
 
 #include <QtGui/QFocusEvent>
 #include <QtGui/QImage>