loplugin:constparams in cppcanvas,drawinglayer

Change-Id: I15cac1411c985afe8d7cb9439214a8092702bdb8
Reviewed-on: https://gerrit.libreoffice.org/44343Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

cppcanvas/source/mtfrenderer/emfpbrush.cxx

@@ -89,7 +89,7 @@ namespace cppcanvas
             }
         }
 
-        void EMFPBrush::Read(SvStream& s, ImplRenderer& rR)
+        void EMFPBrush::Read(SvStream& s, ImplRenderer const & rR)
         {
             sal_uInt32 header;
 

cppcanvas/source/mtfrenderer/emfpbrush.hxx

@@ -121,7 +121,7 @@ namespace cppcanvas
             sal_uInt32 GetType() const { return type; }
             const ::Color& GetColor() const { return solidColor; }
 
-            void Read(SvStream& s, ImplRenderer& rR);
+            void Read(SvStream& s, ImplRenderer const & rR);
         };
     }
 }

cppcanvas/source/mtfrenderer/emfpcustomlinecap.cxx

@@ -74,7 +74,7 @@ namespace cppcanvas
             aAttributes.MiterLimit = miterLimit;
         }
 
-        void EMFPCustomLineCap::ReadPath(SvStream& s, ImplRenderer& rR, bool bFill)
+        void EMFPCustomLineCap::ReadPath(SvStream& s, ImplRenderer const & rR, bool bFill)
         {
             sal_Int32 pathLength;
             s.ReadInt32(pathLength);
@@ -101,7 +101,7 @@ namespace cppcanvas
             polygon.transform(aMatrix);
         };
 
-        void EMFPCustomLineCap::Read(SvStream& s, ImplRenderer& rR)
+        void EMFPCustomLineCap::Read(SvStream& s, ImplRenderer const & rR)
         {
             sal_uInt32 header;
 

cppcanvas/source/mtfrenderer/emfpcustomlinecap.hxx

@@ -35,8 +35,8 @@ namespace cppcanvas
             EMFPCustomLineCap();
 
             void SetAttributes(com::sun::star::rendering::StrokeAttributes& aAttributes);
-            void ReadPath(SvStream& s, ImplRenderer& rR, bool bFill);
-            void Read(SvStream& s, ImplRenderer& rR);
+            void ReadPath(SvStream& s, ImplRenderer const & rR, bool bFill);
+            void Read(SvStream& s, ImplRenderer const & rR);
         };
     }
 }

cppcanvas/source/mtfrenderer/emfppath.cxx

@@ -102,7 +102,7 @@ namespace cppcanvas
 #endif
         }
 
-        ::basegfx::B2DPolyPolygon& EMFPPath::GetPolygon (ImplRenderer& rR, bool bMapIt, bool bAddLineToCloseShape)
+        ::basegfx::B2DPolyPolygon& EMFPPath::GetPolygon (ImplRenderer const & rR, bool bMapIt, bool bAddLineToCloseShape)
         {
             ::basegfx::B2DPolygon polygon;
 

cppcanvas/source/mtfrenderer/emfppath.hxx

@@ -40,7 +40,7 @@ namespace cppcanvas
             // TODO: remove rR argument when debug code is no longer needed
             void Read(SvStream& s, sal_uInt32 pathFlags, ImplRenderer const & rR);
 
-            ::basegfx::B2DPolyPolygon& GetPolygon(ImplRenderer& rR, bool bMapIt = true, bool bAddLineToCloseShape = false);
+            ::basegfx::B2DPolyPolygon& GetPolygon(ImplRenderer const & rR, bool bMapIt = true, bool bAddLineToCloseShape = false);
         };
     }
 }

cppcanvas/source/mtfrenderer/emfppen.cxx

@@ -95,7 +95,7 @@ namespace cppcanvas
             delete customEndCap;
         }
 
-        void EMFPPen::SetStrokeWidth(rendering::StrokeAttributes& rStrokeAttributes, ImplRenderer& rR, const OutDevState& rState)
+        void EMFPPen::SetStrokeWidth(rendering::StrokeAttributes& rStrokeAttributes, ImplRenderer const & rR, const OutDevState& rState)
         {
             // If a zero width is specified, a minimum value is used, which is determined by the units.
             //TODO Add support for other units than Pixel
@@ -169,7 +169,7 @@ namespace cppcanvas
             }
         }
 
-        void EMFPPen::Read(SvStream& s, ImplRenderer& rR)
+        void EMFPPen::Read(SvStream& s, ImplRenderer const & rR)
         {
             sal_uInt32 graphicsVersion, penType, penDataFlags, penUnit;
             int i;

cppcanvas/source/mtfrenderer/emfppen.hxx

@@ -60,11 +60,11 @@ namespace cppcanvas
 
             virtual ~EMFPPen() override;
 
-            void SetStrokeWidth(com::sun::star::rendering::StrokeAttributes& rStrokeAttributes, ImplRenderer& rR, const OutDevState& rState);
+            void SetStrokeWidth(com::sun::star::rendering::StrokeAttributes& rStrokeAttributes, ImplRenderer const & rR, const OutDevState& rState);
 
             void SetStrokeAttributes(com::sun::star::rendering::StrokeAttributes& rStrokeAttributes);
 
-            void Read(SvStream& s, ImplRenderer& rR);
+            void Read(SvStream& s, ImplRenderer const & rR);
 
             static sal_Int8 lcl_convertStrokeCap(sal_uInt32 nEmfStroke);
             static sal_Int8 lcl_convertLineJoinType(sal_uInt32 nEmfLineJoin);

drawinglayer/source/tools/emfpbrush.cxx

@@ -95,7 +95,7 @@ namespace emfplushelper
         }
     }
 
-    void EMFPBrush::Read(SvStream& s, EmfPlusHelperData& rR)
+    void EMFPBrush::Read(SvStream& s, EmfPlusHelperData const & rR)
     {
         sal_uInt32 header;
 

drawinglayer/source/tools/emfpbrush.hxx

@@ -123,7 +123,7 @@ namespace emfplushelper
         sal_uInt32 GetType() const { return type; }
         const ::Color& GetColor() const { return solidColor; }
 
-        void Read(SvStream& s, EmfPlusHelperData& rR);
+        void Read(SvStream& s, EmfPlusHelperData const & rR);
     };
 }
 

drawinglayer/source/tools/emfpcustomlinecap.cxx

@@ -69,7 +69,7 @@ namespace emfplushelper
         aAttributes.MiterLimit = miterLimit;
     }
 
-    void EMFPCustomLineCap::ReadPath(SvStream& s, EmfPlusHelperData& rR, bool bFill)
+    void EMFPCustomLineCap::ReadPath(SvStream& s, EmfPlusHelperData const & rR, bool bFill)
     {
         sal_Int32 pathLength;
         s.ReadInt32(pathLength);
@@ -92,7 +92,7 @@ namespace emfplushelper
         polygon.transform(aMatrix);
     };
 
-    void EMFPCustomLineCap::Read(SvStream& s, EmfPlusHelperData& rR)
+    void EMFPCustomLineCap::Read(SvStream& s, EmfPlusHelperData const & rR)
     {
         sal_uInt32 header;
         s.ReadUInt32(header).ReadUInt32(type);

drawinglayer/source/tools/emfpcustomlinecap.hxx

@@ -35,8 +35,8 @@ namespace emfplushelper
         EMFPCustomLineCap();
 
         void SetAttributes(com::sun::star::rendering::StrokeAttributes& aAttributes);
-        void ReadPath(SvStream& s, EmfPlusHelperData& rR, bool bFill);
-        void Read(SvStream& s, EmfPlusHelperData& rR);
+        void ReadPath(SvStream& s, EmfPlusHelperData const & rR, bool bFill);
+        void Read(SvStream& s, EmfPlusHelperData const & rR);
     };
 }
 

drawinglayer/source/tools/emfphelperdata.cxx

@@ -697,7 +697,7 @@ namespace emfplushelper
     {
     }
 
-    void EmfPlusHelperData::combineClip(int combineMode, ::basegfx::B2DPolyPolygon& polygon)
+    void EmfPlusHelperData::combineClip(int combineMode, ::basegfx::B2DPolyPolygon const & polygon)
     {
         switch (combineMode)
         {

drawinglayer/source/tools/emfphelperdata.hxx

@@ -242,7 +242,7 @@ namespace emfplushelper
 
         // helper functions
         ::basegfx::BColor EMFPGetBrushColorOrARGBColor(sal_uInt16 flags, sal_uInt32 brushIndexOrColor) const;
-        void combineClip(int combineMode, ::basegfx::B2DPolyPolygon& polygon);
+        void combineClip(int combineMode, ::basegfx::B2DPolyPolygon const & polygon);
 
     public:
         EmfPlusHelperData(

drawinglayer/source/tools/emfppath.cxx

@@ -111,7 +111,7 @@ namespace emfplushelper
 #endif
     }
 
-    ::basegfx::B2DPolyPolygon& EMFPPath::GetPolygon (EmfPlusHelperData& rR, bool bMapIt, bool bAddLineToCloseShape)
+    ::basegfx::B2DPolyPolygon& EMFPPath::GetPolygon (EmfPlusHelperData const & rR, bool bMapIt, bool bAddLineToCloseShape)
     {
         ::basegfx::B2DPolygon polygon;
         aPolygon.clear ();

drawinglayer/source/tools/emfppath.hxx

@@ -39,7 +39,7 @@ namespace emfplushelper
         // TODO: remove rR argument when debug code is no longer needed
         void Read(SvStream& s, sal_uInt32 pathFlags, EmfPlusHelperData const & rR);
 
-        ::basegfx::B2DPolyPolygon& GetPolygon(EmfPlusHelperData& rR, bool bMapIt = true, bool bAddLineToCloseShape = false);
+        ::basegfx::B2DPolyPolygon& GetPolygon(EmfPlusHelperData const & rR, bool bMapIt = true, bool bAddLineToCloseShape = false);
     };
 }
 

drawinglayer/source/tools/emfppen.cxx

@@ -86,7 +86,7 @@ namespace emfplushelper
         delete customEndCap;
     }
 
-    void EMFPPen::SetStrokeWidth(rendering::StrokeAttributes& rStrokeAttributes, EmfPlusHelperData& rR, const ::basegfx::B2DHomMatrix& mapModeTransform)
+    void EMFPPen::SetStrokeWidth(rendering::StrokeAttributes& rStrokeAttributes, EmfPlusHelperData const & rR, const ::basegfx::B2DHomMatrix& mapModeTransform)
     {
         // If a zero width is specified, a minimum value is used, which is determined by the units.
         //TODO Add support for other units than Pixel
@@ -162,7 +162,7 @@ namespace emfplushelper
         }
     }
 
-    void EMFPPen::Read(SvStream& s, EmfPlusHelperData& rR)
+    void EMFPPen::Read(SvStream& s, EmfPlusHelperData const & rR)
     {
         sal_uInt32 graphicsVersion, penType;
         int i;

drawinglayer/source/tools/emfppen.hxx

@@ -68,11 +68,11 @@ namespace emfplushelper
 
         virtual ~EMFPPen() override;
 
-        void SetStrokeWidth(com::sun::star::rendering::StrokeAttributes& rStrokeAttributes, EmfPlusHelperData& rR, const ::basegfx::B2DHomMatrix& mapModeTransform);
+        void SetStrokeWidth(com::sun::star::rendering::StrokeAttributes& rStrokeAttributes, EmfPlusHelperData const & rR, const ::basegfx::B2DHomMatrix& mapModeTransform);
 
         void SetStrokeAttributes(com::sun::star::rendering::StrokeAttributes& rStrokeAttributes);
 
-        void Read(SvStream& s, EmfPlusHelperData& rR);
+        void Read(SvStream& s, EmfPlusHelperData const & rR);
 
         static sal_Int8 lcl_convertStrokeCap(sal_uInt32 nEmfStroke);
         static sal_Int8 lcl_convertLineJoinType(sal_uInt32 nEmfLineJoin);

tools/source/stream/strmunx.cxx

@@ -145,7 +145,7 @@ bool lockFile( sal_uInt64 const nStart, sal_uInt64 const nEnd, SvFileStream* pSt
     return true;
 }
 
-void unlockFile( sal_uInt64 const nStart, sal_uInt64 const nEnd, SvFileStream * pStream )
+void unlockFile( sal_uInt64 const nStart, sal_uInt64 const nEnd, SvFileStream const * pStream )
 {
     osl::MutexGuard aGuard( LockMutex::get() );
     std::vector<InternalStreamLock> &rLockList = LockList::get();