loplugin:countusersofdefaultparams in chart2

Change-Id: Ibad415d2c539b2438e4939c2c23f32d84a5a677f
Reviewed-on: https://gerrit.libreoffice.org/45948Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

chart2/source/controller/inc/AccessibleBase.hxx

@@ -101,7 +101,7 @@ public:
 
     AccessibleBase( const AccessibleElementInfo & rAccInfo,
                     bool bMayHaveChildren,
-                    bool bAlwaysTransparent = false );
+                    bool bAlwaysTransparent );
     virtual ~AccessibleBase() override;
 
 protected:

chart2/source/controller/inc/AxisItemConverter.hxx

@@ -39,9 +39,9 @@ public:
         const css::uno::Reference<css::beans::XPropertySet>& rPropertySet,
         SfxItemPool& rItemPool, SdrModel& rDrawModel,
         const css::uno::Reference<css::chart2::XChartDocument> & xChartDoc,
-        ExplicitScaleData const * pScale = nullptr,
-        ExplicitIncrementData const * pIncrement = nullptr,
-        const css::awt::Size* pRefSize = nullptr );
+        ExplicitScaleData const * pScale,
+        ExplicitIncrementData const * pIncrement,
+        const css::awt::Size* pRefSize );
 
     virtual ~AxisItemConverter() override;
 

chart2/source/controller/inc/DataPointItemConverter.hxx

@@ -44,7 +44,7 @@ public:
         SfxItemPool& rItemPool,
         SdrModel& rDrawModel,
         const css::uno::Reference<css::lang::XMultiServiceFactory>& xNamedPropertyContainerFactory,
-        GraphicObjectType eMapTo = GraphicObjectType::FilledDataPoint,
+        GraphicObjectType eMapTo,
         const css::awt::Size* pRefSize = nullptr,
         bool bDataSeries = false,
         bool bUseSpecialFillColor = false,

chart2/source/controller/inc/GraphicPropertyItemConverter.hxx

@@ -46,7 +46,7 @@ public:
         SfxItemPool& rItemPool,
         SdrModel& rDrawModel,
         const css::uno::Reference< css::lang::XMultiServiceFactory > & xNamedPropertyContainerFactory,
-        GraphicObjectType eObjectType = GraphicObjectType::FilledDataPoint );
+        GraphicObjectType eObjectType );
     virtual ~GraphicPropertyItemConverter() override;
 
 protected:

chart2/source/controller/inc/LegendItemConverter.hxx

@@ -40,7 +40,7 @@ public:
         SfxItemPool& rItemPool,
         SdrModel& rDrawModel,
         const css::uno::Reference< css::lang::XMultiServiceFactory > & xNamedPropertyContainerFactory,
-        const css::awt::Size* pRefSize = nullptr );
+        const css::awt::Size* pRefSize );
 
     virtual ~LegendItemConverter() override;
 

chart2/source/controller/inc/MultipleChartConverters.hxx

@@ -35,7 +35,7 @@ public:
         const css::uno::Reference<css::frame::XModel> & xChartModel,
         SfxItemPool& rItemPool,
         SdrModel& rDrawModel,
-        const css::awt::Size* pRefSize = nullptr );
+        const css::awt::Size* pRefSize );
 
     virtual ~AllAxisItemConverter() override;
 

chart2/source/controller/inc/ObjectHierarchy.hxx

@@ -50,7 +50,7 @@ public:
      */
     explicit ObjectHierarchy(
         const css::uno::Reference< css::chart2::XChartDocument > & xChartDocument,
-        ExplicitValueProvider * pExplicitValueProvider = nullptr,
+        ExplicitValueProvider * pExplicitValueProvider,
         bool bFlattenDiagram = false,
         bool bOrderingForElementSelector = false );
     ~ObjectHierarchy();
@@ -80,7 +80,7 @@ class ObjectKeyNavigation
 public:
     explicit ObjectKeyNavigation( const ObjectIdentifier & rCurrentOID,
                                   const css::uno::Reference< css::chart2::XChartDocument > & xChartDocument,
-                                  ExplicitValueProvider * pExplicitValueProvider = nullptr );
+                                  ExplicitValueProvider * pExplicitValueProvider );
 
     bool handleKeyEvent( const css::awt::KeyEvent & rEvent );
     const ObjectIdentifier& getCurrentSelection() const { return m_aCurrentOID;}

chart2/source/controller/inc/RegressionEquationItemConverter.hxx

@@ -40,7 +40,7 @@ public:
         SfxItemPool& rItemPool,
         SdrModel& rDrawModel,
         const css::uno::Reference< css::lang::XMultiServiceFactory > & xNamedPropertyContainerFactory,
-        const css::awt::Size* pRefSize = nullptr );
+        const css::awt::Size* pRefSize );
 
     virtual ~RegressionEquationItemConverter() override;
 

chart2/source/controller/inc/TextLabelItemConverter.hxx

@@ -37,10 +37,10 @@ public:
         const css::uno::Reference<css::beans::XPropertySet>& rPropertySet,
         const css::uno::Reference<css::chart2::XDataSeries>& xSeries,
         SfxItemPool& rItemPool,
-        const css::awt::Size* pRefSize = nullptr,
-        bool bDataSeries = false,
-        sal_Int32 nNumberFormat = 0,
-        sal_Int32 nPercentNumberFormat = 0 );
+        const css::awt::Size* pRefSize,
+        bool bDataSeries,
+        sal_Int32 nNumberFormat,
+        sal_Int32 nPercentNumberFormat );
 
     virtual ~TextLabelItemConverter() override;
 

chart2/source/controller/inc/TitleItemConverter.hxx

@@ -36,7 +36,7 @@ public:
         const css::uno::Reference<css::beans::XPropertySet>& rPropertySet,
         SfxItemPool& rItemPool, SdrModel& rDrawModel,
         const css::uno::Reference<css::lang::XMultiServiceFactory>& xNamedPropertyContainerFactory,
-        const css::awt::Size* pRefSize = nullptr );
+        const css::awt::Size* pRefSize );
 
     virtual ~TitleItemConverter() override;
 

chart2/source/controller/main/ChartTransferable.hxx

@@ -36,7 +36,7 @@ namespace chart
 class ChartTransferable : public TransferableHelper
 {
 public:
-    explicit ChartTransferable( SdrModel* pDrawModel, SdrObject* pSelectedObj, bool bDrawing = false );
+    explicit ChartTransferable( SdrModel* pDrawModel, SdrObject* pSelectedObj, bool bDrawing );
     virtual ~ChartTransferable() override;
 
 protected:

chart2/source/model/inc/BaseCoordinateSystem.hxx

@@ -56,7 +56,7 @@ class BaseCoordinateSystem :
 public:
     BaseCoordinateSystem(
         const css::uno::Reference< css::uno::XComponentContext > & xContext,
-        sal_Int32 nDimensionCount = 2 );
+        sal_Int32 nDimensionCount );
     explicit BaseCoordinateSystem( const BaseCoordinateSystem & rSource );
     virtual ~BaseCoordinateSystem() override;
 

chart2/source/model/inc/CartesianCoordinateSystem.hxx

@@ -29,7 +29,7 @@ class CartesianCoordinateSystem : public BaseCoordinateSystem
 public:
     explicit CartesianCoordinateSystem(
         const css::uno::Reference< css::uno::XComponentContext > & xContext,
-        sal_Int32 nDimensionCount = 2 );
+        sal_Int32 nDimensionCount );
     explicit CartesianCoordinateSystem( const CartesianCoordinateSystem & rSource );
     virtual ~CartesianCoordinateSystem() override;
 

chart2/source/model/inc/PolarCoordinateSystem.hxx

@@ -29,7 +29,7 @@ class PolarCoordinateSystem : public BaseCoordinateSystem
 public:
     explicit PolarCoordinateSystem(
         const css::uno::Reference< css::uno::XComponentContext > & xContext,
-        sal_Int32 nDimensionCount = 2 );
+        sal_Int32 nDimensionCount );
     explicit PolarCoordinateSystem( const PolarCoordinateSystem & rSource );
     virtual ~PolarCoordinateSystem() override;
 

chart2/source/model/template/PieChartTypeTemplate.hxx

@@ -39,7 +39,7 @@ public:
         css::uno::Reference< css::uno::XComponentContext > const & xContext,
         const OUString & rServiceName,
         css::chart2::PieChartOffsetMode eMode,
-        bool bRings = false,
+        bool bRings,
         sal_Int32 nDim = 2 );
     virtual ~PieChartTypeTemplate() override;
 

chart2/source/view/charttypes/AreaChart.hxx

@@ -40,7 +40,7 @@ public:
     virtual ~AreaChart() override;
 
     virtual void createShapes() override;
-    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override;
+    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override;
 
     virtual css::drawing::Direction3D  getPreferredDiagramAspectRatio() const override;
 

chart2/source/view/charttypes/BarChart.hxx

@@ -38,7 +38,7 @@ public:
     virtual ~BarChart() override;
 
     virtual void createShapes() override;
-    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override;
+    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override;
 
     virtual css::drawing::Direction3D  getPreferredDiagramAspectRatio() const override;
 

chart2/source/view/charttypes/CandleStickChart.hxx

@@ -38,7 +38,7 @@ public:
     virtual ~CandleStickChart() override;
 
     virtual void createShapes() override;
-    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override;
+    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override;
 
     virtual css::drawing::Direction3D  getPreferredDiagramAspectRatio() const override;
 

chart2/source/view/charttypes/GL3DBarChart.cxx

@@ -159,7 +159,7 @@ class RenderAnimationThread : public RenderThread
 {
 public:
     RenderAnimationThread(GL3DBarChart* pChart, const glm::vec3& rStartPos, const glm::vec3& rEndPos,
-            const sal_Int32 nSteps = STEPS):
+            const sal_Int32 nSteps):
         RenderThread(pChart),
         maStartPos(rStartPos),
         maEndPos(rEndPos),

chart2/source/view/charttypes/PieChart.hxx

@@ -46,7 +46,7 @@ public:
     virtual void rearrangeLabelToAvoidOverlapIfRequested( const css::awt::Size& rPageSize ) override;
 
     virtual void setScales( const std::vector< ExplicitScaleData >& rScales, bool bSwapXAndYAxis ) override;
-    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override;
+    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override;
 
     virtual css::drawing::Direction3D  getPreferredDiagramAspectRatio() const override;
     virtual bool shouldSnapRectToUsedArea() override;

chart2/source/view/inc/VDiagram.hxx

@@ -41,7 +41,7 @@ class VDiagram final
 public: //methods
     VDiagram( const css::uno::Reference<css::chart2::XDiagram>& xDiagram,
               const css::drawing::Direction3D& rPreferredAspectRatio,
-              sal_Int32 nDimension = 3 );
+              sal_Int32 nDimension );
     ~VDiagram();
 
     void init(

chart2/source/view/inc/VSeriesPlotter.hxx

@@ -124,7 +124,7 @@ public:
 
     virtual ~VSeriesPlotter() override;
 
-    /*
+    /**
     * A new series can be positioned relative to other series in a chart.
     * This positioning has two dimensions. First a series can be placed
     * next to each other on the category axis. This position is indicated by xSlot.
@@ -139,7 +139,7 @@ public:
     * ySlot == already occupied     : insert at given y and x position
     * ySlot > occupied              : stack on top at given x position
     */
-    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 );
+    virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot );
 
     /** a value <= 0 for a directions means that this direction can be stretched arbitrary
     */