loplugin:countusersofdefaultparams in chart2..desktop

Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee
Reviewed-on: https://gerrit.libreoffice.org/27896Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

chart2/source/view/inc/GL3DBarChart.hxx

@@ -104,7 +104,7 @@ private:
     DECL_LINK_TYPED(UpdateTimerHdl, Idle*, void);
     static int calcTimeInterval(TimeValue &startTime, TimeValue &endTime);
     float addScreenTextShape(OUString &nStr, const glm::vec2& rLeftOrRightTop, float nTextHeight, bool bLeftTopFlag,
-                                  const glm::vec4& rColor = glm::vec4(0.0f, 1.0f, 1.0f, 0.0f),
+                                  const glm::vec4& rColor,
                                   const glm::vec3& rPos = glm::vec3(0.0f, 0.0f, 0.0f),
                                   sal_uInt32 nEvent = 0);
     void recordBarHistory(sal_uInt32 &nBarID, float &nVal);

connectivity/source/inc/file/fanalyzer.hxx

@@ -78,7 +78,7 @@ namespace connectivity
             void setOrigColumns(const css::uno::Reference< css::container::XNameAccess>& rCols);
             static OOperandAttr* createOperandAttr(sal_Int32 _nPos,
                                                     const css::uno::Reference< css::beans::XPropertySet>& _xCol,
-                                                    const css::uno::Reference< css::container::XNameAccess>& _xIndexes=nullptr);
+                                                    const css::uno::Reference< css::container::XNameAccess>& _xIndexes);
         };
     }
 }

connectivity/source/inc/file/quotedstring.hxx

@@ -36,7 +36,7 @@ namespace connectivity
         QuotedTokenizedString() {}
 
         sal_Int32  GetTokenCount( sal_Unicode cTok , sal_Unicode cStrDel ) const;
-        OUString   GetTokenSpecial(sal_Int32& nStartPos, sal_Unicode cTok = ';', sal_Unicode cStrDel = '\0') const;
+        OUString   GetTokenSpecial(sal_Int32& nStartPos, sal_Unicode cTok, sal_Unicode cStrDel = '\0') const;
         inline OUString& GetString() { return m_sString; }
         inline void SetString(const OUString& aStr) { m_sString = aStr;}
         inline sal_Int32 Len() const { return m_sString.getLength(); }

connectivity/source/inc/flat/ETable.hxx

@@ -57,7 +57,7 @@ namespace connectivity
             bool                            m_bNeedToReadLine;
         private:
             void fillColumns(const css::lang::Locale& _aLocale);
-            bool readLine(sal_Int32 *pEndPos = nullptr, sal_Int32 *pStartPos = nullptr, bool nonEmpty = false);
+            bool readLine(sal_Int32 *pEndPos, sal_Int32 *pStartPos, bool nonEmpty = false);
             void setRowPos(::std::vector<TRowPositionInFile>::size_type rowNum, const TRowPositionInFile &rowPos);
             void impl_fillColumnInfo_nothrow(QuotedTokenizedString& aFirstLine, sal_Int32& nStartPosFirstLine, sal_Int32& nStartPosFirstLine2,
                                              sal_Int32& io_nType, sal_Int32& io_nPrecisions, sal_Int32& io_nScales, OUString& o_sTypeName,

cppu/source/uno/sequence.cxx

@@ -72,7 +72,7 @@ static inline bool idefaultConstructElements(
     uno_Sequence ** ppSeq,
     typelib_TypeDescriptionReference * pElementType,
     sal_Int32 nStartIndex, sal_Int32 nStopIndex,
-    sal_Int32 nAlloc = -1 ) // >= 0 means (re)alloc memory for nAlloc elements
+    sal_Int32 nAlloc ) // >= 0 means (re)alloc memory for nAlloc elements
 {
     uno_Sequence * pSeq = *ppSeq;
     switch (pElementType->eTypeClass)
@@ -318,7 +318,7 @@ static inline bool icopyConstructFromElements(
     typelib_TypeDescriptionReference * pElementType,
     sal_Int32 nStartIndex, sal_Int32 nStopIndex,
     uno_AcquireFunc acquire,
-    sal_Int32 nAlloc = -1 ) // >= 0 means (re)alloc memory for nAlloc elements
+    sal_Int32 nAlloc ) // >= 0 means (re)alloc memory for nAlloc elements
 {
     uno_Sequence * pSeq = *ppSeq;
     switch (pElementType->eTypeClass)

cui/source/dialogs/hangulhanjadlg.cxx

@@ -100,7 +100,7 @@ namespace svx
 
     public:
         void Paint( OutputDevice& _rDevice, const Rectangle& _rRect, DrawTextFlags _nTextStyle,
-            Rectangle* _pPrimaryLocation = nullptr, Rectangle* _pSecondaryLocation = nullptr,
+            Rectangle* _pPrimaryLocation, Rectangle* _pSecondaryLocation,
             vcl::ControlLayoutData* _pLayoutData = nullptr );
     };
 

cui/source/inc/cfg.hxx

@@ -100,7 +100,7 @@ protected:
     void ApplyMenu(
         css::uno::Reference< css::container::XIndexContainer >& rMenuBar,
         css::uno::Reference< css::lang::XSingleComponentFactory >& rFactory,
-        SvxConfigEntry *pMenuData = nullptr );
+        SvxConfigEntry *pMenuData );
 
     bool LoadSubMenus(
         const css::uno::Reference< css::container::XIndexAccess >& xMenuSettings,
@@ -614,7 +614,7 @@ private:
     void        ApplyToolbar(
         css::uno::Reference< css::container::XIndexContainer >& rNewToolbarBar,
         css::uno::Reference< css::lang::XSingleComponentFactory >& rFactory,
-        SvxConfigEntry *pToolbar = nullptr );
+        SvxConfigEntry *pToolbar );
 
 public:
 

cui/source/inc/dlgname.hxx

@@ -60,7 +60,7 @@ public:
         @todo Remove the parameter bCheckImmediately and incorporate the 'true'
               behaviour as default.
      */
-    void    SetCheckNameHdl( const Link<SvxNameDialog&,bool>& rLink, bool bCheckImmediately = false )
+    void    SetCheckNameHdl( const Link<SvxNameDialog&,bool>& rLink, bool bCheckImmediately )
     {
         aCheckNameHdl = rLink;
         if ( bCheckImmediately )

cui/source/inc/hangulhanjadlg.hxx

@@ -157,7 +157,7 @@ namespace svx
         void    SetCurrentString(
                     const OUString& _rNewString,
                     const css::uno::Sequence< OUString >& _rSuggestions,
-                    bool _bOriginatesFromDocument = true
+                    bool _bOriginatesFromDocument
                 );
 
         void    FocusSuggestion( );

cui/source/options/optaboutconfig.hxx

@@ -70,7 +70,7 @@ public:
    virtual ~CuiAboutConfigTabPage();
    virtual void dispose() override;
    void     InsertEntry(const OUString &rPropertyPath, const OUString& rProp, const OUString& rStatus, const OUString& rType, const OUString& rValue,
-                        SvTreeListEntry *pParentEntry = nullptr, bool bInsertToPrefBox = true);
+                        SvTreeListEntry *pParentEntry, bool bInsertToPrefBox);
    void     Reset();
    void     FillItems(const css::uno::Reference<css::container::XNameAccess>& xNameAccess,
                       SvTreeListEntry *pParentEntry = nullptr, int lineage = 0, bool bLoadAll = false);

dbaccess/source/core/api/KeySet.hxx

@@ -140,8 +140,8 @@ namespace dbaccess
         OUStringBuffer createKeyFilter( );
         bool doTryRefetch_throw() throw(css::sdbc::SQLException, css::uno::RuntimeException);
         void tryRefetch(const ORowSetRow& _rInsertRow,bool bRefetch);
-        void executeUpdate(const ORowSetRow& _rInsertRow ,const ORowSetRow& _rOriginalRow,const OUString& i_sSQL,const OUString& i_sTableName,const ::std::vector<sal_Int32>& _aIndexColumnPositions = ::std::vector<sal_Int32>());
-        void executeInsert( const ORowSetRow& _rInsertRow,const OUString& i_sSQL,const OUString& i_sTableName = OUString(),bool bRefetch = false);
+        void executeUpdate(const ORowSetRow& _rInsertRow, const ORowSetRow& _rOriginalRow, const OUString& i_sSQL, const OUString& i_sTableName,const ::std::vector<sal_Int32>& _aIndexColumnPositions = ::std::vector<sal_Int32>());
+        void executeInsert( const ORowSetRow& _rInsertRow, const OUString& i_sSQL, const OUString& i_sTableName, bool bRefetch = false);
         void executeStatement(OUStringBuffer& io_aFilter, css::uno::Reference< css::sdb::XSingleSelectQueryComposer>& io_xAnalyzer);
 
         virtual ~OKeySet();

dbaccess/source/core/dataaccess/documenteventnotifier.hxx

@@ -71,8 +71,8 @@ namespace dbaccess
         */
         void    notifyDocumentEvent(
                     const OUString& EventName,
-                    const css::uno::Reference< css::frame::XController2 >& _rxViewController = nullptr,
-                    const css::uno::Any& Supplement = css::uno::Any()
+                    const css::uno::Reference< css::frame::XController2 >& _rxViewController,
+                    const css::uno::Any& Supplement
                 );
 
         /** notifies a document event, described by the given parameters, asynchronously
@@ -84,8 +84,8 @@ namespace dbaccess
         */
         void    notifyDocumentEventAsync(
                     const OUString& EventName,
-                    const css::uno::Reference< css::frame::XController2 >& ViewController = nullptr,
-                    const css::uno::Any& Supplement = css::uno::Any()
+                    const css::uno::Reference< css::frame::XController2 >& ViewController,
+                    const css::uno::Any& Supplement
                 );
 
         /** notifies a document event to all registered listeners

dbaccess/source/inc/dsntypes.hxx

@@ -137,7 +137,7 @@ public:
     OUString getMediaType(const OUString& _sURL) const;
 
     /// returns the dsn prefix for a given media type
-    OUString getDatasourcePrefixFromMediaType(const OUString& _sMediaType,const OUString& _sExtension = OUString() );
+    OUString getDatasourcePrefixFromMediaType(const OUString& _sMediaType, const OUString& _sExtension );
 
     void extractHostNamePort(const OUString& _rDsn,OUString& _sDatabaseName,OUString& _rHostname,sal_Int32& _nPortNumber) const;
 

dbaccess/source/ui/inc/JoinTableView.hxx

@@ -318,7 +318,7 @@ namespace dbaui
             modified
             @param _pAction a possible undo action to add at the controller
         */
-        void invalidateAndModify(SfxUndoAction *_pAction=nullptr);
+        void invalidateAndModify(SfxUndoAction *_pAction);
 
     private:
         using Window::Scroll;

dbaccess/source/ui/inc/QueryTableView.hxx

@@ -54,7 +54,7 @@ namespace dbaui
         virtual void RemoveTabWin(OTableWindow* pTabWin) override;
 
         /// AddTabWin, setting an alias
-        void    AddTabWin(const OUString& strDatabase, const OUString& strTableName, const OUString& strAlias, bool bNewTable = false);
+        void    AddTabWin(const OUString& strDatabase, const OUString& strTableName, const OUString& strAlias, bool bNewTable);
         /// search TabWin
         OQueryTableWindow*  FindTable(const OUString& rAliasName);
         bool                FindTableFromField(const OUString& rFieldName, OTableFieldDescRef& rInfo, sal_uInt16& rCnt);

dbaccess/source/ui/inc/linkeddocuments.hxx

@@ -82,12 +82,12 @@ namespace dbaui
                 );
 
         void    newFormWithPilot(
-                    const sal_Int32 _nCommandType = -1,
-                    const OUString& _rObjectName = OUString()
+                    const sal_Int32 _nCommandType,
+                    const OUString& _rObjectName
                 );
         void    newReportWithPilot(
-                    const sal_Int32 _nCommandType = -1,
-                    const OUString& _rObjectName = OUString()
+                    const sal_Int32 _nCommandType,
+                    const OUString& _rObjectName
                 );
         void    newQueryWithPilot();
         void    newTableWithPilot();

dbaccess/source/ui/inc/sbagrid.hxx

@@ -133,7 +133,7 @@ namespace dbaui
         typedef css::uno::Reference< xstlist_type > xlistener_type;
         void NotifyStatusChanged(const css::util::URL& aUrl, const xlistener_type & xControl = xlistener_type() );
 #else
-        void NotifyStatusChanged(const css::util::URL& aUrl, const css::uno::Reference< css::frame::XStatusListener > & xControl = css::uno::Reference< css::frame::XStatusListener > ());
+        void NotifyStatusChanged(const css::util::URL& aUrl, const css::uno::Reference< css::frame::XStatusListener > & xControl);
 #endif // # _MSC_VER
 
     private:

dbaccess/source/ui/inc/unodatbr.hxx

@@ -253,7 +253,7 @@ namespace dbaui
         // returns <TRUE/> if the entry is selected (which means it's part of the selected path)
         static bool isSelected(SvTreeListEntry* _pEntry);
         // select the entry (and only the entry, not the whole path)
-        void        select(SvTreeListEntry* _pEntry, bool _bSelect = true);
+        void        select(SvTreeListEntry* _pEntry, bool _bSelect);
         // select the path of the entry (which must be an entry without children)
         void        selectPath(SvTreeListEntry* _pEntry, bool _bSelect = true);
 
@@ -365,7 +365,7 @@ namespace dbaui
             const sal_Int32 _nCommandType,
             const bool _bEscapeProcessing,
             const SharedConnection& _rxConnection,
-            bool _bSelectDirect = false
+            bool _bSelectDirect
         );
 
         SvTreeListEntry* implGetConnectionEntry(SvTreeListEntry* _pEntry) const;
@@ -379,7 +379,7 @@ namespace dbaui
 
         /// loads the grid control with the data object specified (which may be a table, a query or a command)
         bool implLoadAnything(const OUString& _rDataSourceName, const OUString& _rCommand,
-            const sal_Int32 _nCommandType, const bool _bEscapeProcessing, const SharedConnection& _rxConnection = SharedConnection() );
+            const sal_Int32 _nCommandType, const bool _bEscapeProcessing, const SharedConnection& _rxConnection );
 
         /** retrieves the tree entry for the object described by <arg>_rDescriptor</arg>
             @param _rDescriptor
@@ -390,7 +390,7 @@ namespace dbaui
                 If not <NULL/>, the object container tree entry will be returned here
         */
         SvTreeListEntry* getObjectEntry(const svx::ODataAccessDescriptor& _rDescriptor,
-            SvTreeListEntry** _ppDataSourceEntry = nullptr, SvTreeListEntry** _ppContainerEntry = nullptr
+            SvTreeListEntry** _ppDataSourceEntry, SvTreeListEntry** _ppContainerEntry
         );
         /** retrieves the tree entry for the object described by data source name, command and command type
             @param _rDataSource
@@ -410,7 +410,7 @@ namespace dbaui
         */
         SvTreeListEntry* getObjectEntry(
             const OUString& _rDataSource, const OUString& _rCommand, sal_Int32 _nCommandType,
-            SvTreeListEntry** _ppDataSourceEntry = nullptr, SvTreeListEntry** _ppContainerEntry = nullptr,
+            SvTreeListEntry** _ppDataSourceEntry, SvTreeListEntry** _ppContainerEntry,
             bool _bExpandAncestors = true,
             const SharedConnection& _rxConnection = SharedConnection()
         );

dbaccess/source/ui/querydesign/TableFieldInfo.hxx

@@ -35,7 +35,7 @@ namespace dbaui
         ~OTableFieldInfo();
 
         inline ETableFieldType  GetKeyType() const { return m_eFieldType; }
-        inline void             SetKey(ETableFieldType bKey=TAB_NORMAL_FIELD) { m_eFieldType = bKey; }
+        inline void             SetKey(ETableFieldType bKey) { m_eFieldType = bKey; }
         inline sal_Int32        GetDataType() const { return m_eDataType; }
         inline void             SetDataType(sal_Int32 eTyp) { m_eDataType = eTyp; }
     };

dbaccess/source/ui/tabledesign/TEditControl.hxx

@@ -147,7 +147,7 @@ namespace dbaui
 
         const ::std::shared_ptr<OTableRow>& GetActRow(){ return pActRow; }
         void CellModified( long nRow, sal_uInt16 nColId );
-        void SetReadOnly( bool bRead=true );
+        void SetReadOnly( bool bRead );
 
         virtual void Init() override;
         virtual void DeactivateCell(bool bUpdate = true) override;

desktop/source/app/dispatchwatcher.hxx

@@ -77,7 +77,7 @@ class DispatchWatcher : public ::cppu::WeakImplHelper< css::frame::XDispatchResu
         virtual void SAL_CALL dispatchFinished( const css::frame::DispatchResultEvent& aEvent ) throw( css::uno::RuntimeException, std::exception ) override;
 
         // execute new dispatch request
-        bool executeDispatchRequests( const std::vector<DispatchRequest>& aDispatches, bool bNoTerminate = false );
+        bool executeDispatchRequests( const std::vector<DispatchRequest>& aDispatches, bool bNoTerminate );
 
     private:
         osl::Mutex m_mutex;

desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx

@@ -155,7 +155,7 @@ public:
     void startProgress();
     void stopProgress();
     void progressSection( const OUString &rText,
-                          const uno::Reference< task::XAbortChannel > &xAbortChannel = nullptr );
+                          const uno::Reference< task::XAbortChannel > &xAbortChannel );
     inline void setWarnUser( bool bNewVal ) { m_bWarnUser = bNewVal; }
 
     // XCommandEnvironment