loplugin:checkunusedparams in basctl and basic

Change-Id: I077ce96aed3c79045d5e8438109a8b1690ff1218
Reviewed-on: https://gerrit.libreoffice.org/37062Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

basctl/source/basicide/baside3.cxx

@@ -233,9 +233,9 @@ void DialogWindow::DoInit()
     m_pEditor->SetScrollBars( GetHScrollBar(), GetVScrollBar() );
 }
 
-void DialogWindow::DoScroll( ScrollBar* pCurScrollBar )
+void DialogWindow::DoScroll( ScrollBar*  )
 {
-    m_pEditor->DoScroll( pCurScrollBar );
+    m_pEditor->DoScroll();
 }
 
 void DialogWindow::GetState( SfxItemSet& rSet )

basctl/source/basicide/bastypes.cxx

@@ -410,7 +410,7 @@ void DockingWindow::DockThis ()
     {
         if (!IsFloatingMode() && GetParent() != pLayout)
             SetParent(pLayout);
-        pLayout->DockaWindow(this);
+        pLayout->ArrangeWindows();
     }
 }
 

basctl/source/basicide/layout.cxx

@@ -113,11 +113,6 @@ void Layout::ArrangeWindows ()
     bInArrangeWindows = false;
 }
 
-void Layout::DockaWindow (DockingWindow*)
-{
-    ArrangeWindows();
-}
-
 void Layout::Activating (BaseWindow& rWindow)
 {
     // first activation

basctl/source/dlged/dlged.cxx

@@ -287,12 +287,11 @@ void DlgEditor::InitScrollBars()
     pHScroll->SetPageSize( aOutSize.Width() / 2 );
     pVScroll->SetPageSize( aOutSize.Height() / 2 );
 
-    DoScroll( pHScroll );
-    DoScroll( pVScroll );
+    DoScroll();
 }
 
 
-void DlgEditor::DoScroll( ScrollBar* )
+void DlgEditor::DoScroll()
 {
     if( !pHScroll || !pVScroll )
         return;

basctl/source/dlged/dlgedfunc.cxx

@@ -69,9 +69,9 @@ void DlgEdFunc::ForceScroll( const Point& rPos )
             pVScroll->SetThumbPos( pVScroll->GetThumbPos() + nDeltaY );
 
         if( nDeltaX )
-            rParent.DoScroll( pHScroll );
+            rParent.DoScroll();
         if( nDeltaY )
-            rParent.DoScroll( pVScroll );
+            rParent.DoScroll();
     }
 
     aScrollTimer.Start();
@@ -310,7 +310,7 @@ bool DlgEdFunc::KeyInput( const KeyEvent& rKEvt )
                     if ( nThumbPos > nRangeMax )
                         nThumbPos = nRangeMax;
                     pScrollBar->SetThumbPos( nThumbPos );
-                    rParent.DoScroll( pScrollBar );
+                    rParent.DoScroll();
                 }
             }
 

basctl/source/dlged/dlgedlist.cxx

@@ -60,19 +60,19 @@ void SAL_CALL DlgEdEvtContListenerImpl::disposing( const  css::lang::EventObject
 }
 
 // XContainerListener
-void SAL_CALL DlgEdEvtContListenerImpl::elementInserted(const css::container::ContainerEvent& Event)
+void SAL_CALL DlgEdEvtContListenerImpl::elementInserted(const css::container::ContainerEvent& /*Event*/)
 {
-    rDlgEdObj._elementInserted( Event );
+    rDlgEdObj._elementInserted();
 }
 
-void SAL_CALL DlgEdEvtContListenerImpl::elementReplaced(const css::container::ContainerEvent& Event)
+void SAL_CALL DlgEdEvtContListenerImpl::elementReplaced(const css::container::ContainerEvent& /*Event*/)
 {
-    rDlgEdObj._elementReplaced( Event );
+    rDlgEdObj._elementReplaced();
 }
 
-void SAL_CALL DlgEdEvtContListenerImpl::elementRemoved(const css::container::ContainerEvent& Event)
+void SAL_CALL DlgEdEvtContListenerImpl::elementRemoved(const css::container::ContainerEvent& /*Event*/)
 {
-    rDlgEdObj._elementRemoved( Event );
+    rDlgEdObj._elementRemoved();
 }
 
 } // namespace basctl

basctl/source/dlged/dlgedobj.cxx

@@ -1159,7 +1159,7 @@ void SAL_CALL DlgEdObj::_propertyChange( const  css::beans::PropertyChangeEvent&
     }
 }
 
-void SAL_CALL DlgEdObj::_elementInserted(const css::container::ContainerEvent& )
+void SAL_CALL DlgEdObj::_elementInserted()
 {
     if (isListening())
     {
@@ -1168,7 +1168,7 @@ void SAL_CALL DlgEdObj::_elementInserted(const css::container::ContainerEvent& )
     }
 }
 
-void SAL_CALL DlgEdObj::_elementReplaced(const css::container::ContainerEvent& )
+void SAL_CALL DlgEdObj::_elementReplaced()
 {
     if (isListening())
     {
@@ -1177,7 +1177,7 @@ void SAL_CALL DlgEdObj::_elementReplaced(const css::container::ContainerEvent& )
     }
 }
 
-void SAL_CALL DlgEdObj::_elementRemoved(const css::container::ContainerEvent& )
+void SAL_CALL DlgEdObj::_elementRemoved()
 {
     if (isListening())
     {

basctl/source/inc/dlged.hxx

@@ -154,7 +154,7 @@ public:
     void            InitScrollBars();
     ScrollBar*      GetHScroll() const { return pHScroll; }
     ScrollBar*      GetVScroll() const { return pVScroll; }
-    void            DoScroll( ScrollBar* pActScroll );
+    void            DoScroll();
     void            UpdateScrollBars();
 
     void            SetDialog (const css::uno::Reference<css::container::XNameContainer>& xUnoControlDialogModel);

basctl/source/inc/dlgedobj.hxx

@@ -127,11 +127,11 @@ public:
 
     // ContainerListener
     /// @throws css::uno::RuntimeException
-    void SAL_CALL _elementInserted( const css::container::ContainerEvent& Event );
+    void SAL_CALL _elementInserted();
     /// @throws css::uno::RuntimeException
-    void SAL_CALL _elementReplaced( const css::container::ContainerEvent& Event );
+    void SAL_CALL _elementReplaced();
     /// @throws css::uno::RuntimeException
-    void SAL_CALL _elementRemoved( const css::container::ContainerEvent& Event );
+    void SAL_CALL _elementRemoved();
 
     virtual void SetLayer(SdrLayerID nLayer) override;
     void MakeDataAware( const css::uno::Reference< css::frame::XModel >& xModel );

basctl/source/inc/layout.hxx

@@ -42,7 +42,6 @@ class BaseWindow;
 class Layout: public vcl::Window
 {
 public:
-    void DockaWindow (DockingWindow*);
     void ArrangeWindows ();
 
     virtual void Activating (BaseWindow&);

basic/inc/sbstdobj.hxx

@@ -43,9 +43,9 @@ protected:
     virtual ~SbStdPicture() override;
     virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
 
-    void    PropType( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
-    void    PropWidth( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
-    void    PropHeight( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
+    void    PropType( SbxVariable* pVar, bool bWrite );
+    void    PropWidth( SbxVariable* pVar, bool bWrite );
+    void    PropHeight( SbxVariable* pVar, bool bWrite );
 
 public:
 
@@ -69,12 +69,12 @@ protected:
     virtual ~SbStdFont() override;
     virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
 
-    void    PropBold( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
-    void    PropItalic( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
-    void    PropStrikeThrough( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
-    void    PropUnderline( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
-    void    PropSize( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
-    void    PropName( SbxVariable* pVar, SbxArray* pPar, bool bWrite );
+    void    PropBold( SbxVariable* pVar, bool bWrite );
+    void    PropItalic( SbxVariable* pVar, bool bWrite );
+    void    PropStrikeThrough( SbxVariable* pVar, bool bWrite );
+    void    PropUnderline( SbxVariable* pVar, bool bWrite );
+    void    PropSize( SbxVariable* pVar, bool bWrite );
+    void    PropName( SbxVariable* pVar, bool bWrite );
 
 public:
 

basic/source/runtime/stdobj1.cxx

@@ -56,7 +56,7 @@ SbxObject* SbStdFactory::CreateObject( const OUString& rClassName )
 }
 
 
-void SbStdPicture::PropType( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdPicture::PropType( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
     {
@@ -76,7 +76,7 @@ void SbStdPicture::PropType( SbxVariable* pVar, SbxArray*, bool bWrite )
 }
 
 
-void SbStdPicture::PropWidth( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdPicture::PropWidth( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
     {
@@ -91,7 +91,7 @@ void SbStdPicture::PropWidth( SbxVariable* pVar, SbxArray*, bool bWrite )
     pVar->PutInteger( (sal_Int16)aSize.Width() );
 }
 
-void SbStdPicture::PropHeight( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdPicture::PropHeight( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
     {
@@ -141,16 +141,15 @@ void SbStdPicture::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
         }
 
         SbxVariable* pVar   = pHint->GetVar();
-        SbxArray*    pPar_  = pVar->GetParameters();
         const sal_uInt32 nWhich = pVar->GetUserData();
         bool         bWrite = pHint->GetId() == SfxHintId::BasicDataChanged;
 
-        // Propteries
+        // Properties
         switch( nWhich )
         {
-            case ATTR_IMP_TYPE:     PropType( pVar, pPar_, bWrite ); return;
-            case ATTR_IMP_WIDTH:    PropWidth( pVar, pPar_, bWrite ); return;
-            case ATTR_IMP_HEIGHT:   PropHeight( pVar, pPar_, bWrite ); return;
+            case ATTR_IMP_TYPE:     PropType( pVar, bWrite ); return;
+            case ATTR_IMP_WIDTH:    PropWidth( pVar, bWrite ); return;
+            case ATTR_IMP_HEIGHT:   PropHeight( pVar, bWrite ); return;
         }
 
         SbxObject::Notify( rBC, rHint );
@@ -158,7 +157,7 @@ void SbStdPicture::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
 }
 
 
-void SbStdFont::PropBold( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropBold( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
         SetBold( pVar->GetBool() );
@@ -166,7 +165,7 @@ void SbStdFont::PropBold( SbxVariable* pVar, SbxArray*, bool bWrite )
         pVar->PutBool( IsBold() );
 }
 
-void SbStdFont::PropItalic( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropItalic( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
         SetItalic( pVar->GetBool() );
@@ -174,7 +173,7 @@ void SbStdFont::PropItalic( SbxVariable* pVar, SbxArray*, bool bWrite )
         pVar->PutBool( IsItalic() );
 }
 
-void SbStdFont::PropStrikeThrough( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropStrikeThrough( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
         SetStrikeThrough( pVar->GetBool() );
@@ -182,7 +181,7 @@ void SbStdFont::PropStrikeThrough( SbxVariable* pVar, SbxArray*, bool bWrite )
         pVar->PutBool( IsStrikeThrough() );
 }
 
-void SbStdFont::PropUnderline( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropUnderline( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
         SetUnderline( pVar->GetBool() );
@@ -190,7 +189,7 @@ void SbStdFont::PropUnderline( SbxVariable* pVar, SbxArray*, bool bWrite )
         pVar->PutBool( IsUnderline() );
 }
 
-void SbStdFont::PropSize( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropSize( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
         SetSize( (sal_uInt16)pVar->GetInteger() );
@@ -198,7 +197,7 @@ void SbStdFont::PropSize( SbxVariable* pVar, SbxArray*, bool bWrite )
         pVar->PutInteger( (sal_Int16)GetSize() );
 }
 
-void SbStdFont::PropName( SbxVariable* pVar, SbxArray*, bool bWrite )
+void SbStdFont::PropName( SbxVariable* pVar, bool bWrite )
 {
     if( bWrite )
     {
@@ -259,19 +258,18 @@ void SbStdFont::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
         }
 
         SbxVariable* pVar   = pHint->GetVar();
-        SbxArray*    pPar_  = pVar->GetParameters();
         const sal_uInt32 nWhich = pVar->GetUserData();
         bool         bWrite = pHint->GetId() == SfxHintId::BasicDataChanged;
 
         // Propteries
         switch( nWhich )
         {
-            case ATTR_IMP_BOLD:         PropBold( pVar, pPar_, bWrite ); return;
-            case ATTR_IMP_ITALIC:       PropItalic( pVar, pPar_, bWrite ); return;
-            case ATTR_IMP_STRIKETHROUGH:PropStrikeThrough( pVar, pPar_, bWrite ); return;
-            case ATTR_IMP_UNDERLINE:    PropUnderline( pVar, pPar_, bWrite ); return;
-            case ATTR_IMP_SIZE:         PropSize( pVar, pPar_, bWrite ); return;
-            case ATTR_IMP_NAME:         PropName( pVar, pPar_, bWrite ); return;
+            case ATTR_IMP_BOLD:         PropBold( pVar, bWrite ); return;
+            case ATTR_IMP_ITALIC:       PropItalic( pVar, bWrite ); return;
+            case ATTR_IMP_STRIKETHROUGH:PropStrikeThrough(  pVar, bWrite ); return;
+            case ATTR_IMP_UNDERLINE:    PropUnderline( pVar, bWrite ); return;
+            case ATTR_IMP_SIZE:         PropSize( pVar, bWrite ); return;
+            case ATTR_IMP_NAME:         PropName( pVar, bWrite ); return;
         }
 
         SbxObject::Notify( rBC, rHint );